Skip to content

GH-50697: [C++][FlightRPC] ODBC installer support fixes - #50748

Merged
lidavidm merged 3 commits into
apache:mainfrom
Bit-Quill:gh-50697-odbc-installer-fix
Aug 5, 2026
Merged

GH-50697: [C++][FlightRPC] ODBC installer support fixes#50748
lidavidm merged 3 commits into
apache:mainfrom
Bit-Quill:gh-50697-odbc-installer-fix

Conversation

@alinaliBQ

@alinaliBQalinaliBQ commented Jul 30, 2026•
edited
Loading

Copy link
Copy Markdown
Collaborator

Rationale for this change

GH-50697

I have tested the RPM ODBC installer on AlmaLinux 9. The ODBC driver works as expected on AlmaLinux 9. The only issue I found was that the connection-options.md guide was not included in the package installation. This PR adds connection-options.md to the RPM ODBC package so users can reference the connection options documentation after installation.

Summary of testing results:

  1. Clean install - driver works as expected and registered successfully, arrow installer installs isql and unixODBC during installation.
  2. Uninstall - driver is uninstalled and unregistered automatically, arrow installer flags and uninstalls isql and unixODBC as unused dependency during installation.
    If user wants to avoid this behavior, they can add --noautoremove flag to make dnf keep isql and unixODBC during ODBC uninstallation.
  3. Upgrade - driver can be upgraded to new version.
  4. Data retrieval works as expected, no dependency issues found.

What changes are included in this PR?

  • Add connection-options.md to the RPM ODBC package installation.
    • Example location after install: /usr/share/doc/arrow2600-flight-sql-odbc-libs/connection-options.md
  • Fix Windows ODBC installer to include docs LICENSE.txt and NOTICE.txt
  • Add ODBC installer description to ODBC README.md

Are these changes tested?

Yes

Are there any user-facing changes?

Yes

@alinaliBQ@justing-bq
ODBC installer fixes
298c2a8
- Add installer description to ReadMe
- Fix `docs` on Windows to include docs
Co-authored-by: justing-bq <justin.gossett@improving.com>
@alinaliBQalinaliBQ mentioned this pull request Jul 30, 2026
Closed
@alinaliBQ
Add connection-options.md to be installed
0184698
The installed file would be under `usr/share/doc/arrow2600-flight-sql-odbc-libs/connection-options.md`
@alinaliBQalinaliBQ added CI: Extra: C++ Run extra C++ CI CI: Extra: Package: Linux Run extra Linux Packages CI labels Jul 30, 2026
@alinaliBQ
alinaliBQ marked this pull request as ready for review July 31, 2026 17:27
@alinaliBQ

alinaliBQ commented Jul 31, 2026

Copy link
Copy Markdown
CollaboratorAuthor

Hi @kou cc @lidavidm, this PR is ready for review.

The CI failures don't appear related to the code changes. Package Linux debian-trixie-arm64 failed due to operation being canceled. If possible, could you help to re-run debian-trixie-arm64?

kou
kou approved these changes Aug 1, 2026
View reviewed changes

@koukou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Comment threaddev/tasks/linux-packages/apache-arrow/yum/arrow.spec.in Outdated
@github-actionsgithub-actionsBot added awaiting merge Awaiting merge and removed awaiting review Awaiting review labels Aug 1, 2026
@alinaliBQ@kou
Apply suggestion from@kou
b72a06f
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
@alinaliBQ

alinaliBQ commented Aug 4, 2026

Copy link
Copy Markdown
CollaboratorAuthor

I applied the change and the CI failures still look unrelated, some failures might be due to GitHub connection issue:

C++ Extra / ODBC release AMD64 macOS 15-intel (pull_request):

Error: Failed to CreateArtifact: Unable to make request: ENOTFOUND

Package Linux / almalinux-8-amd64 (pull_request):

ERROR: failed to build: failed to solve: DeadlineExceeded: DeadlineExceeded: almalinux:8: failed to resolve source metadata for docker.io/library/almalinux:8: failed to do request: Head "https://registry-1.docker.io/v2/library/almalinux/manifests/8": dial tcp 52.21.165.20:443: i/o timeout

@lidavidm

lidavidm commented Aug 5, 2026

Copy link
Copy Markdown
Member

I kicked all the failing jobs

@lidavidm
lidavidm merged commit 4dd7eb7 into apache:mainAug 5, 2026
161 of 170 checks passed
@lidavidmlidavidm removed the awaiting merge Awaiting merge label Aug 5, 2026
@lidavidmlidavidm mentioned this pull request Aug 5, 2026
Closed
@conbench-apache-arrow

conbench-apache-arrowBot commented Aug 5, 2026

Copy link
Copy Markdown

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 4dd7eb7.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@koukoukou approved these changes
@lidavidmlidavidmlidavidm approved these changes
@assignUserassignUserAwaiting requested review from assignUserassignUser is a code owner
@jonkeanejonkeaneAwaiting requested review from jonkeanejonkeane is a code owner
@raulcdraulcdAwaiting requested review from raulcdraulcd is a code owner

Assignees

No one assigned

Labels

CI: Extra: C++Run extra C++ CICI: Extra: Package: LinuxRun extra Linux Packages CIComponent: C++Component: DocumentationComponent: FlightRPC

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alinaliBQ@lidavidm@kou