Uh oh!
There was an error while loading. Please reload this page.
GH-50828: [C++][FlightRPC][ODBC] Add SQLGetInfo remote tests - #50838
Open
erichanwang wants to merge 1 commit into
Open
GH-50828: [C++][FlightRPC][ODBC] Add SQLGetInfo remote tests#50838erichanwang wants to merge 1 commit into
erichanwang wants to merge 1 commit into
Conversation
erichanwangforce-pushed
the
fix/odbc-sqlgetinfo-tests-50828
branch
from
August 10, 2026 00:13
3c9b74b to
f4bda93Comparelidavidm
commented
Aug 21, 2026
Member
It may be worth rebasing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
The SQLGetInfo tests for
SQL_CREATE_SCHEMAandSQL_CREATE_TABLEonly covered the mock server. The remote fixture can report different DDL capabilities, so the missing remote coverage allowed regressions to go unnoticed.What changes are included in this PR?
SQL_CREATE_SCHEMAandSQL_CREATE_TABLE.1) and assert the remote fixture's unsupported DDL values (0) separately.Fixes#50828.
Are these changes tested?
The changed C++ test source passes
git diff --checkand was reviewed for fixture-specific expectations. A local runtime ODBC test could not be run because this checkout has no compiled ODBC test binary or configured remote server.Are there any user-facing changes?
No.