Uh oh!
There was an error while loading. Please reload this page.
ARROW-6216: [C++][Parquet] Expose codec compression level to user, add to Parquet writer properties - #5192
Closed
wesm wants to merge 5 commits into
Closed
ARROW-6216: [C++][Parquet] Expose codec compression level to user, add to Parquet writer properties#5192wesm wants to merge 5 commits into
wesm wants to merge 5 commits into
Conversation
In some situations the user might benefit by using a compression level other than the default one in Arrow. This patch adds a method to the ColumnProperties builder to allow the user to select a compression level.
wesm
commented
Aug 25, 2019
MemberAuthor
I also moved the handling of the default compression hint into the codec ctors, and moved the default compression levels into the header files in case that doesn't offend anyone |
martinradev
commented
Aug 25, 2019
Contributor
As you wish, thanks for the effort. |
codecov-io
commented
Aug 26, 2019
Codecov Report
@@ Coverage Diff @@## master #5192 +/- ##
==========================================
+ Coverage 87.65% 89.25% +1.59%
==========================================
Files 1025 742 -283 Lines 146568 105790 -40778 Branches 1437 0 -1437 ==========================================
- Hits 128477 94420 -34057 + Misses 17729 11370 -6359 + Partials 362 0 -362
Continue to review full report at Codecov.
|
wesm
commented
Aug 26, 2019
MemberAuthor
+1. Thanks @martinradev! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch allows the user to select a compression level to be used for when column data in Parquet is compressed. The user can select between better compression ratio or speed.
Reopening PR to supersede #5071 since the GitHub UI closed the PR when I attempted to push commits to the contributor's master branch