Uh oh!
There was an error while loading. Please reload this page.
ARROW-6871: [Java] Enhance TransferPair related parameters check and tests - #5645
ARROW-6871: [Java] Enhance TransferPair related parameters check and tests#5645tianchen92 wants to merge 4 commits into
Conversation
tianchen92
commented
Oct 14, 2019
tianchen92
commented
Oct 23, 2019
also cc @praveenbingo appreciate if you have time to take a look. |
Uh oh!
There was an error while loading. Please reload this page.
emkornfield
commented
Jan 11, 2020
@tianchen92 did you add the benchmark you mentioned in the JIRA? |
I added a benchmark for copyValueSafe and shows no regression, however, due to #5645 (comment), I finally revert the check in copyValueSafe API. |
tianchen92
commented
Jan 17, 2020
I add a benchmark and shows no regression. Before: After: |
emkornfield
commented
Feb 3, 2020
+1 thanks. |
…tests Related to [ARROW-6871](https://issues.apache.org/jira/browse/ARROW-6871). TransferPair related param checks in different classes have potential problems: i. splitAndTansfer has no indices check in classes like VarcharVector ii. splitAndTranser indices check in classes like UnionVector is not correct (Preconditions.checkArgument(startIndex + length <= valueCount)), should check params separately. iii. should add more UT to cover corner cases. Closes#5645 from tianchen92/ARROW-6871 and squashes the following commits: f3b897d <tianchen> fix style 0d3c7ea <tianchen> add benchmark 01f9a48 <tianchen> revert changes in copyFrom a22d58a <tianchen> ARROW-6871: Enhance TransferPair related parameters check and tests Authored-by: tianchen <niki.lj@alibaba-inc.com> Signed-off-by: Micah Kornfield <emkornfield@gmail.com>
…tests Related to [ARROW-6871](https://issues.apache.org/jira/browse/ARROW-6871). TransferPair related param checks in different classes have potential problems: i. splitAndTansfer has no indices check in classes like VarcharVector ii. splitAndTranser indices check in classes like UnionVector is not correct (Preconditions.checkArgument(startIndex + length <= valueCount)), should check params separately. iii. should add more UT to cover corner cases. Closesapache#5645 from tianchen92/ARROW-6871 and squashes the following commits: f3b897d <tianchen> fix style 0d3c7ea <tianchen> add benchmark 01f9a48 <tianchen> revert changes in copyFrom a22d58a <tianchen> ARROW-6871: Enhance TransferPair related parameters check and tests Authored-by: tianchen <niki.lj@alibaba-inc.com> Signed-off-by: Micah Kornfield <emkornfield@gmail.com>
Related to ARROW-6871.
TransferPair related param checks in different classes have potential problems:
i. splitAndTansfer has no indices check in classes like VarcharVector
ii. splitAndTranser indices check in classes like UnionVector is not correct (Preconditions.checkArgument(startIndex + length <= valueCount)), should check params separately.
iii. should add more UT to cover corner cases.