Skip to content

ARROW-7057: [C++] Add API to parse URI query strings - #5770

Closed
pitrou wants to merge 2 commits into
apache:masterfrom
pitrou:ARROW-7057-parse-qs
Closed

ARROW-7057: [C++] Add API to parse URI query strings#5770
pitrou wants to merge 2 commits into
apache:masterfrom
pitrou:ARROW-7057-parse-qs

Conversation

@pitrou

@pitroupitrou commented Nov 4, 2019

Copy link
Copy Markdown
Member

No description provided.

@github-actions

github-actionsBot commented Nov 4, 2019

Copy link
Copy Markdown

https://issues.apache.org/jira/browse/ARROW-7057

@pitroupitrou mentioned this pull request Nov 4, 2019
Closed
pitrou
pitrou commented Nov 4, 2019
View reviewed changes
Comment threadcpp/src/arrow/util/uri.cc Outdated
bkietz
bkietz requested changes Nov 4, 2019
View reviewed changes

@bkietzbkietz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

I think this works:

std::unique_ptr<UriQueryListA, void(UriQueryListA*)> query_list_guard(query_list_start, uriFreeQueryListA);

Comment threadcpp/src/arrow/util/uri.cc Outdated
@pitrou
pitrouforce-pushed the ARROW-7057-parse-qs branch from 4a672b7 to cd340b2CompareNovember 4, 2019 18:10
@bkietz

bkietz commented Nov 4, 2019

Copy link
Copy Markdown
Member

I'll merge on passing CI

@bkietzbkietz closed this in 2f5f261Nov 5, 2019
@pitrou
pitrou deleted the ARROW-7057-parse-qs branch November 5, 2019 08:30
@asfimportasfimport mentioned this pull request Nov 5, 2019
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bkietzbkietzbkietz approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pitrou@bkietz