Uh oh!
There was an error while loading. Please reload this page.
ARROW-7169: [C++] Vendor uriparser library - #5865
Closed
pitrou wants to merge 1 commit into
Closed
Conversation
pitrou
commented
Nov 19, 2019
MemberAuthor
@kou Do you have any concerns? |
pitrouforce-pushed
the
ARROW-7169-vendor-uriparser
branch
from
November 19, 2019 15:54
095988c to
7abf071Comparepitrouforce-pushed
the
ARROW-7169-vendor-uriparser
branch
3 times, most recently
from
November 19, 2019 19:37
01cf4b2 to
0a1a1daComparekou
approved these changes
Nov 20, 2019
Uh oh!
There was an error while loading. Please reload this page.
The library is only used internally (the types and headers are not exposed). Vendoring it makes it easier for core functionality to depend on it.
pitrouforce-pushed
the
ARROW-7169-vendor-uriparser
branch
from
November 20, 2019 12:12
0a1a1da to
83bb7c2Comparekszucs
commented
Nov 20, 2019
Member
@pitrou thanks for updating the packaging builds as well |
pitrou
commented
Nov 20, 2019
MemberAuthor
@kszucs Yes, I had forgotten to update some of them for the double-conversion vendoring. |
kszucs
commented
Nov 20, 2019
Member
Our nightlies are in pretty bad shape, so it would not make much sense to run them. Merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The library is only used internally (the types and headers are not exposed).
Vendoring it makes it easier for core functionality to depend on it.