Skip to content

ARROW-7633: [C++][CI] Create fuzz targets for tensors and sparse tensors - #6302

Closed
mrkn wants to merge 14 commits into
apache:masterfrom
mrkn:ARROW-7633
Closed

ARROW-7633: [C++][CI] Create fuzz targets for tensors and sparse tensors#6302
mrkn wants to merge 14 commits into
apache:masterfrom
mrkn:ARROW-7633

Conversation

@mrkn

@mrknmrkn commented Jan 28, 2020

Copy link
Copy Markdown
Member

No description provided.

@github-actions

Copy link
Copy Markdown

@emkornfield

Copy link
Copy Markdown
Contributor

@mrkn it looks like this needs a rebase? Were you going to pursue these changes (PR is still marked as a draft?)

@mrkn

mrkn commented Sep 14, 2020

Copy link
Copy Markdown
MemberAuthor

@emkornfield The reason why this is marked as draft is that I intend to include the fuzz target for sparse tensors. But I need more time to do it, so I want to split a pull request for sparse tensors.

I'll fix this and rebase to the mater branch asap.

@mrkn

mrkn commented Sep 28, 2020

Copy link
Copy Markdown
MemberAuthor

I need more several days for syncing this pull-request to the latest master branch.

@mrkn
mrknforce-pushed the ARROW-7633 branch 6 times, most recently from 5ee93da to b6bec6fCompareOctober 5, 2020 22:43
@mrkn
mrkn marked this pull request as ready for review October 5, 2020 22:44
@mrkn

mrkn commented Oct 6, 2020

Copy link
Copy Markdown
MemberAuthor

This pull request is ready to review.

@pitrou Could you have a look?

@mrkn
mrkn requested a review from pitrouOctober 6, 2020 14:47
@pitrou

Copy link
Copy Markdown
Member

I'll take a look later this week.

@mrkn

mrkn commented Oct 7, 2020

Copy link
Copy Markdown
MemberAuthor

Rebased due to #8350.

@mrkn

mrkn commented Oct 7, 2020

Copy link
Copy Markdown
MemberAuthor

Need to rebase again after #8373 is merged.

@mrkn
mrknforce-pushed the ARROW-7633 branch 2 times, most recently from 850954c to 1adb812CompareOctober 7, 2020 08:20
@wesm

wesm commented Dec 7, 2020

Copy link
Copy Markdown
Member

@mrkn@pitrou any chance this is close to being mergeable?

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple decltype(ndim) is modified by const so we need to use std::remove_const here.

@mrkn

mrkn commented Jan 19, 2021

Copy link
Copy Markdown
MemberAuthor

@pitrou I changed for your comments and left one reply comment.
One CI job on travis-ci failed but it seems unrelated to this pull-request.

@pitrou

Copy link
Copy Markdown
Member

Indeed, the CI failure is probably unrelated. I restarted it.

@pitrou

Copy link
Copy Markdown
Member

I rebased.

@pitrou

Copy link
Copy Markdown
Member

CI passed on my fork, will merge. Thank you @mrkn !

@mrkn
mrkn deleted the ARROW-7633 branch January 21, 2021 01:36
kszucs pushed a commit that referenced this pull request Jan 25, 2021
Closes#6302 from mrkn/ARROW-7633
Lead-authored-by: Kenta Murata <mrkn@mrkn.jp>
Co-authored-by: Antoine Pitrou <antoine@python.org>
Signed-off-by: Antoine Pitrou <antoine@python.org>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@mrkn@emkornfield@pitrou@wesm