Uh oh!
There was an error while loading. Please reload this page.
ARROW-7735: [Release][Python] Use pip to install dependencies for wheel verification - #6339
Closed
kszucs wants to merge 2 commits into
Closed
ARROW-7735: [Release][Python] Use pip to install dependencies for wheel verification#6339kszucs wants to merge 2 commits into
kszucs wants to merge 2 commits into
Conversation
Thanks for opening a pull request! Could you open an issue for this pull request on JIRA? Then could you also rename pull request title in the following format? See also: |
Member
Python 3.5 + manylinux1 passes with this change. But Python 3.5 + manylinux2000 shows the following error: $ python -c "from pip._internal import pep425tags; print('\n'.join(['-'.join(t) for t in pep425tags.get_supported()]))"cp35-cp35m-manylinux1_x86_64cp35-cp35m-linux_x86_64cp35-abi3-manylinux1_x86_64cp35-abi3-linux_x86_64cp35-none-manylinux1_x86_64cp35-none-linux_x86_64cp34-abi3-manylinux1_x86_64cp34-abi3-linux_x86_64cp33-abi3-manylinux1_x86_64cp33-abi3-linux_x86_64cp32-abi3-manylinux1_x86_64cp32-abi3-linux_x86_64py3-none-manylinux1_x86_64py3-none-linux_x86_64cp35-none-anycp3-none-anypy35-none-anypy3-none-anypy34-none-anypy33-none-anypy32-none-anypy31-none-anypy30-none-any |
kou
commented
Feb 2, 2020
Member
It may be better that we use Docker ( $ % docker run -it --rm python:3.5Python 3.5.9 (default, Feb 2 2020, 10:14:19) [GCC 8.3.0] on linuxType "help", "copyright", "credits" or "license" for more information.>>> from pip._internal import pep425tags; print('\n'.join([str(t) for t in pep425tags.get_supported()]))cp35-cp35m-manylinux2014_x86_64cp35-cp35m-manylinux2010_x86_64cp35-cp35m-manylinux1_x86_64cp35-cp35m-linux_x86_64cp35-abi3-manylinux2014_x86_64cp35-abi3-manylinux2010_x86_64cp35-abi3-manylinux1_x86_64cp35-abi3-linux_x86_64cp35-none-manylinux2014_x86_64cp35-none-manylinux2010_x86_64cp35-none-manylinux1_x86_64cp35-none-linux_x86_64cp34-abi3-manylinux2014_x86_64cp34-abi3-manylinux2010_x86_64cp34-abi3-manylinux1_x86_64cp34-abi3-linux_x86_64cp33-abi3-manylinux2014_x86_64cp33-abi3-manylinux2010_x86_64cp33-abi3-manylinux1_x86_64cp33-abi3-linux_x86_64cp32-abi3-manylinux2014_x86_64cp32-abi3-manylinux2010_x86_64cp32-abi3-manylinux1_x86_64cp32-abi3-linux_x86_64py35-none-manylinux2014_x86_64py35-none-manylinux2010_x86_64py35-none-manylinux1_x86_64py35-none-linux_x86_64py3-none-manylinux2014_x86_64py3-none-manylinux2010_x86_64py3-none-manylinux1_x86_64py3-none-linux_x86_64py34-none-manylinux2014_x86_64py34-none-manylinux2010_x86_64py34-none-manylinux1_x86_64py34-none-linux_x86_64py33-none-manylinux2014_x86_64py33-none-manylinux2010_x86_64py33-none-manylinux1_x86_64py33-none-linux_x86_64py32-none-manylinux2014_x86_64py32-none-manylinux2010_x86_64py32-none-manylinux1_x86_64py32-none-linux_x86_64py31-none-manylinux2014_x86_64py31-none-manylinux2010_x86_64py31-none-manylinux1_x86_64py31-none-linux_x86_64py30-none-manylinux2014_x86_64py30-none-manylinux2010_x86_64py30-none-manylinux1_x86_64py30-none-linux_x86_64cp35-none-anypy35-none-anypy3-none-anypy34-none-anypy33-none-anypy32-none-anypy31-none-anypy30-none-any |
kszucs
commented
Feb 3, 2020
MemberAuthor
@kou for testing the produced wheels we already use these docker images - which doesn't mean that we cannot rerun these checks during the release verification process. Although docker would only be suitable for testing the linux wheels. |
Member
It's quite possible that manylinux2010 doesn't have tooling for Python 3.5. |
pitrou
reviewed
Feb 3, 2020
| pip install -r ${ARROW_DIR}/python/requirements-test.txt | ||
| # execute the tests | ||
| pytest -sv --pyargs pyarrow |
Member
There was a problem hiding this comment.
The -s and -v flags are spammy. Better to remove them IMHO.
kszucs added a commit
that referenced
this pull request
Feb 7, 2020
…el verification The wheel verification script fails for python 3.5. At the same time the wheel properly works for python 3.5 docker images without conda environment. Conda forge doesn't maintain packages for python 3.5 anymore and something must have mixed with the numpy versions. This change fixed the wheel verification locally for me. Closes#6339 from kszucs/wheel-verification and squashes the following commits: 3e96949 <Krisztián Szűcs> remove pytest verbose flags 026e5fb <Krisztián Szűcs> use pip to install dependencies for wheel verification Authored-by: Krisztián Szűcs <szucs.krisztian@gmail.com> Signed-off-by: Krisztián Szűcs <szucs.krisztian@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The wheel verification script fails for python 3.5.
At the same time the wheel properly works for python 3.5 docker
images without conda environment.
Conda forge doesn't maintain packages for python 3.5 anymore
and something must have mixed with the numpy versions.
This change fixed the wheel verification locally for me.