Skip to content

ARROW-7760: [Release] Fix verify-release-candidate.sh since pip3 seems to no longer be in miniconda, install miniconda unconditionally - #6348

Closed
wesm wants to merge 3 commits into
apache:masterfrom
wesm:pip3-to-pip
Closed

ARROW-7760: [Release] Fix verify-release-candidate.sh since pip3 seems to no longer be in miniconda, install miniconda unconditionally#6348
wesm wants to merge 3 commits into
apache:masterfrom
wesm:pip3-to-pip

Conversation

@wesm

@wesmwesm commented Feb 3, 2020

Copy link
Copy Markdown
Member

This change was necessary for me to get the script to finish to completion.

@github-actions

Copy link
Copy Markdown

Thanks for opening a pull request!

Could you open an issue for this pull request on JIRA?
https://issues.apache.org/jira/browse/ARROW

Then could you also rename pull request title in the following format?

ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}

See also:

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you are sure you're using Python 3, I would say python3 -m pip install ... is the surest way.

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This step is invoked from within a conda environment that is set up in the script. I guess recently (January 2020-related?) the pip3 alias disappeared

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The conda environment wouldn't have been installed in certain flag configuration:

TEST_DEFAULT=0 TEST_INTEGRATION_GO=1 dev/release/verify-release-candidate.sh source 0.16.0 2

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed the script to always use miniconda.

@kszucskszucs changed the title [Release] Fix verify-release-candidate.sh since pip3 seems to no longer be in minicondaARROW-7760: [Release] Fix verify-release-candidate.sh since pip3 seems to no longer be in minicondaFeb 4, 2020
@github-actions

Copy link
Copy Markdown

@kszucs
kszucs requested review from kszucs and pitrou and removed request for kszucsFebruary 4, 2020 13:10
@wesmwesm changed the title ARROW-7760: [Release] Fix verify-release-candidate.sh since pip3 seems to no longer be in minicondaARROW-7760: [Release] Fix verify-release-candidate.sh since pip3 seems to no longer be in miniconda, install miniconda unconditionallyFeb 4, 2020
@wesm

wesm commented Feb 4, 2020

Copy link
Copy Markdown
MemberAuthor

+1

@wesm

wesm commented Feb 4, 2020

Copy link
Copy Markdown
MemberAuthor

I'm just running this locally and then will merge

@wesm

wesm commented Feb 4, 2020

Copy link
Copy Markdown
MemberAuthor

There's still some problems, working on fixes

… disabled. Fix selective disabling of integration test components in archery
@wesm

wesm commented Feb 4, 2020

Copy link
Copy Markdown
MemberAuthor

There were multiple other problems:

  • Current miniconda doesn't place a python or pip into PATH when running conda.sh (like it used to?) I guess this is to discourage people installing stuff in the root environment. So now we set up the "arrow-test" conda environment unconditionally
  • Selective disabling of integration test components was broken (so TEST_DEFAULT=0 TEST_SOURCE=1 TEST_INTEGRATION_GO=1 dev/release/verify-release-candidate.sh source 0.16.0 2 from above still failed)
  • Added a more helpful error message when you forget to put TEST_SOURCE=1 when using TEST_DEFAULT=0

@wesm

wesm commented Feb 4, 2020

Copy link
Copy Markdown
MemberAuthor

+1 again, I've put this through the paces locally (had to modify the verification script to install $ARROW_DIR/dev/archery to test the archery changes)

@wesmwesm closed this in 09059d5Feb 4, 2020
@wesm
wesm deleted the pip3-to-pip branch February 4, 2020 18:12
kszucs added a commit that referenced this pull request Feb 7, 2020
…s to no longer be in miniconda, install miniconda unconditionally
This change was necessary for me to get the script to finish to completion.
Closes#6348 from wesm/pip3-to-pip and squashes the following commits:
fcf3ae6 <Wes McKinney> conda environment must be activated for other steps to work if C++ is disabled. Fix selective disabling of integration test components in archery
26da759 <Krisztián Szűcs> always set up miniconda
490ceac <Wes McKinney> pip3 no longer in miniconda
Lead-authored-by: Wes McKinney <wesm+git@apache.org>
Co-authored-by: Krisztián Szűcs <szucs.krisztian@gmail.com>
Signed-off-by: Wes McKinney <wesm+git@apache.org>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@wesm@kszucs@pitrou