Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 4.3k
ARROW-7878: [C++][Compute] Draft LogicalPlan classes#6506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Changes from all commits
93398c3a3d5c678691ace77c5bf91b5931292bf4258ea5ddd8b47016236ff3c52d5a9b7d78abe6fbac474a478095679f83a9fc553f35c500369af82042324124675c6ef10404cf58f34File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,98 @@ | ||
| # Licensed to the Apache Software Foundation (ASF) under one | ||
| # or more contributor license agreements. See the NOTICE file | ||
| # distributed with this work for additional information | ||
| # regarding copyright ownership. The ASF licenses this file | ||
| # to you under the Apache License, Version 2.0 (the | ||
| # "License"); you may not use this file except in compliance | ||
| # with the License. You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, | ||
| # software distributed under the License is distributed on an | ||
| # "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| # KIND, either express or implied. See the License for the | ||
| # specific language governing permissions and limitations | ||
| # under the License. | ||
| # - Find Arrow Query Engine (arrow/engine/api.h, libarrow_engine.a, libarrow_engine.so) | ||
| # | ||
| # This module requires Arrow from which it uses | ||
| # arrow_find_package() | ||
| # | ||
| # This module defines | ||
| # ARROW_ENGINE_FOUND, whether Arrow Query Engine has been found | ||
| # ARROW_ENGINE_IMPORT_LIB, | ||
| # path to libarrow_engine's import library (Windows only) | ||
| # ARROW_ENGINE_INCLUDE_DIR, directory containing headers | ||
| # ARROW_ENGINE_LIB_DIR, directory containing Arrow Query Engine libraries | ||
| # ARROW_ENGINE_SHARED_LIB, path to libarrow_engine's shared library | ||
| # ARROW_ENGINE_STATIC_LIB, path to libarrow_engine.a | ||
| if(DEFINED ARROW_ENGINE_FOUND) | ||
| return() | ||
| endif() | ||
| set(find_package_arguments) | ||
| if(${CMAKE_FIND_PACKAGE_NAME}_FIND_VERSION) | ||
| list(APPEND find_package_arguments | ||
| "${${CMAKE_FIND_PACKAGE_NAME}_FIND_VERSION}") | ||
| endif() | ||
| if(${CMAKE_FIND_PACKAGE_NAME}_FIND_REQUIRED) | ||
| list(APPEND find_package_arguments REQUIRED) | ||
| endif() | ||
| if(${CMAKE_FIND_PACKAGE_NAME}_FIND_QUIETLY) | ||
| list(APPEND find_package_arguments QUIET) | ||
| endif() | ||
| find_package(Arrow ${find_package_arguments}) | ||
| find_package(ArrowEngine ${find_package_arguments}) | ||
| if(ARROW_FOUND AND ARROW_DATASET_FOUND) | ||
| arrow_find_package(ARROW_ENGINE | ||
| "${ARROW_HOME}" | ||
| arrow_engine | ||
| arrow/engine/api.h | ||
| ArrowEngine | ||
| arrow-engine) | ||
| if(NOT ARROW_ENGINE_VERSION) | ||
| set(ARROW_ENGINE_VERSION "${ARROW_VERSION}") | ||
| endif() | ||
| endif() | ||
| if("${ARROW_ENGINE_VERSION}" VERSION_EQUAL "${ARROW_VERSION}") | ||
| set(ARROW_ENGINE_VERSION_MATCH TRUE) | ||
| else() | ||
| set(ARROW_ENGINE_VERSION_MATCH FALSE) | ||
| endif() | ||
| mark_as_advanced(ARROW_ENGINE_IMPORT_LIB | ||
| ARROW_ENGINE_INCLUDE_DIR | ||
| ARROW_ENGINE_LIBS | ||
| ARROW_ENGINE_LIB_DIR | ||
| ARROW_ENGINE_SHARED_IMP_LIB | ||
| ARROW_ENGINE_SHARED_LIB | ||
| ARROW_ENGINE_STATIC_LIB | ||
| ARROW_ENGINE_VERSION | ||
| ARROW_ENGINE_VERSION_MATCH) | ||
| find_package_handle_standard_args(ArrowEngine | ||
| REQUIRED_VARS | ||
| ARROW_ENGINE_INCLUDE_DIR | ||
| ARROW_ENGINE_LIB_DIR | ||
| ARROW_ENGINE_VERSION_MATCH | ||
| VERSION_VAR | ||
| ARROW_ENGINE_VERSION) | ||
| set(ARROW_ENGINE_FOUND ${ArrowEngine_FOUND}) | ||
| if(ArrowEngine_FOUND AND NOT ArrowEngine_FIND_QUIETLY) | ||
| message(STATUS "Found the Arrow Engine by ${ARROW_ENGINE_FIND_APPROACH}") | ||
| message( | ||
| STATUS "Found the Arrow Engine shared library: ${ARROW_ENGINE_SHARED_LIB}" | ||
| ) | ||
| message( | ||
| STATUS "Found the Arrow Engine import library: ${ARROW_ENGINE_IMPORT_LIB}" | ||
| ) | ||
| message( | ||
| STATUS "Found the Arrow Engine static library: ${ARROW_ENGINE_STATIC_LIB}" | ||
| ) | ||
| endif() |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -586,6 +586,10 @@ if(ARROW_DATASET) | ||
| add_subdirectory(dataset) | ||
| endif() | ||
| if(ARROW_ENGINE) | ||
| add_subdirectory(engine) | ||
Member There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Anyone have name opinions. Is Some examples
🤷♂ | ||
| endif() | ||
| if(ARROW_FILESYSTEM) | ||
| add_subdirectory(filesystem) | ||
| endif() | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| # Licensed to the Apache Software Foundation (ASF) under one | ||
| # or more contributor license agreements. See the NOTICE file | ||
| # distributed with this work for additional information | ||
| # regarding copyright ownership. The ASF licenses this file | ||
| # to you under the Apache License, Version 2.0 (the | ||
| # "License"); you may not use this file except in compliance | ||
| # with the License. You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, | ||
| # software distributed under the License is distributed on an | ||
| # "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| # KIND, either express or implied. See the License for the | ||
| # specific language governing permissions and limitations | ||
| # under the License. | ||
| # | ||
| # This config sets the following variables in your project:: | ||
| # | ||
| # ArrowEngine_FOUND - true if Arrow Query engine is found on the system | ||
| # | ||
| # This config sets the following targets in your project:: | ||
| # | ||
| # arrow_engine_shared - for linked as shared library if shared library is built | ||
| # arrow_engine_static - for linked as static library if static library is built | ||
| @PACKAGE_INIT@ | ||
| include(CMakeFindDependencyMacro) | ||
| find_dependency(Arrow) | ||
| find_dependency(ArrowDataset) | ||
| # Load targets only once. If we load targets multiple times, CMake reports | ||
| # already existent target error. | ||
| if(NOT (TARGET arrow_engine_shared OR TARGET arrow_engine_static)) | ||
| include("${CMAKE_CURRENT_LIST_DIR}/ArrowEngineTargets.cmake") | ||
| endif() |
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't want to bikeshed about this but
ARROW_QUERY_ENGINEor something more "obvious" might aid readability, unless we come up with some other name for the project