Uh oh!
There was an error while loading. Please reload this page.
ARROW-8105: [Python] Fix segfault when shrunken masked array is passed to pyarrow.array - #6612
Closed
nugend wants to merge 3 commits into
Closed
ARROW-8105: [Python] Fix segfault when shrunken masked array is passed to pyarrow.array#6612nugend wants to merge 3 commits into
nugend wants to merge 3 commits into
Conversation
nugend
commented
Mar 16, 2020
ContributorAuthor
I'm not sure how to request a new test run for this PR. I think the failures are due to the bug mitigated in #6614 |
…d to pyarrow.array Needed to validate that the mask of the masked array wasn't equal to the nomask constant which indicates that the masked array was shrunk
jorisvandenbossche
approved these changes
Mar 17, 2020
jorisvandenbossche
commented
Mar 17, 2020
Member
@nugend Thanks for the PR! I rebased your commits, that should re-trigger the CI. |
nugend
commented
Mar 17, 2020
ContributorAuthor
@jorisvandenbossche Looks like everything's good now. |
jorisvandenbossche
commented
Mar 17, 2020
Member
@nugend Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needed to validate that the mask of the masked array wasn't equal to the nomask
constant which indicates that the masked array was shrunk