Skip to content

ARROW-8092: [CI][Crossbow] OSX wheels fail on bundled bzip2 - #6616

Closed
kszucs wants to merge 3 commits into
apache:masterfrom
kszucs:ARROW-8092
Closed

ARROW-8092: [CI][Crossbow] OSX wheels fail on bundled bzip2#6616
kszucs wants to merge 3 commits into
apache:masterfrom
kszucs:ARROW-8092

Conversation

@kszucs

Copy link
Copy Markdown
Member

The root cause that the macos sdk headers are no longer installed, don't know why wasn't it an issue previously (perhaps travis has changed something or we changed something in the build config), investigating it.

@kszucs

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit wheel-osx-cp38

@github-actions

Copy link
Copy Markdown

Revision: 608cdb3

Submitted crossbow builds: ursa-labs/crossbow @ actions-4

TaskStatus
wheel-osx-cp38TravisCI

@kszucs

Copy link
Copy Markdown
MemberAuthor

The issue first appeared 8 days ago.

@kszucs

Copy link
Copy Markdown
MemberAuthor

Probably here is the commit which has caused the regression 6fa6c91

@kszucs

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit wheel-osx-cp38

@github-actions

Copy link
Copy Markdown

Revision: 7f2ec9546a4ca8adac2f57027002af02efc43218

Submitted crossbow builds: ursa-labs/crossbow @ actions-5

TaskStatus
wheel-osx-cp38TravisCI

@github-actions

Copy link
Copy Markdown

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like passing CC causes the issue, need to investigate it in more detail.

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

macOS SDK headers are no longer installed under /usr/include so when we use system clang it cannot find its headers unless we explicitly pass the SDK path CFLAGS.

@kszucs

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit wheel-osx-cp35m wheel-osx-cp36m wheel-osx-cp37m wheel-osx-cp38

@github-actions

Copy link
Copy Markdown

Revision: fa25999

Submitted crossbow builds: ursa-labs/crossbow @ actions-10

TaskStatus
wheel-osx-cp35mTravisCI
wheel-osx-cp36mTravisCI
wheel-osx-cp37mTravisCI
wheel-osx-cp38TravisCI

@kszucs

kszucs commented Mar 16, 2020

Copy link
Copy Markdown
MemberAuthor

Passing CFLAGS has resolved the bzip2_ep build issue, so this should resolve the immediate issue with the OSX wheels, although we might want to have a general solution for the missing OSX SDK headers in cmake. cc @xhochy

@kszucs

Copy link
Copy Markdown
MemberAuthor

The build failures should be fixed by #6633

@kou

kou commented Mar 16, 2020

Copy link
Copy Markdown
Member

I think that exporting the SDKROOT environment variable like #5756 will fix this.

@kszucs

Copy link
Copy Markdown
MemberAuthor

Thanks for the suggestion, I'm going to try it.

@kou

kou commented Mar 17, 2020

Copy link
Copy Markdown
Member

@github-actions crossbow submit wheel-osx-cp35m wheel-osx-cp36m wheel-osx-cp37m wheel-osx-cp38

@github-actions

Copy link
Copy Markdown

Revision: edb410a

Submitted crossbow builds: ursa-labs/crossbow @ actions-14

TaskStatus
wheel-osx-cp35mTravisCI
wheel-osx-cp36mTravisCI
wheel-osx-cp37mTravisCI
wheel-osx-cp38TravisCI

@kou

kou commented Mar 18, 2020

Copy link
Copy Markdown
Member

+1
Bzip2 build works with SDKROOT.

@koukou closed this in 5f3504eMar 18, 2020
@kszucs

Copy link
Copy Markdown
MemberAuthor

Thanks @kou!

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@kszucs@kou