Uh oh!
There was an error while loading. Please reload this page.
ARROW-8060: [Python] Make dataset Expression objects serializable - #6702
ARROW-8060: [Python] Make dataset Expression objects serializable#6702kszucs wants to merge 6 commits into
Conversation
Uh oh!
There was an error while loading. Please reload this page.
jorisvandenbossche
left a comment
There was a problem hiding this comment.
Thanks! added some comments
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
wesm
commented
Mar 25, 2020
Is there a JIRA about defining a e.g. Flatbuffers-based serialization protocol (probably better than Protobuf so we avoid having to introduce a library dependency) for expressions? Seems like it might provide a more scalable solution for serialization and could eventually succeed the strategy here |
kszucs
commented
Mar 25, 2020
Created JIRA https://issues.apache.org/jira/browse/ARROW-8214 |
kszucs
left a comment
There was a problem hiding this comment.
+1, build failure is unrelated.
The Scalar are not properly exposed yet and the C++ implementation will change soon so while the serialization will work, we need to refactor this code.