Uh oh!
There was an error while loading. Please reload this page.
ARROW-9079: [C++] Write benchmark for arithmetic kernels - #7417
Conversation
Uh oh!
There was an error while loading. Please reload this page.
wesm
commented
Jun 12, 2020
Thanks for working on this. I'll check the benchmarks on MSVC also |
wesm
commented
Jun 12, 2020
There don't seem to be issues on MSVC https://gist.github.com/wesm/45be57393b2d9186f87faae228f12380/revisions |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
…rrays. Add items processed output
wesm
commented
Jun 13, 2020
+1. I fixed a few lingering issues that jumped out at me, will merge this once build passes |
| bench->Unit(benchmark::kMicrosecond); | ||
| for (const auto size : kMemorySizes) { | ||
| for (const auto size : {kL1Size, kL2Size}) { |
There was a problem hiding this comment.
I have a processor with 22MB L3 cache so generating that much random data is quite expensive. If we want to benchmark arrays that big we should generate a smaller sample of random data and repeat/tile it to make the bigger array.
kszucs
commented
Jun 15, 2020
Thanks! |
Quickly wanted to add a benchmark for the
Addfunction to verify that no significant regressions were introduced by #7341Before:
After:
cc @wesm