Skip to content

ARROW-9055: [C++] Add sum/mean/minmax kernels for Boolean type - #7478

Closed
kszucs wants to merge 11 commits into
apache:masterfrom
kszucs:ARROW-9055
Closed

ARROW-9055: [C++] Add sum/mean/minmax kernels for Boolean type#7478
kszucs wants to merge 11 commits into
apache:masterfrom
kszucs:ARROW-9055

Conversation

@kszucs

@kszucskszucs commented Jun 18, 2020

Copy link
Copy Markdown
Member

No description provided.

kszucs
kszucs commented Jun 18, 2020
View reviewed changes
Comment threadcpp/src/arrow/compute/kernels/aggregate_basic.cc Outdated
@github-actions

github-actionsBot commented Jun 18, 2020

Copy link
Copy Markdown

https://issues.apache.org/jira/browse/ARROW-9055

pitrou
pitrou reviewed Jun 18, 2020
View reviewed changes
Comment threadcpp/src/arrow/compute/kernels/aggregate_test.cc Outdated

@pitroupitrouJun 18, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why isn't it 0 here?

pitrou
pitrou reviewed Jun 18, 2020
View reviewed changes
Comment threadcpp/src/arrow/compute/kernels/aggregate_test.cc Outdated
pitrou
pitrou reviewed Jun 18, 2020
View reviewed changes
Comment threadcpp/src/arrow/compute/kernels/aggregate_test.cc Outdated
pitrou
pitrou reviewed Jun 18, 2020
View reviewed changes
Comment threadcpp/src/arrow/compute/kernels/aggregate_test.cc Outdated
pitrou
pitrou reviewed Jun 18, 2020
View reviewed changes
Comment threadcpp/src/arrow/compute/kernels/aggregate_test.cc Outdated
wesm
wesm requested changes Jun 18, 2020
View reviewed changes
Comment threadcpp/src/arrow/compute/kernels/aggregate_basic.cc Outdated
@nealrichardson

nealrichardson commented Jun 18, 2020

Copy link
Copy Markdown
Member

I pushed some changes to the R bindings to take advantage of this. I'll note that MinMax also doesn't support boolean and probably should.

@kszucskszucs changed the title ARROW-9055: [C++] Add sum/mean kernels for Boolean typeARROW-9055: [C++] Add sum/mean/minmax kernels for Boolean typeJun 19, 2020
kszucs
kszucs commented Jun 19, 2020
View reviewed changes
Comment threadcpp/src/arrow/compute/kernels/aggregate_basic.cc Outdated

@kszucskszucsJun 19, 2020

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BooleanArray has no raw_values() method.

kszucs
kszucs commented Jun 19, 2020
View reviewed changes
Comment threadcpp/src/arrow/compute/kernels/aggregate_basic.cc Outdated
kszucs
kszucs commented Jun 19, 2020
View reviewed changes
Comment threadcpp/src/arrow/compute/kernels/aggregate_test.cc Outdated

@kszucskszucsJun 19, 2020

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So these were returning the types' extreme values.

kszucs
kszucs commented Jun 19, 2020
View reviewed changes
Comment threadr/R/compute.R Outdated
nealrichardson
nealrichardson approved these changes Jun 19, 2020
View reviewed changes

@nealrichardsonnealrichardson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the R side, this LGTM

@kszucs
kszucs requested a review from wesmJune 22, 2020 09:38
@kszucs

kszucs commented Jun 24, 2020

Copy link
Copy Markdown
MemberAuthor

ping @wesm

@wesm

wesm commented Jun 24, 2020

Copy link
Copy Markdown
Member

Looking

wesm
wesm reviewed Jun 24, 2020
View reviewed changes

@wesmwesm left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The min/max implementation seems more complicated / less efficient than it needs to be, and I think the unit test setup could be simplified, but otherwise this looks OK

Comment threadcpp/src/arrow/compute/kernels/aggregate_basic.cc Outdated
Comment threadcpp/src/arrow/compute/kernels/aggregate_test.cc Outdated
Comment threadcpp/src/arrow/testing/gtest_util.h Outdated
@kszucs

kszucs commented Jun 26, 2020

Copy link
Copy Markdown
MemberAuthor

@ursabot build

wesm
wesm approved these changes Jun 30, 2020
View reviewed changes

@wesmwesm left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1. We will have to resolve the sum([]) -> null/0 by introducing a "minimum valid values" option.

  • minimum # valid values == 0 -> 0
  • minimum # valid values == 1 -> null

@wesmwesm closed this in db719ffJul 1, 2020
@jorisvandenbossche

jorisvandenbossche commented Jul 1, 2020•
edited
Loading

Copy link
Copy Markdown
Member

We will have to resolve the sum([]) -> null/0 by introducing a "minimum valid values" option.

Do we already have a JIRA to track this?

EDIT -> it is mentioned in ARROW-9054

@asfimportasfimport mentioned this pull request Jul 1, 2020
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pitroupitroupitrou left review comments
@wesmwesmwesm approved these changes
@nealrichardsonnealrichardsonnealrichardson approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@kszucs@nealrichardson@wesm@jorisvandenbossche@pitrou