ARROW-4429: [Doc] Add Git conventions to contributing guidelines - #7503
Closed
suvayu wants to merge 4 commits into
Closed
ARROW-4429: [Doc] Add Git conventions to contributing guidelines#7503suvayu wants to merge 4 commits into
suvayu wants to merge 4 commits into
Conversation
pitrou
reviewed
Jun 22, 2020
Since `git pull --rebase` is being called earlier, the abort command should be `git rebase --abort`, instead of the usual.
Member
|
@nealrichardson Do you want to review this? |
nealrichardson
self-requested a review
June 22, 2020 15:22
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tried to summarise the mailing list thread mentioned in the JIRA, into a small section in the contributing guidelines. Please have a look.