Uh oh!
There was an error while loading. Please reload this page.
ARROW-9631: [Rust] flight should depend on arrow, not the other way around - #7892
Closed
andygrove wants to merge 4 commits into
Closed
ARROW-9631: [Rust] flight should depend on arrow, not the other way around#7892andygrove wants to merge 4 commits into
andygrove wants to merge 4 commits into
Conversation
vertexclique
commented
Aug 3, 2020
Contributor
Before merging this, please take a look at mine: #7894 |
andygrove
marked this pull request as ready for review
August 4, 2020 01:35
andygrove
commented
Aug 4, 2020
MemberAuthor
@vertexclique I would prefer to have this PR only change the dependency between arrow and flight. This is quite a large change in itself. We can create follow-on PRs to make changes to feature gates. |
nevi-me
commented
Aug 4, 2020
Contributor
or rebase the feature-gating PR against this one when it's merged ... |
Contributor
@nevi-me@andygrove
Sounds good? |
kszucs pushed a commit
to kszucs/arrow
that referenced
this pull request
Aug 17, 2020
…round The core `arrow` crate had a dependency on the `arrow-flight` crate, which doesn't make sense. Arrow should have minimal dependencies and should not depend on protocols or servers. Flight should depend on Arrow instead. I also changed the name of lib from `flight` to `arrow_flight` to match the Cargo manifest. I did this because I ran into compilation issues but I think this is worth changing anyway since there is already a `flight` crate on crates.io (unrelated to Arrow). I can try and roll back this change though if there are objections. Closesapache#7892 from andygrove/ARROW-9631 Authored-by: Andy Grove <andygrove@nvidia.com> Signed-off-by: Andy Grove <andygrove73@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The core
arrowcrate had a dependency on thearrow-flightcrate, which doesn't make sense. Arrow should have minimal dependencies and should not depend on protocols or servers. Flight should depend on Arrow instead.I also changed the name of lib from
flighttoarrow_flightto match the Cargo manifest. I did this because I ran into compilation issues but I think this is worth changing anyway since there is already aflightcrate on crates.io (unrelated to Arrow). I can try and roll back this change though if there are objections.