ARROW-9980: [Rust] [Parquet] Fix clippy lints#8173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nevi-me wants to merge 4 commits into from
Closed

ARROW-9980: [Rust] [Parquet] Fix clippy lints #8173

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a80693c
arrow clippy fixes
nevi-me Sep 11, 2020
0d50898
fix variable in examples
nevi-me Sep 11, 2020
0986881
parquet clippy lints
nevi-me Sep 11, 2020
9da75b5
fix tests, more lint fixes
nevi-me Sep 12, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion rust/arrow/benches/buffer_bit_ops.rs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -97,7 +97,7 @@ where

result_chunks
.into_remainder()
.into_iter()
.iter_mut()
.zip(
left_chunks
.remainder()
Expand Down
4 changes: 2 additions & 2 deletions rust/arrow/benches/cast_kernels.rs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -30,7 +30,7 @@ use arrow::compute::cast;
use arrow::datatypes::*;

// cast array from specified primitive array type to desired data type
fn cast_array<FROM>(size: usize, to_type: DataType) -> ()
fn cast_array<FROM>(size: usize, to_type: DataType)
where
FROM: ArrowNumericType,
Standard: Distribution<FROM::Native>,
Expand All@@ -44,7 +44,7 @@ where
}

// cast timestamp array from specified primitive array type to desired data type
fn cast_timestamp_array<FROM>(size: usize, to_type: DataType) -> ()
fn cast_timestamp_array<FROM>(size: usize, to_type: DataType)
where
FROM: ArrowTimestampType,
Standard: Distribution<i64>,
Expand Down
2 changes: 1 addition & 1 deletion rust/arrow/benches/csv_writer.rs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -65,7 +65,7 @@ fn criterion_benchmark(c: &mut Criterion) {
c.bench(
"record_batches_to_csv",
Benchmark::new("record_batches_to_csv", move |b| {
b.iter(|| record_batches_to_csv())
b.iter(record_batches_to_csv)
}),
);
}
Expand Down
2 changes: 1 addition & 1 deletion rust/arrow/benches/length_kernel.rs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -42,7 +42,7 @@ fn bench_length() {
}

fn add_benchmark(c: &mut Criterion) {
c.bench_function("length", |b| b.iter(|| bench_length()));
c.bench_function("length", |b| b.iter(bench_length));
}

criterion_group!(benches, add_benchmark);
Expand Down
4 changes: 2 additions & 2 deletions rust/arrow/benches/take_kernels.rs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -51,7 +51,7 @@ fn create_random_index(size: usize) -> UInt32Array {
)
}

fn take_numeric<T>(size: usize, index_len: usize) -> ()
fn take_numeric<T>(size: usize, index_len: usize)
where
T: ArrowNumericType,
Standard: Distribution<T::Native>,
Expand All@@ -63,7 +63,7 @@ where
criterion::black_box(take(&array, &index, None).unwrap());
}

fn take_boolean(size: usize, index_len: usize) -> () {
fn take_boolean(size: usize, index_len: usize) {
let array = Arc::new(BooleanArray::from(vec![random::<bool>(); size])) as ArrayRef;
let index = create_random_index(index_len);
criterion::black_box(take(&array, &index, None).unwrap());
Expand Down
6 changes: 3 additions & 3 deletions rust/arrow/examples/builders.rs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -100,10 +100,10 @@ fn main() {

// Construct a list array from the above two
let list_data_type = DataType::List(Box::new(DataType::Int32));
let list_data = ArrayData::builder(list_data_type.clone())
let list_data = ArrayData::builder(list_data_type)
.len(3)
.add_buffer(value_offsets.clone())
.add_child_data(value_data.clone())
.add_buffer(value_offsets)
.add_child_data(value_data)
.build();
let list_array = ListArray::from(list_data);

Expand Down
2 changes: 1 addition & 1 deletion rust/arrow/examples/read_csv.rs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -39,7 +39,7 @@ fn main() -> Result<()> {
let _batch = csv.next().unwrap().unwrap();
#[cfg(feature = "prettyprint")]
{
print_batches(&vec![_batch]).unwrap();
print_batches(&[_batch]).unwrap();
}
Ok(())
}
2 changes: 1 addition & 1 deletion rust/arrow/examples/read_csv_infer_schema.rs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -32,7 +32,7 @@ fn main() -> Result<()> {
let _batch = csv.next().unwrap().unwrap();
#[cfg(feature = "prettyprint")]
{
print_batches(&vec![_batch]).unwrap();
print_batches(&[_batch]).unwrap();
}
Ok(())
}
24 changes: 12 additions & 12 deletions rust/arrow/src/array/array.rs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -3212,9 +3212,9 @@ mod tests {

// Construct a list array from the above two
let list_data_type = DataType::FixedSizeList(Box::new(DataType::Int32), 3);
let list_data = ArrayData::builder(list_data_type.clone())
let list_data = ArrayData::builder(list_data_type)
.len(3)
.add_child_data(value_data.clone())
.add_child_data(value_data)
.build();
FixedSizeListArray::from(list_data);
}
Expand DownExpand Up@@ -3243,9 +3243,9 @@ mod tests {

// Construct a list array from the above two
let list_data_type = DataType::List(Box::new(DataType::Int32));
let list_data = ArrayData::builder(list_data_type.clone())
let list_data = ArrayData::builder(list_data_type)
.len(9)
.add_buffer(value_offsets.clone())
.add_buffer(value_offsets)
.add_child_data(value_data.clone())
.null_bit_buffer(Buffer::from(null_bits))
.build();
Expand DownExpand Up@@ -3307,9 +3307,9 @@ mod tests {

// Construct a list array from the above two
let list_data_type = DataType::LargeList(Box::new(DataType::Int32));
let list_data = ArrayData::builder(list_data_type.clone())
let list_data = ArrayData::builder(list_data_type)
.len(9)
.add_buffer(value_offsets.clone())
.add_buffer(value_offsets)
.add_child_data(value_data.clone())
.null_bit_buffer(Buffer::from(null_bits))
.build();
Expand DownExpand Up@@ -3369,7 +3369,7 @@ mod tests {

// Construct a fixed size list array from the above two
let list_data_type = DataType::FixedSizeList(Box::new(DataType::Int32), 2);
let list_data = ArrayData::builder(list_data_type.clone())
let list_data = ArrayData::builder(list_data_type)
.len(5)
.add_child_data(value_data.clone())
.null_bit_buffer(Buffer::from(null_bits))
Expand DownExpand Up@@ -3449,10 +3449,10 @@ mod tests {
let value_offsets = Buffer::from(&[2, 2, 5, 7].to_byte_slice());

let list_data_type = DataType::List(Box::new(DataType::Int32));
let list_data = ArrayData::builder(list_data_type.clone())
let list_data = ArrayData::builder(list_data_type)
.len(3)
.add_buffer(value_offsets.clone())
.add_child_data(value_data.clone())
.add_buffer(value_offsets)
.add_child_data(value_data)
.build();
ListArray::from(list_data);
}
Expand DownExpand Up@@ -4077,9 +4077,9 @@ mod tests {
.build();

let list_data_type = DataType::List(Box::new(DataType::Int32));
let list_data = ArrayData::builder(list_data_type.clone())
let list_data = ArrayData::builder(list_data_type)
.add_buffer(buf2)
.add_child_data(value_data.clone())
.add_child_data(value_data)
.build();
ListArray::from(list_data);
}
Expand Down
22 changes: 7 additions & 15 deletions rust/arrow/src/array/builder.rs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -2531,8 +2531,8 @@ mod tests {
#[test]
fn test_append_slice() {
let mut b = UInt8BufferBuilder::new(0);
b.append_slice("Hello, ".as_bytes()).unwrap();
b.append_slice("World!".as_bytes()).unwrap();
b.append_slice(b"Hello, ").unwrap();
b.append_slice(b"World!").unwrap();
let buffer = b.finish();
assert_eq!(13, buffer.len());

Expand DownExpand Up@@ -3099,9 +3099,7 @@ mod tests {
builder.append_byte(b'd').unwrap();
builder.append(true).unwrap();

let array = builder.finish();

let binary_array = BinaryArray::from(array);
let binary_array = builder.finish();

assert_eq!(3, binary_array.len());
assert_eq!(0, binary_array.null_count());
Expand DownExpand Up@@ -3130,9 +3128,7 @@ mod tests {
builder.append_byte(b'd').unwrap();
builder.append(true).unwrap();

let array = builder.finish();

let binary_array = LargeBinaryArray::from(array);
let binary_array = builder.finish();

assert_eq!(3, binary_array.len());
assert_eq!(0, binary_array.null_count());
Expand All@@ -3151,9 +3147,7 @@ mod tests {
builder.append(true).unwrap();
builder.append_value("world").unwrap();

let array = builder.finish();

let string_array = StringArray::from(array);
let string_array = builder.finish();

assert_eq!(3, string_array.len());
assert_eq!(0, string_array.null_count());
Expand DownExpand Up@@ -3210,9 +3204,7 @@ mod tests {
builder.append(true).unwrap();
builder.append_value("world").unwrap();

let array = builder.finish();

let string_array = StringArray::from(array);
let string_array = builder.finish();

assert_eq!(3, string_array.len());
assert_eq!(0, string_array.null_count());
Expand DownExpand Up@@ -3274,7 +3266,7 @@ mod tests {
.null_count(2)
.null_bit_buffer(Buffer::from(&[9_u8]))
.add_buffer(Buffer::from(&[0, 3, 3, 3, 7].to_byte_slice()))
.add_buffer(Buffer::from("joemark".as_bytes()))
.add_buffer(Buffer::from(b"joemark"))
.build();

let expected_int_data = ArrayData::builder(DataType::Int32)
Expand Down
20 changes: 10 additions & 10 deletions rust/arrow/src/array/union.rs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -657,7 +657,7 @@ mod tests {
// Check type ids
assert_eq!(
union.data().buffers()[0],
Buffer::from(&expected_type_ids.clone().to_byte_slice())
Buffer::from(&expected_type_ids.to_byte_slice())
);
for (i, id) in expected_type_ids.iter().enumerate() {
assert_eq!(id, &union.type_id(i));
Expand All@@ -666,7 +666,7 @@ mod tests {
// Check offsets
assert_eq!(
union.data().buffers()[1],
Buffer::from(expected_value_offsets.clone().to_byte_slice())
Buffer::from(expected_value_offsets.to_byte_slice())
);
for (i, id) in expected_value_offsets.iter().enumerate() {
assert_eq!(&union.value_offset(i), id);
Expand DownExpand Up@@ -951,7 +951,7 @@ mod tests {
.downcast_ref::<Float64Array>()
.unwrap()
.value(0);
assert_eq!(10.0, value);
assert!(10.0 - value < f64::EPSILON);

let slot = array.value(4);
let value = slot
Expand DownExpand Up@@ -983,7 +983,7 @@ mod tests {

// Check type ids
assert_eq!(
Buffer::from(&expected_type_ids.clone().to_byte_slice()),
Buffer::from(&expected_type_ids.to_byte_slice()),
union.data().buffers()[0]
);
for (i, id) in expected_type_ids.iter().enumerate() {
Expand DownExpand Up@@ -1034,7 +1034,7 @@ mod tests {

// Check type ids
assert_eq!(
Buffer::from(&expected_type_ids.clone().to_byte_slice()),
Buffer::from(&expected_type_ids.to_byte_slice()),
union.data().buffers()[0]
);
for (i, id) in expected_type_ids.iter().enumerate() {
Expand DownExpand Up@@ -1064,7 +1064,7 @@ mod tests {
let slot = slot.as_any().downcast_ref::<Float64Array>().unwrap();
assert_eq!(slot.len(), 1);
let value = slot.value(0);
assert_eq!(value, 3_f64);
assert!(value - 3_f64 < f64::EPSILON);
}
3 => {
let slot = slot.as_any().downcast_ref::<Int32Array>().unwrap();
Expand All@@ -1076,7 +1076,7 @@ mod tests {
let slot = slot.as_any().downcast_ref::<Float64Array>().unwrap();
assert_eq!(slot.len(), 1);
let value = slot.value(0);
assert_eq!(5_f64, value);
assert!(5_f64 - value < f64::EPSILON);
}
5 => {
let slot = slot.as_any().downcast_ref::<Int32Array>().unwrap();
Expand DownExpand Up@@ -1109,7 +1109,7 @@ mod tests {

// Check type ids
assert_eq!(
Buffer::from(&expected_type_ids.clone().to_byte_slice()),
Buffer::from(&expected_type_ids.to_byte_slice()),
union.data().buffers()[0]
);
for (i, id) in expected_type_ids.iter().enumerate() {
Expand DownExpand Up@@ -1142,7 +1142,7 @@ mod tests {
assert_eq!(false, union.is_null(i));
assert_eq!(slot.len(), 1);
let value = slot.value(0);
assert_eq!(value, 3_f64);
assert!(value - 3_f64 < f64::EPSILON);
}
4 => {
let slot = slot.as_any().downcast_ref::<Int32Array>().unwrap();
Expand DownExpand Up@@ -1187,7 +1187,7 @@ mod tests {
assert_eq!(false, new_union.is_null(i));
assert_eq!(slot.len(), 1);
let value = slot.value(0);
assert_eq!(value, 3_f64);
assert!(value - 3_f64 < f64::EPSILON);
}
3 => assert!(new_union.is_null(i)),
4 => {
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
ARROW-9980: [Rust] [Parquet] Fix clippy lints#8173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

nevi-me
wants to merge
4
commits into

from

 Closed


ARROW-9980: [Rust] [Parquet] Fix clippy lints
#8173
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


4 commits


Select commit
Hold shift + click to select a range
a80693c

arrow clippy fixes


nevi-me Sep 11, 2020
0d50898

fix variable in examples


nevi-me Sep 11, 2020
0986881

parquet clippy lints


nevi-me Sep 11, 2020
9da75b5

fix tests, more lint fixes


nevi-me Sep 12, 2020

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


2 changes: 1 addition & 1 deletion
rust/arrow/benches/buffer_bit_ops.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -97,7 +97,7 @@ where

 result_chunks
 .into_remainder()
 .into_iter()
 .iter_mut()
 .zip(
 left_chunks
 .remainder()
Expand Down

4 changes: 2 additions & 2 deletions
rust/arrow/benches/cast_kernels.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -30,7 +30,7 @@ use arrow::compute::cast;
use arrow::datatypes::*;

// cast array from specified primitive array type to desired data type
fn cast_array<FROM>(size: usize, to_type: DataType) -> ()
fn cast_array<FROM>(size: usize, to_type: DataType)
where
 FROM: ArrowNumericType,
 Standard: Distribution<FROM::Native>,
Expand All@@ -44,7 +44,7 @@ where
}

// cast timestamp array from specified primitive array type to desired data type
fn cast_timestamp_array<FROM>(size: usize, to_type: DataType) -> ()
fn cast_timestamp_array<FROM>(size: usize, to_type: DataType)
where
 FROM: ArrowTimestampType,
 Standard: Distribution<i64>,
Expand Down

2 changes: 1 addition & 1 deletion
rust/arrow/benches/csv_writer.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -65,7 +65,7 @@ fn criterion_benchmark(c: &mut Criterion) {
 c.bench(
 "record_batches_to_csv",
 Benchmark::new("record_batches_to_csv", move |b| {
 b.iter(|| record_batches_to_csv())
 b.iter(record_batches_to_csv)
 }),
 );
}
Expand Down

2 changes: 1 addition & 1 deletion
rust/arrow/benches/length_kernel.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -42,7 +42,7 @@ fn bench_length() {
}

fn add_benchmark(c: &mut Criterion) {
 c.bench_function("length", |b| b.iter(|| bench_length()));
 c.bench_function("length", |b| b.iter(bench_length));
}

criterion_group!(benches, add_benchmark);
Expand Down

4 changes: 2 additions & 2 deletions
rust/arrow/benches/take_kernels.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -51,7 +51,7 @@ fn create_random_index(size: usize) -> UInt32Array {
 )
}

fn take_numeric<T>(size: usize, index_len: usize) -> ()
fn take_numeric<T>(size: usize, index_len: usize)
where
 T: ArrowNumericType,
 Standard: Distribution<T::Native>,
Expand All@@ -63,7 +63,7 @@ where
 criterion::black_box(take(&array, &index, None).unwrap());
}

fn take_boolean(size: usize, index_len: usize) -> () {
fn take_boolean(size: usize, index_len: usize) {
 let array = Arc::new(BooleanArray::from(vec![random::<bool>(); size])) as ArrayRef;
 let index = create_random_index(index_len);
 criterion::black_box(take(&array, &index, None).unwrap());
Expand Down

6 changes: 3 additions & 3 deletions
rust/arrow/examples/builders.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -100,10 +100,10 @@ fn main() {

 // Construct a list array from the above two
 let list_data_type = DataType::List(Box::new(DataType::Int32));
 let list_data = ArrayData::builder(list_data_type.clone())
 let list_data = ArrayData::builder(list_data_type)
 .len(3)
 .add_buffer(value_offsets.clone())
 .add_child_data(value_data.clone())
 .add_buffer(value_offsets)
 .add_child_data(value_data)
 .build();
 let list_array = ListArray::from(list_data);

Expand Down

2 changes: 1 addition & 1 deletion
rust/arrow/examples/read_csv.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -39,7 +39,7 @@ fn main() -> Result<()> {
 let _batch = csv.next().unwrap().unwrap();
 #[cfg(feature = "prettyprint")]
 {
 print_batches(&vec![_batch]).unwrap();
 print_batches(&[_batch]).unwrap();
 }
 Ok(())
}

2 changes: 1 addition & 1 deletion
rust/arrow/examples/read_csv_infer_schema.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -32,7 +32,7 @@ fn main() -> Result<()> {
 let _batch = csv.next().unwrap().unwrap();
 #[cfg(feature = "prettyprint")]
 {
 print_batches(&vec![_batch]).unwrap();
 print_batches(&[_batch]).unwrap();
 }
 Ok(())
}

24 changes: 12 additions & 12 deletions
rust/arrow/src/array/array.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -3212,9 +3212,9 @@ mod tests {

 // Construct a list array from the above two
 let list_data_type = DataType::FixedSizeList(Box::new(DataType::Int32), 3);
 let list_data = ArrayData::builder(list_data_type.clone())
 let list_data = ArrayData::builder(list_data_type)
 .len(3)
 .add_child_data(value_data.clone())
 .add_child_data(value_data)
 .build();
 FixedSizeListArray::from(list_data);
 }
Expand DownExpand Up@@ -3243,9 +3243,9 @@ mod tests {

 // Construct a list array from the above two
 let list_data_type = DataType::List(Box::new(DataType::Int32));
 let list_data = ArrayData::builder(list_data_type.clone())
 let list_data = ArrayData::builder(list_data_type)
 .len(9)
 .add_buffer(value_offsets.clone())
 .add_buffer(value_offsets)
 .add_child_data(value_data.clone())
 .null_bit_buffer(Buffer::from(null_bits))
 .build();
Expand DownExpand Up@@ -3307,9 +3307,9 @@ mod tests {

 // Construct a list array from the above two
 let list_data_type = DataType::LargeList(Box::new(DataType::Int32));
 let list_data = ArrayData::builder(list_data_type.clone())
 let list_data = ArrayData::builder(list_data_type)
 .len(9)
 .add_buffer(value_offsets.clone())
 .add_buffer(value_offsets)
 .add_child_data(value_data.clone())
 .null_bit_buffer(Buffer::from(null_bits))
 .build();
Expand DownExpand Up@@ -3369,7 +3369,7 @@ mod tests {

 // Construct a fixed size list array from the above two
 let list_data_type = DataType::FixedSizeList(Box::new(DataType::Int32), 2);
 let list_data = ArrayData::builder(list_data_type.clone())
 let list_data = ArrayData::builder(list_data_type)
 .len(5)
 .add_child_data(value_data.clone())
 .null_bit_buffer(Buffer::from(null_bits))
Expand DownExpand Up@@ -3449,10 +3449,10 @@ mod tests {
 let value_offsets = Buffer::from(&[2, 2, 5, 7].to_byte_slice());

 let list_data_type = DataType::List(Box::new(DataType::Int32));
 let list_data = ArrayData::builder(list_data_type.clone())
 let list_data = ArrayData::builder(list_data_type)
 .len(3)
 .add_buffer(value_offsets.clone())
 .add_child_data(value_data.clone())
 .add_buffer(value_offsets)
 .add_child_data(value_data)
 .build();
 ListArray::from(list_data);
 }
Expand DownExpand Up@@ -4077,9 +4077,9 @@ mod tests {
 .build();

 let list_data_type = DataType::List(Box::new(DataType::Int32));
 let list_data = ArrayData::builder(list_data_type.clone())
 let list_data = ArrayData::builder(list_data_type)
 .add_buffer(buf2)
 .add_child_data(value_data.clone())
 .add_child_data(value_data)
 .build();
 ListArray::from(list_data);
 }
Expand Down

22 changes: 7 additions & 15 deletions
rust/arrow/src/array/builder.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -2531,8 +2531,8 @@ mod tests {
 #[test]
 fn test_append_slice() {
 let mut b = UInt8BufferBuilder::new(0);
 b.append_slice("Hello, ".as_bytes()).unwrap();
 b.append_slice("World!".as_bytes()).unwrap();
 b.append_slice(b"Hello, ").unwrap();
 b.append_slice(b"World!").unwrap();
 let buffer = b.finish();
 assert_eq!(13, buffer.len());

Expand DownExpand Up@@ -3099,9 +3099,7 @@ mod tests {
 builder.append_byte(b'd').unwrap();
 builder.append(true).unwrap();

 let array = builder.finish();

 let binary_array = BinaryArray::from(array);
 let binary_array = builder.finish();

 assert_eq!(3, binary_array.len());
 assert_eq!(0, binary_array.null_count());
Expand DownExpand Up@@ -3130,9 +3128,7 @@ mod tests {
 builder.append_byte(b'd').unwrap();
 builder.append(true).unwrap();

 let array = builder.finish();

 let binary_array = LargeBinaryArray::from(array);
 let binary_array = builder.finish();

 assert_eq!(3, binary_array.len());
 assert_eq!(0, binary_array.null_count());
Expand All@@ -3151,9 +3147,7 @@ mod tests {
 builder.append(true).unwrap();
 builder.append_value("world").unwrap();

 let array = builder.finish();

 let string_array = StringArray::from(array);
 let string_array = builder.finish();

 assert_eq!(3, string_array.len());
 assert_eq!(0, string_array.null_count());
Expand DownExpand Up@@ -3210,9 +3204,7 @@ mod tests {
 builder.append(true).unwrap();
 builder.append_value("world").unwrap();

 let array = builder.finish();

 let string_array = StringArray::from(array);
 let string_array = builder.finish();

 assert_eq!(3, string_array.len());
 assert_eq!(0, string_array.null_count());
Expand DownExpand Up@@ -3274,7 +3266,7 @@ mod tests {
 .null_count(2)
 .null_bit_buffer(Buffer::from(&[9_u8]))
 .add_buffer(Buffer::from(&[0, 3, 3, 3, 7].to_byte_slice()))
 .add_buffer(Buffer::from("joemark".as_bytes()))
 .add_buffer(Buffer::from(b"joemark"))
 .build();

 let expected_int_data = ArrayData::builder(DataType::Int32)
Expand Down

20 changes: 10 additions & 10 deletions
rust/arrow/src/array/union.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -657,7 +657,7 @@ mod tests {
 // Check type ids
 assert_eq!(
 union.data().buffers()[0],
 Buffer::from(&expected_type_ids.clone().to_byte_slice())
 Buffer::from(&expected_type_ids.to_byte_slice())
 );
 for (i, id) in expected_type_ids.iter().enumerate() {
 assert_eq!(id, &union.type_id(i));
Expand All@@ -666,7 +666,7 @@ mod tests {
 // Check offsets
 assert_eq!(
 union.data().buffers()[1],
 Buffer::from(expected_value_offsets.clone().to_byte_slice())
 Buffer::from(expected_value_offsets.to_byte_slice())
 );
 for (i, id) in expected_value_offsets.iter().enumerate() {
 assert_eq!(&union.value_offset(i), id);
Expand DownExpand Up@@ -951,7 +951,7 @@ mod tests {
 .downcast_ref::<Float64Array>()
 .unwrap()
 .value(0);
assert_eq!(10.0, value);
assert!(10.0 - value < f64::EPSILON);

 let slot = array.value(4);
 let value = slot
Expand DownExpand Up@@ -983,7 +983,7 @@ mod tests {

 // Check type ids
 assert_eq!(
 Buffer::from(&expected_type_ids.clone().to_byte_slice()),
 Buffer::from(&expected_type_ids.to_byte_slice()),
 union.data().buffers()[0]
 );
 for (i, id) in expected_type_ids.iter().enumerate() {
Expand DownExpand Up@@ -1034,7 +1034,7 @@ mod tests {

 // Check type ids
 assert_eq!(
 Buffer::from(&expected_type_ids.clone().to_byte_slice()),
 Buffer::from(&expected_type_ids.to_byte_slice()),
 union.data().buffers()[0]
 );
 for (i, id) in expected_type_ids.iter().enumerate() {
Expand DownExpand Up@@ -1064,7 +1064,7 @@ mod tests {
 let slot = slot.as_any().downcast_ref::<Float64Array>().unwrap();
 assert_eq!(slot.len(), 1);
 let value = slot.value(0);
assert_eq!(value, 3_f64);
assert!(value - 3_f64 < f64::EPSILON);
 }
 3 => {
 let slot = slot.as_any().downcast_ref::<Int32Array>().unwrap();
Expand All@@ -1076,7 +1076,7 @@ mod tests {
 let slot = slot.as_any().downcast_ref::<Float64Array>().unwrap();
 assert_eq!(slot.len(), 1);
 let value = slot.value(0);
assert_eq!(5_f64, value);
assert!(5_f64 - value < f64::EPSILON);
 }
 5 => {
 let slot = slot.as_any().downcast_ref::<Int32Array>().unwrap();
Expand DownExpand Up@@ -1109,7 +1109,7 @@ mod tests {

 // Check type ids
 assert_eq!(
 Buffer::from(&expected_type_ids.clone().to_byte_slice()),
 Buffer::from(&expected_type_ids.to_byte_slice()),
 union.data().buffers()[0]
 );
 for (i, id) in expected_type_ids.iter().enumerate() {
Expand DownExpand Up@@ -1142,7 +1142,7 @@ mod tests {
 assert_eq!(false, union.is_null(i));
 assert_eq!(slot.len(), 1);
 let value = slot.value(0);
assert_eq!(value, 3_f64);
assert!(value - 3_f64 < f64::EPSILON);
 }
 4 => {
 let slot = slot.as_any().downcast_ref::<Int32Array>().unwrap();
Expand DownExpand Up@@ -1187,7 +1187,7 @@ mod tests {
 assert_eq!(false, new_union.is_null(i));
 assert_eq!(slot.len(), 1);
 let value = slot.value(0);
assert_eq!(value, 3_f64);
assert!(value - 3_f64 < f64::EPSILON);
 }
 3 => assert!(new_union.is_null(i)),
 4 => {
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
ARROW-9980: [Rust] [Parquet] Fix clippy lints#8173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

nevi-me
wants to merge
4
commits into

from

 Closed


ARROW-9980: [Rust] [Parquet] Fix clippy lints
#8173
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


4 commits


Select commit
Hold shift + click to select a range
a80693c

arrow clippy fixes


nevi-me Sep 11, 2020
0d50898

fix variable in examples


nevi-me Sep 11, 2020
0986881

parquet clippy lints


nevi-me Sep 11, 2020
9da75b5

fix tests, more lint fixes


nevi-me Sep 12, 2020

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


2 changes: 1 addition & 1 deletion
rust/arrow/benches/buffer_bit_ops.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -97,7 +97,7 @@ where

 result_chunks
 .into_remainder()
 .into_iter()
 .iter_mut()
 .zip(
 left_chunks
 .remainder()
Expand Down

4 changes: 2 additions & 2 deletions
rust/arrow/benches/cast_kernels.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -30,7 +30,7 @@ use arrow::compute::cast;
use arrow::datatypes::*;

// cast array from specified primitive array type to desired data type
fn cast_array<FROM>(size: usize, to_type: DataType) -> ()
fn cast_array<FROM>(size: usize, to_type: DataType)
where
 FROM: ArrowNumericType,
 Standard: Distribution<FROM::Native>,
Expand All@@ -44,7 +44,7 @@ where
}

// cast timestamp array from specified primitive array type to desired data type
fn cast_timestamp_array<FROM>(size: usize, to_type: DataType) -> ()
fn cast_timestamp_array<FROM>(size: usize, to_type: DataType)
where
 FROM: ArrowTimestampType,
 Standard: Distribution<i64>,
Expand Down

2 changes: 1 addition & 1 deletion
rust/arrow/benches/csv_writer.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -65,7 +65,7 @@ fn criterion_benchmark(c: &mut Criterion) {
 c.bench(
 "record_batches_to_csv",
 Benchmark::new("record_batches_to_csv", move |b| {
 b.iter(|| record_batches_to_csv())
 b.iter(record_batches_to_csv)
 }),
 );
}
Expand Down

2 changes: 1 addition & 1 deletion
rust/arrow/benches/length_kernel.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -42,7 +42,7 @@ fn bench_length() {
}

fn add_benchmark(c: &mut Criterion) {
 c.bench_function("length", |b| b.iter(|| bench_length()));
 c.bench_function("length", |b| b.iter(bench_length));
}

criterion_group!(benches, add_benchmark);
Expand Down

4 changes: 2 additions & 2 deletions
rust/arrow/benches/take_kernels.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -51,7 +51,7 @@ fn create_random_index(size: usize) -> UInt32Array {
 )
}

fn take_numeric<T>(size: usize, index_len: usize) -> ()
fn take_numeric<T>(size: usize, index_len: usize)
where
 T: ArrowNumericType,
 Standard: Distribution<T::Native>,
Expand All@@ -63,7 +63,7 @@ where
 criterion::black_box(take(&array, &index, None).unwrap());
}

fn take_boolean(size: usize, index_len: usize) -> () {
fn take_boolean(size: usize, index_len: usize) {
 let array = Arc::new(BooleanArray::from(vec![random::<bool>(); size])) as ArrayRef;
 let index = create_random_index(index_len);
 criterion::black_box(take(&array, &index, None).unwrap());
Expand Down

6 changes: 3 additions & 3 deletions
rust/arrow/examples/builders.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -100,10 +100,10 @@ fn main() {

 // Construct a list array from the above two
 let list_data_type = DataType::List(Box::new(DataType::Int32));
 let list_data = ArrayData::builder(list_data_type.clone())
 let list_data = ArrayData::builder(list_data_type)
 .len(3)
 .add_buffer(value_offsets.clone())
 .add_child_data(value_data.clone())
 .add_buffer(value_offsets)
 .add_child_data(value_data)
 .build();
 let list_array = ListArray::from(list_data);

Expand Down

2 changes: 1 addition & 1 deletion
rust/arrow/examples/read_csv.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -39,7 +39,7 @@ fn main() -> Result<()> {
 let _batch = csv.next().unwrap().unwrap();
 #[cfg(feature = "prettyprint")]
 {
 print_batches(&vec![_batch]).unwrap();
 print_batches(&[_batch]).unwrap();
 }
 Ok(())
}

2 changes: 1 addition & 1 deletion
rust/arrow/examples/read_csv_infer_schema.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -32,7 +32,7 @@ fn main() -> Result<()> {
 let _batch = csv.next().unwrap().unwrap();
 #[cfg(feature = "prettyprint")]
 {
 print_batches(&vec![_batch]).unwrap();
 print_batches(&[_batch]).unwrap();
 }
 Ok(())
}

24 changes: 12 additions & 12 deletions
rust/arrow/src/array/array.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -3212,9 +3212,9 @@ mod tests {

 // Construct a list array from the above two
 let list_data_type = DataType::FixedSizeList(Box::new(DataType::Int32), 3);
 let list_data = ArrayData::builder(list_data_type.clone())
 let list_data = ArrayData::builder(list_data_type)
 .len(3)
 .add_child_data(value_data.clone())
 .add_child_data(value_data)
 .build();
 FixedSizeListArray::from(list_data);
 }
Expand DownExpand Up@@ -3243,9 +3243,9 @@ mod tests {

 // Construct a list array from the above two
 let list_data_type = DataType::List(Box::new(DataType::Int32));
 let list_data = ArrayData::builder(list_data_type.clone())
 let list_data = ArrayData::builder(list_data_type)
 .len(9)
 .add_buffer(value_offsets.clone())
 .add_buffer(value_offsets)
 .add_child_data(value_data.clone())
 .null_bit_buffer(Buffer::from(null_bits))
 .build();
Expand DownExpand Up@@ -3307,9 +3307,9 @@ mod tests {

 // Construct a list array from the above two
 let list_data_type = DataType::LargeList(Box::new(DataType::Int32));
 let list_data = ArrayData::builder(list_data_type.clone())
 let list_data = ArrayData::builder(list_data_type)
 .len(9)
 .add_buffer(value_offsets.clone())
 .add_buffer(value_offsets)
 .add_child_data(value_data.clone())
 .null_bit_buffer(Buffer::from(null_bits))
 .build();
Expand DownExpand Up@@ -3369,7 +3369,7 @@ mod tests {

 // Construct a fixed size list array from the above two
 let list_data_type = DataType::FixedSizeList(Box::new(DataType::Int32), 2);
 let list_data = ArrayData::builder(list_data_type.clone())
 let list_data = ArrayData::builder(list_data_type)
 .len(5)
 .add_child_data(value_data.clone())
 .null_bit_buffer(Buffer::from(null_bits))
Expand DownExpand Up@@ -3449,10 +3449,10 @@ mod tests {
 let value_offsets = Buffer::from(&[2, 2, 5, 7].to_byte_slice());

 let list_data_type = DataType::List(Box::new(DataType::Int32));
 let list_data = ArrayData::builder(list_data_type.clone())
 let list_data = ArrayData::builder(list_data_type)
 .len(3)
 .add_buffer(value_offsets.clone())
 .add_child_data(value_data.clone())
 .add_buffer(value_offsets)
 .add_child_data(value_data)
 .build();
 ListArray::from(list_data);
 }
Expand DownExpand Up@@ -4077,9 +4077,9 @@ mod tests {
 .build();

 let list_data_type = DataType::List(Box::new(DataType::Int32));
 let list_data = ArrayData::builder(list_data_type.clone())
 let list_data = ArrayData::builder(list_data_type)
 .add_buffer(buf2)
 .add_child_data(value_data.clone())
 .add_child_data(value_data)
 .build();
 ListArray::from(list_data);
 }
Expand Down

22 changes: 7 additions & 15 deletions
rust/arrow/src/array/builder.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -2531,8 +2531,8 @@ mod tests {
 #[test]
 fn test_append_slice() {
 let mut b = UInt8BufferBuilder::new(0);
 b.append_slice("Hello, ".as_bytes()).unwrap();
 b.append_slice("World!".as_bytes()).unwrap();
 b.append_slice(b"Hello, ").unwrap();
 b.append_slice(b"World!").unwrap();
 let buffer = b.finish();
 assert_eq!(13, buffer.len());

Expand DownExpand Up@@ -3099,9 +3099,7 @@ mod tests {
 builder.append_byte(b'd').unwrap();
 builder.append(true).unwrap();

 let array = builder.finish();

 let binary_array = BinaryArray::from(array);
 let binary_array = builder.finish();

 assert_eq!(3, binary_array.len());
 assert_eq!(0, binary_array.null_count());
Expand DownExpand Up@@ -3130,9 +3128,7 @@ mod tests {
 builder.append_byte(b'd').unwrap();
 builder.append(true).unwrap();

 let array = builder.finish();

 let binary_array = LargeBinaryArray::from(array);
 let binary_array = builder.finish();

 assert_eq!(3, binary_array.len());
 assert_eq!(0, binary_array.null_count());
Expand All@@ -3151,9 +3147,7 @@ mod tests {
 builder.append(true).unwrap();
 builder.append_value("world").unwrap();

 let array = builder.finish();

 let string_array = StringArray::from(array);
 let string_array = builder.finish();

 assert_eq!(3, string_array.len());
 assert_eq!(0, string_array.null_count());
Expand DownExpand Up@@ -3210,9 +3204,7 @@ mod tests {
 builder.append(true).unwrap();
 builder.append_value("world").unwrap();

 let array = builder.finish();

 let string_array = StringArray::from(array);
 let string_array = builder.finish();

 assert_eq!(3, string_array.len());
 assert_eq!(0, string_array.null_count());
Expand DownExpand Up@@ -3274,7 +3266,7 @@ mod tests {
 .null_count(2)
 .null_bit_buffer(Buffer::from(&[9_u8]))
 .add_buffer(Buffer::from(&[0, 3, 3, 3, 7].to_byte_slice()))
 .add_buffer(Buffer::from("joemark".as_bytes()))
 .add_buffer(Buffer::from(b"joemark"))
 .build();

 let expected_int_data = ArrayData::builder(DataType::Int32)
Expand Down

20 changes: 10 additions & 10 deletions
rust/arrow/src/array/union.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -657,7 +657,7 @@ mod tests {
 // Check type ids
 assert_eq!(
 union.data().buffers()[0],
 Buffer::from(&expected_type_ids.clone().to_byte_slice())
 Buffer::from(&expected_type_ids.to_byte_slice())
 );
 for (i, id) in expected_type_ids.iter().enumerate() {
 assert_eq!(id, &union.type_id(i));
Expand All@@ -666,7 +666,7 @@ mod tests {
 // Check offsets
 assert_eq!(
 union.data().buffers()[1],
 Buffer::from(expected_value_offsets.clone().to_byte_slice())
 Buffer::from(expected_value_offsets.to_byte_slice())
 );
 for (i, id) in expected_value_offsets.iter().enumerate() {
 assert_eq!(&union.value_offset(i), id);
Expand DownExpand Up@@ -951,7 +951,7 @@ mod tests {
 .downcast_ref::<Float64Array>()
 .unwrap()
 .value(0);
assert_eq!(10.0, value);
assert!(10.0 - value < f64::EPSILON);

 let slot = array.value(4);
 let value = slot
Expand DownExpand Up@@ -983,7 +983,7 @@ mod tests {

 // Check type ids
 assert_eq!(
 Buffer::from(&expected_type_ids.clone().to_byte_slice()),
 Buffer::from(&expected_type_ids.to_byte_slice()),
 union.data().buffers()[0]
 );
 for (i, id) in expected_type_ids.iter().enumerate() {
Expand DownExpand Up@@ -1034,7 +1034,7 @@ mod tests {

 // Check type ids
 assert_eq!(
 Buffer::from(&expected_type_ids.clone().to_byte_slice()),
 Buffer::from(&expected_type_ids.to_byte_slice()),
 union.data().buffers()[0]
 );
 for (i, id) in expected_type_ids.iter().enumerate() {
Expand DownExpand Up@@ -1064,7 +1064,7 @@ mod tests {
 let slot = slot.as_any().downcast_ref::<Float64Array>().unwrap();
 assert_eq!(slot.len(), 1);
 let value = slot.value(0);
assert_eq!(value, 3_f64);
assert!(value - 3_f64 < f64::EPSILON);
 }
 3 => {
 let slot = slot.as_any().downcast_ref::<Int32Array>().unwrap();
Expand All@@ -1076,7 +1076,7 @@ mod tests {
 let slot = slot.as_any().downcast_ref::<Float64Array>().unwrap();
 assert_eq!(slot.len(), 1);
 let value = slot.value(0);
assert_eq!(5_f64, value);
assert!(5_f64 - value < f64::EPSILON);
 }
 5 => {
 let slot = slot.as_any().downcast_ref::<Int32Array>().unwrap();
Expand DownExpand Up@@ -1109,7 +1109,7 @@ mod tests {

 // Check type ids
 assert_eq!(
 Buffer::from(&expected_type_ids.clone().to_byte_slice()),
 Buffer::from(&expected_type_ids.to_byte_slice()),
 union.data().buffers()[0]
 );
 for (i, id) in expected_type_ids.iter().enumerate() {
Expand DownExpand Up@@ -1142,7 +1142,7 @@ mod tests {
 assert_eq!(false, union.is_null(i));
 assert_eq!(slot.len(), 1);
 let value = slot.value(0);
assert_eq!(value, 3_f64);
assert!(value - 3_f64 < f64::EPSILON);
 }
 4 => {
 let slot = slot.as_any().downcast_ref::<Int32Array>().unwrap();
Expand DownExpand Up@@ -1187,7 +1187,7 @@ mod tests {
 assert_eq!(false, new_union.is_null(i));
 assert_eq!(slot.len(), 1);
 let value = slot.value(0);
assert_eq!(value, 3_f64);
assert!(value - 3_f64 < f64::EPSILON);
 }
 3 => assert!(new_union.is_null(i)),
 4 => {
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
ARROW-9980: [Rust] [Parquet] Fix clippy lints#8173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

nevi-me
wants to merge
4
commits into

from

 Closed


ARROW-9980: [Rust] [Parquet] Fix clippy lints
#8173
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


4 commits


Select commit
Hold shift + click to select a range
a80693c

arrow clippy fixes


nevi-me Sep 11, 2020
0d50898

fix variable in examples


nevi-me Sep 11, 2020
0986881

parquet clippy lints


nevi-me Sep 11, 2020
9da75b5

fix tests, more lint fixes


nevi-me Sep 12, 2020

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


2 changes: 1 addition & 1 deletion
rust/arrow/benches/buffer_bit_ops.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -97,7 +97,7 @@ where

 result_chunks
 .into_remainder()
 .into_iter()
 .iter_mut()
 .zip(
 left_chunks
 .remainder()
Expand Down

4 changes: 2 additions & 2 deletions
rust/arrow/benches/cast_kernels.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -30,7 +30,7 @@ use arrow::compute::cast;
use arrow::datatypes::*;

// cast array from specified primitive array type to desired data type
fn cast_array<FROM>(size: usize, to_type: DataType) -> ()
fn cast_array<FROM>(size: usize, to_type: DataType)
where
 FROM: ArrowNumericType,
 Standard: Distribution<FROM::Native>,
Expand All@@ -44,7 +44,7 @@ where
}

// cast timestamp array from specified primitive array type to desired data type
fn cast_timestamp_array<FROM>(size: usize, to_type: DataType) -> ()
fn cast_timestamp_array<FROM>(size: usize, to_type: DataType)
where
 FROM: ArrowTimestampType,
 Standard: Distribution<i64>,
Expand Down

2 changes: 1 addition & 1 deletion
rust/arrow/benches/csv_writer.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -65,7 +65,7 @@ fn criterion_benchmark(c: &mut Criterion) {
 c.bench(
 "record_batches_to_csv",
 Benchmark::new("record_batches_to_csv", move |b| {
 b.iter(|| record_batches_to_csv())
 b.iter(record_batches_to_csv)
 }),
 );
}
Expand Down

2 changes: 1 addition & 1 deletion
rust/arrow/benches/length_kernel.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -42,7 +42,7 @@ fn bench_length() {
}

fn add_benchmark(c: &mut Criterion) {
 c.bench_function("length", |b| b.iter(|| bench_length()));
 c.bench_function("length", |b| b.iter(bench_length));
}

criterion_group!(benches, add_benchmark);
Expand Down

4 changes: 2 additions & 2 deletions
rust/arrow/benches/take_kernels.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -51,7 +51,7 @@ fn create_random_index(size: usize) -> UInt32Array {
 )
}

fn take_numeric<T>(size: usize, index_len: usize) -> ()
fn take_numeric<T>(size: usize, index_len: usize)
where
 T: ArrowNumericType,
 Standard: Distribution<T::Native>,
Expand All@@ -63,7 +63,7 @@ where
 criterion::black_box(take(&array, &index, None).unwrap());
}

fn take_boolean(size: usize, index_len: usize) -> () {
fn take_boolean(size: usize, index_len: usize) {
 let array = Arc::new(BooleanArray::from(vec![random::<bool>(); size])) as ArrayRef;
 let index = create_random_index(index_len);
 criterion::black_box(take(&array, &index, None).unwrap());
Expand Down

6 changes: 3 additions & 3 deletions
rust/arrow/examples/builders.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -100,10 +100,10 @@ fn main() {

 // Construct a list array from the above two
 let list_data_type = DataType::List(Box::new(DataType::Int32));
 let list_data = ArrayData::builder(list_data_type.clone())
 let list_data = ArrayData::builder(list_data_type)
 .len(3)
 .add_buffer(value_offsets.clone())
 .add_child_data(value_data.clone())
 .add_buffer(value_offsets)
 .add_child_data(value_data)
 .build();
 let list_array = ListArray::from(list_data);

Expand Down

2 changes: 1 addition & 1 deletion
rust/arrow/examples/read_csv.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -39,7 +39,7 @@ fn main() -> Result<()> {
 let _batch = csv.next().unwrap().unwrap();
 #[cfg(feature = "prettyprint")]
 {
 print_batches(&vec![_batch]).unwrap();
 print_batches(&[_batch]).unwrap();
 }
 Ok(())
}

2 changes: 1 addition & 1 deletion
rust/arrow/examples/read_csv_infer_schema.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -32,7 +32,7 @@ fn main() -> Result<()> {
 let _batch = csv.next().unwrap().unwrap();
 #[cfg(feature = "prettyprint")]
 {
 print_batches(&vec![_batch]).unwrap();
 print_batches(&[_batch]).unwrap();
 }
 Ok(())
}

24 changes: 12 additions & 12 deletions
rust/arrow/src/array/array.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -3212,9 +3212,9 @@ mod tests {

 // Construct a list array from the above two
 let list_data_type = DataType::FixedSizeList(Box::new(DataType::Int32), 3);
 let list_data = ArrayData::builder(list_data_type.clone())
 let list_data = ArrayData::builder(list_data_type)
 .len(3)
 .add_child_data(value_data.clone())
 .add_child_data(value_data)
 .build();
 FixedSizeListArray::from(list_data);
 }
Expand DownExpand Up@@ -3243,9 +3243,9 @@ mod tests {

 // Construct a list array from the above two
 let list_data_type = DataType::List(Box::new(DataType::Int32));
 let list_data = ArrayData::builder(list_data_type.clone())
 let list_data = ArrayData::builder(list_data_type)
 .len(9)
 .add_buffer(value_offsets.clone())
 .add_buffer(value_offsets)
 .add_child_data(value_data.clone())
 .null_bit_buffer(Buffer::from(null_bits))
 .build();
Expand DownExpand Up@@ -3307,9 +3307,9 @@ mod tests {

 // Construct a list array from the above two
 let list_data_type = DataType::LargeList(Box::new(DataType::Int32));
 let list_data = ArrayData::builder(list_data_type.clone())
 let list_data = ArrayData::builder(list_data_type)
 .len(9)
 .add_buffer(value_offsets.clone())
 .add_buffer(value_offsets)
 .add_child_data(value_data.clone())
 .null_bit_buffer(Buffer::from(null_bits))
 .build();
Expand DownExpand Up@@ -3369,7 +3369,7 @@ mod tests {

 // Construct a fixed size list array from the above two
 let list_data_type = DataType::FixedSizeList(Box::new(DataType::Int32), 2);
 let list_data = ArrayData::builder(list_data_type.clone())
 let list_data = ArrayData::builder(list_data_type)
 .len(5)
 .add_child_data(value_data.clone())
 .null_bit_buffer(Buffer::from(null_bits))
Expand DownExpand Up@@ -3449,10 +3449,10 @@ mod tests {
 let value_offsets = Buffer::from(&[2, 2, 5, 7].to_byte_slice());

 let list_data_type = DataType::List(Box::new(DataType::Int32));
 let list_data = ArrayData::builder(list_data_type.clone())
 let list_data = ArrayData::builder(list_data_type)
 .len(3)
 .add_buffer(value_offsets.clone())
 .add_child_data(value_data.clone())
 .add_buffer(value_offsets)
 .add_child_data(value_data)
 .build();
 ListArray::from(list_data);
 }
Expand DownExpand Up@@ -4077,9 +4077,9 @@ mod tests {
 .build();

 let list_data_type = DataType::List(Box::new(DataType::Int32));
 let list_data = ArrayData::builder(list_data_type.clone())
 let list_data = ArrayData::builder(list_data_type)
 .add_buffer(buf2)
 .add_child_data(value_data.clone())
 .add_child_data(value_data)
 .build();
 ListArray::from(list_data);
 }
Expand Down

22 changes: 7 additions & 15 deletions
rust/arrow/src/array/builder.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -2531,8 +2531,8 @@ mod tests {
 #[test]
 fn test_append_slice() {
 let mut b = UInt8BufferBuilder::new(0);
 b.append_slice("Hello, ".as_bytes()).unwrap();
 b.append_slice("World!".as_bytes()).unwrap();
 b.append_slice(b"Hello, ").unwrap();
 b.append_slice(b"World!").unwrap();
 let buffer = b.finish();
 assert_eq!(13, buffer.len());

Expand DownExpand Up@@ -3099,9 +3099,7 @@ mod tests {
 builder.append_byte(b'd').unwrap();
 builder.append(true).unwrap();

 let array = builder.finish();

 let binary_array = BinaryArray::from(array);
 let binary_array = builder.finish();

 assert_eq!(3, binary_array.len());
 assert_eq!(0, binary_array.null_count());
Expand DownExpand Up@@ -3130,9 +3128,7 @@ mod tests {
 builder.append_byte(b'd').unwrap();
 builder.append(true).unwrap();

 let array = builder.finish();

 let binary_array = LargeBinaryArray::from(array);
 let binary_array = builder.finish();

 assert_eq!(3, binary_array.len());
 assert_eq!(0, binary_array.null_count());
Expand All@@ -3151,9 +3147,7 @@ mod tests {
 builder.append(true).unwrap();
 builder.append_value("world").unwrap();

 let array = builder.finish();

 let string_array = StringArray::from(array);
 let string_array = builder.finish();

 assert_eq!(3, string_array.len());
 assert_eq!(0, string_array.null_count());
Expand DownExpand Up@@ -3210,9 +3204,7 @@ mod tests {
 builder.append(true).unwrap();
 builder.append_value("world").unwrap();

 let array = builder.finish();

 let string_array = StringArray::from(array);
 let string_array = builder.finish();

 assert_eq!(3, string_array.len());
 assert_eq!(0, string_array.null_count());
Expand DownExpand Up@@ -3274,7 +3266,7 @@ mod tests {
 .null_count(2)
 .null_bit_buffer(Buffer::from(&[9_u8]))
 .add_buffer(Buffer::from(&[0, 3, 3, 3, 7].to_byte_slice()))
 .add_buffer(Buffer::from("joemark".as_bytes()))
 .add_buffer(Buffer::from(b"joemark"))
 .build();

 let expected_int_data = ArrayData::builder(DataType::Int32)
Expand Down

20 changes: 10 additions & 10 deletions
rust/arrow/src/array/union.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -657,7 +657,7 @@ mod tests {
 // Check type ids
 assert_eq!(
 union.data().buffers()[0],
 Buffer::from(&expected_type_ids.clone().to_byte_slice())
 Buffer::from(&expected_type_ids.to_byte_slice())
 );
 for (i, id) in expected_type_ids.iter().enumerate() {
 assert_eq!(id, &union.type_id(i));
Expand All@@ -666,7 +666,7 @@ mod tests {
 // Check offsets
 assert_eq!(
 union.data().buffers()[1],
 Buffer::from(expected_value_offsets.clone().to_byte_slice())
 Buffer::from(expected_value_offsets.to_byte_slice())
 );
 for (i, id) in expected_value_offsets.iter().enumerate() {
 assert_eq!(&union.value_offset(i), id);
Expand DownExpand Up@@ -951,7 +951,7 @@ mod tests {
 .downcast_ref::<Float64Array>()
 .unwrap()
 .value(0);
assert_eq!(10.0, value);
assert!(10.0 - value < f64::EPSILON);

 let slot = array.value(4);
 let value = slot
Expand DownExpand Up@@ -983,7 +983,7 @@ mod tests {

 // Check type ids
 assert_eq!(
 Buffer::from(&expected_type_ids.clone().to_byte_slice()),
 Buffer::from(&expected_type_ids.to_byte_slice()),
 union.data().buffers()[0]
 );
 for (i, id) in expected_type_ids.iter().enumerate() {
Expand DownExpand Up@@ -1034,7 +1034,7 @@ mod tests {

 // Check type ids
 assert_eq!(
 Buffer::from(&expected_type_ids.clone().to_byte_slice()),
 Buffer::from(&expected_type_ids.to_byte_slice()),
 union.data().buffers()[0]
 );
 for (i, id) in expected_type_ids.iter().enumerate() {
Expand DownExpand Up@@ -1064,7 +1064,7 @@ mod tests {
 let slot = slot.as_any().downcast_ref::<Float64Array>().unwrap();
 assert_eq!(slot.len(), 1);
 let value = slot.value(0);
assert_eq!(value, 3_f64);
assert!(value - 3_f64 < f64::EPSILON);
 }
 3 => {
 let slot = slot.as_any().downcast_ref::<Int32Array>().unwrap();
Expand All@@ -1076,7 +1076,7 @@ mod tests {
 let slot = slot.as_any().downcast_ref::<Float64Array>().unwrap();
 assert_eq!(slot.len(), 1);
 let value = slot.value(0);
assert_eq!(5_f64, value);
assert!(5_f64 - value < f64::EPSILON);
 }
 5 => {
 let slot = slot.as_any().downcast_ref::<Int32Array>().unwrap();
Expand DownExpand Up@@ -1109,7 +1109,7 @@ mod tests {

 // Check type ids
 assert_eq!(
 Buffer::from(&expected_type_ids.clone().to_byte_slice()),
 Buffer::from(&expected_type_ids.to_byte_slice()),
 union.data().buffers()[0]
 );
 for (i, id) in expected_type_ids.iter().enumerate() {
Expand DownExpand Up@@ -1142,7 +1142,7 @@ mod tests {
 assert_eq!(false, union.is_null(i));
 assert_eq!(slot.len(), 1);
 let value = slot.value(0);
assert_eq!(value, 3_f64);
assert!(value - 3_f64 < f64::EPSILON);
 }
 4 => {
 let slot = slot.as_any().downcast_ref::<Int32Array>().unwrap();
Expand DownExpand Up@@ -1187,7 +1187,7 @@ mod tests {
 assert_eq!(false, new_union.is_null(i));
 assert_eq!(slot.len(), 1);
 let value = slot.value(0);
assert_eq!(value, 3_f64);
assert!(value - 3_f64 < f64::EPSILON);
 }
 3 => assert!(new_union.is_null(i)),
 4 => {
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
ARROW-9980: [Rust] [Parquet] Fix clippy lints#8173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

nevi-me
wants to merge
4
commits into

from

 Closed


ARROW-9980: [Rust] [Parquet] Fix clippy lints
#8173
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


4 commits


Select commit
Hold shift + click to select a range
a80693c

arrow clippy fixes


nevi-me Sep 11, 2020
0d50898

fix variable in examples


nevi-me Sep 11, 2020
0986881

parquet clippy lints


nevi-me Sep 11, 2020
9da75b5

fix tests, more lint fixes


nevi-me Sep 12, 2020

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


2 changes: 1 addition & 1 deletion
rust/arrow/benches/buffer_bit_ops.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -97,7 +97,7 @@ where

 result_chunks
 .into_remainder()
 .into_iter()
 .iter_mut()
 .zip(
 left_chunks
 .remainder()
Expand Down

4 changes: 2 additions & 2 deletions
rust/arrow/benches/cast_kernels.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -30,7 +30,7 @@ use arrow::compute::cast;
use arrow::datatypes::*;

// cast array from specified primitive array type to desired data type
fn cast_array<FROM>(size: usize, to_type: DataType) -> ()
fn cast_array<FROM>(size: usize, to_type: DataType)
where
 FROM: ArrowNumericType,
 Standard: Distribution<FROM::Native>,
Expand All@@ -44,7 +44,7 @@ where
}

// cast timestamp array from specified primitive array type to desired data type
fn cast_timestamp_array<FROM>(size: usize, to_type: DataType) -> ()
fn cast_timestamp_array<FROM>(size: usize, to_type: DataType)
where
 FROM: ArrowTimestampType,
 Standard: Distribution<i64>,
Expand Down

2 changes: 1 addition & 1 deletion
rust/arrow/benches/csv_writer.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -65,7 +65,7 @@ fn criterion_benchmark(c: &mut Criterion) {
 c.bench(
 "record_batches_to_csv",
 Benchmark::new("record_batches_to_csv", move |b| {
 b.iter(|| record_batches_to_csv())
 b.iter(record_batches_to_csv)
 }),
 );
}
Expand Down

2 changes: 1 addition & 1 deletion
rust/arrow/benches/length_kernel.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -42,7 +42,7 @@ fn bench_length() {
}

fn add_benchmark(c: &mut Criterion) {
 c.bench_function("length", |b| b.iter(|| bench_length()));
 c.bench_function("length", |b| b.iter(bench_length));
}

criterion_group!(benches, add_benchmark);
Expand Down

4 changes: 2 additions & 2 deletions
rust/arrow/benches/take_kernels.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -51,7 +51,7 @@ fn create_random_index(size: usize) -> UInt32Array {
 )
}

fn take_numeric<T>(size: usize, index_len: usize) -> ()
fn take_numeric<T>(size: usize, index_len: usize)
where
 T: ArrowNumericType,
 Standard: Distribution<T::Native>,
Expand All@@ -63,7 +63,7 @@ where
 criterion::black_box(take(&array, &index, None).unwrap());
}

fn take_boolean(size: usize, index_len: usize) -> () {
fn take_boolean(size: usize, index_len: usize) {
 let array = Arc::new(BooleanArray::from(vec![random::<bool>(); size])) as ArrayRef;
 let index = create_random_index(index_len);
 criterion::black_box(take(&array, &index, None).unwrap());
Expand Down

6 changes: 3 additions & 3 deletions
rust/arrow/examples/builders.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -100,10 +100,10 @@ fn main() {

 // Construct a list array from the above two
 let list_data_type = DataType::List(Box::new(DataType::Int32));
 let list_data = ArrayData::builder(list_data_type.clone())
 let list_data = ArrayData::builder(list_data_type)
 .len(3)
 .add_buffer(value_offsets.clone())
 .add_child_data(value_data.clone())
 .add_buffer(value_offsets)
 .add_child_data(value_data)
 .build();
 let list_array = ListArray::from(list_data);

Expand Down

2 changes: 1 addition & 1 deletion
rust/arrow/examples/read_csv.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -39,7 +39,7 @@ fn main() -> Result<()> {
 let _batch = csv.next().unwrap().unwrap();
 #[cfg(feature = "prettyprint")]
 {
 print_batches(&vec![_batch]).unwrap();
 print_batches(&[_batch]).unwrap();
 }
 Ok(())
}

2 changes: 1 addition & 1 deletion
rust/arrow/examples/read_csv_infer_schema.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -32,7 +32,7 @@ fn main() -> Result<()> {
 let _batch = csv.next().unwrap().unwrap();
 #[cfg(feature = "prettyprint")]
 {
 print_batches(&vec![_batch]).unwrap();
 print_batches(&[_batch]).unwrap();
 }
 Ok(())
}

24 changes: 12 additions & 12 deletions
rust/arrow/src/array/array.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -3212,9 +3212,9 @@ mod tests {

 // Construct a list array from the above two
 let list_data_type = DataType::FixedSizeList(Box::new(DataType::Int32), 3);
 let list_data = ArrayData::builder(list_data_type.clone())
 let list_data = ArrayData::builder(list_data_type)
 .len(3)
 .add_child_data(value_data.clone())
 .add_child_data(value_data)
 .build();
 FixedSizeListArray::from(list_data);
 }
Expand DownExpand Up@@ -3243,9 +3243,9 @@ mod tests {

 // Construct a list array from the above two
 let list_data_type = DataType::List(Box::new(DataType::Int32));
 let list_data = ArrayData::builder(list_data_type.clone())
 let list_data = ArrayData::builder(list_data_type)
 .len(9)
 .add_buffer(value_offsets.clone())
 .add_buffer(value_offsets)
 .add_child_data(value_data.clone())
 .null_bit_buffer(Buffer::from(null_bits))
 .build();
Expand DownExpand Up@@ -3307,9 +3307,9 @@ mod tests {

 // Construct a list array from the above two
 let list_data_type = DataType::LargeList(Box::new(DataType::Int32));
 let list_data = ArrayData::builder(list_data_type.clone())
 let list_data = ArrayData::builder(list_data_type)
 .len(9)
 .add_buffer(value_offsets.clone())
 .add_buffer(value_offsets)
 .add_child_data(value_data.clone())
 .null_bit_buffer(Buffer::from(null_bits))
 .build();
Expand DownExpand Up@@ -3369,7 +3369,7 @@ mod tests {

 // Construct a fixed size list array from the above two
 let list_data_type = DataType::FixedSizeList(Box::new(DataType::Int32), 2);
 let list_data = ArrayData::builder(list_data_type.clone())
 let list_data = ArrayData::builder(list_data_type)
 .len(5)
 .add_child_data(value_data.clone())
 .null_bit_buffer(Buffer::from(null_bits))
Expand DownExpand Up@@ -3449,10 +3449,10 @@ mod tests {
 let value_offsets = Buffer::from(&[2, 2, 5, 7].to_byte_slice());

 let list_data_type = DataType::List(Box::new(DataType::Int32));
 let list_data = ArrayData::builder(list_data_type.clone())
 let list_data = ArrayData::builder(list_data_type)
 .len(3)
 .add_buffer(value_offsets.clone())
 .add_child_data(value_data.clone())
 .add_buffer(value_offsets)
 .add_child_data(value_data)
 .build();
 ListArray::from(list_data);
 }
Expand DownExpand Up@@ -4077,9 +4077,9 @@ mod tests {
 .build();

 let list_data_type = DataType::List(Box::new(DataType::Int32));
 let list_data = ArrayData::builder(list_data_type.clone())
 let list_data = ArrayData::builder(list_data_type)
 .add_buffer(buf2)
 .add_child_data(value_data.clone())
 .add_child_data(value_data)
 .build();
 ListArray::from(list_data);
 }
Expand Down

22 changes: 7 additions & 15 deletions
rust/arrow/src/array/builder.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -2531,8 +2531,8 @@ mod tests {
 #[test]
 fn test_append_slice() {
 let mut b = UInt8BufferBuilder::new(0);
 b.append_slice("Hello, ".as_bytes()).unwrap();
 b.append_slice("World!".as_bytes()).unwrap();
 b.append_slice(b"Hello, ").unwrap();
 b.append_slice(b"World!").unwrap();
 let buffer = b.finish();
 assert_eq!(13, buffer.len());

Expand DownExpand Up@@ -3099,9 +3099,7 @@ mod tests {
 builder.append_byte(b'd').unwrap();
 builder.append(true).unwrap();

 let array = builder.finish();

 let binary_array = BinaryArray::from(array);
 let binary_array = builder.finish();

 assert_eq!(3, binary_array.len());
 assert_eq!(0, binary_array.null_count());
Expand DownExpand Up@@ -3130,9 +3128,7 @@ mod tests {
 builder.append_byte(b'd').unwrap();
 builder.append(true).unwrap();

 let array = builder.finish();

 let binary_array = LargeBinaryArray::from(array);
 let binary_array = builder.finish();

 assert_eq!(3, binary_array.len());
 assert_eq!(0, binary_array.null_count());
Expand All@@ -3151,9 +3147,7 @@ mod tests {
 builder.append(true).unwrap();
 builder.append_value("world").unwrap();

 let array = builder.finish();

 let string_array = StringArray::from(array);
 let string_array = builder.finish();

 assert_eq!(3, string_array.len());
 assert_eq!(0, string_array.null_count());
Expand DownExpand Up@@ -3210,9 +3204,7 @@ mod tests {
 builder.append(true).unwrap();
 builder.append_value("world").unwrap();

 let array = builder.finish();

 let string_array = StringArray::from(array);
 let string_array = builder.finish();

 assert_eq!(3, string_array.len());
 assert_eq!(0, string_array.null_count());
Expand DownExpand Up@@ -3274,7 +3266,7 @@ mod tests {
 .null_count(2)
 .null_bit_buffer(Buffer::from(&[9_u8]))
 .add_buffer(Buffer::from(&[0, 3, 3, 3, 7].to_byte_slice()))
 .add_buffer(Buffer::from("joemark".as_bytes()))
 .add_buffer(Buffer::from(b"joemark"))
 .build();

 let expected_int_data = ArrayData::builder(DataType::Int32)
Expand Down

20 changes: 10 additions & 10 deletions
rust/arrow/src/array/union.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -657,7 +657,7 @@ mod tests {
 // Check type ids
 assert_eq!(
 union.data().buffers()[0],
 Buffer::from(&expected_type_ids.clone().to_byte_slice())
 Buffer::from(&expected_type_ids.to_byte_slice())
 );
 for (i, id) in expected_type_ids.iter().enumerate() {
 assert_eq!(id, &union.type_id(i));
Expand All@@ -666,7 +666,7 @@ mod tests {
 // Check offsets
 assert_eq!(
 union.data().buffers()[1],
 Buffer::from(expected_value_offsets.clone().to_byte_slice())
 Buffer::from(expected_value_offsets.to_byte_slice())
 );
 for (i, id) in expected_value_offsets.iter().enumerate() {
 assert_eq!(&union.value_offset(i), id);
Expand DownExpand Up@@ -951,7 +951,7 @@ mod tests {
 .downcast_ref::<Float64Array>()
 .unwrap()
 .value(0);
assert_eq!(10.0, value);
assert!(10.0 - value < f64::EPSILON);

 let slot = array.value(4);
 let value = slot
Expand DownExpand Up@@ -983,7 +983,7 @@ mod tests {

 // Check type ids
 assert_eq!(
 Buffer::from(&expected_type_ids.clone().to_byte_slice()),
 Buffer::from(&expected_type_ids.to_byte_slice()),
 union.data().buffers()[0]
 );
 for (i, id) in expected_type_ids.iter().enumerate() {
Expand DownExpand Up@@ -1034,7 +1034,7 @@ mod tests {

 // Check type ids
 assert_eq!(
 Buffer::from(&expected_type_ids.clone().to_byte_slice()),
 Buffer::from(&expected_type_ids.to_byte_slice()),
 union.data().buffers()[0]
 );
 for (i, id) in expected_type_ids.iter().enumerate() {
Expand DownExpand Up@@ -1064,7 +1064,7 @@ mod tests {
 let slot = slot.as_any().downcast_ref::<Float64Array>().unwrap();
 assert_eq!(slot.len(), 1);
 let value = slot.value(0);
assert_eq!(value, 3_f64);
assert!(value - 3_f64 < f64::EPSILON);
 }
 3 => {
 let slot = slot.as_any().downcast_ref::<Int32Array>().unwrap();
Expand All@@ -1076,7 +1076,7 @@ mod tests {
 let slot = slot.as_any().downcast_ref::<Float64Array>().unwrap();
 assert_eq!(slot.len(), 1);
 let value = slot.value(0);
assert_eq!(5_f64, value);
assert!(5_f64 - value < f64::EPSILON);
 }
 5 => {
 let slot = slot.as_any().downcast_ref::<Int32Array>().unwrap();
Expand DownExpand Up@@ -1109,7 +1109,7 @@ mod tests {

 // Check type ids
 assert_eq!(
 Buffer::from(&expected_type_ids.clone().to_byte_slice()),
 Buffer::from(&expected_type_ids.to_byte_slice()),
 union.data().buffers()[0]
 );
 for (i, id) in expected_type_ids.iter().enumerate() {
Expand DownExpand Up@@ -1142,7 +1142,7 @@ mod tests {
 assert_eq!(false, union.is_null(i));
 assert_eq!(slot.len(), 1);
 let value = slot.value(0);
assert_eq!(value, 3_f64);
assert!(value - 3_f64 < f64::EPSILON);
 }
 4 => {
 let slot = slot.as_any().downcast_ref::<Int32Array>().unwrap();
Expand DownExpand Up@@ -1187,7 +1187,7 @@ mod tests {
 assert_eq!(false, new_union.is_null(i));
 assert_eq!(slot.len(), 1);
 let value = slot.value(0);
assert_eq!(value, 3_f64);
assert!(value - 3_f64 < f64::EPSILON);
 }
 3 => assert!(new_union.is_null(i)),
 4 => {
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
ARROW-9980: [Rust] [Parquet] Fix clippy lints#8173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

nevi-me
wants to merge
4
commits into

from

 Closed


ARROW-9980: [Rust] [Parquet] Fix clippy lints
#8173
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


4 commits


Select commit
Hold shift + click to select a range
a80693c

arrow clippy fixes


nevi-me Sep 11, 2020
0d50898

fix variable in examples


nevi-me Sep 11, 2020
0986881

parquet clippy lints


nevi-me Sep 11, 2020
9da75b5

fix tests, more lint fixes


nevi-me Sep 12, 2020

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


2 changes: 1 addition & 1 deletion
rust/arrow/benches/buffer_bit_ops.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -97,7 +97,7 @@ where

 result_chunks
 .into_remainder()
 .into_iter()
 .iter_mut()
 .zip(
 left_chunks
 .remainder()
Expand Down

4 changes: 2 additions & 2 deletions
rust/arrow/benches/cast_kernels.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -30,7 +30,7 @@ use arrow::compute::cast;
use arrow::datatypes::*;

// cast array from specified primitive array type to desired data type
fn cast_array<FROM>(size: usize, to_type: DataType) -> ()
fn cast_array<FROM>(size: usize, to_type: DataType)
where
 FROM: ArrowNumericType,
 Standard: Distribution<FROM::Native>,
Expand All@@ -44,7 +44,7 @@ where
}

// cast timestamp array from specified primitive array type to desired data type
fn cast_timestamp_array<FROM>(size: usize, to_type: DataType) -> ()
fn cast_timestamp_array<FROM>(size: usize, to_type: DataType)
where
 FROM: ArrowTimestampType,
 Standard: Distribution<i64>,
Expand Down

2 changes: 1 addition & 1 deletion
rust/arrow/benches/csv_writer.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -65,7 +65,7 @@ fn criterion_benchmark(c: &mut Criterion) {
 c.bench(
 "record_batches_to_csv",
 Benchmark::new("record_batches_to_csv", move |b| {
 b.iter(|| record_batches_to_csv())
 b.iter(record_batches_to_csv)
 }),
 );
}
Expand Down

2 changes: 1 addition & 1 deletion
rust/arrow/benches/length_kernel.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -42,7 +42,7 @@ fn bench_length() {
}

fn add_benchmark(c: &mut Criterion) {
 c.bench_function("length", |b| b.iter(|| bench_length()));
 c.bench_function("length", |b| b.iter(bench_length));
}

criterion_group!(benches, add_benchmark);
Expand Down

4 changes: 2 additions & 2 deletions
rust/arrow/benches/take_kernels.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -51,7 +51,7 @@ fn create_random_index(size: usize) -> UInt32Array {
 )
}

fn take_numeric<T>(size: usize, index_len: usize) -> ()
fn take_numeric<T>(size: usize, index_len: usize)
where
 T: ArrowNumericType,
 Standard: Distribution<T::Native>,
Expand All@@ -63,7 +63,7 @@ where
 criterion::black_box(take(&array, &index, None).unwrap());
}

fn take_boolean(size: usize, index_len: usize) -> () {
fn take_boolean(size: usize, index_len: usize) {
 let array = Arc::new(BooleanArray::from(vec![random::<bool>(); size])) as ArrayRef;
 let index = create_random_index(index_len);
 criterion::black_box(take(&array, &index, None).unwrap());
Expand Down

6 changes: 3 additions & 3 deletions
rust/arrow/examples/builders.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -100,10 +100,10 @@ fn main() {

 // Construct a list array from the above two
 let list_data_type = DataType::List(Box::new(DataType::Int32));
 let list_data = ArrayData::builder(list_data_type.clone())
 let list_data = ArrayData::builder(list_data_type)
 .len(3)
 .add_buffer(value_offsets.clone())
 .add_child_data(value_data.clone())
 .add_buffer(value_offsets)
 .add_child_data(value_data)
 .build();
 let list_array = ListArray::from(list_data);

Expand Down

2 changes: 1 addition & 1 deletion
rust/arrow/examples/read_csv.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -39,7 +39,7 @@ fn main() -> Result<()> {
 let _batch = csv.next().unwrap().unwrap();
 #[cfg(feature = "prettyprint")]
 {
 print_batches(&vec![_batch]).unwrap();
 print_batches(&[_batch]).unwrap();
 }
 Ok(())
}

2 changes: 1 addition & 1 deletion
rust/arrow/examples/read_csv_infer_schema.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -32,7 +32,7 @@ fn main() -> Result<()> {
 let _batch = csv.next().unwrap().unwrap();
 #[cfg(feature = "prettyprint")]
 {
 print_batches(&vec![_batch]).unwrap();
 print_batches(&[_batch]).unwrap();
 }
 Ok(())
}

24 changes: 12 additions & 12 deletions
rust/arrow/src/array/array.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -3212,9 +3212,9 @@ mod tests {

 // Construct a list array from the above two
 let list_data_type = DataType::FixedSizeList(Box::new(DataType::Int32), 3);
 let list_data = ArrayData::builder(list_data_type.clone())
 let list_data = ArrayData::builder(list_data_type)
 .len(3)
 .add_child_data(value_data.clone())
 .add_child_data(value_data)
 .build();
 FixedSizeListArray::from(list_data);
 }
Expand DownExpand Up@@ -3243,9 +3243,9 @@ mod tests {

 // Construct a list array from the above two
 let list_data_type = DataType::List(Box::new(DataType::Int32));
 let list_data = ArrayData::builder(list_data_type.clone())
 let list_data = ArrayData::builder(list_data_type)
 .len(9)
 .add_buffer(value_offsets.clone())
 .add_buffer(value_offsets)
 .add_child_data(value_data.clone())
 .null_bit_buffer(Buffer::from(null_bits))
 .build();
Expand DownExpand Up@@ -3307,9 +3307,9 @@ mod tests {

 // Construct a list array from the above two
 let list_data_type = DataType::LargeList(Box::new(DataType::Int32));
 let list_data = ArrayData::builder(list_data_type.clone())
 let list_data = ArrayData::builder(list_data_type)
 .len(9)
 .add_buffer(value_offsets.clone())
 .add_buffer(value_offsets)
 .add_child_data(value_data.clone())
 .null_bit_buffer(Buffer::from(null_bits))
 .build();
Expand DownExpand Up@@ -3369,7 +3369,7 @@ mod tests {

 // Construct a fixed size list array from the above two
 let list_data_type = DataType::FixedSizeList(Box::new(DataType::Int32), 2);
 let list_data = ArrayData::builder(list_data_type.clone())
 let list_data = ArrayData::builder(list_data_type)
 .len(5)
 .add_child_data(value_data.clone())
 .null_bit_buffer(Buffer::from(null_bits))
Expand DownExpand Up@@ -3449,10 +3449,10 @@ mod tests {
 let value_offsets = Buffer::from(&[2, 2, 5, 7].to_byte_slice());

 let list_data_type = DataType::List(Box::new(DataType::Int32));
 let list_data = ArrayData::builder(list_data_type.clone())
 let list_data = ArrayData::builder(list_data_type)
 .len(3)
 .add_buffer(value_offsets.clone())
 .add_child_data(value_data.clone())
 .add_buffer(value_offsets)
 .add_child_data(value_data)
 .build();
 ListArray::from(list_data);
 }
Expand DownExpand Up@@ -4077,9 +4077,9 @@ mod tests {
 .build();

 let list_data_type = DataType::List(Box::new(DataType::Int32));
 let list_data = ArrayData::builder(list_data_type.clone())
 let list_data = ArrayData::builder(list_data_type)
 .add_buffer(buf2)
 .add_child_data(value_data.clone())
 .add_child_data(value_data)
 .build();
 ListArray::from(list_data);
 }
Expand Down

22 changes: 7 additions & 15 deletions
rust/arrow/src/array/builder.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -2531,8 +2531,8 @@ mod tests {
 #[test]
 fn test_append_slice() {
 let mut b = UInt8BufferBuilder::new(0);
 b.append_slice("Hello, ".as_bytes()).unwrap();
 b.append_slice("World!".as_bytes()).unwrap();
 b.append_slice(b"Hello, ").unwrap();
 b.append_slice(b"World!").unwrap();
 let buffer = b.finish();
 assert_eq!(13, buffer.len());

Expand DownExpand Up@@ -3099,9 +3099,7 @@ mod tests {
 builder.append_byte(b'd').unwrap();
 builder.append(true).unwrap();

 let array = builder.finish();

 let binary_array = BinaryArray::from(array);
 let binary_array = builder.finish();

 assert_eq!(3, binary_array.len());
 assert_eq!(0, binary_array.null_count());
Expand DownExpand Up@@ -3130,9 +3128,7 @@ mod tests {
 builder.append_byte(b'd').unwrap();
 builder.append(true).unwrap();

 let array = builder.finish();

 let binary_array = LargeBinaryArray::from(array);
 let binary_array = builder.finish();

 assert_eq!(3, binary_array.len());
 assert_eq!(0, binary_array.null_count());
Expand All@@ -3151,9 +3147,7 @@ mod tests {
 builder.append(true).unwrap();
 builder.append_value("world").unwrap();

 let array = builder.finish();

 let string_array = StringArray::from(array);
 let string_array = builder.finish();

 assert_eq!(3, string_array.len());
 assert_eq!(0, string_array.null_count());
Expand DownExpand Up@@ -3210,9 +3204,7 @@ mod tests {
 builder.append(true).unwrap();
 builder.append_value("world").unwrap();

 let array = builder.finish();

 let string_array = StringArray::from(array);
 let string_array = builder.finish();

 assert_eq!(3, string_array.len());
 assert_eq!(0, string_array.null_count());
Expand DownExpand Up@@ -3274,7 +3266,7 @@ mod tests {
 .null_count(2)
 .null_bit_buffer(Buffer::from(&[9_u8]))
 .add_buffer(Buffer::from(&[0, 3, 3, 3, 7].to_byte_slice()))
 .add_buffer(Buffer::from("joemark".as_bytes()))
 .add_buffer(Buffer::from(b"joemark"))
 .build();

 let expected_int_data = ArrayData::builder(DataType::Int32)
Expand Down

20 changes: 10 additions & 10 deletions
rust/arrow/src/array/union.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -657,7 +657,7 @@ mod tests {
 // Check type ids
 assert_eq!(
 union.data().buffers()[0],
 Buffer::from(&expected_type_ids.clone().to_byte_slice())
 Buffer::from(&expected_type_ids.to_byte_slice())
 );
 for (i, id) in expected_type_ids.iter().enumerate() {
 assert_eq!(id, &union.type_id(i));
Expand All@@ -666,7 +666,7 @@ mod tests {
 // Check offsets
 assert_eq!(
 union.data().buffers()[1],
 Buffer::from(expected_value_offsets.clone().to_byte_slice())
 Buffer::from(expected_value_offsets.to_byte_slice())
 );
 for (i, id) in expected_value_offsets.iter().enumerate() {
 assert_eq!(&union.value_offset(i), id);
Expand DownExpand Up@@ -951,7 +951,7 @@ mod tests {
 .downcast_ref::<Float64Array>()
 .unwrap()
 .value(0);
assert_eq!(10.0, value);
assert!(10.0 - value < f64::EPSILON);

 let slot = array.value(4);
 let value = slot
Expand DownExpand Up@@ -983,7 +983,7 @@ mod tests {

 // Check type ids
 assert_eq!(
 Buffer::from(&expected_type_ids.clone().to_byte_slice()),
 Buffer::from(&expected_type_ids.to_byte_slice()),
 union.data().buffers()[0]
 );
 for (i, id) in expected_type_ids.iter().enumerate() {
Expand DownExpand Up@@ -1034,7 +1034,7 @@ mod tests {

 // Check type ids
 assert_eq!(
 Buffer::from(&expected_type_ids.clone().to_byte_slice()),
 Buffer::from(&expected_type_ids.to_byte_slice()),
 union.data().buffers()[0]
 );
 for (i, id) in expected_type_ids.iter().enumerate() {
Expand DownExpand Up@@ -1064,7 +1064,7 @@ mod tests {
 let slot = slot.as_any().downcast_ref::<Float64Array>().unwrap();
 assert_eq!(slot.len(), 1);
 let value = slot.value(0);
assert_eq!(value, 3_f64);
assert!(value - 3_f64 < f64::EPSILON);
 }
 3 => {
 let slot = slot.as_any().downcast_ref::<Int32Array>().unwrap();
Expand All@@ -1076,7 +1076,7 @@ mod tests {
 let slot = slot.as_any().downcast_ref::<Float64Array>().unwrap();
 assert_eq!(slot.len(), 1);
 let value = slot.value(0);
assert_eq!(5_f64, value);
assert!(5_f64 - value < f64::EPSILON);
 }
 5 => {
 let slot = slot.as_any().downcast_ref::<Int32Array>().unwrap();
Expand DownExpand Up@@ -1109,7 +1109,7 @@ mod tests {

 // Check type ids
 assert_eq!(
 Buffer::from(&expected_type_ids.clone().to_byte_slice()),
 Buffer::from(&expected_type_ids.to_byte_slice()),
 union.data().buffers()[0]
 );
 for (i, id) in expected_type_ids.iter().enumerate() {
Expand DownExpand Up@@ -1142,7 +1142,7 @@ mod tests {
 assert_eq!(false, union.is_null(i));
 assert_eq!(slot.len(), 1);
 let value = slot.value(0);
assert_eq!(value, 3_f64);
assert!(value - 3_f64 < f64::EPSILON);
 }
 4 => {
 let slot = slot.as_any().downcast_ref::<Int32Array>().unwrap();
Expand DownExpand Up@@ -1187,7 +1187,7 @@ mod tests {
 assert_eq!(false, new_union.is_null(i));
 assert_eq!(slot.len(), 1);
 let value = slot.value(0);
assert_eq!(value, 3_f64);
assert!(value - 3_f64 < f64::EPSILON);
 }
 3 => assert!(new_union.is_null(i)),
 4 => {
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
ARROW-9980: [Rust] [Parquet] Fix clippy lints#8173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

nevi-me
wants to merge
4
commits into

from

 Closed


ARROW-9980: [Rust] [Parquet] Fix clippy lints
#8173
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


4 commits


Select commit
Hold shift + click to select a range
a80693c

arrow clippy fixes


nevi-me Sep 11, 2020
0d50898

fix variable in examples


nevi-me Sep 11, 2020
0986881

parquet clippy lints


nevi-me Sep 11, 2020
9da75b5

fix tests, more lint fixes


nevi-me Sep 12, 2020

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


2 changes: 1 addition & 1 deletion
rust/arrow/benches/buffer_bit_ops.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -97,7 +97,7 @@ where

 result_chunks
 .into_remainder()
 .into_iter()
 .iter_mut()
 .zip(
 left_chunks
 .remainder()
Expand Down

4 changes: 2 additions & 2 deletions
rust/arrow/benches/cast_kernels.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -30,7 +30,7 @@ use arrow::compute::cast;
use arrow::datatypes::*;

// cast array from specified primitive array type to desired data type
fn cast_array<FROM>(size: usize, to_type: DataType) -> ()
fn cast_array<FROM>(size: usize, to_type: DataType)
where
 FROM: ArrowNumericType,
 Standard: Distribution<FROM::Native>,
Expand All@@ -44,7 +44,7 @@ where
}

// cast timestamp array from specified primitive array type to desired data type
fn cast_timestamp_array<FROM>(size: usize, to_type: DataType) -> ()
fn cast_timestamp_array<FROM>(size: usize, to_type: DataType)
where
 FROM: ArrowTimestampType,
 Standard: Distribution<i64>,
Expand Down

2 changes: 1 addition & 1 deletion
rust/arrow/benches/csv_writer.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -65,7 +65,7 @@ fn criterion_benchmark(c: &mut Criterion) {
 c.bench(
 "record_batches_to_csv",
 Benchmark::new("record_batches_to_csv", move |b| {
 b.iter(|| record_batches_to_csv())
 b.iter(record_batches_to_csv)
 }),
 );
}
Expand Down

2 changes: 1 addition & 1 deletion
rust/arrow/benches/length_kernel.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -42,7 +42,7 @@ fn bench_length() {
}

fn add_benchmark(c: &mut Criterion) {
 c.bench_function("length", |b| b.iter(|| bench_length()));
 c.bench_function("length", |b| b.iter(bench_length));
}

criterion_group!(benches, add_benchmark);
Expand Down

4 changes: 2 additions & 2 deletions
rust/arrow/benches/take_kernels.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -51,7 +51,7 @@ fn create_random_index(size: usize) -> UInt32Array {
 )
}

fn take_numeric<T>(size: usize, index_len: usize) -> ()
fn take_numeric<T>(size: usize, index_len: usize)
where
 T: ArrowNumericType,
 Standard: Distribution<T::Native>,
Expand All@@ -63,7 +63,7 @@ where
 criterion::black_box(take(&array, &index, None).unwrap());
}

fn take_boolean(size: usize, index_len: usize) -> () {
fn take_boolean(size: usize, index_len: usize) {
 let array = Arc::new(BooleanArray::from(vec![random::<bool>(); size])) as ArrayRef;
 let index = create_random_index(index_len);
 criterion::black_box(take(&array, &index, None).unwrap());
Expand Down

6 changes: 3 additions & 3 deletions
rust/arrow/examples/builders.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -100,10 +100,10 @@ fn main() {

 // Construct a list array from the above two
 let list_data_type = DataType::List(Box::new(DataType::Int32));
 let list_data = ArrayData::builder(list_data_type.clone())
 let list_data = ArrayData::builder(list_data_type)
 .len(3)
 .add_buffer(value_offsets.clone())
 .add_child_data(value_data.clone())
 .add_buffer(value_offsets)
 .add_child_data(value_data)
 .build();
 let list_array = ListArray::from(list_data);

Expand Down

2 changes: 1 addition & 1 deletion
rust/arrow/examples/read_csv.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -39,7 +39,7 @@ fn main() -> Result<()> {
 let _batch = csv.next().unwrap().unwrap();
 #[cfg(feature = "prettyprint")]
 {
 print_batches(&vec![_batch]).unwrap();
 print_batches(&[_batch]).unwrap();
 }
 Ok(())
}

2 changes: 1 addition & 1 deletion
rust/arrow/examples/read_csv_infer_schema.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -32,7 +32,7 @@ fn main() -> Result<()> {
 let _batch = csv.next().unwrap().unwrap();
 #[cfg(feature = "prettyprint")]
 {
 print_batches(&vec![_batch]).unwrap();
 print_batches(&[_batch]).unwrap();
 }
 Ok(())
}

24 changes: 12 additions & 12 deletions
rust/arrow/src/array/array.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -3212,9 +3212,9 @@ mod tests {

 // Construct a list array from the above two
 let list_data_type = DataType::FixedSizeList(Box::new(DataType::Int32), 3);
 let list_data = ArrayData::builder(list_data_type.clone())
 let list_data = ArrayData::builder(list_data_type)
 .len(3)
 .add_child_data(value_data.clone())
 .add_child_data(value_data)
 .build();
 FixedSizeListArray::from(list_data);
 }
Expand DownExpand Up@@ -3243,9 +3243,9 @@ mod tests {

 // Construct a list array from the above two
 let list_data_type = DataType::List(Box::new(DataType::Int32));
 let list_data = ArrayData::builder(list_data_type.clone())
 let list_data = ArrayData::builder(list_data_type)
 .len(9)
 .add_buffer(value_offsets.clone())
 .add_buffer(value_offsets)
 .add_child_data(value_data.clone())
 .null_bit_buffer(Buffer::from(null_bits))
 .build();
Expand DownExpand Up@@ -3307,9 +3307,9 @@ mod tests {

 // Construct a list array from the above two
 let list_data_type = DataType::LargeList(Box::new(DataType::Int32));
 let list_data = ArrayData::builder(list_data_type.clone())
 let list_data = ArrayData::builder(list_data_type)
 .len(9)
 .add_buffer(value_offsets.clone())
 .add_buffer(value_offsets)
 .add_child_data(value_data.clone())
 .null_bit_buffer(Buffer::from(null_bits))
 .build();
Expand DownExpand Up@@ -3369,7 +3369,7 @@ mod tests {

 // Construct a fixed size list array from the above two
 let list_data_type = DataType::FixedSizeList(Box::new(DataType::Int32), 2);
 let list_data = ArrayData::builder(list_data_type.clone())
 let list_data = ArrayData::builder(list_data_type)
 .len(5)
 .add_child_data(value_data.clone())
 .null_bit_buffer(Buffer::from(null_bits))
Expand DownExpand Up@@ -3449,10 +3449,10 @@ mod tests {
 let value_offsets = Buffer::from(&[2, 2, 5, 7].to_byte_slice());

 let list_data_type = DataType::List(Box::new(DataType::Int32));
 let list_data = ArrayData::builder(list_data_type.clone())
 let list_data = ArrayData::builder(list_data_type)
 .len(3)
 .add_buffer(value_offsets.clone())
 .add_child_data(value_data.clone())
 .add_buffer(value_offsets)
 .add_child_data(value_data)
 .build();
 ListArray::from(list_data);
 }
Expand DownExpand Up@@ -4077,9 +4077,9 @@ mod tests {
 .build();

 let list_data_type = DataType::List(Box::new(DataType::Int32));
 let list_data = ArrayData::builder(list_data_type.clone())
 let list_data = ArrayData::builder(list_data_type)
 .add_buffer(buf2)
 .add_child_data(value_data.clone())
 .add_child_data(value_data)
 .build();
 ListArray::from(list_data);
 }
Expand Down

22 changes: 7 additions & 15 deletions
rust/arrow/src/array/builder.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -2531,8 +2531,8 @@ mod tests {
 #[test]
 fn test_append_slice() {
 let mut b = UInt8BufferBuilder::new(0);
 b.append_slice("Hello, ".as_bytes()).unwrap();
 b.append_slice("World!".as_bytes()).unwrap();
 b.append_slice(b"Hello, ").unwrap();
 b.append_slice(b"World!").unwrap();
 let buffer = b.finish();
 assert_eq!(13, buffer.len());

Expand DownExpand Up@@ -3099,9 +3099,7 @@ mod tests {
 builder.append_byte(b'd').unwrap();
 builder.append(true).unwrap();

 let array = builder.finish();

 let binary_array = BinaryArray::from(array);
 let binary_array = builder.finish();

 assert_eq!(3, binary_array.len());
 assert_eq!(0, binary_array.null_count());
Expand DownExpand Up@@ -3130,9 +3128,7 @@ mod tests {
 builder.append_byte(b'd').unwrap();
 builder.append(true).unwrap();

 let array = builder.finish();

 let binary_array = LargeBinaryArray::from(array);
 let binary_array = builder.finish();

 assert_eq!(3, binary_array.len());
 assert_eq!(0, binary_array.null_count());
Expand All@@ -3151,9 +3147,7 @@ mod tests {
 builder.append(true).unwrap();
 builder.append_value("world").unwrap();

 let array = builder.finish();

 let string_array = StringArray::from(array);
 let string_array = builder.finish();

 assert_eq!(3, string_array.len());
 assert_eq!(0, string_array.null_count());
Expand DownExpand Up@@ -3210,9 +3204,7 @@ mod tests {
 builder.append(true).unwrap();
 builder.append_value("world").unwrap();

 let array = builder.finish();

 let string_array = StringArray::from(array);
 let string_array = builder.finish();

 assert_eq!(3, string_array.len());
 assert_eq!(0, string_array.null_count());
Expand DownExpand Up@@ -3274,7 +3266,7 @@ mod tests {
 .null_count(2)
 .null_bit_buffer(Buffer::from(&[9_u8]))
 .add_buffer(Buffer::from(&[0, 3, 3, 3, 7].to_byte_slice()))
 .add_buffer(Buffer::from("joemark".as_bytes()))
 .add_buffer(Buffer::from(b"joemark"))
 .build();

 let expected_int_data = ArrayData::builder(DataType::Int32)
Expand Down

20 changes: 10 additions & 10 deletions
rust/arrow/src/array/union.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -657,7 +657,7 @@ mod tests {
 // Check type ids
 assert_eq!(
 union.data().buffers()[0],
 Buffer::from(&expected_type_ids.clone().to_byte_slice())
 Buffer::from(&expected_type_ids.to_byte_slice())
 );
 for (i, id) in expected_type_ids.iter().enumerate() {
 assert_eq!(id, &union.type_id(i));
Expand All@@ -666,7 +666,7 @@ mod tests {
 // Check offsets
 assert_eq!(
 union.data().buffers()[1],
 Buffer::from(expected_value_offsets.clone().to_byte_slice())
 Buffer::from(expected_value_offsets.to_byte_slice())
 );
 for (i, id) in expected_value_offsets.iter().enumerate() {
 assert_eq!(&union.value_offset(i), id);
Expand DownExpand Up@@ -951,7 +951,7 @@ mod tests {
 .downcast_ref::<Float64Array>()
 .unwrap()
 .value(0);
assert_eq!(10.0, value);
assert!(10.0 - value < f64::EPSILON);

 let slot = array.value(4);
 let value = slot
Expand DownExpand Up@@ -983,7 +983,7 @@ mod tests {

 // Check type ids
 assert_eq!(
 Buffer::from(&expected_type_ids.clone().to_byte_slice()),
 Buffer::from(&expected_type_ids.to_byte_slice()),
 union.data().buffers()[0]
 );
 for (i, id) in expected_type_ids.iter().enumerate() {
Expand DownExpand Up@@ -1034,7 +1034,7 @@ mod tests {

 // Check type ids
 assert_eq!(
 Buffer::from(&expected_type_ids.clone().to_byte_slice()),
 Buffer::from(&expected_type_ids.to_byte_slice()),
 union.data().buffers()[0]
 );
 for (i, id) in expected_type_ids.iter().enumerate() {
Expand DownExpand Up@@ -1064,7 +1064,7 @@ mod tests {
 let slot = slot.as_any().downcast_ref::<Float64Array>().unwrap();
 assert_eq!(slot.len(), 1);
 let value = slot.value(0);
assert_eq!(value, 3_f64);
assert!(value - 3_f64 < f64::EPSILON);
 }
 3 => {
 let slot = slot.as_any().downcast_ref::<Int32Array>().unwrap();
Expand All@@ -1076,7 +1076,7 @@ mod tests {
 let slot = slot.as_any().downcast_ref::<Float64Array>().unwrap();
 assert_eq!(slot.len(), 1);
 let value = slot.value(0);
assert_eq!(5_f64, value);
assert!(5_f64 - value < f64::EPSILON);
 }
 5 => {
 let slot = slot.as_any().downcast_ref::<Int32Array>().unwrap();
Expand DownExpand Up@@ -1109,7 +1109,7 @@ mod tests {

 // Check type ids
 assert_eq!(
 Buffer::from(&expected_type_ids.clone().to_byte_slice()),
 Buffer::from(&expected_type_ids.to_byte_slice()),
 union.data().buffers()[0]
 );
 for (i, id) in expected_type_ids.iter().enumerate() {
Expand DownExpand Up@@ -1142,7 +1142,7 @@ mod tests {
 assert_eq!(false, union.is_null(i));
 assert_eq!(slot.len(), 1);
 let value = slot.value(0);
assert_eq!(value, 3_f64);
assert!(value - 3_f64 < f64::EPSILON);
 }
 4 => {
 let slot = slot.as_any().downcast_ref::<Int32Array>().unwrap();
Expand DownExpand Up@@ -1187,7 +1187,7 @@ mod tests {
 assert_eq!(false, new_union.is_null(i));
 assert_eq!(slot.len(), 1);
 let value = slot.value(0);
assert_eq!(value, 3_f64);
assert!(value - 3_f64 < f64::EPSILON);
 }
 3 => assert!(new_union.is_null(i)),
 4 => {
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
ARROW-9980: [Rust] [Parquet] Fix clippy lints#8173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

nevi-me
wants to merge
4
commits into

from

 Closed


ARROW-9980: [Rust] [Parquet] Fix clippy lints
#8173
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


4 commits


Select commit
Hold shift + click to select a range
a80693c

arrow clippy fixes


nevi-me Sep 11, 2020
0d50898

fix variable in examples


nevi-me Sep 11, 2020
0986881

parquet clippy lints


nevi-me Sep 11, 2020
9da75b5

fix tests, more lint fixes


nevi-me Sep 12, 2020

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


2 changes: 1 addition & 1 deletion
rust/arrow/benches/buffer_bit_ops.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -97,7 +97,7 @@ where

 result_chunks
 .into_remainder()
 .into_iter()
 .iter_mut()
 .zip(
 left_chunks
 .remainder()
Expand Down

4 changes: 2 additions & 2 deletions
rust/arrow/benches/cast_kernels.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -30,7 +30,7 @@ use arrow::compute::cast;
use arrow::datatypes::*;

// cast array from specified primitive array type to desired data type
fn cast_array<FROM>(size: usize, to_type: DataType) -> ()
fn cast_array<FROM>(size: usize, to_type: DataType)
where
 FROM: ArrowNumericType,
 Standard: Distribution<FROM::Native>,
Expand All@@ -44,7 +44,7 @@ where
}

// cast timestamp array from specified primitive array type to desired data type
fn cast_timestamp_array<FROM>(size: usize, to_type: DataType) -> ()
fn cast_timestamp_array<FROM>(size: usize, to_type: DataType)
where
 FROM: ArrowTimestampType,
 Standard: Distribution<i64>,
Expand Down

2 changes: 1 addition & 1 deletion
rust/arrow/benches/csv_writer.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -65,7 +65,7 @@ fn criterion_benchmark(c: &mut Criterion) {
 c.bench(
 "record_batches_to_csv",
 Benchmark::new("record_batches_to_csv", move |b| {
 b.iter(|| record_batches_to_csv())
 b.iter(record_batches_to_csv)
 }),
 );
}
Expand Down

2 changes: 1 addition & 1 deletion
rust/arrow/benches/length_kernel.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -42,7 +42,7 @@ fn bench_length() {
}

fn add_benchmark(c: &mut Criterion) {
 c.bench_function("length", |b| b.iter(|| bench_length()));
 c.bench_function("length", |b| b.iter(bench_length));
}

criterion_group!(benches, add_benchmark);
Expand Down

4 changes: 2 additions & 2 deletions
rust/arrow/benches/take_kernels.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -51,7 +51,7 @@ fn create_random_index(size: usize) -> UInt32Array {
 )
}

fn take_numeric<T>(size: usize, index_len: usize) -> ()
fn take_numeric<T>(size: usize, index_len: usize)
where
 T: ArrowNumericType,
 Standard: Distribution<T::Native>,
Expand All@@ -63,7 +63,7 @@ where
 criterion::black_box(take(&array, &index, None).unwrap());
}

fn take_boolean(size: usize, index_len: usize) -> () {
fn take_boolean(size: usize, index_len: usize) {
 let array = Arc::new(BooleanArray::from(vec![random::<bool>(); size])) as ArrayRef;
 let index = create_random_index(index_len);
 criterion::black_box(take(&array, &index, None).unwrap());
Expand Down

6 changes: 3 additions & 3 deletions
rust/arrow/examples/builders.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -100,10 +100,10 @@ fn main() {

 // Construct a list array from the above two
 let list_data_type = DataType::List(Box::new(DataType::Int32));
 let list_data = ArrayData::builder(list_data_type.clone())
 let list_data = ArrayData::builder(list_data_type)
 .len(3)
 .add_buffer(value_offsets.clone())
 .add_child_data(value_data.clone())
 .add_buffer(value_offsets)
 .add_child_data(value_data)
 .build();
 let list_array = ListArray::from(list_data);

Expand Down

2 changes: 1 addition & 1 deletion
rust/arrow/examples/read_csv.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -39,7 +39,7 @@ fn main() -> Result<()> {
 let _batch = csv.next().unwrap().unwrap();
 #[cfg(feature = "prettyprint")]
 {
 print_batches(&vec![_batch]).unwrap();
 print_batches(&[_batch]).unwrap();
 }
 Ok(())
}

2 changes: 1 addition & 1 deletion
rust/arrow/examples/read_csv_infer_schema.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -32,7 +32,7 @@ fn main() -> Result<()> {
 let _batch = csv.next().unwrap().unwrap();
 #[cfg(feature = "prettyprint")]
 {
 print_batches(&vec![_batch]).unwrap();
 print_batches(&[_batch]).unwrap();
 }
 Ok(())
}

24 changes: 12 additions & 12 deletions
rust/arrow/src/array/array.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -3212,9 +3212,9 @@ mod tests {

 // Construct a list array from the above two
 let list_data_type = DataType::FixedSizeList(Box::new(DataType::Int32), 3);
 let list_data = ArrayData::builder(list_data_type.clone())
 let list_data = ArrayData::builder(list_data_type)
 .len(3)
 .add_child_data(value_data.clone())
 .add_child_data(value_data)
 .build();
 FixedSizeListArray::from(list_data);
 }
Expand DownExpand Up@@ -3243,9 +3243,9 @@ mod tests {

 // Construct a list array from the above two
 let list_data_type = DataType::List(Box::new(DataType::Int32));
 let list_data = ArrayData::builder(list_data_type.clone())
 let list_data = ArrayData::builder(list_data_type)
 .len(9)
 .add_buffer(value_offsets.clone())
 .add_buffer(value_offsets)
 .add_child_data(value_data.clone())
 .null_bit_buffer(Buffer::from(null_bits))
 .build();
Expand DownExpand Up@@ -3307,9 +3307,9 @@ mod tests {

 // Construct a list array from the above two
 let list_data_type = DataType::LargeList(Box::new(DataType::Int32));
 let list_data = ArrayData::builder(list_data_type.clone())
 let list_data = ArrayData::builder(list_data_type)
 .len(9)
 .add_buffer(value_offsets.clone())
 .add_buffer(value_offsets)
 .add_child_data(value_data.clone())
 .null_bit_buffer(Buffer::from(null_bits))
 .build();
Expand DownExpand Up@@ -3369,7 +3369,7 @@ mod tests {

 // Construct a fixed size list array from the above two
 let list_data_type = DataType::FixedSizeList(Box::new(DataType::Int32), 2);
 let list_data = ArrayData::builder(list_data_type.clone())
 let list_data = ArrayData::builder(list_data_type)
 .len(5)
 .add_child_data(value_data.clone())
 .null_bit_buffer(Buffer::from(null_bits))
Expand DownExpand Up@@ -3449,10 +3449,10 @@ mod tests {
 let value_offsets = Buffer::from(&[2, 2, 5, 7].to_byte_slice());

 let list_data_type = DataType::List(Box::new(DataType::Int32));
 let list_data = ArrayData::builder(list_data_type.clone())
 let list_data = ArrayData::builder(list_data_type)
 .len(3)
 .add_buffer(value_offsets.clone())
 .add_child_data(value_data.clone())
 .add_buffer(value_offsets)
 .add_child_data(value_data)
 .build();
 ListArray::from(list_data);
 }
Expand DownExpand Up@@ -4077,9 +4077,9 @@ mod tests {
 .build();

 let list_data_type = DataType::List(Box::new(DataType::Int32));
 let list_data = ArrayData::builder(list_data_type.clone())
 let list_data = ArrayData::builder(list_data_type)
 .add_buffer(buf2)
 .add_child_data(value_data.clone())
 .add_child_data(value_data)
 .build();
 ListArray::from(list_data);
 }
Expand Down

22 changes: 7 additions & 15 deletions
rust/arrow/src/array/builder.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -2531,8 +2531,8 @@ mod tests {
 #[test]
 fn test_append_slice() {
 let mut b = UInt8BufferBuilder::new(0);
 b.append_slice("Hello, ".as_bytes()).unwrap();
 b.append_slice("World!".as_bytes()).unwrap();
 b.append_slice(b"Hello, ").unwrap();
 b.append_slice(b"World!").unwrap();
 let buffer = b.finish();
 assert_eq!(13, buffer.len());

Expand DownExpand Up@@ -3099,9 +3099,7 @@ mod tests {
 builder.append_byte(b'd').unwrap();
 builder.append(true).unwrap();

 let array = builder.finish();

 let binary_array = BinaryArray::from(array);
 let binary_array = builder.finish();

 assert_eq!(3, binary_array.len());
 assert_eq!(0, binary_array.null_count());
Expand DownExpand Up@@ -3130,9 +3128,7 @@ mod tests {
 builder.append_byte(b'd').unwrap();
 builder.append(true).unwrap();

 let array = builder.finish();

 let binary_array = LargeBinaryArray::from(array);
 let binary_array = builder.finish();

 assert_eq!(3, binary_array.len());
 assert_eq!(0, binary_array.null_count());
Expand All@@ -3151,9 +3147,7 @@ mod tests {
 builder.append(true).unwrap();
 builder.append_value("world").unwrap();

 let array = builder.finish();

 let string_array = StringArray::from(array);
 let string_array = builder.finish();

 assert_eq!(3, string_array.len());
 assert_eq!(0, string_array.null_count());
Expand DownExpand Up@@ -3210,9 +3204,7 @@ mod tests {
 builder.append(true).unwrap();
 builder.append_value("world").unwrap();

 let array = builder.finish();

 let string_array = StringArray::from(array);
 let string_array = builder.finish();

 assert_eq!(3, string_array.len());
 assert_eq!(0, string_array.null_count());
Expand DownExpand Up@@ -3274,7 +3266,7 @@ mod tests {
 .null_count(2)
 .null_bit_buffer(Buffer::from(&[9_u8]))
 .add_buffer(Buffer::from(&[0, 3, 3, 3, 7].to_byte_slice()))
 .add_buffer(Buffer::from("joemark".as_bytes()))
 .add_buffer(Buffer::from(b"joemark"))
 .build();

 let expected_int_data = ArrayData::builder(DataType::Int32)
Expand Down

20 changes: 10 additions & 10 deletions
rust/arrow/src/array/union.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -657,7 +657,7 @@ mod tests {
 // Check type ids
 assert_eq!(
 union.data().buffers()[0],
 Buffer::from(&expected_type_ids.clone().to_byte_slice())
 Buffer::from(&expected_type_ids.to_byte_slice())
 );
 for (i, id) in expected_type_ids.iter().enumerate() {
 assert_eq!(id, &union.type_id(i));
Expand All@@ -666,7 +666,7 @@ mod tests {
 // Check offsets
 assert_eq!(
 union.data().buffers()[1],
 Buffer::from(expected_value_offsets.clone().to_byte_slice())
 Buffer::from(expected_value_offsets.to_byte_slice())
 );
 for (i, id) in expected_value_offsets.iter().enumerate() {
 assert_eq!(&union.value_offset(i), id);
Expand DownExpand Up@@ -951,7 +951,7 @@ mod tests {
 .downcast_ref::<Float64Array>()
 .unwrap()
 .value(0);
assert_eq!(10.0, value);
assert!(10.0 - value < f64::EPSILON);

 let slot = array.value(4);
 let value = slot
Expand DownExpand Up@@ -983,7 +983,7 @@ mod tests {

 // Check type ids
 assert_eq!(
 Buffer::from(&expected_type_ids.clone().to_byte_slice()),
 Buffer::from(&expected_type_ids.to_byte_slice()),
 union.data().buffers()[0]
 );
 for (i, id) in expected_type_ids.iter().enumerate() {
Expand DownExpand Up@@ -1034,7 +1034,7 @@ mod tests {

 // Check type ids
 assert_eq!(
 Buffer::from(&expected_type_ids.clone().to_byte_slice()),
 Buffer::from(&expected_type_ids.to_byte_slice()),
 union.data().buffers()[0]
 );
 for (i, id) in expected_type_ids.iter().enumerate() {
Expand DownExpand Up@@ -1064,7 +1064,7 @@ mod tests {
 let slot = slot.as_any().downcast_ref::<Float64Array>().unwrap();
 assert_eq!(slot.len(), 1);
 let value = slot.value(0);
assert_eq!(value, 3_f64);
assert!(value - 3_f64 < f64::EPSILON);
 }
 3 => {
 let slot = slot.as_any().downcast_ref::<Int32Array>().unwrap();
Expand All@@ -1076,7 +1076,7 @@ mod tests {
 let slot = slot.as_any().downcast_ref::<Float64Array>().unwrap();
 assert_eq!(slot.len(), 1);
 let value = slot.value(0);
assert_eq!(5_f64, value);
assert!(5_f64 - value < f64::EPSILON);
 }
 5 => {
 let slot = slot.as_any().downcast_ref::<Int32Array>().unwrap();
Expand DownExpand Up@@ -1109,7 +1109,7 @@ mod tests {

 // Check type ids
 assert_eq!(
 Buffer::from(&expected_type_ids.clone().to_byte_slice()),
 Buffer::from(&expected_type_ids.to_byte_slice()),
 union.data().buffers()[0]
 );
 for (i, id) in expected_type_ids.iter().enumerate() {
Expand DownExpand Up@@ -1142,7 +1142,7 @@ mod tests {
 assert_eq!(false, union.is_null(i));
 assert_eq!(slot.len(), 1);
 let value = slot.value(0);
assert_eq!(value, 3_f64);
assert!(value - 3_f64 < f64::EPSILON);
 }
 4 => {
 let slot = slot.as_any().downcast_ref::<Int32Array>().unwrap();
Expand DownExpand Up@@ -1187,7 +1187,7 @@ mod tests {
 assert_eq!(false, new_union.is_null(i));
 assert_eq!(slot.len(), 1);
 let value = slot.value(0);
assert_eq!(value, 3_f64);
assert!(value - 3_f64 < f64::EPSILON);
 }
 3 => assert!(new_union.is_null(i)),
 4 => {
Expand Down
Loading