Uh oh!
There was an error while loading. Please reload this page.
ARROW-10277: [C++] Support comparing scalars approximately - #8438
Closed
liyafan82 wants to merge 1 commit into
Closed
ARROW-10277: [C++] Support comparing scalars approximately#8438liyafan82 wants to merge 1 commit into
liyafan82 wants to merge 1 commit into
Conversation
liyafan82force-pushed
the
fly_1012_scl
branch
2 times, most recently
from
October 12, 2020 09:56
cd08795 to
9631e9fComparepitrou
commented
Dec 7, 2020
Member
Sorry for the delay @liyafan82 . I will take a look at this now. |
pitrou
commented
Dec 7, 2020
Member
I more or less rewrote this PR entirely as I identified other issues that were entangled with this one, and added a bunch of tests. |
pitrou
commented
Dec 7, 2020
Member
+1. Will merge now that this is green. |
liyafan82
commented
Dec 8, 2020
ContributorAuthor
@pitrou Thanks for your effort. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #7748 (comment), we need to compare scalars approximately in some scenarios.
Also: