Uh oh!
There was an error while loading. Please reload this page.
ARROW-10293: [Rust] [DataFusion] Fixed benchmarks - #8452
Closed
jorgecarleitao wants to merge 1 commit into
Closed
Conversation
jorgecarleitao
commented
Oct 13, 2020
MemberAuthor
FYI @andygrove , as 2.0.0' benchmarks not benchmarking anything atm :/ |
alamb
approved these changes
Oct 13, 2020
alamb
left a comment
Contributor
There was a problem hiding this comment.
This PR also changes some of the batch sizes -- which seems reasonable.
| // display the relation | ||
| for _batch in results {} | ||
| rt.block_on(df.collect()).unwrap(); |
Contributor
There was a problem hiding this comment.
👍 this is the major change, right?
MemberAuthor
There was a problem hiding this comment.
yes, the block is pick up the task. We also benchmark creating a runtime itself, but that was a very small compared to the task itself, so I left it there.
andygrove
approved these changes
Oct 13, 2020
kszucs pushed a commit
that referenced
this pull request
Oct 19, 2020
The benchmarks were only benchmarking planning, not execution, of the plans. This PR fixes this. Closes#8452 from jorgecarleitao/bench Authored-by: Jorge C. Leitao <jorgecarleitao@gmail.com> Signed-off-by: Andy Grove <andygrove@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The benchmarks were only benchmarking planning, not execution, of the plans. This PR fixes this.