Uh oh!
There was an error while loading. Please reload this page.
ARROW-10313: [C++] Faster UTF8 validation for small strings - #8470
Closed
pitrou wants to merge 4 commits into
Closed
ARROW-10313: [C++] Faster UTF8 validation for small strings#8470pitrou wants to merge 4 commits into
pitrou wants to merge 4 commits into
Conversation
This improves CSV string conversion by about 30%.
pitrou
commented
Oct 15, 2020
MemberAuthor
This also improves the ARROW-10308 benchmark by about 9%. |
MemberAuthor
Another possibility would be to compute and store ASCIIness of values while parsing CSV (ideally this should not cost anything CPU-wise). Then we can reuse that information to skip UTF8 validation for most values. Edit: actually, a quick attempt shows a significant decrease in CSV parsing speed. Too bad. |
bkietz
requested changes
Oct 15, 2020
Uh oh!
There was an error while loading. Please reload this page.
bkietz
approved these changes
Oct 15, 2020
bkietz
requested changes
Oct 15, 2020
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Benjamin Kietzman <bengilgit@gmail.com>
Co-authored-by: Benjamin Kietzman <bengilgit@gmail.com>
kszucs pushed a commit
that referenced
this pull request
Oct 19, 2020
This improves CSV string conversion performance by about 30%. Closes#8470 from pitrou/ARROW-10313-faster-utf8-validate Authored-by: Antoine Pitrou <antoine@python.org> Signed-off-by: Antoine Pitrou <antoine@python.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This improves CSV string conversion performance by about 30%.