Uh oh!
There was an error while loading. Please reload this page.
ARROW-10269: [Rust] Update to 2020-11-14 nightly - #8666
Conversation
We have over 100 warnings, which cause too much noise
nevi-me
commented
Nov 15, 2020
FYI @vertexclique |
jorgecarleitao
commented
Nov 15, 2020
Segfault on the coverage, outch :/ |
nevi-me
commented
Nov 15, 2020
I want to look at whether we can use the new llvm-based coverage instead of tarpaulin |
The failure was from a newer version of `cargo-tarpaulin`
nevi-me
commented
Nov 15, 2020
Found and fixed the problem. We were using an older cached version of We should be good to go @jorgecarleitao |
codecov-io
commented
Nov 15, 2020
Codecov Report
@@ Coverage Diff @@## master #8666 +/- ##
==========================================
- Coverage 84.84% 84.55% -0.30%
==========================================
Files 165 177 +12 Lines 43322 43567 +245 ==========================================
+ Hits 36757 36838 +81 - Misses 6565 6729 +164
Continue to review full report at Codecov.
|
jorgecarleitao
left a comment
There was a problem hiding this comment.
LGTM. Thanks a lot @nevi-me , cool fixes to the code also.
vertexclique
left a comment
There was a problem hiding this comment.
Thanks for this Neville!
jorgecarleitao
commented
Nov 15, 2020
Do we wait for some of the PRs to be flushed, or do we merge this? |
nevi-me
commented
Nov 15, 2020
I don't see this being a big risk to open PRs (as some already have merge conflicts). We run 36 CI jobs for this, vs the normal 8; so maybe there's an efficiency argument in merging this sooner, instead of having to rebase later (which I don't mind doing). |
alamb
left a comment
There was a problem hiding this comment.
🎉 -- thank you @nevi-me
FYI I filed https://issues.apache.org/jira/browse/ARROW-10597 to track enablign clippy lints in datafusion
nevi-me
commented
Nov 15, 2020
@alamb thanks. A quick solution for many of the lints, is to run clippy-fix with -Z unstable-options, so that one doesn't manually fix them. |
This takes us from 2020-04-22 to 2020-11-14.
There have been a lot of clippy lints introduced since April, and an incompleteness feature warning about specialization (which causes CI to fail).
I have allowed almost all clippy lints in datafusion, as we have >150 warnings there.
I have made changes to fix arrow and parquet lints where I perceive them not to affect open PRs.