Uh oh!
There was an error while loading. Please reload this page.
ARROW-10647: [Rust] [Parquet] Port benchmarks from from parquet-rs to arrow repo - #8708
ARROW-10647: [Rust] [Parquet] Port benchmarks from from parquet-rs to arrow repo#8708alamb wants to merge 6 commits into
Conversation
nevi-me
commented
Nov 18, 2020
This will also close https://issues.apache.org/jira/browse/ARROW-4063 |
GregBowyer
left a comment
There was a problem hiding this comment.
Super minor: The commit message possibly should be s/benche/bench
| // } | ||
| // | ||
| // filled with random values. | ||
| const TEST_FILE: &str = "10k-v2.parquet"; |
There was a problem hiding this comment.
I think we normally put test data in https://github.com/apache/parquet-testing so perhaps we should add this one there as well (or if there any existing file there that we can use instead)?
There was a problem hiding this comment.
I created apache/parquet-testing#15 -- if/when that gets merged in, I'll update this PR to pick up a later version of parquet-testing and remove the binary from this PR as well.
sunchao
commented
Nov 18, 2020
Unrelated: there is also the fuzz module which is quite useful for detecting bad crashes in the code. It probably worth porting to arrow as well. |
GregBowyer
commented
Nov 18, 2020
I am going to suggest porting these to criterion (as it makes it easier to compare parameters and runs) I have a PR in the works for this, PR-ception I will PR on your repo to PR the PR :P |
alamb
commented
Nov 18, 2020
@GregBowyer -- sounds great! |
alamb
commented
Nov 18, 2020
alamb
commented
Nov 19, 2020
@wesm suggests that rather than checking in files, we write / use a data generator, which makes sense to me. I'll try and work on such a thing -- though I am not sure when I will get time to do so |
wesm
commented
Nov 19, 2020
I'm fine with checking in these files (or putting them in an S3 bucket, or anything really), but just don't think that checking in binary files should be the project's benchmarking strategy =) |
alamb
commented
Dec 3, 2020
Update on this PR -- I plan to try and make a synthetic data generator rather than checking the data files in. I just haven't had the chance to do so yet |
sunchao
commented
Jan 9, 2021
I'll spend some time on this. We can probably port encoding/decoding benchmark first as they do not rely on the test file. |
alamb
commented
Jan 10, 2021
Thank you @sunchao |

This PR ports the parquet benchmarks from the original parquet-rs repo in service of helping to get #8698 merged.
The PR may be easier to review commit by commit to see what I had to change to make the benchmarks work in this Repo
My one question is if it is ok to add a 653KB binary file as part of this PR, or if that should be put into one of the other repos (like test data)
To run:
Example output: