Uh oh!
There was an error while loading. Please reload this page.
ARROW-10677: [Rust] Fix CSV Boolean parsing + add tests to demonstrate supported csv parsing - #8733
Closed
alamb wants to merge 1 commit into
Closed
ARROW-10677: [Rust] Fix CSV Boolean parsing + add tests to demonstrate supported csv parsing#8733alamb wants to merge 1 commit into
alamb wants to merge 1 commit into
Conversation
alambforce-pushed
the
alamb/ARROW-10677-boolean-parsing
branch
from
November 21, 2020 23:12
3a3a353 to
3f63f67Comparealamb
marked this pull request as ready for review
November 21, 2020 23:12
Dandandan
approved these changes
Nov 22, 2020
Dandandan
commented
Nov 22, 2020
Contributor
👍 |
alambforce-pushed
the
alamb/ARROW-10677-boolean-parsing
branch
from
November 22, 2020 12:24
3f63f67 to
0432192Comparealamb
commented
Nov 22, 2020
ContributorAuthor
There was a problem hiding this comment.
note the condition was inverted here ("False" --> Some(true)) -- this was introduced in #8714 by accident
vertexclique
approved these changes
Nov 22, 2020
paddyhoran
approved these changes
Nov 22, 2020
alamb
commented
Nov 23, 2020
ContributorAuthor
looks like this needs a rebase -- doing so now |
alambforce-pushed
the
alamb/ARROW-10677-boolean-parsing
branch
from
November 23, 2020 21:44
0432192 to
67cd72aCompare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background:
https://github.com/apache/arrow/pull/8714/files# / ARROW-10654 adds some specialized parsing for the csv reader but there was no unit test coverage.
I am fairly sure that a late commit actually introduced a bug, but clearly there weren't unit tests to find it (see details 52bf0e8#r528201732)
Changes: