Skip to content

ARROW-8147: [C++] Add google-cloud-cpp to ThirdpartyToolchain#8757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
josiahyan wants to merge 10 commits into from
Closed

ARROW-8147: [C++] Add google-cloud-cpp to ThirdpartyToolchain #8757

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
6600fb5
ARROW-8147: [C++] Add google-cloud-cpp to ThirdpartyToolchain
josiahyan Nov 24, 2020
17d3636
Add google-cloud-cpp to conda requirements for CI
josiahyan Nov 24, 2020
72cb6f0
Add dependency on nlohmann_json for google-cloud-cpp build
josiahyan Nov 25, 2020
69b5799
Move google-cloud-cpp conda dependencies to unix only
josiahyan Nov 25, 2020
433eca0
Reorder dependencies, minor fixes
josiahyan Dec 1, 2020
46e9dcc
Add URLs to fetch dependencies to cpp/thirdparty/versions.txt
josiahyan Dec 1, 2020
99852f9
Lock GCP SDK version to 1.20.0
josiahyan Feb 28, 2021
cb06b47
Remove GCS SDK from Windows cpp appveyor CI build
josiahyan Feb 28, 2021
7531ca5
Resynchronize GCS SDK's Abseil includes against Abseil LTS branch, Se…
josiahyan Feb 28, 2021
d92433a
Fix typo
josiahyan Aug 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ci/conda_env_unix.txt
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -19,5 +19,7 @@

autoconf
ccache
google-cloud-cpp=1.20.0
nlohmann_json>=3.4.0

@emkornfieldemkornfieldSep 12, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is the new JSON dependency for?

@emkornfieldemkornfieldSep 12, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess google's SDK must rely on it?

@coryancoryanSep 27, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am one of the authors of google's GCS SDK. Yes, the SDK definitely depends on nlohmann_json.

@pitroupitrouSep 27, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conda has dependency handling, so there is no reason to mention it explicitly, though.

orc
pkg-config
1 change: 1 addition & 0 deletions ci/docker/conda-cpp.dockerfile
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -36,6 +36,7 @@ ENV ARROW_BUILD_TESTS=ON \
ARROW_DEPENDENCY_SOURCE=CONDA \
ARROW_FLIGHT=ON \
ARROW_GANDIVA=ON \
ARROW_GCS=ON \
ARROW_HOME=$CONDA_PREFIX \
ARROW_ORC=ON \
ARROW_PARQUET=ON \
Expand Down
2 changes: 2 additions & 0 deletions ci/docker/ubuntu-20.04-cpp.dockerfile
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -110,6 +110,7 @@ ENV ARROW_BUILD_TESTS=ON \
ARROW_DATASET=ON \
ARROW_FLIGHT=OFF \
ARROW_GANDIVA=ON \
ARROW_GCS=ON \
ARROW_HDFS=ON \
ARROW_HOME=/usr/local \
ARROW_INSTALL_NAME_RPATH=OFF \
Expand All@@ -129,6 +130,7 @@ ENV ARROW_BUILD_TESTS=ON \
ARROW_WITH_ZSTD=ON \
ASAN_SYMBOLIZER_PATH=/usr/lib/llvm-${llvm}/bin/llvm-symbolizer \
AWSSDK_SOURCE=BUNDLED \
GCPSDK_SOURCE=BUNDLED \
GTest_SOURCE=BUNDLED \
gRPC_SOURCE=BUNDLED \
ORC_SOURCE=BUNDLED \
Expand Down
2 changes: 2 additions & 0 deletions ci/scripts/cpp_build.sh
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -74,6 +74,7 @@ cmake -G "${CMAKE_GENERATOR:-Ninja}" \
-DARROW_GANDIVA_JAVA=${ARROW_GANDIVA_JAVA:-OFF} \
-DARROW_GANDIVA_PC_CXX_FLAGS=${ARROW_GANDIVA_PC_CXX_FLAGS:-} \
-DARROW_GANDIVA=${ARROW_GANDIVA:-OFF} \
-DARROW_GCS=${ARROW_GCS:-OFF} \
-DARROW_HDFS=${ARROW_HDFS:-ON} \
-DARROW_HIVESERVER2=${ARROW_HIVESERVER2:-OFF} \
-DARROW_INSTALL_NAME_RPATH=${ARROW_INSTALL_NAME_RPATH:-ON} \
Expand DownExpand Up@@ -120,6 +121,7 @@ cmake -G "${CMAKE_GENERATOR:-Ninja}" \
-DCMAKE_INSTALL_LIBDIR=${CMAKE_INSTALL_LIBDIR:-lib} \
-DCMAKE_INSTALL_PREFIX=${CMAKE_INSTALL_PREFIX:-${ARROW_HOME}} \
-DCMAKE_UNITY_BUILD=${CMAKE_UNITY_BUILD:-OFF} \
-DGCPSDK_SOURCE=${GCPSDK_SOURCE:-} \
-Dgflags_SOURCE=${gflags_SOURCE:-} \
-DgRPC_SOURCE=${gRPC_SOURCE:-} \
-DGTest_SOURCE=${GTest_SOURCE:-} \
Expand Down
8 changes: 8 additions & 0 deletions cpp/CMakeLists.txt
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -754,6 +754,14 @@ if(ARROW_S3)
list(APPEND ARROW_STATIC_LINK_LIBS ${AWSSDK_LINK_LIBRARIES})
endif()

if(ARROW_GCS)
list(APPEND ARROW_LINK_LIBS storage_client)
list(APPEND ARROW_STATIC_LINK_LIBS storage_client)
if(GCPSDK_SOURCE STREQUAL "SYSTEM")
list(APPEND ARROW_STATIC_INSTALL_INTERFACE_LIBS storage_client)
endif()
endif()

if(ARROW_WITH_UTF8PROC)
list(APPEND ARROW_LINK_LIBS utf8proc::utf8proc)
list(APPEND ARROW_STATIC_LINK_LIBS utf8proc::utf8proc)
Expand Down
4 changes: 4 additions & 0 deletions cpp/cmake_modules/DefineOptions.cmake
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -224,6 +224,10 @@ if("${CMAKE_SOURCE_DIR}" STREQUAL "${CMAKE_CURRENT_SOURCE_DIR}")

define_option(ARROW_GANDIVA "Build the Gandiva libraries" OFF)

define_option(ARROW_GCS
"Build Arrow with GCS support (requires the GCloud SDK for C++)" OFF)
mark_as_advanced(ARROW_GCS) # remove when GCS implementation is complete

define_option(ARROW_HDFS "Build the Arrow HDFS bridge" OFF)

define_option(ARROW_HIVESERVER2 "Build the HiveServer2 client and Arrow adapter" OFF)
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
ARROW-8147: [C++] Add google-cloud-cpp to ThirdpartyToolchain by josiahyan · Pull Request #8757 · apache/arrow · GitHub
Skip to content
ARROW-8147: [C++] Add google-cloud-cpp to ThirdpartyToolchain#8757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

josiahyan
wants to merge
10
commits into

from

 Closed


ARROW-8147: [C++] Add google-cloud-cpp to ThirdpartyToolchain
#8757
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


10 commits


Select commit
Hold shift + click to select a range
6600fb5

ARROW-8147: [C++] Add google-cloud-cpp to ThirdpartyToolchain


josiahyan Nov 24, 2020
17d3636

Add google-cloud-cpp to conda requirements for CI


josiahyan Nov 24, 2020
72cb6f0

Add dependency on nlohmann_json for google-cloud-cpp build


josiahyan Nov 25, 2020
69b5799

Move google-cloud-cpp conda dependencies to unix only


josiahyan Nov 25, 2020
433eca0

Reorder dependencies, minor fixes


josiahyan Dec 1, 2020
46e9dcc

Add URLs to fetch dependencies to cpp/thirdparty/versions.txt


josiahyan Dec 1, 2020
99852f9

Lock GCP SDK version to 1.20.0


josiahyan Feb 28, 2021
cb06b47

Remove GCS SDK from Windows cpp appveyor CI build


josiahyan Feb 28, 2021
7531ca5

Resynchronize GCS SDK's Abseil includes against Abseil LTS branch, Se…


josiahyan Feb 28, 2021
d92433a

Fix typo


josiahyan Aug 23, 2021

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


2 changes: 2 additions & 0 deletions
ci/conda_env_unix.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -19,5 +19,7 @@

autoconf
ccache
google-cloud-cpp=1.20.0
nlohmann_json>=3.4.0
@emkornfieldemkornfieldSep 12, 2021

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is the new JSON dependency for?
@emkornfieldemkornfieldSep 12, 2021

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess google's SDK must rely on it?
@coryancoryanSep 27, 2021

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am one of the authors of google's GCS SDK. Yes, the SDK definitely depends on nlohmann_json.
@pitroupitrouSep 27, 2021

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conda has dependency handling, so there is no reason to mention it explicitly, though.
orc
pkg-config

1 change: 1 addition & 0 deletions
ci/docker/conda-cpp.dockerfile

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -36,6 +36,7 @@ ENV ARROW_BUILD_TESTS=ON \
 ARROW_DEPENDENCY_SOURCE=CONDA \
 ARROW_FLIGHT=ON \
 ARROW_GANDIVA=ON \
 ARROW_GCS=ON \
 ARROW_HOME=$CONDA_PREFIX \
 ARROW_ORC=ON \
 ARROW_PARQUET=ON \
Expand Down

2 changes: 2 additions & 0 deletions
ci/docker/ubuntu-20.04-cpp.dockerfile

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -110,6 +110,7 @@ ENV ARROW_BUILD_TESTS=ON \
 ARROW_DATASET=ON \
 ARROW_FLIGHT=OFF \
 ARROW_GANDIVA=ON \
 ARROW_GCS=ON \
 ARROW_HDFS=ON \
 ARROW_HOME=/usr/local \
 ARROW_INSTALL_NAME_RPATH=OFF \
Expand All@@ -129,6 +130,7 @@ ENV ARROW_BUILD_TESTS=ON \
 ARROW_WITH_ZSTD=ON \
 ASAN_SYMBOLIZER_PATH=/usr/lib/llvm-${llvm}/bin/llvm-symbolizer \
 AWSSDK_SOURCE=BUNDLED \
 GCPSDK_SOURCE=BUNDLED \
 GTest_SOURCE=BUNDLED \
 gRPC_SOURCE=BUNDLED \
 ORC_SOURCE=BUNDLED \
Expand Down

2 changes: 2 additions & 0 deletions
ci/scripts/cpp_build.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -74,6 +74,7 @@ cmake -G "${CMAKE_GENERATOR:-Ninja}" \
 -DARROW_GANDIVA_JAVA=${ARROW_GANDIVA_JAVA:-OFF} \
 -DARROW_GANDIVA_PC_CXX_FLAGS=${ARROW_GANDIVA_PC_CXX_FLAGS:-} \
 -DARROW_GANDIVA=${ARROW_GANDIVA:-OFF} \
 -DARROW_GCS=${ARROW_GCS:-OFF} \
 -DARROW_HDFS=${ARROW_HDFS:-ON} \
 -DARROW_HIVESERVER2=${ARROW_HIVESERVER2:-OFF} \
 -DARROW_INSTALL_NAME_RPATH=${ARROW_INSTALL_NAME_RPATH:-ON} \
Expand DownExpand Up@@ -120,6 +121,7 @@ cmake -G "${CMAKE_GENERATOR:-Ninja}" \
 -DCMAKE_INSTALL_LIBDIR=${CMAKE_INSTALL_LIBDIR:-lib} \
 -DCMAKE_INSTALL_PREFIX=${CMAKE_INSTALL_PREFIX:-${ARROW_HOME}} \
 -DCMAKE_UNITY_BUILD=${CMAKE_UNITY_BUILD:-OFF} \
 -DGCPSDK_SOURCE=${GCPSDK_SOURCE:-} \
 -Dgflags_SOURCE=${gflags_SOURCE:-} \
 -DgRPC_SOURCE=${gRPC_SOURCE:-} \
 -DGTest_SOURCE=${GTest_SOURCE:-} \
Expand Down

8 changes: 8 additions & 0 deletions
cpp/CMakeLists.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -754,6 +754,14 @@ if(ARROW_S3)
 list(APPEND ARROW_STATIC_LINK_LIBS ${AWSSDK_LINK_LIBRARIES})
endif()

if(ARROW_GCS)
 list(APPEND ARROW_LINK_LIBS storage_client)
 list(APPEND ARROW_STATIC_LINK_LIBS storage_client)
 if(GCPSDK_SOURCE STREQUAL "SYSTEM")
 list(APPEND ARROW_STATIC_INSTALL_INTERFACE_LIBS storage_client)
 endif()
endif()

if(ARROW_WITH_UTF8PROC)
 list(APPEND ARROW_LINK_LIBS utf8proc::utf8proc)
 list(APPEND ARROW_STATIC_LINK_LIBS utf8proc::utf8proc)
Expand Down

4 changes: 4 additions & 0 deletions
cpp/cmake_modules/DefineOptions.cmake

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -224,6 +224,10 @@ if("${CMAKE_SOURCE_DIR}" STREQUAL "${CMAKE_CURRENT_SOURCE_DIR}")

 define_option(ARROW_GANDIVA "Build the Gandiva libraries" OFF)

 define_option(ARROW_GCS
 "Build Arrow with GCS support (requires the GCloud SDK for C++)" OFF)
 mark_as_advanced(ARROW_GCS) # remove when GCS implementation is complete

 define_option(ARROW_HDFS "Build the Arrow HDFS bridge" OFF)

 define_option(ARROW_HIVESERVER2 "Build the HiveServer2 client and Arrow adapter" OFF)
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
ARROW-8147: [C++] Add google-cloud-cpp to ThirdpartyToolchain by josiahyan · Pull Request #8757 · apache/arrow · GitHub
Skip to content
ARROW-8147: [C++] Add google-cloud-cpp to ThirdpartyToolchain#8757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

josiahyan
wants to merge
10
commits into

from

 Closed


ARROW-8147: [C++] Add google-cloud-cpp to ThirdpartyToolchain
#8757
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


10 commits


Select commit
Hold shift + click to select a range
6600fb5

ARROW-8147: [C++] Add google-cloud-cpp to ThirdpartyToolchain


josiahyan Nov 24, 2020
17d3636

Add google-cloud-cpp to conda requirements for CI


josiahyan Nov 24, 2020
72cb6f0

Add dependency on nlohmann_json for google-cloud-cpp build


josiahyan Nov 25, 2020
69b5799

Move google-cloud-cpp conda dependencies to unix only


josiahyan Nov 25, 2020
433eca0

Reorder dependencies, minor fixes


josiahyan Dec 1, 2020
46e9dcc

Add URLs to fetch dependencies to cpp/thirdparty/versions.txt


josiahyan Dec 1, 2020
99852f9

Lock GCP SDK version to 1.20.0


josiahyan Feb 28, 2021
cb06b47

Remove GCS SDK from Windows cpp appveyor CI build


josiahyan Feb 28, 2021
7531ca5

Resynchronize GCS SDK's Abseil includes against Abseil LTS branch, Se…


josiahyan Feb 28, 2021
d92433a

Fix typo


josiahyan Aug 23, 2021

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


2 changes: 2 additions & 0 deletions
ci/conda_env_unix.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -19,5 +19,7 @@

autoconf
ccache
google-cloud-cpp=1.20.0
nlohmann_json>=3.4.0
@emkornfieldemkornfieldSep 12, 2021

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is the new JSON dependency for?
@emkornfieldemkornfieldSep 12, 2021

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess google's SDK must rely on it?
@coryancoryanSep 27, 2021

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am one of the authors of google's GCS SDK. Yes, the SDK definitely depends on nlohmann_json.
@pitroupitrouSep 27, 2021

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conda has dependency handling, so there is no reason to mention it explicitly, though.
orc
pkg-config

1 change: 1 addition & 0 deletions
ci/docker/conda-cpp.dockerfile

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -36,6 +36,7 @@ ENV ARROW_BUILD_TESTS=ON \
 ARROW_DEPENDENCY_SOURCE=CONDA \
 ARROW_FLIGHT=ON \
 ARROW_GANDIVA=ON \
 ARROW_GCS=ON \
 ARROW_HOME=$CONDA_PREFIX \
 ARROW_ORC=ON \
 ARROW_PARQUET=ON \
Expand Down

2 changes: 2 additions & 0 deletions
ci/docker/ubuntu-20.04-cpp.dockerfile

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -110,6 +110,7 @@ ENV ARROW_BUILD_TESTS=ON \
 ARROW_DATASET=ON \
 ARROW_FLIGHT=OFF \
 ARROW_GANDIVA=ON \
 ARROW_GCS=ON \
 ARROW_HDFS=ON \
 ARROW_HOME=/usr/local \
 ARROW_INSTALL_NAME_RPATH=OFF \
Expand All@@ -129,6 +130,7 @@ ENV ARROW_BUILD_TESTS=ON \
 ARROW_WITH_ZSTD=ON \
 ASAN_SYMBOLIZER_PATH=/usr/lib/llvm-${llvm}/bin/llvm-symbolizer \
 AWSSDK_SOURCE=BUNDLED \
 GCPSDK_SOURCE=BUNDLED \
 GTest_SOURCE=BUNDLED \
 gRPC_SOURCE=BUNDLED \
 ORC_SOURCE=BUNDLED \
Expand Down

2 changes: 2 additions & 0 deletions
ci/scripts/cpp_build.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -74,6 +74,7 @@ cmake -G "${CMAKE_GENERATOR:-Ninja}" \
 -DARROW_GANDIVA_JAVA=${ARROW_GANDIVA_JAVA:-OFF} \
 -DARROW_GANDIVA_PC_CXX_FLAGS=${ARROW_GANDIVA_PC_CXX_FLAGS:-} \
 -DARROW_GANDIVA=${ARROW_GANDIVA:-OFF} \
 -DARROW_GCS=${ARROW_GCS:-OFF} \
 -DARROW_HDFS=${ARROW_HDFS:-ON} \
 -DARROW_HIVESERVER2=${ARROW_HIVESERVER2:-OFF} \
 -DARROW_INSTALL_NAME_RPATH=${ARROW_INSTALL_NAME_RPATH:-ON} \
Expand DownExpand Up@@ -120,6 +121,7 @@ cmake -G "${CMAKE_GENERATOR:-Ninja}" \
 -DCMAKE_INSTALL_LIBDIR=${CMAKE_INSTALL_LIBDIR:-lib} \
 -DCMAKE_INSTALL_PREFIX=${CMAKE_INSTALL_PREFIX:-${ARROW_HOME}} \
 -DCMAKE_UNITY_BUILD=${CMAKE_UNITY_BUILD:-OFF} \
 -DGCPSDK_SOURCE=${GCPSDK_SOURCE:-} \
 -Dgflags_SOURCE=${gflags_SOURCE:-} \
 -DgRPC_SOURCE=${gRPC_SOURCE:-} \
 -DGTest_SOURCE=${GTest_SOURCE:-} \
Expand Down

8 changes: 8 additions & 0 deletions
cpp/CMakeLists.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -754,6 +754,14 @@ if(ARROW_S3)
 list(APPEND ARROW_STATIC_LINK_LIBS ${AWSSDK_LINK_LIBRARIES})
endif()

if(ARROW_GCS)
 list(APPEND ARROW_LINK_LIBS storage_client)
 list(APPEND ARROW_STATIC_LINK_LIBS storage_client)
 if(GCPSDK_SOURCE STREQUAL "SYSTEM")
 list(APPEND ARROW_STATIC_INSTALL_INTERFACE_LIBS storage_client)
 endif()
endif()

if(ARROW_WITH_UTF8PROC)
 list(APPEND ARROW_LINK_LIBS utf8proc::utf8proc)
 list(APPEND ARROW_STATIC_LINK_LIBS utf8proc::utf8proc)
Expand Down

4 changes: 4 additions & 0 deletions
cpp/cmake_modules/DefineOptions.cmake

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -224,6 +224,10 @@ if("${CMAKE_SOURCE_DIR}" STREQUAL "${CMAKE_CURRENT_SOURCE_DIR}")

 define_option(ARROW_GANDIVA "Build the Gandiva libraries" OFF)

 define_option(ARROW_GCS
 "Build Arrow with GCS support (requires the GCloud SDK for C++)" OFF)
 mark_as_advanced(ARROW_GCS) # remove when GCS implementation is complete

 define_option(ARROW_HDFS "Build the Arrow HDFS bridge" OFF)

 define_option(ARROW_HIVESERVER2 "Build the HiveServer2 client and Arrow adapter" OFF)
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
ARROW-8147: [C++] Add google-cloud-cpp to ThirdpartyToolchain by josiahyan · Pull Request #8757 · apache/arrow · GitHub
Skip to content
ARROW-8147: [C++] Add google-cloud-cpp to ThirdpartyToolchain#8757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

josiahyan
wants to merge
10
commits into

from

 Closed


ARROW-8147: [C++] Add google-cloud-cpp to ThirdpartyToolchain
#8757
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


10 commits


Select commit
Hold shift + click to select a range
6600fb5

ARROW-8147: [C++] Add google-cloud-cpp to ThirdpartyToolchain


josiahyan Nov 24, 2020
17d3636

Add google-cloud-cpp to conda requirements for CI


josiahyan Nov 24, 2020
72cb6f0

Add dependency on nlohmann_json for google-cloud-cpp build


josiahyan Nov 25, 2020
69b5799

Move google-cloud-cpp conda dependencies to unix only


josiahyan Nov 25, 2020
433eca0

Reorder dependencies, minor fixes


josiahyan Dec 1, 2020
46e9dcc

Add URLs to fetch dependencies to cpp/thirdparty/versions.txt


josiahyan Dec 1, 2020
99852f9

Lock GCP SDK version to 1.20.0


josiahyan Feb 28, 2021
cb06b47

Remove GCS SDK from Windows cpp appveyor CI build


josiahyan Feb 28, 2021
7531ca5

Resynchronize GCS SDK's Abseil includes against Abseil LTS branch, Se…


josiahyan Feb 28, 2021
d92433a

Fix typo


josiahyan Aug 23, 2021

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


2 changes: 2 additions & 0 deletions
ci/conda_env_unix.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -19,5 +19,7 @@

autoconf
ccache
google-cloud-cpp=1.20.0
nlohmann_json>=3.4.0
@emkornfieldemkornfieldSep 12, 2021

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is the new JSON dependency for?
@emkornfieldemkornfieldSep 12, 2021

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess google's SDK must rely on it?
@coryancoryanSep 27, 2021

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am one of the authors of google's GCS SDK. Yes, the SDK definitely depends on nlohmann_json.
@pitroupitrouSep 27, 2021

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conda has dependency handling, so there is no reason to mention it explicitly, though.
orc
pkg-config

1 change: 1 addition & 0 deletions
ci/docker/conda-cpp.dockerfile

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -36,6 +36,7 @@ ENV ARROW_BUILD_TESTS=ON \
 ARROW_DEPENDENCY_SOURCE=CONDA \
 ARROW_FLIGHT=ON \
 ARROW_GANDIVA=ON \
 ARROW_GCS=ON \
 ARROW_HOME=$CONDA_PREFIX \
 ARROW_ORC=ON \
 ARROW_PARQUET=ON \
Expand Down

2 changes: 2 additions & 0 deletions
ci/docker/ubuntu-20.04-cpp.dockerfile

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -110,6 +110,7 @@ ENV ARROW_BUILD_TESTS=ON \
 ARROW_DATASET=ON \
 ARROW_FLIGHT=OFF \
 ARROW_GANDIVA=ON \
 ARROW_GCS=ON \
 ARROW_HDFS=ON \
 ARROW_HOME=/usr/local \
 ARROW_INSTALL_NAME_RPATH=OFF \
Expand All@@ -129,6 +130,7 @@ ENV ARROW_BUILD_TESTS=ON \
 ARROW_WITH_ZSTD=ON \
 ASAN_SYMBOLIZER_PATH=/usr/lib/llvm-${llvm}/bin/llvm-symbolizer \
 AWSSDK_SOURCE=BUNDLED \
 GCPSDK_SOURCE=BUNDLED \
 GTest_SOURCE=BUNDLED \
 gRPC_SOURCE=BUNDLED \
 ORC_SOURCE=BUNDLED \
Expand Down

2 changes: 2 additions & 0 deletions
ci/scripts/cpp_build.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -74,6 +74,7 @@ cmake -G "${CMAKE_GENERATOR:-Ninja}" \
 -DARROW_GANDIVA_JAVA=${ARROW_GANDIVA_JAVA:-OFF} \
 -DARROW_GANDIVA_PC_CXX_FLAGS=${ARROW_GANDIVA_PC_CXX_FLAGS:-} \
 -DARROW_GANDIVA=${ARROW_GANDIVA:-OFF} \
 -DARROW_GCS=${ARROW_GCS:-OFF} \
 -DARROW_HDFS=${ARROW_HDFS:-ON} \
 -DARROW_HIVESERVER2=${ARROW_HIVESERVER2:-OFF} \
 -DARROW_INSTALL_NAME_RPATH=${ARROW_INSTALL_NAME_RPATH:-ON} \
Expand DownExpand Up@@ -120,6 +121,7 @@ cmake -G "${CMAKE_GENERATOR:-Ninja}" \
 -DCMAKE_INSTALL_LIBDIR=${CMAKE_INSTALL_LIBDIR:-lib} \
 -DCMAKE_INSTALL_PREFIX=${CMAKE_INSTALL_PREFIX:-${ARROW_HOME}} \
 -DCMAKE_UNITY_BUILD=${CMAKE_UNITY_BUILD:-OFF} \
 -DGCPSDK_SOURCE=${GCPSDK_SOURCE:-} \
 -Dgflags_SOURCE=${gflags_SOURCE:-} \
 -DgRPC_SOURCE=${gRPC_SOURCE:-} \
 -DGTest_SOURCE=${GTest_SOURCE:-} \
Expand Down

8 changes: 8 additions & 0 deletions
cpp/CMakeLists.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -754,6 +754,14 @@ if(ARROW_S3)
 list(APPEND ARROW_STATIC_LINK_LIBS ${AWSSDK_LINK_LIBRARIES})
endif()

if(ARROW_GCS)
 list(APPEND ARROW_LINK_LIBS storage_client)
 list(APPEND ARROW_STATIC_LINK_LIBS storage_client)
 if(GCPSDK_SOURCE STREQUAL "SYSTEM")
 list(APPEND ARROW_STATIC_INSTALL_INTERFACE_LIBS storage_client)
 endif()
endif()

if(ARROW_WITH_UTF8PROC)
 list(APPEND ARROW_LINK_LIBS utf8proc::utf8proc)
 list(APPEND ARROW_STATIC_LINK_LIBS utf8proc::utf8proc)
Expand Down

4 changes: 4 additions & 0 deletions
cpp/cmake_modules/DefineOptions.cmake

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -224,6 +224,10 @@ if("${CMAKE_SOURCE_DIR}" STREQUAL "${CMAKE_CURRENT_SOURCE_DIR}")

 define_option(ARROW_GANDIVA "Build the Gandiva libraries" OFF)

 define_option(ARROW_GCS
 "Build Arrow with GCS support (requires the GCloud SDK for C++)" OFF)
 mark_as_advanced(ARROW_GCS) # remove when GCS implementation is complete

 define_option(ARROW_HDFS "Build the Arrow HDFS bridge" OFF)

 define_option(ARROW_HIVESERVER2 "Build the HiveServer2 client and Arrow adapter" OFF)
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
ARROW-8147: [C++] Add google-cloud-cpp to ThirdpartyToolchain by josiahyan · Pull Request #8757 · apache/arrow · GitHub
Skip to content
ARROW-8147: [C++] Add google-cloud-cpp to ThirdpartyToolchain#8757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

josiahyan
wants to merge
10
commits into

from

 Closed


ARROW-8147: [C++] Add google-cloud-cpp to ThirdpartyToolchain
#8757
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


10 commits


Select commit
Hold shift + click to select a range
6600fb5

ARROW-8147: [C++] Add google-cloud-cpp to ThirdpartyToolchain


josiahyan Nov 24, 2020
17d3636

Add google-cloud-cpp to conda requirements for CI


josiahyan Nov 24, 2020
72cb6f0

Add dependency on nlohmann_json for google-cloud-cpp build


josiahyan Nov 25, 2020
69b5799

Move google-cloud-cpp conda dependencies to unix only


josiahyan Nov 25, 2020
433eca0

Reorder dependencies, minor fixes


josiahyan Dec 1, 2020
46e9dcc

Add URLs to fetch dependencies to cpp/thirdparty/versions.txt


josiahyan Dec 1, 2020
99852f9

Lock GCP SDK version to 1.20.0


josiahyan Feb 28, 2021
cb06b47

Remove GCS SDK from Windows cpp appveyor CI build


josiahyan Feb 28, 2021
7531ca5

Resynchronize GCS SDK's Abseil includes against Abseil LTS branch, Se…


josiahyan Feb 28, 2021
d92433a

Fix typo


josiahyan Aug 23, 2021

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


2 changes: 2 additions & 0 deletions
ci/conda_env_unix.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -19,5 +19,7 @@

autoconf
ccache
google-cloud-cpp=1.20.0
nlohmann_json>=3.4.0
@emkornfieldemkornfieldSep 12, 2021

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is the new JSON dependency for?
@emkornfieldemkornfieldSep 12, 2021

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess google's SDK must rely on it?
@coryancoryanSep 27, 2021

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am one of the authors of google's GCS SDK. Yes, the SDK definitely depends on nlohmann_json.
@pitroupitrouSep 27, 2021

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conda has dependency handling, so there is no reason to mention it explicitly, though.
orc
pkg-config

1 change: 1 addition & 0 deletions
ci/docker/conda-cpp.dockerfile

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -36,6 +36,7 @@ ENV ARROW_BUILD_TESTS=ON \
 ARROW_DEPENDENCY_SOURCE=CONDA \
 ARROW_FLIGHT=ON \
 ARROW_GANDIVA=ON \
 ARROW_GCS=ON \
 ARROW_HOME=$CONDA_PREFIX \
 ARROW_ORC=ON \
 ARROW_PARQUET=ON \
Expand Down

2 changes: 2 additions & 0 deletions
ci/docker/ubuntu-20.04-cpp.dockerfile

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -110,6 +110,7 @@ ENV ARROW_BUILD_TESTS=ON \
 ARROW_DATASET=ON \
 ARROW_FLIGHT=OFF \
 ARROW_GANDIVA=ON \
 ARROW_GCS=ON \
 ARROW_HDFS=ON \
 ARROW_HOME=/usr/local \
 ARROW_INSTALL_NAME_RPATH=OFF \
Expand All@@ -129,6 +130,7 @@ ENV ARROW_BUILD_TESTS=ON \
 ARROW_WITH_ZSTD=ON \
 ASAN_SYMBOLIZER_PATH=/usr/lib/llvm-${llvm}/bin/llvm-symbolizer \
 AWSSDK_SOURCE=BUNDLED \
 GCPSDK_SOURCE=BUNDLED \
 GTest_SOURCE=BUNDLED \
 gRPC_SOURCE=BUNDLED \
 ORC_SOURCE=BUNDLED \
Expand Down

2 changes: 2 additions & 0 deletions
ci/scripts/cpp_build.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -74,6 +74,7 @@ cmake -G "${CMAKE_GENERATOR:-Ninja}" \
 -DARROW_GANDIVA_JAVA=${ARROW_GANDIVA_JAVA:-OFF} \
 -DARROW_GANDIVA_PC_CXX_FLAGS=${ARROW_GANDIVA_PC_CXX_FLAGS:-} \
 -DARROW_GANDIVA=${ARROW_GANDIVA:-OFF} \
 -DARROW_GCS=${ARROW_GCS:-OFF} \
 -DARROW_HDFS=${ARROW_HDFS:-ON} \
 -DARROW_HIVESERVER2=${ARROW_HIVESERVER2:-OFF} \
 -DARROW_INSTALL_NAME_RPATH=${ARROW_INSTALL_NAME_RPATH:-ON} \
Expand DownExpand Up@@ -120,6 +121,7 @@ cmake -G "${CMAKE_GENERATOR:-Ninja}" \
 -DCMAKE_INSTALL_LIBDIR=${CMAKE_INSTALL_LIBDIR:-lib} \
 -DCMAKE_INSTALL_PREFIX=${CMAKE_INSTALL_PREFIX:-${ARROW_HOME}} \
 -DCMAKE_UNITY_BUILD=${CMAKE_UNITY_BUILD:-OFF} \
 -DGCPSDK_SOURCE=${GCPSDK_SOURCE:-} \
 -Dgflags_SOURCE=${gflags_SOURCE:-} \
 -DgRPC_SOURCE=${gRPC_SOURCE:-} \
 -DGTest_SOURCE=${GTest_SOURCE:-} \
Expand Down

8 changes: 8 additions & 0 deletions
cpp/CMakeLists.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -754,6 +754,14 @@ if(ARROW_S3)
 list(APPEND ARROW_STATIC_LINK_LIBS ${AWSSDK_LINK_LIBRARIES})
endif()

if(ARROW_GCS)
 list(APPEND ARROW_LINK_LIBS storage_client)
 list(APPEND ARROW_STATIC_LINK_LIBS storage_client)
 if(GCPSDK_SOURCE STREQUAL "SYSTEM")
 list(APPEND ARROW_STATIC_INSTALL_INTERFACE_LIBS storage_client)
 endif()
endif()

if(ARROW_WITH_UTF8PROC)
 list(APPEND ARROW_LINK_LIBS utf8proc::utf8proc)
 list(APPEND ARROW_STATIC_LINK_LIBS utf8proc::utf8proc)
Expand Down

4 changes: 4 additions & 0 deletions
cpp/cmake_modules/DefineOptions.cmake

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -224,6 +224,10 @@ if("${CMAKE_SOURCE_DIR}" STREQUAL "${CMAKE_CURRENT_SOURCE_DIR}")

 define_option(ARROW_GANDIVA "Build the Gandiva libraries" OFF)

 define_option(ARROW_GCS
 "Build Arrow with GCS support (requires the GCloud SDK for C++)" OFF)
 mark_as_advanced(ARROW_GCS) # remove when GCS implementation is complete

 define_option(ARROW_HDFS "Build the Arrow HDFS bridge" OFF)

 define_option(ARROW_HIVESERVER2 "Build the HiveServer2 client and Arrow adapter" OFF)
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
ARROW-8147: [C++] Add google-cloud-cpp to ThirdpartyToolchain by josiahyan · Pull Request #8757 · apache/arrow · GitHub
Skip to content
ARROW-8147: [C++] Add google-cloud-cpp to ThirdpartyToolchain#8757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

josiahyan
wants to merge
10
commits into

from

 Closed


ARROW-8147: [C++] Add google-cloud-cpp to ThirdpartyToolchain
#8757
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


10 commits


Select commit
Hold shift + click to select a range
6600fb5

ARROW-8147: [C++] Add google-cloud-cpp to ThirdpartyToolchain


josiahyan Nov 24, 2020
17d3636

Add google-cloud-cpp to conda requirements for CI


josiahyan Nov 24, 2020
72cb6f0

Add dependency on nlohmann_json for google-cloud-cpp build


josiahyan Nov 25, 2020
69b5799

Move google-cloud-cpp conda dependencies to unix only


josiahyan Nov 25, 2020
433eca0

Reorder dependencies, minor fixes


josiahyan Dec 1, 2020
46e9dcc

Add URLs to fetch dependencies to cpp/thirdparty/versions.txt


josiahyan Dec 1, 2020
99852f9

Lock GCP SDK version to 1.20.0


josiahyan Feb 28, 2021
cb06b47

Remove GCS SDK from Windows cpp appveyor CI build


josiahyan Feb 28, 2021
7531ca5

Resynchronize GCS SDK's Abseil includes against Abseil LTS branch, Se…


josiahyan Feb 28, 2021
d92433a

Fix typo


josiahyan Aug 23, 2021

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


2 changes: 2 additions & 0 deletions
ci/conda_env_unix.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -19,5 +19,7 @@

autoconf
ccache
google-cloud-cpp=1.20.0
nlohmann_json>=3.4.0
@emkornfieldemkornfieldSep 12, 2021

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is the new JSON dependency for?
@emkornfieldemkornfieldSep 12, 2021

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess google's SDK must rely on it?
@coryancoryanSep 27, 2021

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am one of the authors of google's GCS SDK. Yes, the SDK definitely depends on nlohmann_json.
@pitroupitrouSep 27, 2021

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conda has dependency handling, so there is no reason to mention it explicitly, though.
orc
pkg-config

1 change: 1 addition & 0 deletions
ci/docker/conda-cpp.dockerfile

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -36,6 +36,7 @@ ENV ARROW_BUILD_TESTS=ON \
 ARROW_DEPENDENCY_SOURCE=CONDA \
 ARROW_FLIGHT=ON \
 ARROW_GANDIVA=ON \
 ARROW_GCS=ON \
 ARROW_HOME=$CONDA_PREFIX \
 ARROW_ORC=ON \
 ARROW_PARQUET=ON \
Expand Down

2 changes: 2 additions & 0 deletions
ci/docker/ubuntu-20.04-cpp.dockerfile

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -110,6 +110,7 @@ ENV ARROW_BUILD_TESTS=ON \
 ARROW_DATASET=ON \
 ARROW_FLIGHT=OFF \
 ARROW_GANDIVA=ON \
 ARROW_GCS=ON \
 ARROW_HDFS=ON \
 ARROW_HOME=/usr/local \
 ARROW_INSTALL_NAME_RPATH=OFF \
Expand All@@ -129,6 +130,7 @@ ENV ARROW_BUILD_TESTS=ON \
 ARROW_WITH_ZSTD=ON \
 ASAN_SYMBOLIZER_PATH=/usr/lib/llvm-${llvm}/bin/llvm-symbolizer \
 AWSSDK_SOURCE=BUNDLED \
 GCPSDK_SOURCE=BUNDLED \
 GTest_SOURCE=BUNDLED \
 gRPC_SOURCE=BUNDLED \
 ORC_SOURCE=BUNDLED \
Expand Down

2 changes: 2 additions & 0 deletions
ci/scripts/cpp_build.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -74,6 +74,7 @@ cmake -G "${CMAKE_GENERATOR:-Ninja}" \
 -DARROW_GANDIVA_JAVA=${ARROW_GANDIVA_JAVA:-OFF} \
 -DARROW_GANDIVA_PC_CXX_FLAGS=${ARROW_GANDIVA_PC_CXX_FLAGS:-} \
 -DARROW_GANDIVA=${ARROW_GANDIVA:-OFF} \
 -DARROW_GCS=${ARROW_GCS:-OFF} \
 -DARROW_HDFS=${ARROW_HDFS:-ON} \
 -DARROW_HIVESERVER2=${ARROW_HIVESERVER2:-OFF} \
 -DARROW_INSTALL_NAME_RPATH=${ARROW_INSTALL_NAME_RPATH:-ON} \
Expand DownExpand Up@@ -120,6 +121,7 @@ cmake -G "${CMAKE_GENERATOR:-Ninja}" \
 -DCMAKE_INSTALL_LIBDIR=${CMAKE_INSTALL_LIBDIR:-lib} \
 -DCMAKE_INSTALL_PREFIX=${CMAKE_INSTALL_PREFIX:-${ARROW_HOME}} \
 -DCMAKE_UNITY_BUILD=${CMAKE_UNITY_BUILD:-OFF} \
 -DGCPSDK_SOURCE=${GCPSDK_SOURCE:-} \
 -Dgflags_SOURCE=${gflags_SOURCE:-} \
 -DgRPC_SOURCE=${gRPC_SOURCE:-} \
 -DGTest_SOURCE=${GTest_SOURCE:-} \
Expand Down

8 changes: 8 additions & 0 deletions
cpp/CMakeLists.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -754,6 +754,14 @@ if(ARROW_S3)
 list(APPEND ARROW_STATIC_LINK_LIBS ${AWSSDK_LINK_LIBRARIES})
endif()

if(ARROW_GCS)
 list(APPEND ARROW_LINK_LIBS storage_client)
 list(APPEND ARROW_STATIC_LINK_LIBS storage_client)
 if(GCPSDK_SOURCE STREQUAL "SYSTEM")
 list(APPEND ARROW_STATIC_INSTALL_INTERFACE_LIBS storage_client)
 endif()
endif()

if(ARROW_WITH_UTF8PROC)
 list(APPEND ARROW_LINK_LIBS utf8proc::utf8proc)
 list(APPEND ARROW_STATIC_LINK_LIBS utf8proc::utf8proc)
Expand Down

4 changes: 4 additions & 0 deletions
cpp/cmake_modules/DefineOptions.cmake

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -224,6 +224,10 @@ if("${CMAKE_SOURCE_DIR}" STREQUAL "${CMAKE_CURRENT_SOURCE_DIR}")

 define_option(ARROW_GANDIVA "Build the Gandiva libraries" OFF)

 define_option(ARROW_GCS
 "Build Arrow with GCS support (requires the GCloud SDK for C++)" OFF)
 mark_as_advanced(ARROW_GCS) # remove when GCS implementation is complete

 define_option(ARROW_HDFS "Build the Arrow HDFS bridge" OFF)

 define_option(ARROW_HIVESERVER2 "Build the HiveServer2 client and Arrow adapter" OFF)
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
ARROW-8147: [C++] Add google-cloud-cpp to ThirdpartyToolchain by josiahyan · Pull Request #8757 · apache/arrow · GitHub
Skip to content
ARROW-8147: [C++] Add google-cloud-cpp to ThirdpartyToolchain#8757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

josiahyan
wants to merge
10
commits into

from

 Closed


ARROW-8147: [C++] Add google-cloud-cpp to ThirdpartyToolchain
#8757
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


10 commits


Select commit
Hold shift + click to select a range
6600fb5

ARROW-8147: [C++] Add google-cloud-cpp to ThirdpartyToolchain


josiahyan Nov 24, 2020
17d3636

Add google-cloud-cpp to conda requirements for CI


josiahyan Nov 24, 2020
72cb6f0

Add dependency on nlohmann_json for google-cloud-cpp build


josiahyan Nov 25, 2020
69b5799

Move google-cloud-cpp conda dependencies to unix only


josiahyan Nov 25, 2020
433eca0

Reorder dependencies, minor fixes


josiahyan Dec 1, 2020
46e9dcc

Add URLs to fetch dependencies to cpp/thirdparty/versions.txt


josiahyan Dec 1, 2020
99852f9

Lock GCP SDK version to 1.20.0


josiahyan Feb 28, 2021
cb06b47

Remove GCS SDK from Windows cpp appveyor CI build


josiahyan Feb 28, 2021
7531ca5

Resynchronize GCS SDK's Abseil includes against Abseil LTS branch, Se…


josiahyan Feb 28, 2021
d92433a

Fix typo


josiahyan Aug 23, 2021

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


2 changes: 2 additions & 0 deletions
ci/conda_env_unix.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -19,5 +19,7 @@

autoconf
ccache
google-cloud-cpp=1.20.0
nlohmann_json>=3.4.0
@emkornfieldemkornfieldSep 12, 2021

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is the new JSON dependency for?
@emkornfieldemkornfieldSep 12, 2021

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess google's SDK must rely on it?
@coryancoryanSep 27, 2021

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am one of the authors of google's GCS SDK. Yes, the SDK definitely depends on nlohmann_json.
@pitroupitrouSep 27, 2021

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conda has dependency handling, so there is no reason to mention it explicitly, though.
orc
pkg-config

1 change: 1 addition & 0 deletions
ci/docker/conda-cpp.dockerfile

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -36,6 +36,7 @@ ENV ARROW_BUILD_TESTS=ON \
 ARROW_DEPENDENCY_SOURCE=CONDA \
 ARROW_FLIGHT=ON \
 ARROW_GANDIVA=ON \
 ARROW_GCS=ON \
 ARROW_HOME=$CONDA_PREFIX \
 ARROW_ORC=ON \
 ARROW_PARQUET=ON \
Expand Down

2 changes: 2 additions & 0 deletions
ci/docker/ubuntu-20.04-cpp.dockerfile

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -110,6 +110,7 @@ ENV ARROW_BUILD_TESTS=ON \
 ARROW_DATASET=ON \
 ARROW_FLIGHT=OFF \
 ARROW_GANDIVA=ON \
 ARROW_GCS=ON \
 ARROW_HDFS=ON \
 ARROW_HOME=/usr/local \
 ARROW_INSTALL_NAME_RPATH=OFF \
Expand All@@ -129,6 +130,7 @@ ENV ARROW_BUILD_TESTS=ON \
 ARROW_WITH_ZSTD=ON \
 ASAN_SYMBOLIZER_PATH=/usr/lib/llvm-${llvm}/bin/llvm-symbolizer \
 AWSSDK_SOURCE=BUNDLED \
 GCPSDK_SOURCE=BUNDLED \
 GTest_SOURCE=BUNDLED \
 gRPC_SOURCE=BUNDLED \
 ORC_SOURCE=BUNDLED \
Expand Down

2 changes: 2 additions & 0 deletions
ci/scripts/cpp_build.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -74,6 +74,7 @@ cmake -G "${CMAKE_GENERATOR:-Ninja}" \
 -DARROW_GANDIVA_JAVA=${ARROW_GANDIVA_JAVA:-OFF} \
 -DARROW_GANDIVA_PC_CXX_FLAGS=${ARROW_GANDIVA_PC_CXX_FLAGS:-} \
 -DARROW_GANDIVA=${ARROW_GANDIVA:-OFF} \
 -DARROW_GCS=${ARROW_GCS:-OFF} \
 -DARROW_HDFS=${ARROW_HDFS:-ON} \
 -DARROW_HIVESERVER2=${ARROW_HIVESERVER2:-OFF} \
 -DARROW_INSTALL_NAME_RPATH=${ARROW_INSTALL_NAME_RPATH:-ON} \
Expand DownExpand Up@@ -120,6 +121,7 @@ cmake -G "${CMAKE_GENERATOR:-Ninja}" \
 -DCMAKE_INSTALL_LIBDIR=${CMAKE_INSTALL_LIBDIR:-lib} \
 -DCMAKE_INSTALL_PREFIX=${CMAKE_INSTALL_PREFIX:-${ARROW_HOME}} \
 -DCMAKE_UNITY_BUILD=${CMAKE_UNITY_BUILD:-OFF} \
 -DGCPSDK_SOURCE=${GCPSDK_SOURCE:-} \
 -Dgflags_SOURCE=${gflags_SOURCE:-} \
 -DgRPC_SOURCE=${gRPC_SOURCE:-} \
 -DGTest_SOURCE=${GTest_SOURCE:-} \
Expand Down

8 changes: 8 additions & 0 deletions
cpp/CMakeLists.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -754,6 +754,14 @@ if(ARROW_S3)
 list(APPEND ARROW_STATIC_LINK_LIBS ${AWSSDK_LINK_LIBRARIES})
endif()

if(ARROW_GCS)
 list(APPEND ARROW_LINK_LIBS storage_client)
 list(APPEND ARROW_STATIC_LINK_LIBS storage_client)
 if(GCPSDK_SOURCE STREQUAL "SYSTEM")
 list(APPEND ARROW_STATIC_INSTALL_INTERFACE_LIBS storage_client)
 endif()
endif()

if(ARROW_WITH_UTF8PROC)
 list(APPEND ARROW_LINK_LIBS utf8proc::utf8proc)
 list(APPEND ARROW_STATIC_LINK_LIBS utf8proc::utf8proc)
Expand Down

4 changes: 4 additions & 0 deletions
cpp/cmake_modules/DefineOptions.cmake

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -224,6 +224,10 @@ if("${CMAKE_SOURCE_DIR}" STREQUAL "${CMAKE_CURRENT_SOURCE_DIR}")

 define_option(ARROW_GANDIVA "Build the Gandiva libraries" OFF)

 define_option(ARROW_GCS
 "Build Arrow with GCS support (requires the GCloud SDK for C++)" OFF)
 mark_as_advanced(ARROW_GCS) # remove when GCS implementation is complete

 define_option(ARROW_HDFS "Build the Arrow HDFS bridge" OFF)

 define_option(ARROW_HIVESERVER2 "Build the HiveServer2 client and Arrow adapter" OFF)
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
ARROW-8147: [C++] Add google-cloud-cpp to ThirdpartyToolchain by josiahyan · Pull Request #8757 · apache/arrow · GitHub
Skip to content
ARROW-8147: [C++] Add google-cloud-cpp to ThirdpartyToolchain#8757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

josiahyan
wants to merge
10
commits into

from

 Closed


ARROW-8147: [C++] Add google-cloud-cpp to ThirdpartyToolchain
#8757
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


10 commits


Select commit
Hold shift + click to select a range
6600fb5

ARROW-8147: [C++] Add google-cloud-cpp to ThirdpartyToolchain


josiahyan Nov 24, 2020
17d3636

Add google-cloud-cpp to conda requirements for CI


josiahyan Nov 24, 2020
72cb6f0

Add dependency on nlohmann_json for google-cloud-cpp build


josiahyan Nov 25, 2020
69b5799

Move google-cloud-cpp conda dependencies to unix only


josiahyan Nov 25, 2020
433eca0

Reorder dependencies, minor fixes


josiahyan Dec 1, 2020
46e9dcc

Add URLs to fetch dependencies to cpp/thirdparty/versions.txt


josiahyan Dec 1, 2020
99852f9

Lock GCP SDK version to 1.20.0


josiahyan Feb 28, 2021
cb06b47

Remove GCS SDK from Windows cpp appveyor CI build


josiahyan Feb 28, 2021
7531ca5

Resynchronize GCS SDK's Abseil includes against Abseil LTS branch, Se…


josiahyan Feb 28, 2021
d92433a

Fix typo


josiahyan Aug 23, 2021

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


2 changes: 2 additions & 0 deletions
ci/conda_env_unix.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -19,5 +19,7 @@

autoconf
ccache
google-cloud-cpp=1.20.0
nlohmann_json>=3.4.0
@emkornfieldemkornfieldSep 12, 2021

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is the new JSON dependency for?
@emkornfieldemkornfieldSep 12, 2021

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess google's SDK must rely on it?
@coryancoryanSep 27, 2021

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am one of the authors of google's GCS SDK. Yes, the SDK definitely depends on nlohmann_json.
@pitroupitrouSep 27, 2021

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conda has dependency handling, so there is no reason to mention it explicitly, though.
orc
pkg-config

1 change: 1 addition & 0 deletions
ci/docker/conda-cpp.dockerfile

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -36,6 +36,7 @@ ENV ARROW_BUILD_TESTS=ON \
 ARROW_DEPENDENCY_SOURCE=CONDA \
 ARROW_FLIGHT=ON \
 ARROW_GANDIVA=ON \
 ARROW_GCS=ON \
 ARROW_HOME=$CONDA_PREFIX \
 ARROW_ORC=ON \
 ARROW_PARQUET=ON \
Expand Down

2 changes: 2 additions & 0 deletions
ci/docker/ubuntu-20.04-cpp.dockerfile

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -110,6 +110,7 @@ ENV ARROW_BUILD_TESTS=ON \
 ARROW_DATASET=ON \
 ARROW_FLIGHT=OFF \
 ARROW_GANDIVA=ON \
 ARROW_GCS=ON \
 ARROW_HDFS=ON \
 ARROW_HOME=/usr/local \
 ARROW_INSTALL_NAME_RPATH=OFF \
Expand All@@ -129,6 +130,7 @@ ENV ARROW_BUILD_TESTS=ON \
 ARROW_WITH_ZSTD=ON \
 ASAN_SYMBOLIZER_PATH=/usr/lib/llvm-${llvm}/bin/llvm-symbolizer \
 AWSSDK_SOURCE=BUNDLED \
 GCPSDK_SOURCE=BUNDLED \
 GTest_SOURCE=BUNDLED \
 gRPC_SOURCE=BUNDLED \
 ORC_SOURCE=BUNDLED \
Expand Down

2 changes: 2 additions & 0 deletions
ci/scripts/cpp_build.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -74,6 +74,7 @@ cmake -G "${CMAKE_GENERATOR:-Ninja}" \
 -DARROW_GANDIVA_JAVA=${ARROW_GANDIVA_JAVA:-OFF} \
 -DARROW_GANDIVA_PC_CXX_FLAGS=${ARROW_GANDIVA_PC_CXX_FLAGS:-} \
 -DARROW_GANDIVA=${ARROW_GANDIVA:-OFF} \
 -DARROW_GCS=${ARROW_GCS:-OFF} \
 -DARROW_HDFS=${ARROW_HDFS:-ON} \
 -DARROW_HIVESERVER2=${ARROW_HIVESERVER2:-OFF} \
 -DARROW_INSTALL_NAME_RPATH=${ARROW_INSTALL_NAME_RPATH:-ON} \
Expand DownExpand Up@@ -120,6 +121,7 @@ cmake -G "${CMAKE_GENERATOR:-Ninja}" \
 -DCMAKE_INSTALL_LIBDIR=${CMAKE_INSTALL_LIBDIR:-lib} \
 -DCMAKE_INSTALL_PREFIX=${CMAKE_INSTALL_PREFIX:-${ARROW_HOME}} \
 -DCMAKE_UNITY_BUILD=${CMAKE_UNITY_BUILD:-OFF} \
 -DGCPSDK_SOURCE=${GCPSDK_SOURCE:-} \
 -Dgflags_SOURCE=${gflags_SOURCE:-} \
 -DgRPC_SOURCE=${gRPC_SOURCE:-} \
 -DGTest_SOURCE=${GTest_SOURCE:-} \
Expand Down

8 changes: 8 additions & 0 deletions
cpp/CMakeLists.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -754,6 +754,14 @@ if(ARROW_S3)
 list(APPEND ARROW_STATIC_LINK_LIBS ${AWSSDK_LINK_LIBRARIES})
endif()

if(ARROW_GCS)
 list(APPEND ARROW_LINK_LIBS storage_client)
 list(APPEND ARROW_STATIC_LINK_LIBS storage_client)
 if(GCPSDK_SOURCE STREQUAL "SYSTEM")
 list(APPEND ARROW_STATIC_INSTALL_INTERFACE_LIBS storage_client)
 endif()
endif()

if(ARROW_WITH_UTF8PROC)
 list(APPEND ARROW_LINK_LIBS utf8proc::utf8proc)
 list(APPEND ARROW_STATIC_LINK_LIBS utf8proc::utf8proc)
Expand Down

4 changes: 4 additions & 0 deletions
cpp/cmake_modules/DefineOptions.cmake

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -224,6 +224,10 @@ if("${CMAKE_SOURCE_DIR}" STREQUAL "${CMAKE_CURRENT_SOURCE_DIR}")

 define_option(ARROW_GANDIVA "Build the Gandiva libraries" OFF)

 define_option(ARROW_GCS
 "Build Arrow with GCS support (requires the GCloud SDK for C++)" OFF)
 mark_as_advanced(ARROW_GCS) # remove when GCS implementation is complete

 define_option(ARROW_HDFS "Build the Arrow HDFS bridge" OFF)

 define_option(ARROW_HIVESERVER2 "Build the HiveServer2 client and Arrow adapter" OFF)
Expand Down
Loading