Skip to content

ARROW-10907: [Rust] Fix Cast UTF8 to Date64 - #8918

Closed
seddonm1 wants to merge 1 commit into
apache:masterfrom
seddonm1:fix-date64-cast
Closed

ARROW-10907: [Rust] Fix Cast UTF8 to Date64#8918
seddonm1 wants to merge 1 commit into
apache:masterfrom
seddonm1:fix-date64-cast

Conversation

@seddonm1

Copy link
Copy Markdown
Contributor

This PR fixes the behavior of a UTF8 -> Date64 conversion process to use %Y-%m-%dT%H:%M:%S rather than %Y-%m-%d with 00:00:00 time component.

It aligns with #8913.

@seddonm1seddonm1 changed the title ARROW-10907: [Rust] Correct date64 behaviorARROW-10907: [Rust] Fix Cast UTF8 to Date64Dec 14, 2020
@github-actions

Copy link
Copy Markdown

@codecov-io

codecov-io commented Dec 14, 2020

Copy link
Copy Markdown

Codecov Report

Merging #8918 (1863c08) into master (408e5be) will decrease coverage by 23.45%.
The diff coverage is 100.00%.

Impacted file tree graph

@@ Coverage Diff @@## master #8918 +/- ##
===========================================
- Coverage 75.35% 51.90% -23.46% 
===========================================
Files 177 173 -4 Lines 40821 31082 -9739 ===========================================
- Hits 30762 16132 -14630 - Misses 10059 14950 +4891 
Impacted FilesCoverage Δ
rust/datafusion/src/physical_plan/expressions.rs0.00% <ø> (ø)
rust/arrow/src/compute/kernels/cast.rs96.21% <100.00%> (-0.13%)⬇️
rust/parquet/src/column/page.rs0.00% <0.00%> (-98.69%)⬇️
rust/parquet/src/record/api.rs0.00% <0.00%> (-98.15%)⬇️
rust/parquet/src/arrow/arrow_writer.rs0.00% <0.00%> (-97.34%)⬇️
rust/parquet/src/basic.rs0.00% <0.00%> (-97.27%)⬇️
rust/parquet/src/file/properties.rs0.00% <0.00%> (-95.73%)⬇️
rust/parquet/src/file/serialized_reader.rs0.00% <0.00%> (-95.62%)⬇️
rust/parquet/src/file/writer.rs0.00% <0.00%> (-95.11%)⬇️
rust/parquet/src/arrow/record_reader.rs0.00% <0.00%> (-94.54%)⬇️
... and 44 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cbb1ed5...1863c08. Read the comment docs.

@nevi-menevi-me left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DandandanDandandanDec 15, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See latest commits in #8913. There is a default parser for the same format that also avoids parsing the format for each value (faster), and also supports the decimal fraction

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Dandandan will update.

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have updated with your suggested changes. thank you very much - this helps me learn.

@alambalamb closed this in 970a9e7Dec 15, 2020
@alamb

Copy link
Copy Markdown
Contributor

Thanks @Dandandan and @seddonm1 👍

@seddonm1
seddonm1 deleted the fix-date64-cast branch December 16, 2020 02:05
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@seddonm1@codecov-io@alamb@Dandandan@nevi-me