Uh oh!
There was an error while loading. Please reload this page.
ARROW-10938: [Rust] upgrade dependency "flatbuffers" to 0.8 - #8936
Conversation
… rust/arrow/src/ipc/gen/ format/*.fbs
Uh oh!
There was an error while loading. Please reload this page.
| message | ||
| .header_as_schema() | ||
| .map(arrow::ipc::convert::fb_to_schema) | ||
| if let Ok(message) = arrow::ipc::root_as_message(slice) { |
There was a problem hiding this comment.
We are ignoring errors here too. Is this the intent?
There was a problem hiding this comment.
DONE. Since there is already a eprintln!(), the new error is caught with eprintln!() too.
We may improve them later, right?
BTW, I failed to change the return type of get_arrow_schema_from_metadata() from Option<Schema> to Result<Schema> or Result<Option<Schema>>.
Uh oh!
There was an error while loading. Please reload this page.
andygrove
commented
Dec 16, 2020
Thanks @mqy this is looking good and I appreciate you breaking this down into the individual commits. I have some questions on error handling but other than that it LGTM. |
mqy
commented
Dec 16, 2020
@andygrove that's great! Since i'm pretty new to rust, it may take me some time to completely fix/enhance the "Option -> Result problems", and time to sleep for now. I'll continue this PR next morning, if ... it is not merged :) |
Codecov Report
@@ Coverage Diff @@## master #8936 +/- ##
==========================================
- Coverage 83.26% 82.85% -0.42%
==========================================
Files 195 196 +1 Lines 48066 48577 +511 ==========================================
+ Hits 40023 40249 +226 - Misses 8043 8328 +285
Continue to review full report at Codecov.
|
alamb
commented
Dec 17, 2020
The conda integration test failed due to what appears to be some unrelated error: I will restart the check to see if we can get a green CI run |
mqy
commented
Dec 18, 2020
@alamb pushed another commit 0dff5ea1ee It's the update after fixing flatc rust generator, google/flatbuffers 05192553 FYI. |
nevi-me
left a comment
There was a problem hiding this comment.
LGTM, we should open a JIRA to move us to the next flatbuffers release
alamb
commented
Dec 19, 2020
Thanks @mqy -- I'll try and look at this carefully tomorrow. |
alamb
commented
Dec 21, 2020
@nevi-me -- filed https://issues.apache.org/jira/browse/ARROW-10997 |
| .header_as_schema() | ||
| .map(arrow::ipc::convert::fb_to_schema), | ||
| Err(err) => { | ||
| // The flatbuffers implementation returns an error on verification error. |
There was a problem hiding this comment.
I filed https://issues.apache.org/jira/browse/ARROW-10996 to track returning this is a proper error message. I think this PR improves the situation so at least eprintln! is called where prior to this PR no error message is created.
alamb
commented
Dec 21, 2020
I merged this branch into apache/master and ran the tests locally just to be sure things are good. Merging |
…chema_from_metadata() #8936 updated crate `flatbuffers` to 0.8.0 , but function `get_arrow_schema_from_metadata` still returning `Option` rather than `Result`. This PR fixes this issue. Closes#9058 from mqy/get_arrow_schema_from_metadata Authored-by: mqy <meng.qingyou@gmail.com> Signed-off-by: Jorge C. Leitao <jorgecarleitao@gmail.com>
…chema_from_metadata() apache/arrow#8936 updated crate `flatbuffers` to 0.8.0 , but function `get_arrow_schema_from_metadata` still returning `Option` rather than `Result`. This PR fixes this issue. Closes#9058 from mqy/get_arrow_schema_from_metadata Authored-by: mqy <meng.qingyou@gmail.com> Signed-off-by: Jorge C. Leitao <jorgecarleitao@gmail.com>
flatbuffers 0.8.0 was released on Dec 10, 2020, with some notable changes:
flatbuffers 0.8.0 requires the latest flatc, the git commit for flatc is updated too.
I deliberately commit all changes step by step to make them clear.