Skip to content

ARROW-10350: [Rust] Fixes to publication metadata in Cargo.toml - #9031

Closed
huitseeker wants to merge 3 commits into
apache:masterfrom
huitseeker:publication
Closed

ARROW-10350: [Rust] Fixes to publication metadata in Cargo.toml#9031
huitseeker wants to merge 3 commits into
apache:masterfrom
huitseeker:publication

Conversation

@huitseeker

@huitseekerhuitseeker commented Dec 28, 2020

Copy link
Copy Markdown
Contributor

Cleans some TOML fields and marks some testing crates not-for-publication.

andygrove
andygrove reviewed Dec 28, 2020
View reviewed changes
Comment threadrust/parquet_derive/Cargo.toml Outdated
@github-actions

github-actionsBot commented Dec 28, 2020

Copy link
Copy Markdown

https://issues.apache.org/jira/browse/ARROW-10350

@huitseeker
huitseekerforce-pushed the publication branch 2 times, most recently from 2406448 to b519716CompareDecember 28, 2020 18:17
andygrove
andygrove reviewed Dec 28, 2020
View reviewed changes
Comment threadrust/parquet_derive_test/Cargo.toml Outdated
@andygrove

andygrove commented Dec 28, 2020

Copy link
Copy Markdown
Member

@huitseeker Unfortunately the release verification scripts will need updating to reflect the changes to these Cargo.toml files. If you look at the CI failure you should be able to reproduce this locally by running the same script.

@nevi-me

nevi-me commented Jan 6, 2021

Copy link
Copy Markdown
Contributor

I'll complete this during the week

@huitseeker

huitseeker commented Jan 8, 2021

Copy link
Copy Markdown
ContributorAuthor

@nevi-me@andygrove The release verification component should now be fixed. Besides that, some integration tests seem to be running on the wrong side of a source incompatible change (e.g. the same compilation errors are met in the unrelated #9137). Those failures should probably be addressed in a distinct PR?

@nevi-me

nevi-me commented Jan 9, 2021

Copy link
Copy Markdown
Contributor

Hey @huitseeker, the errors in integration tests should be fixed now, may you please kindly rebase

paddyhoran
paddyhoran approved these changes Jan 10, 2021
View reviewed changes

@paddyhoranpaddyhoran left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@asfimportasfimport mentioned this pull request Jan 10, 2021
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andygroveandygroveandygrove approved these changes
@nevi-menevi-menevi-me approved these changes
@paddyhoranpaddyhoranpaddyhoran approved these changes

Assignees

No one assigned

Labels

Component: ParquetComponent: Rust

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@huitseeker@andygrove@nevi-me@paddyhoran