Skip to content

ARROW-11216: [Rust] add doc example for StringDictionaryBuilder - #9169

Closed
alamb wants to merge 1 commit into
apache:masterfrom
alamb:alamb/doc-example
Closed

ARROW-11216: [Rust] add doc example for StringDictionaryBuilder#9169
alamb wants to merge 1 commit into
apache:masterfrom
alamb:alamb/doc-example

Conversation

@alamb

Copy link
Copy Markdown
Contributor

I find myself trying to remember the exact incantation to create a StringDictionaryBuilder so I figured I would add it as a doc example

@github-actions

Copy link
Copy Markdown

@codecov-io

Copy link
Copy Markdown

Codecov Report

Merging #9169 (7ab19e3) into master (6da7718) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@## master #9169 +/- ##
=======================================
Coverage 81.55% 81.55% =======================================
Files 215 215 Lines 51600 51600 =======================================
Hits 42084 42084 Misses 9516 9516 
Impacted FilesCoverage Δ
rust/arrow/src/array/builder.rs85.89% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6da7718...7ab19e3. Read the comment docs.

@jorgecarleitaojorgecarleitao left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks a lot.

The API is not very pretty, imo. :(

We will need to find a way to generate that from an iterator or something ^_^

@alamb

Copy link
Copy Markdown
ContributorAuthor

I apologize for the delay in merging Rust PRs -- the 3.0 release is being finalized now and are planning to minimize entropy by postponing merging changes not critical for the release until the process was complete. I hope the process is complete in the next few days. There is more discussion in the mailing list

kszucs pushed a commit that referenced this pull request Jan 25, 2021
I find myself trying to remember the exact incantation to create a `StringDictionaryBuilder` so I figured I would add it as a doc example
Closes#9169 from alamb/alamb/doc-example
Authored-by: Andrew Lamb <andrew@nerdnetworks.org>
Signed-off-by: Jorge C. Leitao <jorgecarleitao@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@alamb@codecov-io@jorgecarleitao