Skip to content

ARROW-11246: [Rust] Add type to Unexpected accumulator state error - #9201

Closed
ovr wants to merge 1 commit into
apache:masterfrom
ovr:unexpected-accumulator-state
Closed

ARROW-11246: [Rust] Add type to Unexpected accumulator state error#9201
ovr wants to merge 1 commit into
apache:masterfrom
ovr:unexpected-accumulator-state

Conversation

@ovr

@ovrovr commented Jan 13, 2021

Copy link
Copy Markdown
Contributor

I am getting a bug with an error: Unexpected accumulator state, but It's not possible to understand what value was passed when the exception is done on the user's side. I add type to the error message to make investigation of the bug more easy.

@github-actions

Copy link
Copy Markdown

@codecov-io

Copy link
Copy Markdown

Codecov Report

Merging #9201 (e2179b9) into master (6da7718) will increase coverage by 0.00%.
The diff coverage is 62.90%.

Impacted file tree graph

@@ Coverage Diff @@## master #9201 +/- ##
=======================================
Coverage 81.55% 81.56% =======================================
Files 215 215 Lines 51600 51656 +56 =======================================
+ Hits 42084 42133 +49 - Misses 9516 9523 +7 
Impacted FilesCoverage Δ
rust/arrow/src/datatypes.rs78.59% <0.00%> (-0.16%)⬇️
...tafusion/src/physical_plan/distinct_expressions.rs91.26% <0.00%> (-0.45%)⬇️
...ust/datafusion/src/physical_plan/hash_aggregate.rs84.65% <0.00%> (ø)
rust/datafusion/src/physical_plan/hash_join.rs84.27% <0.00%> (ø)
rust/datafusion/src/physical_plan/common.rs78.78% <73.58%> (+13.57%)⬆️
rust/parquet/src/encodings/encoding.rs95.43% <0.00%> (+0.19%)⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 081d966...e2179b9. Read the comment docs.

@alamb

Copy link
Copy Markdown
Contributor

I apologize for the delay in merging Rust PRs -- the 3.0 release is being finalized now and are planning to minimize entropy by postponing merging changes not critical for the release until the process was complete. I hope the process is complete in the next few days. There is more discussion in the mailing list

@alambalamb closed this in 2d3e8f9Jan 19, 2021
kszucs pushed a commit that referenced this pull request Jan 25, 2021
I am getting a bug with an error: Unexpected accumulator state, but It's not possible to understand what value was passed when the exception is done on the user's side. I add type to the error message to make investigation of the bug more easy.
Closes#9201 from ovr/unexpected-accumulator-state
Authored-by: Dmitry Patsura <zaets28rus@gmail.com>
Signed-off-by: Andrew Lamb <andrew@nerdnetworks.org>
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 81.56%. Comparing base (6da7718) to head (e2179b9).

Files with missing linesPatch %Lines
...tafusion/src/physical_plan/distinct_expressions.rs0.00%3 Missing ⚠️
Additional details and impacted files
@@ Coverage Diff @@## master #9201 +/- ##
=======================================
Coverage 81.55% 81.56% =======================================
Files 215 215 Lines 51600 51656 +56 =======================================
+ Hits 42084 42133 +49 - Misses 9516 9523 +7 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@ovr@codecov-io@alamb@codecov-commenter@jorgecarleitao