ARROW-1300: [JAVA] Fix Tests for ListVector#925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
siddharthteotia wants to merge 4 commits into from
Closed

ARROW-1300: [JAVA] Fix Tests for ListVector #925

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
777e0de
ARROW-1300: Fix Tests for ListVector
siddharthteotia Aug 1, 2017
9978199
ARROW-1300: Fix tests for ListVector
siddharthteotia Aug 1, 2017
ff84253
ARROW-1300: Fix Tests for ListVector
siddharthteotia Aug 1, 2017
584c79e
ARROW-1300: Fix tests for ListVector
siddharthteotia Aug 4, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
151 changes: 143 additions & 8 deletions java/vector/src/test/java/org/apache/arrow/vector/TestListVector.java
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -38,8 +38,10 @@
import org.junit.Before;
import org.junit.Test;

import java.util.ArrayList;
import java.util.List;


public class TestListVector {

private BufferAllocator allocator;
Expand DownExpand Up@@ -92,6 +94,26 @@ public void testCopyFrom() throws Exception {
Assert.assertFalse("should be null", reader.isSet());
reader.setPosition(2);
Assert.assertTrue("shouldn't be null", reader.isSet());

/* check the exact contents of vector */
final ListVector.Accessor accessor = outVector.getAccessor();

/* index 0 */
Object result = accessor.getObject(0);
ArrayList<Long> resultSet = (ArrayList<Long>)result;

@icexellossicexellossAug 1, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need space between (ArrayList<Long>) and result

@icexellossicexellossAug 1, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, google_checks.xml doesn't specify TypecastParenPad rule, so this is fine.

assertEquals(3, resultSet.size());
assertEquals(new Long(1), (Long)resultSet.get(0));
assertEquals(new Long(2), (Long)resultSet.get(1));
assertEquals(new Long(3), (Long)resultSet.get(2));

/* index 1 */
result = accessor.getObject(1);
assertNull(result);

/* index 2 */
result = accessor.getObject(2);
resultSet = (ArrayList<Long>)result;
assertEquals(0, resultSet.size());
}
}

Expand DownExpand Up@@ -127,7 +149,7 @@ public void testSetLastSetUsage() throws Exception {
dataVector.getMutator().setSafe(2, 1, 12);
offsetVector.getMutator().setSafe(index + 1, 3);

index += 1;
index += 1;

/* write [13, 14] to the list vector at index 1 */
bitVector.getMutator().setSafe(index, 1);
Expand DownExpand Up@@ -193,7 +215,7 @@ public void testSetLastSetUsage() throws Exception {
final UInt4Vector.Accessor offsetAccessor = offsetVector.getAccessor();
final ValueVector.Accessor valueAccessor = dataVector.getAccessor();

index = 0;
index = 0;
offset = offsetAccessor.get(index);
assertEquals(Integer.toString(0), Integer.toString(offset));

Expand DownExpand Up@@ -300,7 +322,7 @@ public void testSplitAndTransfer() throws Exception {
final UInt4Vector.Accessor offsetAccessor = offsetVector.getAccessor();
final ValueVector.Accessor valueAccessor = dataVector.getAccessor();

int index = 0;
int index = 0;
int offset = 0;
Object actual = null;

Expand DownExpand Up@@ -386,10 +408,7 @@ public void testSplitAndTransfer() throws Exception {

TransferPair transferPair = listVector.makeTransferPair(toVector);

int[][] transferLengths = { {0, 2},
{3, 1},
{4, 1}
};
int[][] transferLengths = {{0, 2}, {3, 1}, {4, 1}};

for (final int[] transferLength : transferLengths) {
int start = transferLength[0];
Expand DownExpand Up@@ -423,7 +442,7 @@ public void testSplitAndTransfer() throws Exception {

for(int j = 0; j < dataLength1; j++) {
assertEquals("Different data at indexes: " + offset1 + " and " + offset2,
valueAccessor.getObject(offset1), valueAccessor1.getObject(offset2));
valueAccessor.getObject(offset1), valueAccessor1.getObject(offset2));

offset1++;
offset2++;
Expand All@@ -433,4 +452,120 @@ public void testSplitAndTransfer() throws Exception {
}
}
}

@Test
public void testNestedListVector() throws Exception {
try (ListVector listVector = ListVector.empty("sourceVector", allocator)) {

UnionListWriter listWriter = listVector.getWriter();

/* allocate memory */
listWriter.allocate();

/* the dataVector that backs a listVector will also be a
* listVector for this test.
*/

/* write one or more inner lists at index 0 */
listWriter.setPosition(0);
listWriter.startList();

listWriter.list().startList();
listWriter.list().bigInt().writeBigInt(50);
listWriter.list().bigInt().writeBigInt(100);
listWriter.list().bigInt().writeBigInt(200);
listWriter.list().endList();

listWriter.list().startList();
listWriter.list().bigInt().writeBigInt(75);
listWriter.list().bigInt().writeBigInt(125);
listWriter.list().bigInt().writeBigInt(150);
listWriter.list().bigInt().writeBigInt(175);
listWriter.list().endList();

listWriter.endList();

/* write one or more inner lists at index 1 */
listWriter.setPosition(1);
listWriter.startList();

listWriter.list().startList();
listWriter.list().bigInt().writeBigInt(10);
listWriter.list().endList();

listWriter.list().startList();
listWriter.list().bigInt().writeBigInt(15);
listWriter.list().bigInt().writeBigInt(20);
listWriter.list().endList();

listWriter.list().startList();
listWriter.list().bigInt().writeBigInt(25);
listWriter.list().bigInt().writeBigInt(30);
listWriter.list().bigInt().writeBigInt(35);
listWriter.list().endList();

listWriter.endList();

assertEquals(2, listVector.getMutator().getLastSet());

listVector.getMutator().setValueCount(2);

final ListVector.Accessor accessor = listVector.getAccessor();
assertEquals(2, accessor.getValueCount());

/* get listVector value at index 0 -- the value itself is a listvector */
Object result = accessor.getObject(0);

@icexellossicexellossAug 1, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated:

Is there a way to get unboxed value from nested list vector?

ArrayList<ArrayList<Long>> resultSet = (ArrayList<ArrayList<Long>>)result;
ArrayList<Long> list;

assertEquals(2, resultSet.size()); /* 2 inner lists at index 0 */
assertEquals(3, resultSet.get(0).size()); /* size of first inner list */
assertEquals(4, resultSet.get(1).size()); /* size of second inner list */

list = resultSet.get(0);
assertEquals(new Long(50), list.get(0));
assertEquals(new Long(100), list.get(1));
assertEquals(new Long(200), list.get(2));

list = resultSet.get(1);
assertEquals(new Long(75), list.get(0));
assertEquals(new Long(125), list.get(1));
assertEquals(new Long(150), list.get(2));
assertEquals(new Long(175), list.get(3));

/* get listVector value at index 1 -- the value itself is a listvector */
result = accessor.getObject(1);
resultSet = (ArrayList<ArrayList<Long>>)result;

assertEquals(3, resultSet.size()); /* 3 inner lists at index 1 */
assertEquals(1, resultSet.get(0).size()); /* size of first inner list */
assertEquals(2, resultSet.get(1).size()); /* size of second inner list */
assertEquals(3, resultSet.get(2).size()); /* size of third inner list */

list = resultSet.get(0);
assertEquals(new Long(10), list.get(0));

list = resultSet.get(1);
assertEquals(new Long(15), list.get(0));
assertEquals(new Long(20), list.get(1));

list = resultSet.get(2);
assertEquals(new Long(25), list.get(0));
assertEquals(new Long(30), list.get(1));
assertEquals(new Long(35), list.get(2));

/* check underlying bitVector */
assertFalse(accessor.isNull(0));
assertFalse(accessor.isNull(1));

/* check underlying offsetVector */
UInt4Vector offsetVector = listVector.getOffsetVector();
final UInt4Vector.Accessor offsetAccessor = offsetVector.getAccessor();

/* listVector has 2 lists at index 0 and 3 lists at index 1 */
assertEquals(0, offsetAccessor.get(0));
assertEquals(2, offsetAccessor.get(1));
assertEquals(5, offsetAccessor.get(2));
}
}
}
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
ARROW-1300: [JAVA] Fix Tests for ListVector#925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

siddharthteotia
wants to merge
4
commits into

from

 Closed


ARROW-1300: [JAVA] Fix Tests for ListVector
#925
 Changes from all commits
Commits

Show all changes


4 commits


Select commit
Hold shift + click to select a range
777e0de

ARROW-1300: Fix Tests for ListVector


siddharthteotia Aug 1, 2017
9978199

ARROW-1300: Fix tests for ListVector


siddharthteotia Aug 1, 2017
ff84253

ARROW-1300: Fix Tests for ListVector


siddharthteotia Aug 1, 2017
584c79e

ARROW-1300: Fix tests for ListVector


siddharthteotia Aug 4, 2017

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


151 changes: 143 additions & 8 deletions
java/vector/src/test/java/org/apache/arrow/vector/TestListVector.java

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -38,8 +38,10 @@
import org.junit.Before;
import org.junit.Test;

import java.util.ArrayList;
import java.util.List;


public class TestListVector {

 private BufferAllocator allocator;
Expand DownExpand Up@@ -92,6 +94,26 @@ public void testCopyFrom() throws Exception {
 Assert.assertFalse("should be null", reader.isSet());
 reader.setPosition(2);
 Assert.assertTrue("shouldn't be null", reader.isSet());

 /* check the exact contents of vector */
 final ListVector.Accessor accessor = outVector.getAccessor();

 /* index 0 */
 Object result = accessor.getObject(0);
 ArrayList<Long> resultSet = (ArrayList<Long>)result;
@icexellossicexellossAug 1, 2017

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need space between (ArrayList<Long>) and result
@icexellossicexellossAug 1, 2017

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, google_checks.xml doesn't specify TypecastParenPad rule, so this is fine.
 assertEquals(3, resultSet.size());
 assertEquals(new Long(1), (Long)resultSet.get(0));
 assertEquals(new Long(2), (Long)resultSet.get(1));
 assertEquals(new Long(3), (Long)resultSet.get(2));

 /* index 1 */
 result = accessor.getObject(1);
 assertNull(result);

 /* index 2 */
 result = accessor.getObject(2);
 resultSet = (ArrayList<Long>)result;
 assertEquals(0, resultSet.size());
 }
 }

Expand DownExpand Up@@ -127,7 +149,7 @@ public void testSetLastSetUsage() throws Exception {
 dataVector.getMutator().setSafe(2, 1, 12);
 offsetVector.getMutator().setSafe(index + 1, 3);

 index += 1;
 index += 1;

 /* write [13, 14] to the list vector at index 1 */
 bitVector.getMutator().setSafe(index, 1);
Expand DownExpand Up@@ -193,7 +215,7 @@ public void testSetLastSetUsage() throws Exception {
 final UInt4Vector.Accessor offsetAccessor = offsetVector.getAccessor();
 final ValueVector.Accessor valueAccessor = dataVector.getAccessor();

 index = 0;
 index = 0;
 offset = offsetAccessor.get(index);
 assertEquals(Integer.toString(0), Integer.toString(offset));

Expand DownExpand Up@@ -300,7 +322,7 @@ public void testSplitAndTransfer() throws Exception {
 final UInt4Vector.Accessor offsetAccessor = offsetVector.getAccessor();
 final ValueVector.Accessor valueAccessor = dataVector.getAccessor();

 int index = 0;
 int index = 0;
 int offset = 0;
 Object actual = null;

Expand DownExpand Up@@ -386,10 +408,7 @@ public void testSplitAndTransfer() throws Exception {

 TransferPair transferPair = listVector.makeTransferPair(toVector);

 int[][] transferLengths = { {0, 2},
 {3, 1},
 {4, 1}
 };
 int[][] transferLengths = {{0, 2}, {3, 1}, {4, 1}};

 for (final int[] transferLength : transferLengths) {
 int start = transferLength[0];
Expand DownExpand Up@@ -423,7 +442,7 @@ public void testSplitAndTransfer() throws Exception {

 for(int j = 0; j < dataLength1; j++) {
 assertEquals("Different data at indexes: " + offset1 + " and " + offset2,
 valueAccessor.getObject(offset1), valueAccessor1.getObject(offset2));
valueAccessor.getObject(offset1), valueAccessor1.getObject(offset2));

 offset1++;
 offset2++;
Expand All@@ -433,4 +452,120 @@ public void testSplitAndTransfer() throws Exception {
 }
 }
 }

 @Test
 public void testNestedListVector() throws Exception {
 try (ListVector listVector = ListVector.empty("sourceVector", allocator)) {

 UnionListWriter listWriter = listVector.getWriter();

 /* allocate memory */
 listWriter.allocate();

 /* the dataVector that backs a listVector will also be a
 * listVector for this test.
 */

 /* write one or more inner lists at index 0 */
 listWriter.setPosition(0);
 listWriter.startList();

 listWriter.list().startList();
 listWriter.list().bigInt().writeBigInt(50);
 listWriter.list().bigInt().writeBigInt(100);
 listWriter.list().bigInt().writeBigInt(200);
 listWriter.list().endList();

 listWriter.list().startList();
 listWriter.list().bigInt().writeBigInt(75);
 listWriter.list().bigInt().writeBigInt(125);
 listWriter.list().bigInt().writeBigInt(150);
 listWriter.list().bigInt().writeBigInt(175);
 listWriter.list().endList();

 listWriter.endList();

 /* write one or more inner lists at index 1 */
 listWriter.setPosition(1);
 listWriter.startList();

 listWriter.list().startList();
 listWriter.list().bigInt().writeBigInt(10);
 listWriter.list().endList();

 listWriter.list().startList();
 listWriter.list().bigInt().writeBigInt(15);
 listWriter.list().bigInt().writeBigInt(20);
 listWriter.list().endList();

 listWriter.list().startList();
 listWriter.list().bigInt().writeBigInt(25);
 listWriter.list().bigInt().writeBigInt(30);
 listWriter.list().bigInt().writeBigInt(35);
 listWriter.list().endList();

 listWriter.endList();

 assertEquals(2, listVector.getMutator().getLastSet());

 listVector.getMutator().setValueCount(2);

 final ListVector.Accessor accessor = listVector.getAccessor();
 assertEquals(2, accessor.getValueCount());

 /* get listVector value at index 0 -- the value itself is a listvector */
 Object result = accessor.getObject(0);
@icexellossicexellossAug 1, 2017

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated:
Is there a way to get unboxed value from nested list vector?
 ArrayList<ArrayList<Long>> resultSet = (ArrayList<ArrayList<Long>>)result;
 ArrayList<Long> list;

 assertEquals(2, resultSet.size()); /* 2 inner lists at index 0 */
 assertEquals(3, resultSet.get(0).size()); /* size of first inner list */
 assertEquals(4, resultSet.get(1).size()); /* size of second inner list */

 list = resultSet.get(0);
 assertEquals(new Long(50), list.get(0));
 assertEquals(new Long(100), list.get(1));
 assertEquals(new Long(200), list.get(2));

 list = resultSet.get(1);
 assertEquals(new Long(75), list.get(0));
 assertEquals(new Long(125), list.get(1));
 assertEquals(new Long(150), list.get(2));
 assertEquals(new Long(175), list.get(3));

 /* get listVector value at index 1 -- the value itself is a listvector */
 result = accessor.getObject(1);
 resultSet = (ArrayList<ArrayList<Long>>)result;

 assertEquals(3, resultSet.size()); /* 3 inner lists at index 1 */
 assertEquals(1, resultSet.get(0).size()); /* size of first inner list */
 assertEquals(2, resultSet.get(1).size()); /* size of second inner list */
 assertEquals(3, resultSet.get(2).size()); /* size of third inner list */

 list = resultSet.get(0);
 assertEquals(new Long(10), list.get(0));

 list = resultSet.get(1);
 assertEquals(new Long(15), list.get(0));
 assertEquals(new Long(20), list.get(1));

 list = resultSet.get(2);
 assertEquals(new Long(25), list.get(0));
 assertEquals(new Long(30), list.get(1));
 assertEquals(new Long(35), list.get(2));

 /* check underlying bitVector */
 assertFalse(accessor.isNull(0));
 assertFalse(accessor.isNull(1));

 /* check underlying offsetVector */
 UInt4Vector offsetVector = listVector.getOffsetVector();
 final UInt4Vector.Accessor offsetAccessor = offsetVector.getAccessor();

 /* listVector has 2 lists at index 0 and 3 lists at index 1 */
 assertEquals(0, offsetAccessor.get(0));
 assertEquals(2, offsetAccessor.get(1));
 assertEquals(5, offsetAccessor.get(2));
 }
 }
}

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
ARROW-1300: [JAVA] Fix Tests for ListVector#925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

siddharthteotia
wants to merge
4
commits into

from

 Closed


ARROW-1300: [JAVA] Fix Tests for ListVector
#925
 Changes from all commits
Commits

Show all changes


4 commits


Select commit
Hold shift + click to select a range
777e0de

ARROW-1300: Fix Tests for ListVector


siddharthteotia Aug 1, 2017
9978199

ARROW-1300: Fix tests for ListVector


siddharthteotia Aug 1, 2017
ff84253

ARROW-1300: Fix Tests for ListVector


siddharthteotia Aug 1, 2017
584c79e

ARROW-1300: Fix tests for ListVector


siddharthteotia Aug 4, 2017

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


151 changes: 143 additions & 8 deletions
java/vector/src/test/java/org/apache/arrow/vector/TestListVector.java

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -38,8 +38,10 @@
import org.junit.Before;
import org.junit.Test;

import java.util.ArrayList;
import java.util.List;


public class TestListVector {

 private BufferAllocator allocator;
Expand DownExpand Up@@ -92,6 +94,26 @@ public void testCopyFrom() throws Exception {
 Assert.assertFalse("should be null", reader.isSet());
 reader.setPosition(2);
 Assert.assertTrue("shouldn't be null", reader.isSet());

 /* check the exact contents of vector */
 final ListVector.Accessor accessor = outVector.getAccessor();

 /* index 0 */
 Object result = accessor.getObject(0);
 ArrayList<Long> resultSet = (ArrayList<Long>)result;
@icexellossicexellossAug 1, 2017

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need space between (ArrayList<Long>) and result
@icexellossicexellossAug 1, 2017

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, google_checks.xml doesn't specify TypecastParenPad rule, so this is fine.
 assertEquals(3, resultSet.size());
 assertEquals(new Long(1), (Long)resultSet.get(0));
 assertEquals(new Long(2), (Long)resultSet.get(1));
 assertEquals(new Long(3), (Long)resultSet.get(2));

 /* index 1 */
 result = accessor.getObject(1);
 assertNull(result);

 /* index 2 */
 result = accessor.getObject(2);
 resultSet = (ArrayList<Long>)result;
 assertEquals(0, resultSet.size());
 }
 }

Expand DownExpand Up@@ -127,7 +149,7 @@ public void testSetLastSetUsage() throws Exception {
 dataVector.getMutator().setSafe(2, 1, 12);
 offsetVector.getMutator().setSafe(index + 1, 3);

 index += 1;
 index += 1;

 /* write [13, 14] to the list vector at index 1 */
 bitVector.getMutator().setSafe(index, 1);
Expand DownExpand Up@@ -193,7 +215,7 @@ public void testSetLastSetUsage() throws Exception {
 final UInt4Vector.Accessor offsetAccessor = offsetVector.getAccessor();
 final ValueVector.Accessor valueAccessor = dataVector.getAccessor();

 index = 0;
 index = 0;
 offset = offsetAccessor.get(index);
 assertEquals(Integer.toString(0), Integer.toString(offset));

Expand DownExpand Up@@ -300,7 +322,7 @@ public void testSplitAndTransfer() throws Exception {
 final UInt4Vector.Accessor offsetAccessor = offsetVector.getAccessor();
 final ValueVector.Accessor valueAccessor = dataVector.getAccessor();

 int index = 0;
 int index = 0;
 int offset = 0;
 Object actual = null;

Expand DownExpand Up@@ -386,10 +408,7 @@ public void testSplitAndTransfer() throws Exception {

 TransferPair transferPair = listVector.makeTransferPair(toVector);

 int[][] transferLengths = { {0, 2},
 {3, 1},
 {4, 1}
 };
 int[][] transferLengths = {{0, 2}, {3, 1}, {4, 1}};

 for (final int[] transferLength : transferLengths) {
 int start = transferLength[0];
Expand DownExpand Up@@ -423,7 +442,7 @@ public void testSplitAndTransfer() throws Exception {

 for(int j = 0; j < dataLength1; j++) {
 assertEquals("Different data at indexes: " + offset1 + " and " + offset2,
 valueAccessor.getObject(offset1), valueAccessor1.getObject(offset2));
valueAccessor.getObject(offset1), valueAccessor1.getObject(offset2));

 offset1++;
 offset2++;
Expand All@@ -433,4 +452,120 @@ public void testSplitAndTransfer() throws Exception {
 }
 }
 }

 @Test
 public void testNestedListVector() throws Exception {
 try (ListVector listVector = ListVector.empty("sourceVector", allocator)) {

 UnionListWriter listWriter = listVector.getWriter();

 /* allocate memory */
 listWriter.allocate();

 /* the dataVector that backs a listVector will also be a
 * listVector for this test.
 */

 /* write one or more inner lists at index 0 */
 listWriter.setPosition(0);
 listWriter.startList();

 listWriter.list().startList();
 listWriter.list().bigInt().writeBigInt(50);
 listWriter.list().bigInt().writeBigInt(100);
 listWriter.list().bigInt().writeBigInt(200);
 listWriter.list().endList();

 listWriter.list().startList();
 listWriter.list().bigInt().writeBigInt(75);
 listWriter.list().bigInt().writeBigInt(125);
 listWriter.list().bigInt().writeBigInt(150);
 listWriter.list().bigInt().writeBigInt(175);
 listWriter.list().endList();

 listWriter.endList();

 /* write one or more inner lists at index 1 */
 listWriter.setPosition(1);
 listWriter.startList();

 listWriter.list().startList();
 listWriter.list().bigInt().writeBigInt(10);
 listWriter.list().endList();

 listWriter.list().startList();
 listWriter.list().bigInt().writeBigInt(15);
 listWriter.list().bigInt().writeBigInt(20);
 listWriter.list().endList();

 listWriter.list().startList();
 listWriter.list().bigInt().writeBigInt(25);
 listWriter.list().bigInt().writeBigInt(30);
 listWriter.list().bigInt().writeBigInt(35);
 listWriter.list().endList();

 listWriter.endList();

 assertEquals(2, listVector.getMutator().getLastSet());

 listVector.getMutator().setValueCount(2);

 final ListVector.Accessor accessor = listVector.getAccessor();
 assertEquals(2, accessor.getValueCount());

 /* get listVector value at index 0 -- the value itself is a listvector */
 Object result = accessor.getObject(0);
@icexellossicexellossAug 1, 2017

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated:
Is there a way to get unboxed value from nested list vector?
 ArrayList<ArrayList<Long>> resultSet = (ArrayList<ArrayList<Long>>)result;
 ArrayList<Long> list;

 assertEquals(2, resultSet.size()); /* 2 inner lists at index 0 */
 assertEquals(3, resultSet.get(0).size()); /* size of first inner list */
 assertEquals(4, resultSet.get(1).size()); /* size of second inner list */

 list = resultSet.get(0);
 assertEquals(new Long(50), list.get(0));
 assertEquals(new Long(100), list.get(1));
 assertEquals(new Long(200), list.get(2));

 list = resultSet.get(1);
 assertEquals(new Long(75), list.get(0));
 assertEquals(new Long(125), list.get(1));
 assertEquals(new Long(150), list.get(2));
 assertEquals(new Long(175), list.get(3));

 /* get listVector value at index 1 -- the value itself is a listvector */
 result = accessor.getObject(1);
 resultSet = (ArrayList<ArrayList<Long>>)result;

 assertEquals(3, resultSet.size()); /* 3 inner lists at index 1 */
 assertEquals(1, resultSet.get(0).size()); /* size of first inner list */
 assertEquals(2, resultSet.get(1).size()); /* size of second inner list */
 assertEquals(3, resultSet.get(2).size()); /* size of third inner list */

 list = resultSet.get(0);
 assertEquals(new Long(10), list.get(0));

 list = resultSet.get(1);
 assertEquals(new Long(15), list.get(0));
 assertEquals(new Long(20), list.get(1));

 list = resultSet.get(2);
 assertEquals(new Long(25), list.get(0));
 assertEquals(new Long(30), list.get(1));
 assertEquals(new Long(35), list.get(2));

 /* check underlying bitVector */
 assertFalse(accessor.isNull(0));
 assertFalse(accessor.isNull(1));

 /* check underlying offsetVector */
 UInt4Vector offsetVector = listVector.getOffsetVector();
 final UInt4Vector.Accessor offsetAccessor = offsetVector.getAccessor();

 /* listVector has 2 lists at index 0 and 3 lists at index 1 */
 assertEquals(0, offsetAccessor.get(0));
 assertEquals(2, offsetAccessor.get(1));
 assertEquals(5, offsetAccessor.get(2));
 }
 }
}

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
ARROW-1300: [JAVA] Fix Tests for ListVector#925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

siddharthteotia
wants to merge
4
commits into

from

 Closed


ARROW-1300: [JAVA] Fix Tests for ListVector
#925
 Changes from all commits
Commits

Show all changes


4 commits


Select commit
Hold shift + click to select a range
777e0de

ARROW-1300: Fix Tests for ListVector


siddharthteotia Aug 1, 2017
9978199

ARROW-1300: Fix tests for ListVector


siddharthteotia Aug 1, 2017
ff84253

ARROW-1300: Fix Tests for ListVector


siddharthteotia Aug 1, 2017
584c79e

ARROW-1300: Fix tests for ListVector


siddharthteotia Aug 4, 2017

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


151 changes: 143 additions & 8 deletions
java/vector/src/test/java/org/apache/arrow/vector/TestListVector.java

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -38,8 +38,10 @@
import org.junit.Before;
import org.junit.Test;

import java.util.ArrayList;
import java.util.List;


public class TestListVector {

 private BufferAllocator allocator;
Expand DownExpand Up@@ -92,6 +94,26 @@ public void testCopyFrom() throws Exception {
 Assert.assertFalse("should be null", reader.isSet());
 reader.setPosition(2);
 Assert.assertTrue("shouldn't be null", reader.isSet());

 /* check the exact contents of vector */
 final ListVector.Accessor accessor = outVector.getAccessor();

 /* index 0 */
 Object result = accessor.getObject(0);
 ArrayList<Long> resultSet = (ArrayList<Long>)result;
@icexellossicexellossAug 1, 2017

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need space between (ArrayList<Long>) and result
@icexellossicexellossAug 1, 2017

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, google_checks.xml doesn't specify TypecastParenPad rule, so this is fine.
 assertEquals(3, resultSet.size());
 assertEquals(new Long(1), (Long)resultSet.get(0));
 assertEquals(new Long(2), (Long)resultSet.get(1));
 assertEquals(new Long(3), (Long)resultSet.get(2));

 /* index 1 */
 result = accessor.getObject(1);
 assertNull(result);

 /* index 2 */
 result = accessor.getObject(2);
 resultSet = (ArrayList<Long>)result;
 assertEquals(0, resultSet.size());
 }
 }

Expand DownExpand Up@@ -127,7 +149,7 @@ public void testSetLastSetUsage() throws Exception {
 dataVector.getMutator().setSafe(2, 1, 12);
 offsetVector.getMutator().setSafe(index + 1, 3);

 index += 1;
 index += 1;

 /* write [13, 14] to the list vector at index 1 */
 bitVector.getMutator().setSafe(index, 1);
Expand DownExpand Up@@ -193,7 +215,7 @@ public void testSetLastSetUsage() throws Exception {
 final UInt4Vector.Accessor offsetAccessor = offsetVector.getAccessor();
 final ValueVector.Accessor valueAccessor = dataVector.getAccessor();

 index = 0;
 index = 0;
 offset = offsetAccessor.get(index);
 assertEquals(Integer.toString(0), Integer.toString(offset));

Expand DownExpand Up@@ -300,7 +322,7 @@ public void testSplitAndTransfer() throws Exception {
 final UInt4Vector.Accessor offsetAccessor = offsetVector.getAccessor();
 final ValueVector.Accessor valueAccessor = dataVector.getAccessor();

 int index = 0;
 int index = 0;
 int offset = 0;
 Object actual = null;

Expand DownExpand Up@@ -386,10 +408,7 @@ public void testSplitAndTransfer() throws Exception {

 TransferPair transferPair = listVector.makeTransferPair(toVector);

 int[][] transferLengths = { {0, 2},
 {3, 1},
 {4, 1}
 };
 int[][] transferLengths = {{0, 2}, {3, 1}, {4, 1}};

 for (final int[] transferLength : transferLengths) {
 int start = transferLength[0];
Expand DownExpand Up@@ -423,7 +442,7 @@ public void testSplitAndTransfer() throws Exception {

 for(int j = 0; j < dataLength1; j++) {
 assertEquals("Different data at indexes: " + offset1 + " and " + offset2,
 valueAccessor.getObject(offset1), valueAccessor1.getObject(offset2));
valueAccessor.getObject(offset1), valueAccessor1.getObject(offset2));

 offset1++;
 offset2++;
Expand All@@ -433,4 +452,120 @@ public void testSplitAndTransfer() throws Exception {
 }
 }
 }

 @Test
 public void testNestedListVector() throws Exception {
 try (ListVector listVector = ListVector.empty("sourceVector", allocator)) {

 UnionListWriter listWriter = listVector.getWriter();

 /* allocate memory */
 listWriter.allocate();

 /* the dataVector that backs a listVector will also be a
 * listVector for this test.
 */

 /* write one or more inner lists at index 0 */
 listWriter.setPosition(0);
 listWriter.startList();

 listWriter.list().startList();
 listWriter.list().bigInt().writeBigInt(50);
 listWriter.list().bigInt().writeBigInt(100);
 listWriter.list().bigInt().writeBigInt(200);
 listWriter.list().endList();

 listWriter.list().startList();
 listWriter.list().bigInt().writeBigInt(75);
 listWriter.list().bigInt().writeBigInt(125);
 listWriter.list().bigInt().writeBigInt(150);
 listWriter.list().bigInt().writeBigInt(175);
 listWriter.list().endList();

 listWriter.endList();

 /* write one or more inner lists at index 1 */
 listWriter.setPosition(1);
 listWriter.startList();

 listWriter.list().startList();
 listWriter.list().bigInt().writeBigInt(10);
 listWriter.list().endList();

 listWriter.list().startList();
 listWriter.list().bigInt().writeBigInt(15);
 listWriter.list().bigInt().writeBigInt(20);
 listWriter.list().endList();

 listWriter.list().startList();
 listWriter.list().bigInt().writeBigInt(25);
 listWriter.list().bigInt().writeBigInt(30);
 listWriter.list().bigInt().writeBigInt(35);
 listWriter.list().endList();

 listWriter.endList();

 assertEquals(2, listVector.getMutator().getLastSet());

 listVector.getMutator().setValueCount(2);

 final ListVector.Accessor accessor = listVector.getAccessor();
 assertEquals(2, accessor.getValueCount());

 /* get listVector value at index 0 -- the value itself is a listvector */
 Object result = accessor.getObject(0);
@icexellossicexellossAug 1, 2017

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated:
Is there a way to get unboxed value from nested list vector?
 ArrayList<ArrayList<Long>> resultSet = (ArrayList<ArrayList<Long>>)result;
 ArrayList<Long> list;

 assertEquals(2, resultSet.size()); /* 2 inner lists at index 0 */
 assertEquals(3, resultSet.get(0).size()); /* size of first inner list */
 assertEquals(4, resultSet.get(1).size()); /* size of second inner list */

 list = resultSet.get(0);
 assertEquals(new Long(50), list.get(0));
 assertEquals(new Long(100), list.get(1));
 assertEquals(new Long(200), list.get(2));

 list = resultSet.get(1);
 assertEquals(new Long(75), list.get(0));
 assertEquals(new Long(125), list.get(1));
 assertEquals(new Long(150), list.get(2));
 assertEquals(new Long(175), list.get(3));

 /* get listVector value at index 1 -- the value itself is a listvector */
 result = accessor.getObject(1);
 resultSet = (ArrayList<ArrayList<Long>>)result;

 assertEquals(3, resultSet.size()); /* 3 inner lists at index 1 */
 assertEquals(1, resultSet.get(0).size()); /* size of first inner list */
 assertEquals(2, resultSet.get(1).size()); /* size of second inner list */
 assertEquals(3, resultSet.get(2).size()); /* size of third inner list */

 list = resultSet.get(0);
 assertEquals(new Long(10), list.get(0));

 list = resultSet.get(1);
 assertEquals(new Long(15), list.get(0));
 assertEquals(new Long(20), list.get(1));

 list = resultSet.get(2);
 assertEquals(new Long(25), list.get(0));
 assertEquals(new Long(30), list.get(1));
 assertEquals(new Long(35), list.get(2));

 /* check underlying bitVector */
 assertFalse(accessor.isNull(0));
 assertFalse(accessor.isNull(1));

 /* check underlying offsetVector */
 UInt4Vector offsetVector = listVector.getOffsetVector();
 final UInt4Vector.Accessor offsetAccessor = offsetVector.getAccessor();

 /* listVector has 2 lists at index 0 and 3 lists at index 1 */
 assertEquals(0, offsetAccessor.get(0));
 assertEquals(2, offsetAccessor.get(1));
 assertEquals(5, offsetAccessor.get(2));
 }
 }
}

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
ARROW-1300: [JAVA] Fix Tests for ListVector#925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

siddharthteotia
wants to merge
4
commits into

from

 Closed


ARROW-1300: [JAVA] Fix Tests for ListVector
#925
 Changes from all commits
Commits

Show all changes


4 commits


Select commit
Hold shift + click to select a range
777e0de

ARROW-1300: Fix Tests for ListVector


siddharthteotia Aug 1, 2017
9978199

ARROW-1300: Fix tests for ListVector


siddharthteotia Aug 1, 2017
ff84253

ARROW-1300: Fix Tests for ListVector


siddharthteotia Aug 1, 2017
584c79e

ARROW-1300: Fix tests for ListVector


siddharthteotia Aug 4, 2017

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


151 changes: 143 additions & 8 deletions
java/vector/src/test/java/org/apache/arrow/vector/TestListVector.java

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -38,8 +38,10 @@
import org.junit.Before;
import org.junit.Test;

import java.util.ArrayList;
import java.util.List;


public class TestListVector {

 private BufferAllocator allocator;
Expand DownExpand Up@@ -92,6 +94,26 @@ public void testCopyFrom() throws Exception {
 Assert.assertFalse("should be null", reader.isSet());
 reader.setPosition(2);
 Assert.assertTrue("shouldn't be null", reader.isSet());

 /* check the exact contents of vector */
 final ListVector.Accessor accessor = outVector.getAccessor();

 /* index 0 */
 Object result = accessor.getObject(0);
 ArrayList<Long> resultSet = (ArrayList<Long>)result;
@icexellossicexellossAug 1, 2017

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need space between (ArrayList<Long>) and result
@icexellossicexellossAug 1, 2017

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, google_checks.xml doesn't specify TypecastParenPad rule, so this is fine.
 assertEquals(3, resultSet.size());
 assertEquals(new Long(1), (Long)resultSet.get(0));
 assertEquals(new Long(2), (Long)resultSet.get(1));
 assertEquals(new Long(3), (Long)resultSet.get(2));

 /* index 1 */
 result = accessor.getObject(1);
 assertNull(result);

 /* index 2 */
 result = accessor.getObject(2);
 resultSet = (ArrayList<Long>)result;
 assertEquals(0, resultSet.size());
 }
 }

Expand DownExpand Up@@ -127,7 +149,7 @@ public void testSetLastSetUsage() throws Exception {
 dataVector.getMutator().setSafe(2, 1, 12);
 offsetVector.getMutator().setSafe(index + 1, 3);

 index += 1;
 index += 1;

 /* write [13, 14] to the list vector at index 1 */
 bitVector.getMutator().setSafe(index, 1);
Expand DownExpand Up@@ -193,7 +215,7 @@ public void testSetLastSetUsage() throws Exception {
 final UInt4Vector.Accessor offsetAccessor = offsetVector.getAccessor();
 final ValueVector.Accessor valueAccessor = dataVector.getAccessor();

 index = 0;
 index = 0;
 offset = offsetAccessor.get(index);
 assertEquals(Integer.toString(0), Integer.toString(offset));

Expand DownExpand Up@@ -300,7 +322,7 @@ public void testSplitAndTransfer() throws Exception {
 final UInt4Vector.Accessor offsetAccessor = offsetVector.getAccessor();
 final ValueVector.Accessor valueAccessor = dataVector.getAccessor();

 int index = 0;
 int index = 0;
 int offset = 0;
 Object actual = null;

Expand DownExpand Up@@ -386,10 +408,7 @@ public void testSplitAndTransfer() throws Exception {

 TransferPair transferPair = listVector.makeTransferPair(toVector);

 int[][] transferLengths = { {0, 2},
 {3, 1},
 {4, 1}
 };
 int[][] transferLengths = {{0, 2}, {3, 1}, {4, 1}};

 for (final int[] transferLength : transferLengths) {
 int start = transferLength[0];
Expand DownExpand Up@@ -423,7 +442,7 @@ public void testSplitAndTransfer() throws Exception {

 for(int j = 0; j < dataLength1; j++) {
 assertEquals("Different data at indexes: " + offset1 + " and " + offset2,
 valueAccessor.getObject(offset1), valueAccessor1.getObject(offset2));
valueAccessor.getObject(offset1), valueAccessor1.getObject(offset2));

 offset1++;
 offset2++;
Expand All@@ -433,4 +452,120 @@ public void testSplitAndTransfer() throws Exception {
 }
 }
 }

 @Test
 public void testNestedListVector() throws Exception {
 try (ListVector listVector = ListVector.empty("sourceVector", allocator)) {

 UnionListWriter listWriter = listVector.getWriter();

 /* allocate memory */
 listWriter.allocate();

 /* the dataVector that backs a listVector will also be a
 * listVector for this test.
 */

 /* write one or more inner lists at index 0 */
 listWriter.setPosition(0);
 listWriter.startList();

 listWriter.list().startList();
 listWriter.list().bigInt().writeBigInt(50);
 listWriter.list().bigInt().writeBigInt(100);
 listWriter.list().bigInt().writeBigInt(200);
 listWriter.list().endList();

 listWriter.list().startList();
 listWriter.list().bigInt().writeBigInt(75);
 listWriter.list().bigInt().writeBigInt(125);
 listWriter.list().bigInt().writeBigInt(150);
 listWriter.list().bigInt().writeBigInt(175);
 listWriter.list().endList();

 listWriter.endList();

 /* write one or more inner lists at index 1 */
 listWriter.setPosition(1);
 listWriter.startList();

 listWriter.list().startList();
 listWriter.list().bigInt().writeBigInt(10);
 listWriter.list().endList();

 listWriter.list().startList();
 listWriter.list().bigInt().writeBigInt(15);
 listWriter.list().bigInt().writeBigInt(20);
 listWriter.list().endList();

 listWriter.list().startList();
 listWriter.list().bigInt().writeBigInt(25);
 listWriter.list().bigInt().writeBigInt(30);
 listWriter.list().bigInt().writeBigInt(35);
 listWriter.list().endList();

 listWriter.endList();

 assertEquals(2, listVector.getMutator().getLastSet());

 listVector.getMutator().setValueCount(2);

 final ListVector.Accessor accessor = listVector.getAccessor();
 assertEquals(2, accessor.getValueCount());

 /* get listVector value at index 0 -- the value itself is a listvector */
 Object result = accessor.getObject(0);
@icexellossicexellossAug 1, 2017

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated:
Is there a way to get unboxed value from nested list vector?
 ArrayList<ArrayList<Long>> resultSet = (ArrayList<ArrayList<Long>>)result;
 ArrayList<Long> list;

 assertEquals(2, resultSet.size()); /* 2 inner lists at index 0 */
 assertEquals(3, resultSet.get(0).size()); /* size of first inner list */
 assertEquals(4, resultSet.get(1).size()); /* size of second inner list */

 list = resultSet.get(0);
 assertEquals(new Long(50), list.get(0));
 assertEquals(new Long(100), list.get(1));
 assertEquals(new Long(200), list.get(2));

 list = resultSet.get(1);
 assertEquals(new Long(75), list.get(0));
 assertEquals(new Long(125), list.get(1));
 assertEquals(new Long(150), list.get(2));
 assertEquals(new Long(175), list.get(3));

 /* get listVector value at index 1 -- the value itself is a listvector */
 result = accessor.getObject(1);
 resultSet = (ArrayList<ArrayList<Long>>)result;

 assertEquals(3, resultSet.size()); /* 3 inner lists at index 1 */
 assertEquals(1, resultSet.get(0).size()); /* size of first inner list */
 assertEquals(2, resultSet.get(1).size()); /* size of second inner list */
 assertEquals(3, resultSet.get(2).size()); /* size of third inner list */

 list = resultSet.get(0);
 assertEquals(new Long(10), list.get(0));

 list = resultSet.get(1);
 assertEquals(new Long(15), list.get(0));
 assertEquals(new Long(20), list.get(1));

 list = resultSet.get(2);
 assertEquals(new Long(25), list.get(0));
 assertEquals(new Long(30), list.get(1));
 assertEquals(new Long(35), list.get(2));

 /* check underlying bitVector */
 assertFalse(accessor.isNull(0));
 assertFalse(accessor.isNull(1));

 /* check underlying offsetVector */
 UInt4Vector offsetVector = listVector.getOffsetVector();
 final UInt4Vector.Accessor offsetAccessor = offsetVector.getAccessor();

 /* listVector has 2 lists at index 0 and 3 lists at index 1 */
 assertEquals(0, offsetAccessor.get(0));
 assertEquals(2, offsetAccessor.get(1));
 assertEquals(5, offsetAccessor.get(2));
 }
 }
}

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
ARROW-1300: [JAVA] Fix Tests for ListVector#925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

siddharthteotia
wants to merge
4
commits into

from

 Closed


ARROW-1300: [JAVA] Fix Tests for ListVector
#925
 Changes from all commits
Commits

Show all changes


4 commits


Select commit
Hold shift + click to select a range
777e0de

ARROW-1300: Fix Tests for ListVector


siddharthteotia Aug 1, 2017
9978199

ARROW-1300: Fix tests for ListVector


siddharthteotia Aug 1, 2017
ff84253

ARROW-1300: Fix Tests for ListVector


siddharthteotia Aug 1, 2017
584c79e

ARROW-1300: Fix tests for ListVector


siddharthteotia Aug 4, 2017

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


151 changes: 143 additions & 8 deletions
java/vector/src/test/java/org/apache/arrow/vector/TestListVector.java

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -38,8 +38,10 @@
import org.junit.Before;
import org.junit.Test;

import java.util.ArrayList;
import java.util.List;


public class TestListVector {

 private BufferAllocator allocator;
Expand DownExpand Up@@ -92,6 +94,26 @@ public void testCopyFrom() throws Exception {
 Assert.assertFalse("should be null", reader.isSet());
 reader.setPosition(2);
 Assert.assertTrue("shouldn't be null", reader.isSet());

 /* check the exact contents of vector */
 final ListVector.Accessor accessor = outVector.getAccessor();

 /* index 0 */
 Object result = accessor.getObject(0);
 ArrayList<Long> resultSet = (ArrayList<Long>)result;
@icexellossicexellossAug 1, 2017

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need space between (ArrayList<Long>) and result
@icexellossicexellossAug 1, 2017

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, google_checks.xml doesn't specify TypecastParenPad rule, so this is fine.
 assertEquals(3, resultSet.size());
 assertEquals(new Long(1), (Long)resultSet.get(0));
 assertEquals(new Long(2), (Long)resultSet.get(1));
 assertEquals(new Long(3), (Long)resultSet.get(2));

 /* index 1 */
 result = accessor.getObject(1);
 assertNull(result);

 /* index 2 */
 result = accessor.getObject(2);
 resultSet = (ArrayList<Long>)result;
 assertEquals(0, resultSet.size());
 }
 }

Expand DownExpand Up@@ -127,7 +149,7 @@ public void testSetLastSetUsage() throws Exception {
 dataVector.getMutator().setSafe(2, 1, 12);
 offsetVector.getMutator().setSafe(index + 1, 3);

 index += 1;
 index += 1;

 /* write [13, 14] to the list vector at index 1 */
 bitVector.getMutator().setSafe(index, 1);
Expand DownExpand Up@@ -193,7 +215,7 @@ public void testSetLastSetUsage() throws Exception {
 final UInt4Vector.Accessor offsetAccessor = offsetVector.getAccessor();
 final ValueVector.Accessor valueAccessor = dataVector.getAccessor();

 index = 0;
 index = 0;
 offset = offsetAccessor.get(index);
 assertEquals(Integer.toString(0), Integer.toString(offset));

Expand DownExpand Up@@ -300,7 +322,7 @@ public void testSplitAndTransfer() throws Exception {
 final UInt4Vector.Accessor offsetAccessor = offsetVector.getAccessor();
 final ValueVector.Accessor valueAccessor = dataVector.getAccessor();

 int index = 0;
 int index = 0;
 int offset = 0;
 Object actual = null;

Expand DownExpand Up@@ -386,10 +408,7 @@ public void testSplitAndTransfer() throws Exception {

 TransferPair transferPair = listVector.makeTransferPair(toVector);

 int[][] transferLengths = { {0, 2},
 {3, 1},
 {4, 1}
 };
 int[][] transferLengths = {{0, 2}, {3, 1}, {4, 1}};

 for (final int[] transferLength : transferLengths) {
 int start = transferLength[0];
Expand DownExpand Up@@ -423,7 +442,7 @@ public void testSplitAndTransfer() throws Exception {

 for(int j = 0; j < dataLength1; j++) {
 assertEquals("Different data at indexes: " + offset1 + " and " + offset2,
 valueAccessor.getObject(offset1), valueAccessor1.getObject(offset2));
valueAccessor.getObject(offset1), valueAccessor1.getObject(offset2));

 offset1++;
 offset2++;
Expand All@@ -433,4 +452,120 @@ public void testSplitAndTransfer() throws Exception {
 }
 }
 }

 @Test
 public void testNestedListVector() throws Exception {
 try (ListVector listVector = ListVector.empty("sourceVector", allocator)) {

 UnionListWriter listWriter = listVector.getWriter();

 /* allocate memory */
 listWriter.allocate();

 /* the dataVector that backs a listVector will also be a
 * listVector for this test.
 */

 /* write one or more inner lists at index 0 */
 listWriter.setPosition(0);
 listWriter.startList();

 listWriter.list().startList();
 listWriter.list().bigInt().writeBigInt(50);
 listWriter.list().bigInt().writeBigInt(100);
 listWriter.list().bigInt().writeBigInt(200);
 listWriter.list().endList();

 listWriter.list().startList();
 listWriter.list().bigInt().writeBigInt(75);
 listWriter.list().bigInt().writeBigInt(125);
 listWriter.list().bigInt().writeBigInt(150);
 listWriter.list().bigInt().writeBigInt(175);
 listWriter.list().endList();

 listWriter.endList();

 /* write one or more inner lists at index 1 */
 listWriter.setPosition(1);
 listWriter.startList();

 listWriter.list().startList();
 listWriter.list().bigInt().writeBigInt(10);
 listWriter.list().endList();

 listWriter.list().startList();
 listWriter.list().bigInt().writeBigInt(15);
 listWriter.list().bigInt().writeBigInt(20);
 listWriter.list().endList();

 listWriter.list().startList();
 listWriter.list().bigInt().writeBigInt(25);
 listWriter.list().bigInt().writeBigInt(30);
 listWriter.list().bigInt().writeBigInt(35);
 listWriter.list().endList();

 listWriter.endList();

 assertEquals(2, listVector.getMutator().getLastSet());

 listVector.getMutator().setValueCount(2);

 final ListVector.Accessor accessor = listVector.getAccessor();
 assertEquals(2, accessor.getValueCount());

 /* get listVector value at index 0 -- the value itself is a listvector */
 Object result = accessor.getObject(0);
@icexellossicexellossAug 1, 2017

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated:
Is there a way to get unboxed value from nested list vector?
 ArrayList<ArrayList<Long>> resultSet = (ArrayList<ArrayList<Long>>)result;
 ArrayList<Long> list;

 assertEquals(2, resultSet.size()); /* 2 inner lists at index 0 */
 assertEquals(3, resultSet.get(0).size()); /* size of first inner list */
 assertEquals(4, resultSet.get(1).size()); /* size of second inner list */

 list = resultSet.get(0);
 assertEquals(new Long(50), list.get(0));
 assertEquals(new Long(100), list.get(1));
 assertEquals(new Long(200), list.get(2));

 list = resultSet.get(1);
 assertEquals(new Long(75), list.get(0));
 assertEquals(new Long(125), list.get(1));
 assertEquals(new Long(150), list.get(2));
 assertEquals(new Long(175), list.get(3));

 /* get listVector value at index 1 -- the value itself is a listvector */
 result = accessor.getObject(1);
 resultSet = (ArrayList<ArrayList<Long>>)result;

 assertEquals(3, resultSet.size()); /* 3 inner lists at index 1 */
 assertEquals(1, resultSet.get(0).size()); /* size of first inner list */
 assertEquals(2, resultSet.get(1).size()); /* size of second inner list */
 assertEquals(3, resultSet.get(2).size()); /* size of third inner list */

 list = resultSet.get(0);
 assertEquals(new Long(10), list.get(0));

 list = resultSet.get(1);
 assertEquals(new Long(15), list.get(0));
 assertEquals(new Long(20), list.get(1));

 list = resultSet.get(2);
 assertEquals(new Long(25), list.get(0));
 assertEquals(new Long(30), list.get(1));
 assertEquals(new Long(35), list.get(2));

 /* check underlying bitVector */
 assertFalse(accessor.isNull(0));
 assertFalse(accessor.isNull(1));

 /* check underlying offsetVector */
 UInt4Vector offsetVector = listVector.getOffsetVector();
 final UInt4Vector.Accessor offsetAccessor = offsetVector.getAccessor();

 /* listVector has 2 lists at index 0 and 3 lists at index 1 */
 assertEquals(0, offsetAccessor.get(0));
 assertEquals(2, offsetAccessor.get(1));
 assertEquals(5, offsetAccessor.get(2));
 }
 }
}

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
ARROW-1300: [JAVA] Fix Tests for ListVector#925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

siddharthteotia
wants to merge
4
commits into

from

 Closed


ARROW-1300: [JAVA] Fix Tests for ListVector
#925
 Changes from all commits
Commits

Show all changes


4 commits


Select commit
Hold shift + click to select a range
777e0de

ARROW-1300: Fix Tests for ListVector


siddharthteotia Aug 1, 2017
9978199

ARROW-1300: Fix tests for ListVector


siddharthteotia Aug 1, 2017
ff84253

ARROW-1300: Fix Tests for ListVector


siddharthteotia Aug 1, 2017
584c79e

ARROW-1300: Fix tests for ListVector


siddharthteotia Aug 4, 2017

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


151 changes: 143 additions & 8 deletions
java/vector/src/test/java/org/apache/arrow/vector/TestListVector.java

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -38,8 +38,10 @@
import org.junit.Before;
import org.junit.Test;

import java.util.ArrayList;
import java.util.List;


public class TestListVector {

 private BufferAllocator allocator;
Expand DownExpand Up@@ -92,6 +94,26 @@ public void testCopyFrom() throws Exception {
 Assert.assertFalse("should be null", reader.isSet());
 reader.setPosition(2);
 Assert.assertTrue("shouldn't be null", reader.isSet());

 /* check the exact contents of vector */
 final ListVector.Accessor accessor = outVector.getAccessor();

 /* index 0 */
 Object result = accessor.getObject(0);
 ArrayList<Long> resultSet = (ArrayList<Long>)result;
@icexellossicexellossAug 1, 2017

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need space between (ArrayList<Long>) and result
@icexellossicexellossAug 1, 2017

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, google_checks.xml doesn't specify TypecastParenPad rule, so this is fine.
 assertEquals(3, resultSet.size());
 assertEquals(new Long(1), (Long)resultSet.get(0));
 assertEquals(new Long(2), (Long)resultSet.get(1));
 assertEquals(new Long(3), (Long)resultSet.get(2));

 /* index 1 */
 result = accessor.getObject(1);
 assertNull(result);

 /* index 2 */
 result = accessor.getObject(2);
 resultSet = (ArrayList<Long>)result;
 assertEquals(0, resultSet.size());
 }
 }

Expand DownExpand Up@@ -127,7 +149,7 @@ public void testSetLastSetUsage() throws Exception {
 dataVector.getMutator().setSafe(2, 1, 12);
 offsetVector.getMutator().setSafe(index + 1, 3);

 index += 1;
 index += 1;

 /* write [13, 14] to the list vector at index 1 */
 bitVector.getMutator().setSafe(index, 1);
Expand DownExpand Up@@ -193,7 +215,7 @@ public void testSetLastSetUsage() throws Exception {
 final UInt4Vector.Accessor offsetAccessor = offsetVector.getAccessor();
 final ValueVector.Accessor valueAccessor = dataVector.getAccessor();

 index = 0;
 index = 0;
 offset = offsetAccessor.get(index);
 assertEquals(Integer.toString(0), Integer.toString(offset));

Expand DownExpand Up@@ -300,7 +322,7 @@ public void testSplitAndTransfer() throws Exception {
 final UInt4Vector.Accessor offsetAccessor = offsetVector.getAccessor();
 final ValueVector.Accessor valueAccessor = dataVector.getAccessor();

 int index = 0;
 int index = 0;
 int offset = 0;
 Object actual = null;

Expand DownExpand Up@@ -386,10 +408,7 @@ public void testSplitAndTransfer() throws Exception {

 TransferPair transferPair = listVector.makeTransferPair(toVector);

 int[][] transferLengths = { {0, 2},
 {3, 1},
 {4, 1}
 };
 int[][] transferLengths = {{0, 2}, {3, 1}, {4, 1}};

 for (final int[] transferLength : transferLengths) {
 int start = transferLength[0];
Expand DownExpand Up@@ -423,7 +442,7 @@ public void testSplitAndTransfer() throws Exception {

 for(int j = 0; j < dataLength1; j++) {
 assertEquals("Different data at indexes: " + offset1 + " and " + offset2,
 valueAccessor.getObject(offset1), valueAccessor1.getObject(offset2));
valueAccessor.getObject(offset1), valueAccessor1.getObject(offset2));

 offset1++;
 offset2++;
Expand All@@ -433,4 +452,120 @@ public void testSplitAndTransfer() throws Exception {
 }
 }
 }

 @Test
 public void testNestedListVector() throws Exception {
 try (ListVector listVector = ListVector.empty("sourceVector", allocator)) {

 UnionListWriter listWriter = listVector.getWriter();

 /* allocate memory */
 listWriter.allocate();

 /* the dataVector that backs a listVector will also be a
 * listVector for this test.
 */

 /* write one or more inner lists at index 0 */
 listWriter.setPosition(0);
 listWriter.startList();

 listWriter.list().startList();
 listWriter.list().bigInt().writeBigInt(50);
 listWriter.list().bigInt().writeBigInt(100);
 listWriter.list().bigInt().writeBigInt(200);
 listWriter.list().endList();

 listWriter.list().startList();
 listWriter.list().bigInt().writeBigInt(75);
 listWriter.list().bigInt().writeBigInt(125);
 listWriter.list().bigInt().writeBigInt(150);
 listWriter.list().bigInt().writeBigInt(175);
 listWriter.list().endList();

 listWriter.endList();

 /* write one or more inner lists at index 1 */
 listWriter.setPosition(1);
 listWriter.startList();

 listWriter.list().startList();
 listWriter.list().bigInt().writeBigInt(10);
 listWriter.list().endList();

 listWriter.list().startList();
 listWriter.list().bigInt().writeBigInt(15);
 listWriter.list().bigInt().writeBigInt(20);
 listWriter.list().endList();

 listWriter.list().startList();
 listWriter.list().bigInt().writeBigInt(25);
 listWriter.list().bigInt().writeBigInt(30);
 listWriter.list().bigInt().writeBigInt(35);
 listWriter.list().endList();

 listWriter.endList();

 assertEquals(2, listVector.getMutator().getLastSet());

 listVector.getMutator().setValueCount(2);

 final ListVector.Accessor accessor = listVector.getAccessor();
 assertEquals(2, accessor.getValueCount());

 /* get listVector value at index 0 -- the value itself is a listvector */
 Object result = accessor.getObject(0);
@icexellossicexellossAug 1, 2017

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated:
Is there a way to get unboxed value from nested list vector?
 ArrayList<ArrayList<Long>> resultSet = (ArrayList<ArrayList<Long>>)result;
 ArrayList<Long> list;

 assertEquals(2, resultSet.size()); /* 2 inner lists at index 0 */
 assertEquals(3, resultSet.get(0).size()); /* size of first inner list */
 assertEquals(4, resultSet.get(1).size()); /* size of second inner list */

 list = resultSet.get(0);
 assertEquals(new Long(50), list.get(0));
 assertEquals(new Long(100), list.get(1));
 assertEquals(new Long(200), list.get(2));

 list = resultSet.get(1);
 assertEquals(new Long(75), list.get(0));
 assertEquals(new Long(125), list.get(1));
 assertEquals(new Long(150), list.get(2));
 assertEquals(new Long(175), list.get(3));

 /* get listVector value at index 1 -- the value itself is a listvector */
 result = accessor.getObject(1);
 resultSet = (ArrayList<ArrayList<Long>>)result;

 assertEquals(3, resultSet.size()); /* 3 inner lists at index 1 */
 assertEquals(1, resultSet.get(0).size()); /* size of first inner list */
 assertEquals(2, resultSet.get(1).size()); /* size of second inner list */
 assertEquals(3, resultSet.get(2).size()); /* size of third inner list */

 list = resultSet.get(0);
 assertEquals(new Long(10), list.get(0));

 list = resultSet.get(1);
 assertEquals(new Long(15), list.get(0));
 assertEquals(new Long(20), list.get(1));

 list = resultSet.get(2);
 assertEquals(new Long(25), list.get(0));
 assertEquals(new Long(30), list.get(1));
 assertEquals(new Long(35), list.get(2));

 /* check underlying bitVector */
 assertFalse(accessor.isNull(0));
 assertFalse(accessor.isNull(1));

 /* check underlying offsetVector */
 UInt4Vector offsetVector = listVector.getOffsetVector();
 final UInt4Vector.Accessor offsetAccessor = offsetVector.getAccessor();

 /* listVector has 2 lists at index 0 and 3 lists at index 1 */
 assertEquals(0, offsetAccessor.get(0));
 assertEquals(2, offsetAccessor.get(1));
 assertEquals(5, offsetAccessor.get(2));
 }
 }
}

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
ARROW-1300: [JAVA] Fix Tests for ListVector#925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

siddharthteotia
wants to merge
4
commits into

from

 Closed


ARROW-1300: [JAVA] Fix Tests for ListVector
#925
 Changes from all commits
Commits

Show all changes


4 commits


Select commit
Hold shift + click to select a range
777e0de

ARROW-1300: Fix Tests for ListVector


siddharthteotia Aug 1, 2017
9978199

ARROW-1300: Fix tests for ListVector


siddharthteotia Aug 1, 2017
ff84253

ARROW-1300: Fix Tests for ListVector


siddharthteotia Aug 1, 2017
584c79e

ARROW-1300: Fix tests for ListVector


siddharthteotia Aug 4, 2017

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


151 changes: 143 additions & 8 deletions
java/vector/src/test/java/org/apache/arrow/vector/TestListVector.java

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -38,8 +38,10 @@
import org.junit.Before;
import org.junit.Test;

import java.util.ArrayList;
import java.util.List;


public class TestListVector {

 private BufferAllocator allocator;
Expand DownExpand Up@@ -92,6 +94,26 @@ public void testCopyFrom() throws Exception {
 Assert.assertFalse("should be null", reader.isSet());
 reader.setPosition(2);
 Assert.assertTrue("shouldn't be null", reader.isSet());

 /* check the exact contents of vector */
 final ListVector.Accessor accessor = outVector.getAccessor();

 /* index 0 */
 Object result = accessor.getObject(0);
 ArrayList<Long> resultSet = (ArrayList<Long>)result;
@icexellossicexellossAug 1, 2017

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need space between (ArrayList<Long>) and result
@icexellossicexellossAug 1, 2017

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, google_checks.xml doesn't specify TypecastParenPad rule, so this is fine.
 assertEquals(3, resultSet.size());
 assertEquals(new Long(1), (Long)resultSet.get(0));
 assertEquals(new Long(2), (Long)resultSet.get(1));
 assertEquals(new Long(3), (Long)resultSet.get(2));

 /* index 1 */
 result = accessor.getObject(1);
 assertNull(result);

 /* index 2 */
 result = accessor.getObject(2);
 resultSet = (ArrayList<Long>)result;
 assertEquals(0, resultSet.size());
 }
 }

Expand DownExpand Up@@ -127,7 +149,7 @@ public void testSetLastSetUsage() throws Exception {
 dataVector.getMutator().setSafe(2, 1, 12);
 offsetVector.getMutator().setSafe(index + 1, 3);

 index += 1;
 index += 1;

 /* write [13, 14] to the list vector at index 1 */
 bitVector.getMutator().setSafe(index, 1);
Expand DownExpand Up@@ -193,7 +215,7 @@ public void testSetLastSetUsage() throws Exception {
 final UInt4Vector.Accessor offsetAccessor = offsetVector.getAccessor();
 final ValueVector.Accessor valueAccessor = dataVector.getAccessor();

 index = 0;
 index = 0;
 offset = offsetAccessor.get(index);
 assertEquals(Integer.toString(0), Integer.toString(offset));

Expand DownExpand Up@@ -300,7 +322,7 @@ public void testSplitAndTransfer() throws Exception {
 final UInt4Vector.Accessor offsetAccessor = offsetVector.getAccessor();
 final ValueVector.Accessor valueAccessor = dataVector.getAccessor();

 int index = 0;
 int index = 0;
 int offset = 0;
 Object actual = null;

Expand DownExpand Up@@ -386,10 +408,7 @@ public void testSplitAndTransfer() throws Exception {

 TransferPair transferPair = listVector.makeTransferPair(toVector);

 int[][] transferLengths = { {0, 2},
 {3, 1},
 {4, 1}
 };
 int[][] transferLengths = {{0, 2}, {3, 1}, {4, 1}};

 for (final int[] transferLength : transferLengths) {
 int start = transferLength[0];
Expand DownExpand Up@@ -423,7 +442,7 @@ public void testSplitAndTransfer() throws Exception {

 for(int j = 0; j < dataLength1; j++) {
 assertEquals("Different data at indexes: " + offset1 + " and " + offset2,
 valueAccessor.getObject(offset1), valueAccessor1.getObject(offset2));
valueAccessor.getObject(offset1), valueAccessor1.getObject(offset2));

 offset1++;
 offset2++;
Expand All@@ -433,4 +452,120 @@ public void testSplitAndTransfer() throws Exception {
 }
 }
 }

 @Test
 public void testNestedListVector() throws Exception {
 try (ListVector listVector = ListVector.empty("sourceVector", allocator)) {

 UnionListWriter listWriter = listVector.getWriter();

 /* allocate memory */
 listWriter.allocate();

 /* the dataVector that backs a listVector will also be a
 * listVector for this test.
 */

 /* write one or more inner lists at index 0 */
 listWriter.setPosition(0);
 listWriter.startList();

 listWriter.list().startList();
 listWriter.list().bigInt().writeBigInt(50);
 listWriter.list().bigInt().writeBigInt(100);
 listWriter.list().bigInt().writeBigInt(200);
 listWriter.list().endList();

 listWriter.list().startList();
 listWriter.list().bigInt().writeBigInt(75);
 listWriter.list().bigInt().writeBigInt(125);
 listWriter.list().bigInt().writeBigInt(150);
 listWriter.list().bigInt().writeBigInt(175);
 listWriter.list().endList();

 listWriter.endList();

 /* write one or more inner lists at index 1 */
 listWriter.setPosition(1);
 listWriter.startList();

 listWriter.list().startList();
 listWriter.list().bigInt().writeBigInt(10);
 listWriter.list().endList();

 listWriter.list().startList();
 listWriter.list().bigInt().writeBigInt(15);
 listWriter.list().bigInt().writeBigInt(20);
 listWriter.list().endList();

 listWriter.list().startList();
 listWriter.list().bigInt().writeBigInt(25);
 listWriter.list().bigInt().writeBigInt(30);
 listWriter.list().bigInt().writeBigInt(35);
 listWriter.list().endList();

 listWriter.endList();

 assertEquals(2, listVector.getMutator().getLastSet());

 listVector.getMutator().setValueCount(2);

 final ListVector.Accessor accessor = listVector.getAccessor();
 assertEquals(2, accessor.getValueCount());

 /* get listVector value at index 0 -- the value itself is a listvector */
 Object result = accessor.getObject(0);
@icexellossicexellossAug 1, 2017

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated:
Is there a way to get unboxed value from nested list vector?
 ArrayList<ArrayList<Long>> resultSet = (ArrayList<ArrayList<Long>>)result;
 ArrayList<Long> list;

 assertEquals(2, resultSet.size()); /* 2 inner lists at index 0 */
 assertEquals(3, resultSet.get(0).size()); /* size of first inner list */
 assertEquals(4, resultSet.get(1).size()); /* size of second inner list */

 list = resultSet.get(0);
 assertEquals(new Long(50), list.get(0));
 assertEquals(new Long(100), list.get(1));
 assertEquals(new Long(200), list.get(2));

 list = resultSet.get(1);
 assertEquals(new Long(75), list.get(0));
 assertEquals(new Long(125), list.get(1));
 assertEquals(new Long(150), list.get(2));
 assertEquals(new Long(175), list.get(3));

 /* get listVector value at index 1 -- the value itself is a listvector */
 result = accessor.getObject(1);
 resultSet = (ArrayList<ArrayList<Long>>)result;

 assertEquals(3, resultSet.size()); /* 3 inner lists at index 1 */
 assertEquals(1, resultSet.get(0).size()); /* size of first inner list */
 assertEquals(2, resultSet.get(1).size()); /* size of second inner list */
 assertEquals(3, resultSet.get(2).size()); /* size of third inner list */

 list = resultSet.get(0);
 assertEquals(new Long(10), list.get(0));

 list = resultSet.get(1);
 assertEquals(new Long(15), list.get(0));
 assertEquals(new Long(20), list.get(1));

 list = resultSet.get(2);
 assertEquals(new Long(25), list.get(0));
 assertEquals(new Long(30), list.get(1));
 assertEquals(new Long(35), list.get(2));

 /* check underlying bitVector */
 assertFalse(accessor.isNull(0));
 assertFalse(accessor.isNull(1));

 /* check underlying offsetVector */
 UInt4Vector offsetVector = listVector.getOffsetVector();
 final UInt4Vector.Accessor offsetAccessor = offsetVector.getAccessor();

 /* listVector has 2 lists at index 0 and 3 lists at index 1 */
 assertEquals(0, offsetAccessor.get(0));
 assertEquals(2, offsetAccessor.get(1));
 assertEquals(5, offsetAccessor.get(2));
 }
 }
}