Skip to content

ARROW-11269: [Rust] [Parquet] Preserve timezone in int96 reader#9253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nevi-me wants to merge 1 commit into from
Closed

ARROW-11269: [Rust] [Parquet] Preserve timezone in int96 reader #9253

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion rust/parquet/src/arrow/array_reader.rs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -1503,7 +1503,18 @@ impl<'a> ArrayReaderBuilder {
arrow_type,
)?)),
PhysicalType::INT96 => {
let converter = Int96Converter::new(Int96ArrayConverter {});
// get the optional timezone information from arrow type
let timezone = arrow_type
.as_ref()
.map(|data_type| {
if let ArrowType::Timestamp(_, tz) = data_type {
tz.clone()
} else {
None
}
})
.flatten();
let converter = Int96Converter::new(Int96ArrayConverter { timezone });
Ok(Box::new(ComplexObjectArrayReader::<
Int96Type,
Int96Converter,
Expand Down
21 changes: 10 additions & 11 deletions rust/parquet/src/arrow/converter.rs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -22,7 +22,6 @@ use arrow::array::{
IntervalDayTimeArray, IntervalDayTimeBuilder, IntervalYearMonthArray,
IntervalYearMonthBuilder, LargeBinaryBuilder, LargeStringBuilder, PrimitiveBuilder,
PrimitiveDictionaryBuilder, StringBuilder, StringDictionaryBuilder,
TimestampNanosecondBuilder,
};
use arrow::compute::cast;
use std::convert::{From, TryInto};
Expand DownExpand Up@@ -168,19 +167,19 @@ impl Converter<Vec<Option<FixedLenByteArray>>, IntervalDayTimeArray>
}
}

pub struct Int96ArrayConverter {}
pub struct Int96ArrayConverter {
pub timezone: Option<String>,
}

impl Converter<Vec<Option<Int96>>, TimestampNanosecondArray> for Int96ArrayConverter {
fn convert(&self, source: Vec<Option<Int96>>) -> Result<TimestampNanosecondArray> {
let mut builder = TimestampNanosecondBuilder::new(source.len());
for v in source {
match v {
Some(array) => builder.append_value(array.to_i64() * 1000000),
None => builder.append_null(),
}?
}

Ok(builder.finish())
Ok(TimestampNanosecondArray::from_opt_vec(

@sunchaosunchaoJan 19, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we going to change other converters to use this pattern as well? Also I'm not sure what the performance looks like with this new approach though - seems it needs to allocate extra memory for the intermediate Vec?

@nevi-menevi-meJan 19, 2021

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've found the builder pattern to be slower than allocating vecs. There's FromIter for PrimitiveArray, but no equivalent for TimestampArray::from_opt_vec. I've filed ARROW-11312 to address this.

On the other field types, we don't use Array builder there, but use ArrayData::builder(timestamp_with_timezone). So they don't suffer from the same limitation.

@sunchaosunchaoJan 19, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. Good to know. Thanks.

source
.into_iter()
.map(|int96| int96.map(|val| val.to_i64() * 1_000_000))
.collect(),
self.timezone.clone(),
))
}
}

Expand Down