Uh oh!
There was an error while loading. Please reload this page.
ARROW-10489: [C++] Add Intel C++ compiler options for different warning levels - #9266
Closed
jcmuel wants to merge 2 commits into
Closed
ARROW-10489: [C++] Add Intel C++ compiler options for different warning levels#9266jcmuel wants to merge 2 commits into
jcmuel wants to merge 2 commits into
Conversation
pitrou
commented
Jan 19, 2021
Member
Thank you for the PR @jcmuel ! Can you also make sure the two other |
…EVEL == EVERYTHING and Production. In both cases, we simply use -Wall.
jcmuel
commented
Jan 19, 2021
ContributorAuthor
I just added the missing code path, and adjusted the production code path, such that it uses "/Wall" on Intel for Windows. Not sure if this is necessary, but I did it for the sake of consistency with the other two code paths. |
pitrou
commented
Jan 19, 2021
Member
Those warnings are mainly for development, but useful anyway. |
kszucs pushed a commit
that referenced
this pull request
Jan 25, 2021
…ng levels See [Intel Compiler warning flag documentation](https://software.intel.com/content/www/us/en/develop/documentation/cpp-compiler-developer-guide-and-reference/top/compiler-reference/error-handling-1/warnings-errors-and-remarks.html). Closes#9266 from jcmuel/master Authored-by: Johannes Müller <JohannesMueller@fico.com> Signed-off-by: Antoine Pitrou <antoine@python.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Intel Compiler warning flag documentation.