Skip to content

ARROW-11321: [Rust][DataFusion] Fix DataFusion compilation error - #9269

Closed
Dandandan wants to merge 4 commits into
apache:masterfrom
Dandandan:fix_datafusion
Closed

ARROW-11321: [Rust][DataFusion] Fix DataFusion compilation error#9269
Dandandan wants to merge 4 commits into
apache:masterfrom
Dandandan:fix_datafusion

Conversation

@Dandandan

@DandandanDandandan commented Jan 19, 2021

Copy link
Copy Markdown
Contributor

FYI @jorgecarleitao I think some change on master and maybe some parquet related changes caused a compilation error on master. This fixes the compilation error.

@jorgecarleitao

Copy link
Copy Markdown
Member

This has an unrelated change on a submodule?

@Dandandan

Copy link
Copy Markdown
ContributorAuthor

Yeah those submodules seems to cause some issues lately :/. Should be fixed now @jorgecarleitao

@github-actions

Copy link
Copy Markdown

@jorgecarleitao

Copy link
Copy Markdown
Member

cc @alamb

@alambalamb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think #9076 changed the API. Thanks @Dandandan

@alamb

Copy link
Copy Markdown
Contributor

I ran this locally and it fixes the build for me. I plan to merge this in prior to CI finishing to get master back to green

@alamb

Copy link
Copy Markdown
Contributor

For anyone else following along, the error this PR fixes looks like the following (from https://github.com/apache/arrow/runs/1729540155):

 Compiling arrow-flight v3.0.0-SNAPSHOT (/__w/arrow/arrow/rust/arrow-flight)
Compiling tonic v0.3.1
Compiling datafusion v3.0.0-SNAPSHOT (/__w/arrow/arrow/rust/datafusion)
error[E0061]: this function takes 2 arguments but 1 argument was supplied
--> datafusion/src/physical_plan/parquet.rs:712:25
|
712 | data_buffer.resize(data_buffer.len() + data_size);
| ^^^^^^ ----------------------------- supplied 1 argument
| |
| expected 2 arguments
error: aborting due to previous error

@alambalamb closed this in a4266a1Jan 19, 2021
@alamb

Copy link
Copy Markdown
Contributor

🚀

@jorgecarleitao

Copy link
Copy Markdown
Member

Thanks a lot, @Dandandan and @alamb , and sorry for the mess 😞

@alamb

Copy link
Copy Markdown
Contributor

No worries @jorgecarleitao -- I think this was likely to happen given the backup of PRs waiting to go on to master :)

@Dandandan

Copy link
Copy Markdown
ContributorAuthor

I am really excited for the changes w.r.t. performance in the merged PRs!

This will allow us to further improve some kernels 👍

kszucs pushed a commit that referenced this pull request Jan 25, 2021
FYI @jorgecarleitao I think some change on master and maybe some parquet related changes caused a compilation error on master. This fixes the compilation error.
Closes#9269 from Dandandan/fix_datafusion
Authored-by: Heres, Daniel <danielheres@gmail.com>
Signed-off-by: Andrew Lamb <andrew@nerdnetworks.org>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@Dandandan@jorgecarleitao@alamb