Uh oh!
There was an error while loading. Please reload this page.
ARROW-11563: [Rust] Support Cast(Utf8, TimeStamp(Nanoseconds, None)) - #9449
Closed
ovr wants to merge 1 commit into
Closed
ARROW-11563: [Rust] Support Cast(Utf8, TimeStamp(Nanoseconds, None))#9449ovr wants to merge 1 commit into
ovr wants to merge 1 commit into
Conversation
alamb
approved these changes
Feb 9, 2021
Uh oh!
There was an error while loading. Please reload this page.
Contributor
There was a problem hiding this comment.
Adding a new Arrow Error variant seems reasonable to me -- what do you think @jorgecarleitao and @nevi-me and @andygrove ?
alamb
commented
Feb 11, 2021
Contributor
I think this PR is ready to go after a rebase -- any thoughts @Dandandan@jorgecarleitao or @andygrove ? |
ovr
commented
Feb 12, 2021
ContributorAuthor
Just a notice: Rebased |
alamb
commented
Feb 12, 2021
Contributor
Thanks again @ovr ! |
sgnkc pushed a commit
to sgnkc/arrow
that referenced
this pull request
Feb 17, 2021
DataFushion already has this cast with its own implementation inside DF based on top of the chrono library. In this PR, I moved functions called string_to_timestamp_nanos and naive_datetime_to_timestamp (helpers) to Arrow's compute::kernels crate to make it possible to do Cast(Utf8, Timestamp(Nanoseconds, None)) and usage these helpers inside DF for to_timestamp function. Closesapache#9449 from ovr/issue-11563 Authored-by: Dmitry Patsura <zaets28rus@gmail.com> Signed-off-by: Andrew Lamb <andrew@nerdnetworks.org>
Merged
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DataFushion already has this cast with its own implementation inside DF based on top of the chrono library. In this PR, I moved functions called string_to_timestamp_nanos and naive_datetime_to_timestamp (helpers) to Arrow's compute::kernels crate to make it possible to do Cast(Utf8, Timestamp(Nanoseconds, None)) and usage these helpers inside DF for to_timestamp function.