Skip to content

ARROW-11586: [Rust][Datafusion] Remove force unwrap - #9479

Closed
marcprux wants to merge 1 commit into
apache:masterfrom
marcprux:patch-3
Closed

ARROW-11586: [Rust][Datafusion] Remove force unwrap#9479
marcprux wants to merge 1 commit into
apache:masterfrom
marcprux:patch-3

Conversation

@marcprux

Copy link
Copy Markdown
Member

@github-actions

Copy link
Copy Markdown

@codecov-io

Copy link
Copy Markdown

Codecov Report

Merging #9479 (ed800b7) into master (5e3fcfa) will decrease coverage by 0.01%.
The diff coverage is 88.57%.

Impacted file tree graph

@@ Coverage Diff @@## master #9479 +/- ##
==========================================
- Coverage 82.32% 82.31% -0.02% 
==========================================
Files 233 234 +1 Lines 54446 54461 +15 ==========================================
+ Hits 44823 44828 +5 - Misses 9623 9633 +10 
Impacted FilesCoverage Δ
rust/arrow/src/array/builder.rs84.93% <ø> (ø)
rust/arrow/src/compute/kernels/sort.rs93.56% <ø> (ø)
rust/arrow/src/compute/kernels/substring.rs98.29% <ø> (ø)
rust/arrow/src/compute/util.rs98.92% <ø> (ø)
rust/arrow/src/json/reader.rs82.82% <ø> (ø)
rust/benchmarks/src/bin/tpch.rs38.33% <0.00%> (+0.18%)⬆️
rust/datafusion/src/datasource/memory.rs80.00% <ø> (ø)
rust/datafusion/src/logical_plan/dfschema.rs85.52% <ø> (ø)
...tafusion/src/physical_plan/datetime_expressions.rs93.28% <ø> (+0.24%)⬆️
...atafusion/src/physical_plan/expressions/in_list.rs75.37% <ø> (ø)
... and 41 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34e7671...ed800b7. Read the comment docs.

@marcprux
marcprux marked this pull request as draft February 12, 2021 14:26

@jorgecarleitaojorgecarleitao left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know it is draft, but it looks good to me already :)

@marcpruxmarcprux changed the title ARROW-11586: [Rust][Datafusion][WIP] Remove force unwrapARROW-11586: [Rust][Datafusion] Remove force unwrapFeb 12, 2021
@marcprux
marcprux marked this pull request as ready for review February 12, 2021 18:36
@marcprux

Copy link
Copy Markdown
MemberAuthor

I've un-drafted it.

@DandandanDandandan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 😎

@alambalamb closed this in 7660a22Feb 12, 2021
@alamb

Copy link
Copy Markdown
Contributor

Thanks @marcprux

sgnkc pushed a commit to sgnkc/arrow that referenced this pull request Feb 17, 2021
Fix for https://issues.apache.org/jira/browse/ARROW-11586Closesapache#9479 from marcprux/patch-3
Authored-by: Marc Prud'hommeaux <marc@glimpse.io>
Signed-off-by: Andrew Lamb <andrew@nerdnetworks.org>
andygrove pushed a commit that referenced this pull request Mar 12, 2021
Fix for https://issues.apache.org/jira/browse/ARROW-11586Closes#9479 from marcprux/patch-3
Authored-by: Marc Prud'hommeaux <marc@glimpse.io>
Signed-off-by: Andrew Lamb <andrew@nerdnetworks.org>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@marcprux@codecov-io@alamb@Dandandan@nevi-me@jorgecarleitao