Uh oh!
There was an error while loading. Please reload this page.
ARROW-11738: [Rust][DataFusion] Fix Concat and Trim Functions - #9551
ARROW-11738: [Rust][DataFusion] Fix Concat and Trim Functions#9551seddonm1 wants to merge 1 commit into
Conversation
alamb
commented
Feb 23, 2021
Thanks @seddonm1 -- I will plan to review this over the next few days |
seddonm1
commented
Feb 23, 2021
@Dandandan I can add |
seddonm1
commented
Feb 23, 2021
@Dandandan I have added |
There was a problem hiding this comment.
Alphabetically, this should be after concat?
There was a problem hiding this comment.
yes, my VSCode sorting treats _ before ". fixed 👍
seddonm1
commented
Feb 23, 2021
@Dandandan basically the string functions PR is so big even splitting like this makes a big difference and allows applying some of the foundational components (see the testing) required for the rest. So if this helps unblock you then thats a good thing :D |
alamb
commented
Feb 23, 2021
This PR sadly does need a rebase |
seddonm1
commented
Feb 23, 2021
thanks @alamb rebased 👍 |
alamb
commented
Feb 24, 2021
Integration test failure looks like https://issues.apache.org/jira/browse/ARROW-11717, so ignoring |
This PR is a child of #9243
It does a few things that are hard to separate:
concatandtrimfunctions to be in line with the Postgres implementations@alamb@jorgecarleitao
please review but merging will be dependent on #9507