Skip to content

ARROW-11580: [C++] Add CMake option ARROW_DEPENDENCY_SOURCE=VCPKG - #9553

Closed
ianmcook wants to merge 15 commits into
apache:masterfrom
ianmcook:ARROW-11580-take2
Closed

ARROW-11580: [C++] Add CMake option ARROW_DEPENDENCY_SOURCE=VCPKG#9553
ianmcook wants to merge 15 commits into
apache:masterfrom
ianmcook:ARROW-11580-take2

Conversation

@ianmcook

@ianmcookianmcook commented Feb 23, 2021•
edited
Loading

Copy link
Copy Markdown
Member

This builds upon ARROW-11340 and makes it simpler to use vcpkg for dependencies.

Previously, to use vcpkg it was necessary to specify:

  • -DARROW_DEPENDENCY_SOURCE=SYSTEM
  • -DCMAKE_TOOLCHAIN_FILE=/path/to/vcpkg.cmake
  • -DVCPKG_TARGET_TRIPLET=xxx-yyy-zzz
  • Various*_MSVC_* variables on Windows
  • Various *_ROOT, *_LIB, and *_INCLUDE variables in some cases
  • -D_VCPKG_INSTALLED_DIR=/path/to/vcpkg/installed/dir in some cases

Now all that is necessary is:

  • -DARROW_DEPENDENCY_SOURCE=VCPKG

Other variables are now optional and can be specified to override default behaviors.

After this is merged, I will make additional updates to the docs, focusing initially on Windows (ARROW-11336).

@github-actions

github-actionsBot commented Feb 23, 2021

Copy link
Copy Markdown

https://issues.apache.org/jira/browse/ARROW-11580

@ianmcook

ianmcook commented Feb 23, 2021

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-build-vcpkg-win wheel-manylinux2010-cp36m wheel-windows-cp36m

@github-actions

github-actionsBot commented Feb 23, 2021

Copy link
Copy Markdown

Revision: 17c32d4

Submitted crossbow builds: ursacomputing/crossbow @ actions-172

TaskStatus
test-build-vcpkg-winGithub Actions
wheel-manylinux2010-cp36mGithub Actions
wheel-windows-cp36mGithub Actions

@ianmcook
ianmcook marked this pull request as ready for review February 23, 2021 02:44
@pitrou
pitrou requested a review from kouFebruary 23, 2021 13:30
kou
kou reviewed Feb 24, 2021
View reviewed changes

@koukou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(My review isn't completed yet... I'll continue later.)

Comment threadcpp/CMakeLists.txt Outdated
@ianmcook

ianmcook commented Feb 25, 2021

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-build-vcpkg-win wheel-manylinux2010-cp36m wheel-windows-cp36m

@github-actions

github-actionsBot commented Feb 25, 2021

Copy link
Copy Markdown

Revision: f5c21b3

Submitted crossbow builds: ursacomputing/crossbow @ actions-173

TaskStatus
test-build-vcpkg-winGithub Actions
wheel-manylinux2010-cp36mGithub Actions
wheel-windows-cp36mGithub Actions

ianmcook
ianmcook commented Feb 26, 2021
View reviewed changes
Comment threadrun-cmake-format.py Outdated
@ianmcook

ianmcook commented Feb 26, 2021•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

FYI, I have not attempted to thoroughly test and fix debug builds with vcpkg-installed dependencies, but I plan to do that in ARROW-11796.

@ianmcook

ianmcook commented Mar 4, 2021

Copy link
Copy Markdown
MemberAuthor

@kou let me know if there is anything I can do to help you complete your review. Thank you!

kou
kou reviewed Mar 4, 2021
View reviewed changes

@koukou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It almost looks good to me!
I'm not sure many CACHE are really needed.

Comment threadcpp/cmake_modules/Usevcpkg.cmake Outdated
Comment threadcpp/cmake_modules/Usevcpkg.cmake Outdated
Comment threadcpp/cmake_modules/Usevcpkg.cmake
Comment threadcpp/cmake_modules/Usevcpkg.cmake Outdated
@kou

kou commented Mar 4, 2021

Copy link
Copy Markdown
Member

Oh, sorry for my late review...

@ianmcook

ianmcook commented Mar 4, 2021

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-build-vcpkg-win wheel-manylinux2010-cp36m wheel-windows-cp36m

@github-actions

github-actionsBot commented Mar 4, 2021

Copy link
Copy Markdown

Revision: d7f0e22

Submitted crossbow builds: ursacomputing/crossbow @ actions-178

TaskStatus
test-build-vcpkg-winGithub Actions
wheel-manylinux2010-cp36mGithub Actions
wheel-windows-cp36mGithub Actions

kou
kou approved these changes Mar 5, 2021
View reviewed changes

@koukou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

We can merge this once CI is green.

@ianmcook

ianmcook commented Mar 5, 2021

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-build-vcpkg-win wheel-manylinux2010-cp36m wheel-windows-cp36m

@github-actions

github-actionsBot commented Mar 5, 2021

Copy link
Copy Markdown

Revision: 2e6905a

Submitted crossbow builds: ursacomputing/crossbow @ actions-180

TaskStatus
test-build-vcpkg-winGithub Actions
wheel-manylinux2010-cp36mGithub Actions
wheel-windows-cp36mGithub Actions

@koukou closed this in 479dce5Mar 5, 2021
@asfimportasfimport mentioned this pull request Mar 5, 2021
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@koukoukou approved these changes

Assignees

No one assigned

Labels

Component: C++

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ianmcook@kou