Skip to content

ARROW-11784: [Rust][DataFusion] CoalesceBatchesStream doesn't honor Stream interface - #9574

Closed
edrevo wants to merge 2 commits into
apache:masterfrom
edrevo:fix-coalescebatchesstream
Closed

ARROW-11784: [Rust][DataFusion] CoalesceBatchesStream doesn't honor Stream interface#9574
edrevo wants to merge 2 commits into
apache:masterfrom
edrevo:fix-coalescebatchesstream

Conversation

@edrevo

Copy link
Copy Markdown
Contributor

Unit tests now cover the bug to avoid regressions.

@edrevo

Copy link
Copy Markdown
ContributorAuthor

cc @andygrove

@andygroveandygrove left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch. LGTM!

@github-actions

Copy link
Copy Markdown

@edrevo

Copy link
Copy Markdown
ContributorAuthor

I really need an fmt hook in my git... Fmt fixed!

@edrevo

Copy link
Copy Markdown
ContributorAuthor

@andygrove, I think the CI failure is unrelated to this change. Can you confirm?

@alamb

Copy link
Copy Markdown
Contributor

@edrevo the integration test failure looks like https://issues.apache.org/jira/browse/ARROW-11717 to me (not related to your PR)

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@edrevo@alamb@andygrove