Skip to content

ARROW-11881: [Rust][DataFusion] Fix clippy lint - #9642

Closed
alamb wants to merge 1 commit into
apache:masterfrom
alamb:fix_clippy
Closed

ARROW-11881: [Rust][DataFusion] Fix clippy lint#9642
alamb wants to merge 1 commit into
apache:masterfrom
alamb:fix_clippy

Conversation

@alamb

@alambalamb commented Mar 5, 2021

Copy link
Copy Markdown
Contributor

ARROW-11881: [Rust][DataFusion] Fix clippy lint

A linter error has appeared on master somehow:

error: unnecessary parentheses around `for` iterator expression
--> datafusion/src/physical_plan/merge.rs:124:31
|
124 | for part_i in (0..input_partitions) {
| ^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses
|
= note: `-D unused-parens` implied by `-D warnings`

Seen on at least #9612 and #9639:

https://github.com/apache/arrow/pull/9612/checks?check_run_id=2042047472

https://github.com/apache/arrow/pull/9639/checks?check_run_id=2042649120

@github-actions

Copy link
Copy Markdown

@codecov-io

Copy link
Copy Markdown

Codecov Report

Merging #9642 (c9bb438) into master (35daca2) will increase coverage by 0.06%.
The diff coverage is 88.18%.

Impacted file tree graph

@@ Coverage Diff @@## master #9642 +/- ##
==========================================
+ Coverage 82.32% 82.39% +0.06% 
==========================================
Files 245 245 Lines 56412 57170 +758 ==========================================
+ Hits 46442 47105 +663 - Misses 9970 10065 +95 
Impacted FilesCoverage Δ
rust/benchmarks/src/bin/tpch.rs38.33% <ø> (ø)
...datafusion/src/physical_plan/crypto_expressions.rs52.45% <ø> (ø)
rust/datafusion/src/physical_plan/mod.rs88.00% <ø> (ø)
rust/arrow/src/datatypes/field.rs55.47% <47.61%> (-0.66%)⬇️
rust/datafusion/src/physical_plan/parquet.rs87.83% <57.14%> (-0.22%)⬇️
...datafusion/src/physical_plan/string_expressions.rs73.38% <74.59%> (-3.62%)⬇️
rust/datafusion/src/physical_plan/hash_join.rs84.16% <77.77%> (+0.64%)⬆️
rust/arrow/src/datatypes/schema.rs73.39% <78.57%> (+0.76%)⬆️
rust/datafusion/src/physical_plan/repartition.rs81.21% <87.50%> (-0.14%)⬇️
rust/datafusion/src/physical_plan/functions.rs89.22% <96.19%> (+3.70%)⬆️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 479dce5...c9bb438. Read the comment docs.

@DandandanDandandan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alamb

alamb commented Mar 6, 2021

Copy link
Copy Markdown
ContributorAuthor

Thanks @nevi-me and @Dandandan

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.39%. Comparing base (35daca2) to head (c9bb438).

Additional details and impacted files
@@ Coverage Diff @@## master #9642 +/- ##
==========================================
+ Coverage 82.32% 82.39% +0.06% 
==========================================
Files 245 245 Lines 56412 57170 +758 ==========================================
+ Hits 46442 47105 +663 - Misses 9970 10065 +95 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@alamb@codecov-io@codecov-commenter@Dandandan@nevi-me