Uh oh!
There was an error while loading. Please reload this page.
ARROW-11894: [Rust][DataFusion] Change flight server example to use DataFrame API - #9645
ARROW-11894: [Rust][DataFusion] Change flight server example to use DataFrame API#9645Dandandan wants to merge 5 commits into
Conversation
alamb
commented
Mar 7, 2021
BTW the test workspace check is also failing on master, so it may not be related to this PR. See more details on https://issues.apache.org/jira/browse/ARROW-11896 |
alamb
commented
Mar 7, 2021
FYI I merged #9653 / ARROW-11896 for the Rust CI checks which may affect this PR. If you see "Rust / AMD64 Debian 10 Rust stable test workspace" failing with a linker error or no logs, rebasing against master will hopefully fix the problem |
alamb
left a comment
There was a problem hiding this comment.
I think this is a nice cleanup @Dandandan thank you. I don't think this code is tested as part of CI link so I would like someone to test it locally before merging -- I'll do so either later today or tomorrow if no one else gets around to it
21c7c01 to
b86061bComparecodecov-io
commented
Mar 7, 2021
Codecov Report
@@ Coverage Diff @@## master #9645 +/- ##
==========================================
- Coverage 82.49% 82.43% -0.07%
==========================================
Files 245 245 Lines 57347 57643 +296 ==========================================
+ Hits 47311 47517 +206 - Misses 10036 10126 +90
Continue to review full report at Codecov.
|
alamb
commented
Mar 8, 2021
I tried to retrigger the jobs on this PR as I think |
Uh oh!
There was an error while loading. Please reload this page.
| let schema_flight_data = | ||
| arrow_flight::utils::flight_data_from_arrow_schema( | ||
| schema.as_ref(), | ||
| &df.schema().clone().into(), |
Before this PR, it uses the logical plan / optimization / physical plan more directly.
As it is meant as example, I think it's better to use the more higher level
sqlandcollectfunctions.Also, some misc cleanup.