Skip to content

ARROW-11898: [Rust] Pretty print columns - #9650

Closed
nevi-me wants to merge 1 commit into
apache:masterfrom
nevi-me:pretty-print-col
Closed

ARROW-11898: [Rust] Pretty print columns#9650
nevi-me wants to merge 1 commit into
apache:masterfrom
nevi-me:pretty-print-col

Conversation

@nevi-me

Copy link
Copy Markdown
Contributor

Adds a way to also pretty-print a slice of columns, as a convenience to aviod creating a single-column record batch.

@github-actions

Copy link
Copy Markdown

Comment thread.github/workflows/rust.yml Outdated
@codecov-io

Copy link
Copy Markdown

Codecov Report

Merging #9650 (e5c8fe5) into master (dec5ab9) will decrease coverage by 0.01%.
The diff coverage is 71.42%.

Impacted file tree graph

@@ Coverage Diff @@## master #9650 +/- ##
==========================================
- Coverage 82.51% 82.50% -0.02% 
==========================================
Files 245 245 Lines 57329 57378 +49 ==========================================
+ Hits 47306 47338 +32 - Misses 10023 10040 +17 
Impacted FilesCoverage Δ
rust/arrow/src/array/array_list.rs92.88% <ø> (-0.07%)⬇️
rust/arrow/src/datatypes/native.rs76.59% <22.22%> (-12.88%)⬇️
rust/arrow/src/util/pretty.rs94.77% <87.09%> (-2.32%)⬇️
rust/arrow/src/array/array_binary.rs91.82% <100.00%> (ø)
rust/arrow/src/array/array_primitive.rs95.00% <100.00%> (+0.04%)⬆️
rust/arrow/src/array/array_string.rs96.06% <100.00%> (ø)
rust/datafusion/src/physical_plan/merge.rs76.56% <100.00%> (ø)
rust/parquet/src/encodings/encoding.rs95.05% <0.00%> (+0.19%)⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2585f7c...e5c8fe5. Read the comment docs.

@alambalamb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went through this code and it makes sense to me (other than the change to disable cargo test which should be removed prior to merging) -- thanks @nevi-me

I am now going to spend some time looking into the CI hang

@alamb

alamb commented Mar 7, 2021

Copy link
Copy Markdown
Contributor

FYI I merged #9653 / ARROW-11896 for the Rust CI checks which may affect this PR. If you see "Rust / AMD64 Debian 10 Rust stable test workspace" failing with a linker error or no logs, rebasing against master will hopefully fix the problem

Introduces `arrow::util::pretty::print_columns`
@nevi-me

Copy link
Copy Markdown
ContributorAuthor

FYI I merged #9653 / ARROW-11896 for the Rust CI checks which may affect this PR. If you see "Rust / AMD64 Debian 10 Rust stable test workspace" failing with a linker error or no logs, rebasing against master will hopefully fix the problem

Thakns, I'm rebasing my PRs

@alambalamb closed this in b7b90fcMar 8, 2021
@asfimportasfimport mentioned this pull request Mar 8, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@nevi-me@codecov-io@alamb