Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions rust/benchmarks/src/bin/tpch.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -157,9 +157,9 @@ async fn benchmark(opt: BenchmarkOpt) -> Result<Vec<arrow::record_batch::RecordB
table,
start.elapsed().as_millis()
);
ctx.register_table(table, Arc::new(memtable));
ctx.register_table(*table, Arc::new(memtable))?;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change to make register_table fallible is a breaking change, but a very reasonable one I think.

} else {
ctx.register_table(table, table_provider);
ctx.register_table(*table, table_provider)?;
}
}

Expand DownExpand Up@@ -1105,7 +1105,7 @@ fn get_table(
table: &str,
table_format: &str,
max_concurrency: usize,
) -> Result<Arc<dyn TableProvider + Send + Sync>> {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW I was confused about this change initially until I saw that you added Send + Sync to the TableProvider trait itself. I think that is a good change (so we don't have to remember to add Send + Sync everywhere)

) -> Result<Arc<dyn TableProvider>> {
match table_format {
// dbgen creates .tbl ('|' delimited) files without header
"tbl" => {
Expand DownExpand Up@@ -1614,7 +1614,7 @@ mod tests {

let provider = MemTable::try_new(Arc::new(schema), vec![vec![batch]])?;

ctx.register_table(table, Arc::new(provider));
ctx.register_table(table, Arc::new(provider))?;
}

let plan = create_logical_plan(&mut ctx, n)?;
Expand Down
2 changes: 1 addition & 1 deletion rust/datafusion/benches/aggregate_query_sql.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -150,7 +150,7 @@ fn create_context(

// declare a table in memory. In spark API, this corresponds to createDataFrame(...).
let provider = MemTable::try_new(schema, partitions)?;
ctx.register_table("t", Arc::new(provider));
ctx.register_table("t", Arc::new(provider))?;

Ok(Arc::new(Mutex::new(ctx)))
}
Expand Down
2 changes: 1 addition & 1 deletion rust/datafusion/benches/filter_query_sql.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -62,7 +62,7 @@ fn create_context(array_len: usize, batch_size: usize) -> Result<ExecutionContex

// declare a table in memory. In spark API, this corresponds to createDataFrame(...).
let provider = MemTable::try_new(schema, vec![batches])?;
ctx.register_table("t", Arc::new(provider));
ctx.register_table("t", Arc::new(provider))?;

Ok(ctx)
}
Expand Down
2 changes: 1 addition & 1 deletion rust/datafusion/benches/math_query_sql.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -72,7 +72,7 @@ fn create_context(

// declare a table in memory. In spark API, this corresponds to createDataFrame(...).
let provider = MemTable::try_new(schema, vec![batches])?;
ctx.register_table("t", Arc::new(provider));
ctx.register_table("t", Arc::new(provider))?;

Ok(Arc::new(Mutex::new(ctx)))
}
Expand Down
3 changes: 2 additions & 1 deletion rust/datafusion/benches/sort_limit_query_sql.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -81,7 +81,8 @@ fn create_context() -> Arc<Mutex<ExecutionContext>> {
// create local execution context
let mut ctx = ExecutionContext::new();
ctx.state.lock().unwrap().config.concurrency = 1;
ctx.register_table("aggregate_test_100", Arc::new(mem_table));
ctx.register_table("aggregate_test_100", Arc::new(mem_table))
.unwrap();
ctx_holder.lock().unwrap().push(Arc::new(Mutex::new(ctx)))
});

Expand Down
2 changes: 1 addition & 1 deletion rust/datafusion/examples/dataframe_in_memory.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -49,7 +49,7 @@ async fn main() -> Result<()> {

// declare a table in memory. In spark API, this corresponds to createDataFrame(...).
let provider = MemTable::try_new(schema, vec![vec![batch]])?;
ctx.register_table("t", Arc::new(provider));
ctx.register_table("t", Arc::new(provider))?;
let df = ctx.table("t")?;

// construct an expression corresponding to "SELECT a, b FROM t WHERE b = 10" in SQL
Expand Down
2 changes: 1 addition & 1 deletion rust/datafusion/examples/simple_udaf.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -48,7 +48,7 @@ fn create_context() -> Result<ExecutionContext> {

// declare a table in memory. In spark API, this corresponds to createDataFrame(...).
let provider = MemTable::try_new(schema, vec![vec![batch1], vec![batch2]])?;
ctx.register_table("t", Arc::new(provider));
ctx.register_table("t", Arc::new(provider))?;
Ok(ctx)
}

Expand Down
2 changes: 1 addition & 1 deletion rust/datafusion/examples/simple_udf.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -50,7 +50,7 @@ fn create_context() -> Result<ExecutionContext> {

// declare a table in memory. In spark API, this corresponds to createDataFrame(...).
let provider = MemTable::try_new(schema, vec![vec![batch]])?;
ctx.register_table("t", Arc::new(provider));
ctx.register_table("t", Arc::new(provider))?;
Ok(ctx)
}

Expand Down
78 changes: 78 additions & 0 deletions rust/datafusion/src/catalog/catalog.rs
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,78 @@
// Licensed to the Apache Software Foundation (ASF) under one
// or more contributor license agreements. See the NOTICE file
// distributed with this work for additional information
// regarding copyright ownership. The ASF licenses this file
// to you under the Apache License, Version 2.0 (the
// "License"); you may not use this file except in compliance
// with the License. You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing,
// software distributed under the License is distributed on an
// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
// KIND, either express or implied. See the License for the
// specific language governing permissions and limitations
// under the License.

//! Describes the interface and built-in implementations of catalogs,

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

//! representing collections of named schemas.

use crate::catalog::schema::SchemaProvider;
use std::any::Any;
use std::collections::HashMap;
use std::sync::{Arc, RwLock};

/// Represents a catalog, comprising a number of named schemas.
pub trait CatalogProvider: Sync + Send {
/// Returns the catalog provider as [`Any`](std::any::Any)
/// so that it can be downcast to a specific implementation.
fn as_any(&self) -> &dyn Any;

/// Retrieves the list of available schema names in this catalog.
fn schema_names(&self) -> Vec<String>;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about returning something more like Vec<&str> to prevent requiring a copy?

Ideally it would be nice if we could do something like

fn schema_names(&self) -> impl Iterator<Item=&str>

As all uses of the results here will need to iterate over the names I suspect

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I iniitally tried to implement these returning &[&str] but with the threading requirements I struggled to get anything working that way. I think this would require a larger refactoring to enable, but I'm not 100% sure on that.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vec<&str> might be possible


/// Retrieves a specific schema from the catalog by name, provided it exists.
fn schema(&self, name: &str) -> Option<Arc<dyn SchemaProvider>>;
}

/// Simple in-memory implementation of a catalog.
pub struct MemoryCatalogProvider {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In some other PR perhaps we can put the concrete implementations into their own modules. I don't think this one is big enough to warrant that yet, however; I just wanted to point it out

schemas: RwLock<HashMap<String, Arc<dyn SchemaProvider>>>,
}

impl MemoryCatalogProvider {
/// Instantiates a new MemoryCatalogProvider with an empty collection of schemas.
pub fn new() -> Self {
Self {
schemas: RwLock::new(HashMap::new()),
}
}

/// Adds a new schema to this catalog.
/// If a schema of the same name existed before, it is replaced in the catalog and returned.
pub fn register_schema(
&self,
name: impl Into<String>,
schema: Arc<dyn SchemaProvider>,
) -> Option<Arc<dyn SchemaProvider>> {
let mut schemas = self.schemas.write().unwrap();
schemas.insert(name.into(), schema)
}
}

impl CatalogProvider for MemoryCatalogProvider {
fn as_any(&self) -> &dyn Any {
self
}

fn schema_names(&self) -> Vec<String> {
let schemas = self.schemas.read().unwrap();
schemas.keys().cloned().collect()
}

fn schema(&self, name: &str) -> Option<Arc<dyn SchemaProvider>> {
let schemas = self.schemas.read().unwrap();
schemas.get(name).cloned()
}
}
145 changes: 145 additions & 0 deletions rust/datafusion/src/catalog/mod.rs
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,145 @@
// Licensed to the Apache Software Foundation (ASF) under one
// or more contributor license agreements. See the NOTICE file
// distributed with this work for additional information
// regarding copyright ownership. The ASF licenses this file
// to you under the Apache License, Version 2.0 (the
// "License"); you may not use this file except in compliance
// with the License. You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing,
// software distributed under the License is distributed on an
// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
// KIND, either express or implied. See the License for the
// specific language governing permissions and limitations
// under the License.

//! This module contains interfaces and default implementations
//! of table namespacing concepts, including catalogs and schemas.

pub mod catalog;
pub mod schema;

use crate::error::DataFusionError;
use std::convert::TryFrom;

/// Represents a resolved path to a table of the form "catalog.schema.table"
#[derive(Clone, Copy)]
pub struct ResolvedTableReference<'a> {
/// The catalog (aka database) containing the table
pub catalog: &'a str,
/// The schema containing the table
pub schema: &'a str,
/// The table name
pub table: &'a str,
}

/// Represents a path to a table that may require further resolution
#[derive(Clone, Copy)]
pub enum TableReference<'a> {
/// An unqualified table reference, e.g. "table"
Bare {
/// The table name
table: &'a str,
},
/// A partially resolved table reference, e.g. "schema.table"
Partial {
/// The schema containing the table
schema: &'a str,
/// The table name
table: &'a str,
},
/// A fully resolved table reference, e.g. "catalog.schema.table"
Full {
/// The catalog (aka database) containing the table
catalog: &'a str,
/// The schema containing the table
schema: &'a str,
/// The table name
table: &'a str,
},
}

impl<'a> TableReference<'a> {
/// Retrieve the actual table name, regardless of qualification
pub fn table(&self) -> &str {
match self {
Self::Full { table, .. }
| Self::Partial { table, .. }
| Self::Bare { table } => table,
}
}

/// Given a default catalog and schema, ensure this table reference is fully resolved
pub fn resolve(
self,
default_catalog: &'a str,
default_schema: &'a str,
) -> ResolvedTableReference<'a> {
match self {
Self::Full {
catalog,
schema,
table,
} => ResolvedTableReference {
catalog,
schema,
table,
},
Self::Partial { schema, table } => ResolvedTableReference {
catalog: default_catalog,
schema,
table,
},
Self::Bare { table } => ResolvedTableReference {
catalog: default_catalog,
schema: default_schema,
table,
},
}
}
}

impl<'a> From<&'a str> for TableReference<'a> {
fn from(s: &'a str) -> Self {
Self::Bare { table: s }
}
}

impl<'a> From<ResolvedTableReference<'a>> for TableReference<'a> {
fn from(resolved: ResolvedTableReference<'a>) -> Self {
Self::Full {
catalog: resolved.catalog,
schema: resolved.schema,
table: resolved.table,
}
}
}

impl<'a> TryFrom<&'a sqlparser::ast::ObjectName> for TableReference<'a> {
type Error = DataFusionError;

fn try_from(value: &'a sqlparser::ast::ObjectName) -> Result<Self, Self::Error> {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

let idents = &value.0;

match idents.len() {
1 => Ok(Self::Bare {
table: &idents[0].value,
}),
2 => Ok(Self::Partial {
schema: &idents[0].value,
table: &idents[1].value,
}),
3 => Ok(Self::Full {
catalog: &idents[0].value,
schema: &idents[1].value,
table: &idents[2].value,
}),
_ => Err(DataFusionError::Plan(format!(
"invalid table reference: {}",
value
))),
}
}
}
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all \u003cpre\u003e\u003ccode\u003e blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks"); } } catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); } })(); (function(){ try { var __m = "github.com"; var __re = new RegExp('^' + "github\\.com" + '
Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions rust/benchmarks/src/bin/tpch.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -157,9 +157,9 @@ async fn benchmark(opt: BenchmarkOpt) -> Result<Vec<arrow::record_batch::RecordB
table,
start.elapsed().as_millis()
);
ctx.register_table(table, Arc::new(memtable));
ctx.register_table(*table, Arc::new(memtable))?;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change to make register_table fallible is a breaking change, but a very reasonable one I think.

} else {
ctx.register_table(table, table_provider);
ctx.register_table(*table, table_provider)?;
}
}

Expand DownExpand Up@@ -1105,7 +1105,7 @@ fn get_table(
table: &str,
table_format: &str,
max_concurrency: usize,
) -> Result<Arc<dyn TableProvider + Send + Sync>> {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW I was confused about this change initially until I saw that you added Send + Sync to the TableProvider trait itself. I think that is a good change (so we don't have to remember to add Send + Sync everywhere)

) -> Result<Arc<dyn TableProvider>> {
match table_format {
// dbgen creates .tbl ('|' delimited) files without header
"tbl" => {
Expand DownExpand Up@@ -1614,7 +1614,7 @@ mod tests {

let provider = MemTable::try_new(Arc::new(schema), vec![vec![batch]])?;

ctx.register_table(table, Arc::new(provider));
ctx.register_table(table, Arc::new(provider))?;
}

let plan = create_logical_plan(&mut ctx, n)?;
Expand Down
2 changes: 1 addition & 1 deletion rust/datafusion/benches/aggregate_query_sql.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -150,7 +150,7 @@ fn create_context(

// declare a table in memory. In spark API, this corresponds to createDataFrame(...).
let provider = MemTable::try_new(schema, partitions)?;
ctx.register_table("t", Arc::new(provider));
ctx.register_table("t", Arc::new(provider))?;

Ok(Arc::new(Mutex::new(ctx)))
}
Expand Down
2 changes: 1 addition & 1 deletion rust/datafusion/benches/filter_query_sql.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -62,7 +62,7 @@ fn create_context(array_len: usize, batch_size: usize) -> Result<ExecutionContex

// declare a table in memory. In spark API, this corresponds to createDataFrame(...).
let provider = MemTable::try_new(schema, vec![batches])?;
ctx.register_table("t", Arc::new(provider));
ctx.register_table("t", Arc::new(provider))?;

Ok(ctx)
}
Expand Down
2 changes: 1 addition & 1 deletion rust/datafusion/benches/math_query_sql.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -72,7 +72,7 @@ fn create_context(

// declare a table in memory. In spark API, this corresponds to createDataFrame(...).
let provider = MemTable::try_new(schema, vec![batches])?;
ctx.register_table("t", Arc::new(provider));
ctx.register_table("t", Arc::new(provider))?;

Ok(Arc::new(Mutex::new(ctx)))
}
Expand Down
3 changes: 2 additions & 1 deletion rust/datafusion/benches/sort_limit_query_sql.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -81,7 +81,8 @@ fn create_context() -> Arc<Mutex<ExecutionContext>> {
// create local execution context
let mut ctx = ExecutionContext::new();
ctx.state.lock().unwrap().config.concurrency = 1;
ctx.register_table("aggregate_test_100", Arc::new(mem_table));
ctx.register_table("aggregate_test_100", Arc::new(mem_table))
.unwrap();
ctx_holder.lock().unwrap().push(Arc::new(Mutex::new(ctx)))
});

Expand Down
2 changes: 1 addition & 1 deletion rust/datafusion/examples/dataframe_in_memory.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -49,7 +49,7 @@ async fn main() -> Result<()> {

// declare a table in memory. In spark API, this corresponds to createDataFrame(...).
let provider = MemTable::try_new(schema, vec![vec![batch]])?;
ctx.register_table("t", Arc::new(provider));
ctx.register_table("t", Arc::new(provider))?;
let df = ctx.table("t")?;

// construct an expression corresponding to "SELECT a, b FROM t WHERE b = 10" in SQL
Expand Down
2 changes: 1 addition & 1 deletion rust/datafusion/examples/simple_udaf.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -48,7 +48,7 @@ fn create_context() -> Result<ExecutionContext> {

// declare a table in memory. In spark API, this corresponds to createDataFrame(...).
let provider = MemTable::try_new(schema, vec![vec![batch1], vec![batch2]])?;
ctx.register_table("t", Arc::new(provider));
ctx.register_table("t", Arc::new(provider))?;
Ok(ctx)
}

Expand Down
2 changes: 1 addition & 1 deletion rust/datafusion/examples/simple_udf.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -50,7 +50,7 @@ fn create_context() -> Result<ExecutionContext> {

// declare a table in memory. In spark API, this corresponds to createDataFrame(...).
let provider = MemTable::try_new(schema, vec![vec![batch]])?;
ctx.register_table("t", Arc::new(provider));
ctx.register_table("t", Arc::new(provider))?;
Ok(ctx)
}

Expand Down
78 changes: 78 additions & 0 deletions rust/datafusion/src/catalog/catalog.rs
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,78 @@
// Licensed to the Apache Software Foundation (ASF) under one
// or more contributor license agreements. See the NOTICE file
// distributed with this work for additional information
// regarding copyright ownership. The ASF licenses this file
// to you under the Apache License, Version 2.0 (the
// "License"); you may not use this file except in compliance
// with the License. You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing,
// software distributed under the License is distributed on an
// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
// KIND, either express or implied. See the License for the
// specific language governing permissions and limitations
// under the License.

//! Describes the interface and built-in implementations of catalogs,

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

//! representing collections of named schemas.

use crate::catalog::schema::SchemaProvider;
use std::any::Any;
use std::collections::HashMap;
use std::sync::{Arc, RwLock};

/// Represents a catalog, comprising a number of named schemas.
pub trait CatalogProvider: Sync + Send {
/// Returns the catalog provider as [`Any`](std::any::Any)
/// so that it can be downcast to a specific implementation.
fn as_any(&self) -> &dyn Any;

/// Retrieves the list of available schema names in this catalog.
fn schema_names(&self) -> Vec<String>;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about returning something more like Vec<&str> to prevent requiring a copy?

Ideally it would be nice if we could do something like

fn schema_names(&self) -> impl Iterator<Item=&str>

As all uses of the results here will need to iterate over the names I suspect

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I iniitally tried to implement these returning &[&str] but with the threading requirements I struggled to get anything working that way. I think this would require a larger refactoring to enable, but I'm not 100% sure on that.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vec<&str> might be possible


/// Retrieves a specific schema from the catalog by name, provided it exists.
fn schema(&self, name: &str) -> Option<Arc<dyn SchemaProvider>>;
}

/// Simple in-memory implementation of a catalog.
pub struct MemoryCatalogProvider {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In some other PR perhaps we can put the concrete implementations into their own modules. I don't think this one is big enough to warrant that yet, however; I just wanted to point it out

schemas: RwLock<HashMap<String, Arc<dyn SchemaProvider>>>,
}

impl MemoryCatalogProvider {
/// Instantiates a new MemoryCatalogProvider with an empty collection of schemas.
pub fn new() -> Self {
Self {
schemas: RwLock::new(HashMap::new()),
}
}

/// Adds a new schema to this catalog.
/// If a schema of the same name existed before, it is replaced in the catalog and returned.
pub fn register_schema(
&self,
name: impl Into<String>,
schema: Arc<dyn SchemaProvider>,
) -> Option<Arc<dyn SchemaProvider>> {
let mut schemas = self.schemas.write().unwrap();
schemas.insert(name.into(), schema)
}
}

impl CatalogProvider for MemoryCatalogProvider {
fn as_any(&self) -> &dyn Any {
self
}

fn schema_names(&self) -> Vec<String> {
let schemas = self.schemas.read().unwrap();
schemas.keys().cloned().collect()
}

fn schema(&self, name: &str) -> Option<Arc<dyn SchemaProvider>> {
let schemas = self.schemas.read().unwrap();
schemas.get(name).cloned()
}
}
145 changes: 145 additions & 0 deletions rust/datafusion/src/catalog/mod.rs
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,145 @@
// Licensed to the Apache Software Foundation (ASF) under one
// or more contributor license agreements. See the NOTICE file
// distributed with this work for additional information
// regarding copyright ownership. The ASF licenses this file
// to you under the Apache License, Version 2.0 (the
// "License"); you may not use this file except in compliance
// with the License. You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing,
// software distributed under the License is distributed on an
// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
// KIND, either express or implied. See the License for the
// specific language governing permissions and limitations
// under the License.

//! This module contains interfaces and default implementations
//! of table namespacing concepts, including catalogs and schemas.

pub mod catalog;
pub mod schema;

use crate::error::DataFusionError;
use std::convert::TryFrom;

/// Represents a resolved path to a table of the form "catalog.schema.table"
#[derive(Clone, Copy)]
pub struct ResolvedTableReference<'a> {
/// The catalog (aka database) containing the table
pub catalog: &'a str,
/// The schema containing the table
pub schema: &'a str,
/// The table name
pub table: &'a str,
}

/// Represents a path to a table that may require further resolution
#[derive(Clone, Copy)]
pub enum TableReference<'a> {
/// An unqualified table reference, e.g. "table"
Bare {
/// The table name
table: &'a str,
},
/// A partially resolved table reference, e.g. "schema.table"
Partial {
/// The schema containing the table
schema: &'a str,
/// The table name
table: &'a str,
},
/// A fully resolved table reference, e.g. "catalog.schema.table"
Full {
/// The catalog (aka database) containing the table
catalog: &'a str,
/// The schema containing the table
schema: &'a str,
/// The table name
table: &'a str,
},
}

impl<'a> TableReference<'a> {
/// Retrieve the actual table name, regardless of qualification
pub fn table(&self) -> &str {
match self {
Self::Full { table, .. }
| Self::Partial { table, .. }
| Self::Bare { table } => table,
}
}

/// Given a default catalog and schema, ensure this table reference is fully resolved
pub fn resolve(
self,
default_catalog: &'a str,
default_schema: &'a str,
) -> ResolvedTableReference<'a> {
match self {
Self::Full {
catalog,
schema,
table,
} => ResolvedTableReference {
catalog,
schema,
table,
},
Self::Partial { schema, table } => ResolvedTableReference {
catalog: default_catalog,
schema,
table,
},
Self::Bare { table } => ResolvedTableReference {
catalog: default_catalog,
schema: default_schema,
table,
},
}
}
}

impl<'a> From<&'a str> for TableReference<'a> {
fn from(s: &'a str) -> Self {
Self::Bare { table: s }
}
}

impl<'a> From<ResolvedTableReference<'a>> for TableReference<'a> {
fn from(resolved: ResolvedTableReference<'a>) -> Self {
Self::Full {
catalog: resolved.catalog,
schema: resolved.schema,
table: resolved.table,
}
}
}

impl<'a> TryFrom<&'a sqlparser::ast::ObjectName> for TableReference<'a> {
type Error = DataFusionError;

fn try_from(value: &'a sqlparser::ast::ObjectName) -> Result<Self, Self::Error> {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

let idents = &value.0;

match idents.len() {
1 => Ok(Self::Bare {
table: &idents[0].value,
}),
2 => Ok(Self::Partial {
schema: &idents[0].value,
table: &idents[1].value,
}),
3 => Ok(Self::Full {
catalog: &idents[0].value,
schema: &idents[1].value,
table: &idents[2].value,
}),
_ => Err(DataFusionError::Plan(format!(
"invalid table reference: {}",
value
))),
}
}
}
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions rust/benchmarks/src/bin/tpch.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -157,9 +157,9 @@ async fn benchmark(opt: BenchmarkOpt) -> Result<Vec<arrow::record_batch::RecordB
table,
start.elapsed().as_millis()
);
ctx.register_table(table, Arc::new(memtable));
ctx.register_table(*table, Arc::new(memtable))?;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change to make register_table fallible is a breaking change, but a very reasonable one I think.

} else {
ctx.register_table(table, table_provider);
ctx.register_table(*table, table_provider)?;
}
}

Expand DownExpand Up@@ -1105,7 +1105,7 @@ fn get_table(
table: &str,
table_format: &str,
max_concurrency: usize,
) -> Result<Arc<dyn TableProvider + Send + Sync>> {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW I was confused about this change initially until I saw that you added Send + Sync to the TableProvider trait itself. I think that is a good change (so we don't have to remember to add Send + Sync everywhere)

) -> Result<Arc<dyn TableProvider>> {
match table_format {
// dbgen creates .tbl ('|' delimited) files without header
"tbl" => {
Expand DownExpand Up@@ -1614,7 +1614,7 @@ mod tests {

let provider = MemTable::try_new(Arc::new(schema), vec![vec![batch]])?;

ctx.register_table(table, Arc::new(provider));
ctx.register_table(table, Arc::new(provider))?;
}

let plan = create_logical_plan(&mut ctx, n)?;
Expand Down
2 changes: 1 addition & 1 deletion rust/datafusion/benches/aggregate_query_sql.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -150,7 +150,7 @@ fn create_context(

// declare a table in memory. In spark API, this corresponds to createDataFrame(...).
let provider = MemTable::try_new(schema, partitions)?;
ctx.register_table("t", Arc::new(provider));
ctx.register_table("t", Arc::new(provider))?;

Ok(Arc::new(Mutex::new(ctx)))
}
Expand Down
2 changes: 1 addition & 1 deletion rust/datafusion/benches/filter_query_sql.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -62,7 +62,7 @@ fn create_context(array_len: usize, batch_size: usize) -> Result<ExecutionContex

// declare a table in memory. In spark API, this corresponds to createDataFrame(...).
let provider = MemTable::try_new(schema, vec![batches])?;
ctx.register_table("t", Arc::new(provider));
ctx.register_table("t", Arc::new(provider))?;

Ok(ctx)
}
Expand Down
2 changes: 1 addition & 1 deletion rust/datafusion/benches/math_query_sql.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -72,7 +72,7 @@ fn create_context(

// declare a table in memory. In spark API, this corresponds to createDataFrame(...).
let provider = MemTable::try_new(schema, vec![batches])?;
ctx.register_table("t", Arc::new(provider));
ctx.register_table("t", Arc::new(provider))?;

Ok(Arc::new(Mutex::new(ctx)))
}
Expand Down
3 changes: 2 additions & 1 deletion rust/datafusion/benches/sort_limit_query_sql.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -81,7 +81,8 @@ fn create_context() -> Arc<Mutex<ExecutionContext>> {
// create local execution context
let mut ctx = ExecutionContext::new();
ctx.state.lock().unwrap().config.concurrency = 1;
ctx.register_table("aggregate_test_100", Arc::new(mem_table));
ctx.register_table("aggregate_test_100", Arc::new(mem_table))
.unwrap();
ctx_holder.lock().unwrap().push(Arc::new(Mutex::new(ctx)))
});

Expand Down
2 changes: 1 addition & 1 deletion rust/datafusion/examples/dataframe_in_memory.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -49,7 +49,7 @@ async fn main() -> Result<()> {

// declare a table in memory. In spark API, this corresponds to createDataFrame(...).
let provider = MemTable::try_new(schema, vec![vec![batch]])?;
ctx.register_table("t", Arc::new(provider));
ctx.register_table("t", Arc::new(provider))?;
let df = ctx.table("t")?;

// construct an expression corresponding to "SELECT a, b FROM t WHERE b = 10" in SQL
Expand Down
2 changes: 1 addition & 1 deletion rust/datafusion/examples/simple_udaf.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -48,7 +48,7 @@ fn create_context() -> Result<ExecutionContext> {

// declare a table in memory. In spark API, this corresponds to createDataFrame(...).
let provider = MemTable::try_new(schema, vec![vec![batch1], vec![batch2]])?;
ctx.register_table("t", Arc::new(provider));
ctx.register_table("t", Arc::new(provider))?;
Ok(ctx)
}

Expand Down
2 changes: 1 addition & 1 deletion rust/datafusion/examples/simple_udf.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -50,7 +50,7 @@ fn create_context() -> Result<ExecutionContext> {

// declare a table in memory. In spark API, this corresponds to createDataFrame(...).
let provider = MemTable::try_new(schema, vec![vec![batch]])?;
ctx.register_table("t", Arc::new(provider));
ctx.register_table("t", Arc::new(provider))?;
Ok(ctx)
}

Expand Down
78 changes: 78 additions & 0 deletions rust/datafusion/src/catalog/catalog.rs
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,78 @@
// Licensed to the Apache Software Foundation (ASF) under one
// or more contributor license agreements. See the NOTICE file
// distributed with this work for additional information
// regarding copyright ownership. The ASF licenses this file
// to you under the Apache License, Version 2.0 (the
// "License"); you may not use this file except in compliance
// with the License. You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing,
// software distributed under the License is distributed on an
// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
// KIND, either express or implied. See the License for the
// specific language governing permissions and limitations
// under the License.

//! Describes the interface and built-in implementations of catalogs,

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

//! representing collections of named schemas.

use crate::catalog::schema::SchemaProvider;
use std::any::Any;
use std::collections::HashMap;
use std::sync::{Arc, RwLock};

/// Represents a catalog, comprising a number of named schemas.
pub trait CatalogProvider: Sync + Send {
/// Returns the catalog provider as [`Any`](std::any::Any)
/// so that it can be downcast to a specific implementation.
fn as_any(&self) -> &dyn Any;

/// Retrieves the list of available schema names in this catalog.
fn schema_names(&self) -> Vec<String>;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about returning something more like Vec<&str> to prevent requiring a copy?

Ideally it would be nice if we could do something like

fn schema_names(&self) -> impl Iterator<Item=&str>

As all uses of the results here will need to iterate over the names I suspect

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I iniitally tried to implement these returning &[&str] but with the threading requirements I struggled to get anything working that way. I think this would require a larger refactoring to enable, but I'm not 100% sure on that.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vec<&str> might be possible


/// Retrieves a specific schema from the catalog by name, provided it exists.
fn schema(&self, name: &str) -> Option<Arc<dyn SchemaProvider>>;
}

/// Simple in-memory implementation of a catalog.
pub struct MemoryCatalogProvider {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In some other PR perhaps we can put the concrete implementations into their own modules. I don't think this one is big enough to warrant that yet, however; I just wanted to point it out

schemas: RwLock<HashMap<String, Arc<dyn SchemaProvider>>>,
}

impl MemoryCatalogProvider {
/// Instantiates a new MemoryCatalogProvider with an empty collection of schemas.
pub fn new() -> Self {
Self {
schemas: RwLock::new(HashMap::new()),
}
}

/// Adds a new schema to this catalog.
/// If a schema of the same name existed before, it is replaced in the catalog and returned.
pub fn register_schema(
&self,
name: impl Into<String>,
schema: Arc<dyn SchemaProvider>,
) -> Option<Arc<dyn SchemaProvider>> {
let mut schemas = self.schemas.write().unwrap();
schemas.insert(name.into(), schema)
}
}

impl CatalogProvider for MemoryCatalogProvider {
fn as_any(&self) -> &dyn Any {
self
}

fn schema_names(&self) -> Vec<String> {
let schemas = self.schemas.read().unwrap();
schemas.keys().cloned().collect()
}

fn schema(&self, name: &str) -> Option<Arc<dyn SchemaProvider>> {
let schemas = self.schemas.read().unwrap();
schemas.get(name).cloned()
}
}
145 changes: 145 additions & 0 deletions rust/datafusion/src/catalog/mod.rs
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,145 @@
// Licensed to the Apache Software Foundation (ASF) under one
// or more contributor license agreements. See the NOTICE file
// distributed with this work for additional information
// regarding copyright ownership. The ASF licenses this file
// to you under the Apache License, Version 2.0 (the
// "License"); you may not use this file except in compliance
// with the License. You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing,
// software distributed under the License is distributed on an
// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
// KIND, either express or implied. See the License for the
// specific language governing permissions and limitations
// under the License.

//! This module contains interfaces and default implementations
//! of table namespacing concepts, including catalogs and schemas.

pub mod catalog;
pub mod schema;

use crate::error::DataFusionError;
use std::convert::TryFrom;

/// Represents a resolved path to a table of the form "catalog.schema.table"
#[derive(Clone, Copy)]
pub struct ResolvedTableReference<'a> {
/// The catalog (aka database) containing the table
pub catalog: &'a str,
/// The schema containing the table
pub schema: &'a str,
/// The table name
pub table: &'a str,
}

/// Represents a path to a table that may require further resolution
#[derive(Clone, Copy)]
pub enum TableReference<'a> {
/// An unqualified table reference, e.g. "table"
Bare {
/// The table name
table: &'a str,
},
/// A partially resolved table reference, e.g. "schema.table"
Partial {
/// The schema containing the table
schema: &'a str,
/// The table name
table: &'a str,
},
/// A fully resolved table reference, e.g. "catalog.schema.table"
Full {
/// The catalog (aka database) containing the table
catalog: &'a str,
/// The schema containing the table
schema: &'a str,
/// The table name
table: &'a str,
},
}

impl<'a> TableReference<'a> {
/// Retrieve the actual table name, regardless of qualification
pub fn table(&self) -> &str {
match self {
Self::Full { table, .. }
| Self::Partial { table, .. }
| Self::Bare { table } => table,
}
}

/// Given a default catalog and schema, ensure this table reference is fully resolved
pub fn resolve(
self,
default_catalog: &'a str,
default_schema: &'a str,
) -> ResolvedTableReference<'a> {
match self {
Self::Full {
catalog,
schema,
table,
} => ResolvedTableReference {
catalog,
schema,
table,
},
Self::Partial { schema, table } => ResolvedTableReference {
catalog: default_catalog,
schema,
table,
},
Self::Bare { table } => ResolvedTableReference {
catalog: default_catalog,
schema: default_schema,
table,
},
}
}
}

impl<'a> From<&'a str> for TableReference<'a> {
fn from(s: &'a str) -> Self {
Self::Bare { table: s }
}
}

impl<'a> From<ResolvedTableReference<'a>> for TableReference<'a> {
fn from(resolved: ResolvedTableReference<'a>) -> Self {
Self::Full {
catalog: resolved.catalog,
schema: resolved.schema,
table: resolved.table,
}
}
}

impl<'a> TryFrom<&'a sqlparser::ast::ObjectName> for TableReference<'a> {
type Error = DataFusionError;

fn try_from(value: &'a sqlparser::ast::ObjectName) -> Result<Self, Self::Error> {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

let idents = &value.0;

match idents.len() {
1 => Ok(Self::Bare {
table: &idents[0].value,
}),
2 => Ok(Self::Partial {
schema: &idents[0].value,
table: &idents[1].value,
}),
3 => Ok(Self::Full {
catalog: &idents[0].value,
schema: &idents[1].value,
table: &idents[2].value,
}),
_ => Err(DataFusionError::Plan(format!(
"invalid table reference: {}",
value
))),
}
}
}
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length \u003e 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions rust/benchmarks/src/bin/tpch.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -157,9 +157,9 @@ async fn benchmark(opt: BenchmarkOpt) -> Result<Vec<arrow::record_batch::RecordB
table,
start.elapsed().as_millis()
);
ctx.register_table(table, Arc::new(memtable));
ctx.register_table(*table, Arc::new(memtable))?;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change to make register_table fallible is a breaking change, but a very reasonable one I think.

} else {
ctx.register_table(table, table_provider);
ctx.register_table(*table, table_provider)?;
}
}

Expand DownExpand Up@@ -1105,7 +1105,7 @@ fn get_table(
table: &str,
table_format: &str,
max_concurrency: usize,
) -> Result<Arc<dyn TableProvider + Send + Sync>> {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW I was confused about this change initially until I saw that you added Send + Sync to the TableProvider trait itself. I think that is a good change (so we don't have to remember to add Send + Sync everywhere)

) -> Result<Arc<dyn TableProvider>> {
match table_format {
// dbgen creates .tbl ('|' delimited) files without header
"tbl" => {
Expand DownExpand Up@@ -1614,7 +1614,7 @@ mod tests {

let provider = MemTable::try_new(Arc::new(schema), vec![vec![batch]])?;

ctx.register_table(table, Arc::new(provider));
ctx.register_table(table, Arc::new(provider))?;
}

let plan = create_logical_plan(&mut ctx, n)?;
Expand Down
2 changes: 1 addition & 1 deletion rust/datafusion/benches/aggregate_query_sql.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -150,7 +150,7 @@ fn create_context(

// declare a table in memory. In spark API, this corresponds to createDataFrame(...).
let provider = MemTable::try_new(schema, partitions)?;
ctx.register_table("t", Arc::new(provider));
ctx.register_table("t", Arc::new(provider))?;

Ok(Arc::new(Mutex::new(ctx)))
}
Expand Down
2 changes: 1 addition & 1 deletion rust/datafusion/benches/filter_query_sql.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -62,7 +62,7 @@ fn create_context(array_len: usize, batch_size: usize) -> Result<ExecutionContex

// declare a table in memory. In spark API, this corresponds to createDataFrame(...).
let provider = MemTable::try_new(schema, vec![batches])?;
ctx.register_table("t", Arc::new(provider));
ctx.register_table("t", Arc::new(provider))?;

Ok(ctx)
}
Expand Down
2 changes: 1 addition & 1 deletion rust/datafusion/benches/math_query_sql.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -72,7 +72,7 @@ fn create_context(

// declare a table in memory. In spark API, this corresponds to createDataFrame(...).
let provider = MemTable::try_new(schema, vec![batches])?;
ctx.register_table("t", Arc::new(provider));
ctx.register_table("t", Arc::new(provider))?;

Ok(Arc::new(Mutex::new(ctx)))
}
Expand Down
3 changes: 2 additions & 1 deletion rust/datafusion/benches/sort_limit_query_sql.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -81,7 +81,8 @@ fn create_context() -> Arc<Mutex<ExecutionContext>> {
// create local execution context
let mut ctx = ExecutionContext::new();
ctx.state.lock().unwrap().config.concurrency = 1;
ctx.register_table("aggregate_test_100", Arc::new(mem_table));
ctx.register_table("aggregate_test_100", Arc::new(mem_table))
.unwrap();
ctx_holder.lock().unwrap().push(Arc::new(Mutex::new(ctx)))
});

Expand Down
2 changes: 1 addition & 1 deletion rust/datafusion/examples/dataframe_in_memory.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -49,7 +49,7 @@ async fn main() -> Result<()> {

// declare a table in memory. In spark API, this corresponds to createDataFrame(...).
let provider = MemTable::try_new(schema, vec![vec![batch]])?;
ctx.register_table("t", Arc::new(provider));
ctx.register_table("t", Arc::new(provider))?;
let df = ctx.table("t")?;

// construct an expression corresponding to "SELECT a, b FROM t WHERE b = 10" in SQL
Expand Down
2 changes: 1 addition & 1 deletion rust/datafusion/examples/simple_udaf.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -48,7 +48,7 @@ fn create_context() -> Result<ExecutionContext> {

// declare a table in memory. In spark API, this corresponds to createDataFrame(...).
let provider = MemTable::try_new(schema, vec![vec![batch1], vec![batch2]])?;
ctx.register_table("t", Arc::new(provider));
ctx.register_table("t", Arc::new(provider))?;
Ok(ctx)
}

Expand Down
2 changes: 1 addition & 1 deletion rust/datafusion/examples/simple_udf.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -50,7 +50,7 @@ fn create_context() -> Result<ExecutionContext> {

// declare a table in memory. In spark API, this corresponds to createDataFrame(...).
let provider = MemTable::try_new(schema, vec![vec![batch]])?;
ctx.register_table("t", Arc::new(provider));
ctx.register_table("t", Arc::new(provider))?;
Ok(ctx)
}

Expand Down
78 changes: 78 additions & 0 deletions rust/datafusion/src/catalog/catalog.rs
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,78 @@
// Licensed to the Apache Software Foundation (ASF) under one
// or more contributor license agreements. See the NOTICE file
// distributed with this work for additional information
// regarding copyright ownership. The ASF licenses this file
// to you under the Apache License, Version 2.0 (the
// "License"); you may not use this file except in compliance
// with the License. You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing,
// software distributed under the License is distributed on an
// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
// KIND, either express or implied. See the License for the
// specific language governing permissions and limitations
// under the License.

//! Describes the interface and built-in implementations of catalogs,

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

//! representing collections of named schemas.

use crate::catalog::schema::SchemaProvider;
use std::any::Any;
use std::collections::HashMap;
use std::sync::{Arc, RwLock};

/// Represents a catalog, comprising a number of named schemas.
pub trait CatalogProvider: Sync + Send {
/// Returns the catalog provider as [`Any`](std::any::Any)
/// so that it can be downcast to a specific implementation.
fn as_any(&self) -> &dyn Any;

/// Retrieves the list of available schema names in this catalog.
fn schema_names(&self) -> Vec<String>;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about returning something more like Vec<&str> to prevent requiring a copy?

Ideally it would be nice if we could do something like

fn schema_names(&self) -> impl Iterator<Item=&str>

As all uses of the results here will need to iterate over the names I suspect

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I iniitally tried to implement these returning &[&str] but with the threading requirements I struggled to get anything working that way. I think this would require a larger refactoring to enable, but I'm not 100% sure on that.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vec<&str> might be possible


/// Retrieves a specific schema from the catalog by name, provided it exists.
fn schema(&self, name: &str) -> Option<Arc<dyn SchemaProvider>>;
}

/// Simple in-memory implementation of a catalog.
pub struct MemoryCatalogProvider {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In some other PR perhaps we can put the concrete implementations into their own modules. I don't think this one is big enough to warrant that yet, however; I just wanted to point it out

schemas: RwLock<HashMap<String, Arc<dyn SchemaProvider>>>,
}

impl MemoryCatalogProvider {
/// Instantiates a new MemoryCatalogProvider with an empty collection of schemas.
pub fn new() -> Self {
Self {
schemas: RwLock::new(HashMap::new()),
}
}

/// Adds a new schema to this catalog.
/// If a schema of the same name existed before, it is replaced in the catalog and returned.
pub fn register_schema(
&self,
name: impl Into<String>,
schema: Arc<dyn SchemaProvider>,
) -> Option<Arc<dyn SchemaProvider>> {
let mut schemas = self.schemas.write().unwrap();
schemas.insert(name.into(), schema)
}
}

impl CatalogProvider for MemoryCatalogProvider {
fn as_any(&self) -> &dyn Any {
self
}

fn schema_names(&self) -> Vec<String> {
let schemas = self.schemas.read().unwrap();
schemas.keys().cloned().collect()
}

fn schema(&self, name: &str) -> Option<Arc<dyn SchemaProvider>> {
let schemas = self.schemas.read().unwrap();
schemas.get(name).cloned()
}
}
145 changes: 145 additions & 0 deletions rust/datafusion/src/catalog/mod.rs
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,145 @@
// Licensed to the Apache Software Foundation (ASF) under one
// or more contributor license agreements. See the NOTICE file
// distributed with this work for additional information
// regarding copyright ownership. The ASF licenses this file
// to you under the Apache License, Version 2.0 (the
// "License"); you may not use this file except in compliance
// with the License. You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing,
// software distributed under the License is distributed on an
// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
// KIND, either express or implied. See the License for the
// specific language governing permissions and limitations
// under the License.

//! This module contains interfaces and default implementations
//! of table namespacing concepts, including catalogs and schemas.

pub mod catalog;
pub mod schema;

use crate::error::DataFusionError;
use std::convert::TryFrom;

/// Represents a resolved path to a table of the form "catalog.schema.table"
#[derive(Clone, Copy)]
pub struct ResolvedTableReference<'a> {
/// The catalog (aka database) containing the table
pub catalog: &'a str,
/// The schema containing the table
pub schema: &'a str,
/// The table name
pub table: &'a str,
}

/// Represents a path to a table that may require further resolution
#[derive(Clone, Copy)]
pub enum TableReference<'a> {
/// An unqualified table reference, e.g. "table"
Bare {
/// The table name
table: &'a str,
},
/// A partially resolved table reference, e.g. "schema.table"
Partial {
/// The schema containing the table
schema: &'a str,
/// The table name
table: &'a str,
},
/// A fully resolved table reference, e.g. "catalog.schema.table"
Full {
/// The catalog (aka database) containing the table
catalog: &'a str,
/// The schema containing the table
schema: &'a str,
/// The table name
table: &'a str,
},
}

impl<'a> TableReference<'a> {
/// Retrieve the actual table name, regardless of qualification
pub fn table(&self) -> &str {
match self {
Self::Full { table, .. }
| Self::Partial { table, .. }
| Self::Bare { table } => table,
}
}

/// Given a default catalog and schema, ensure this table reference is fully resolved
pub fn resolve(
self,
default_catalog: &'a str,
default_schema: &'a str,
) -> ResolvedTableReference<'a> {
match self {
Self::Full {
catalog,
schema,
table,
} => ResolvedTableReference {
catalog,
schema,
table,
},
Self::Partial { schema, table } => ResolvedTableReference {
catalog: default_catalog,
schema,
table,
},
Self::Bare { table } => ResolvedTableReference {
catalog: default_catalog,
schema: default_schema,
table,
},
}
}
}

impl<'a> From<&'a str> for TableReference<'a> {
fn from(s: &'a str) -> Self {
Self::Bare { table: s }
}
}

impl<'a> From<ResolvedTableReference<'a>> for TableReference<'a> {
fn from(resolved: ResolvedTableReference<'a>) -> Self {
Self::Full {
catalog: resolved.catalog,
schema: resolved.schema,
table: resolved.table,
}
}
}

impl<'a> TryFrom<&'a sqlparser::ast::ObjectName> for TableReference<'a> {
type Error = DataFusionError;

fn try_from(value: &'a sqlparser::ast::ObjectName) -> Result<Self, Self::Error> {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

let idents = &value.0;

match idents.len() {
1 => Ok(Self::Bare {
table: &idents[0].value,
}),
2 => Ok(Self::Partial {
schema: &idents[0].value,
table: &idents[1].value,
}),
3 => Ok(Self::Full {
catalog: &idents[0].value,
schema: &idents[1].value,
table: &idents[2].value,
}),
_ => Err(DataFusionError::Plan(format!(
"invalid table reference: {}",
value
))),
}
}
}
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions rust/benchmarks/src/bin/tpch.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -157,9 +157,9 @@ async fn benchmark(opt: BenchmarkOpt) -> Result<Vec<arrow::record_batch::RecordB
table,
start.elapsed().as_millis()
);
ctx.register_table(table, Arc::new(memtable));
ctx.register_table(*table, Arc::new(memtable))?;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change to make register_table fallible is a breaking change, but a very reasonable one I think.

} else {
ctx.register_table(table, table_provider);
ctx.register_table(*table, table_provider)?;
}
}

Expand DownExpand Up@@ -1105,7 +1105,7 @@ fn get_table(
table: &str,
table_format: &str,
max_concurrency: usize,
) -> Result<Arc<dyn TableProvider + Send + Sync>> {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW I was confused about this change initially until I saw that you added Send + Sync to the TableProvider trait itself. I think that is a good change (so we don't have to remember to add Send + Sync everywhere)

) -> Result<Arc<dyn TableProvider>> {
match table_format {
// dbgen creates .tbl ('|' delimited) files without header
"tbl" => {
Expand DownExpand Up@@ -1614,7 +1614,7 @@ mod tests {

let provider = MemTable::try_new(Arc::new(schema), vec![vec![batch]])?;

ctx.register_table(table, Arc::new(provider));
ctx.register_table(table, Arc::new(provider))?;
}

let plan = create_logical_plan(&mut ctx, n)?;
Expand Down
2 changes: 1 addition & 1 deletion rust/datafusion/benches/aggregate_query_sql.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -150,7 +150,7 @@ fn create_context(

// declare a table in memory. In spark API, this corresponds to createDataFrame(...).
let provider = MemTable::try_new(schema, partitions)?;
ctx.register_table("t", Arc::new(provider));
ctx.register_table("t", Arc::new(provider))?;

Ok(Arc::new(Mutex::new(ctx)))
}
Expand Down
2 changes: 1 addition & 1 deletion rust/datafusion/benches/filter_query_sql.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -62,7 +62,7 @@ fn create_context(array_len: usize, batch_size: usize) -> Result<ExecutionContex

// declare a table in memory. In spark API, this corresponds to createDataFrame(...).
let provider = MemTable::try_new(schema, vec![batches])?;
ctx.register_table("t", Arc::new(provider));
ctx.register_table("t", Arc::new(provider))?;

Ok(ctx)
}
Expand Down
2 changes: 1 addition & 1 deletion rust/datafusion/benches/math_query_sql.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -72,7 +72,7 @@ fn create_context(

// declare a table in memory. In spark API, this corresponds to createDataFrame(...).
let provider = MemTable::try_new(schema, vec![batches])?;
ctx.register_table("t", Arc::new(provider));
ctx.register_table("t", Arc::new(provider))?;

Ok(Arc::new(Mutex::new(ctx)))
}
Expand Down
3 changes: 2 additions & 1 deletion rust/datafusion/benches/sort_limit_query_sql.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -81,7 +81,8 @@ fn create_context() -> Arc<Mutex<ExecutionContext>> {
// create local execution context
let mut ctx = ExecutionContext::new();
ctx.state.lock().unwrap().config.concurrency = 1;
ctx.register_table("aggregate_test_100", Arc::new(mem_table));
ctx.register_table("aggregate_test_100", Arc::new(mem_table))
.unwrap();
ctx_holder.lock().unwrap().push(Arc::new(Mutex::new(ctx)))
});

Expand Down
2 changes: 1 addition & 1 deletion rust/datafusion/examples/dataframe_in_memory.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -49,7 +49,7 @@ async fn main() -> Result<()> {

// declare a table in memory. In spark API, this corresponds to createDataFrame(...).
let provider = MemTable::try_new(schema, vec![vec![batch]])?;
ctx.register_table("t", Arc::new(provider));
ctx.register_table("t", Arc::new(provider))?;
let df = ctx.table("t")?;

// construct an expression corresponding to "SELECT a, b FROM t WHERE b = 10" in SQL
Expand Down
2 changes: 1 addition & 1 deletion rust/datafusion/examples/simple_udaf.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -48,7 +48,7 @@ fn create_context() -> Result<ExecutionContext> {

// declare a table in memory. In spark API, this corresponds to createDataFrame(...).
let provider = MemTable::try_new(schema, vec![vec![batch1], vec![batch2]])?;
ctx.register_table("t", Arc::new(provider));
ctx.register_table("t", Arc::new(provider))?;
Ok(ctx)
}

Expand Down
2 changes: 1 addition & 1 deletion rust/datafusion/examples/simple_udf.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -50,7 +50,7 @@ fn create_context() -> Result<ExecutionContext> {

// declare a table in memory. In spark API, this corresponds to createDataFrame(...).
let provider = MemTable::try_new(schema, vec![vec![batch]])?;
ctx.register_table("t", Arc::new(provider));
ctx.register_table("t", Arc::new(provider))?;
Ok(ctx)
}

Expand Down
78 changes: 78 additions & 0 deletions rust/datafusion/src/catalog/catalog.rs
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,78 @@
// Licensed to the Apache Software Foundation (ASF) under one
// or more contributor license agreements. See the NOTICE file
// distributed with this work for additional information
// regarding copyright ownership. The ASF licenses this file
// to you under the Apache License, Version 2.0 (the
// "License"); you may not use this file except in compliance
// with the License. You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing,
// software distributed under the License is distributed on an
// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
// KIND, either express or implied. See the License for the
// specific language governing permissions and limitations
// under the License.

//! Describes the interface and built-in implementations of catalogs,

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

//! representing collections of named schemas.

use crate::catalog::schema::SchemaProvider;
use std::any::Any;
use std::collections::HashMap;
use std::sync::{Arc, RwLock};

/// Represents a catalog, comprising a number of named schemas.
pub trait CatalogProvider: Sync + Send {
/// Returns the catalog provider as [`Any`](std::any::Any)
/// so that it can be downcast to a specific implementation.
fn as_any(&self) -> &dyn Any;

/// Retrieves the list of available schema names in this catalog.
fn schema_names(&self) -> Vec<String>;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about returning something more like Vec<&str> to prevent requiring a copy?

Ideally it would be nice if we could do something like

fn schema_names(&self) -> impl Iterator<Item=&str>

As all uses of the results here will need to iterate over the names I suspect

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I iniitally tried to implement these returning &[&str] but with the threading requirements I struggled to get anything working that way. I think this would require a larger refactoring to enable, but I'm not 100% sure on that.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vec<&str> might be possible


/// Retrieves a specific schema from the catalog by name, provided it exists.
fn schema(&self, name: &str) -> Option<Arc<dyn SchemaProvider>>;
}

/// Simple in-memory implementation of a catalog.
pub struct MemoryCatalogProvider {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In some other PR perhaps we can put the concrete implementations into their own modules. I don't think this one is big enough to warrant that yet, however; I just wanted to point it out

schemas: RwLock<HashMap<String, Arc<dyn SchemaProvider>>>,
}

impl MemoryCatalogProvider {
/// Instantiates a new MemoryCatalogProvider with an empty collection of schemas.
pub fn new() -> Self {
Self {
schemas: RwLock::new(HashMap::new()),
}
}

/// Adds a new schema to this catalog.
/// If a schema of the same name existed before, it is replaced in the catalog and returned.
pub fn register_schema(
&self,
name: impl Into<String>,
schema: Arc<dyn SchemaProvider>,
) -> Option<Arc<dyn SchemaProvider>> {
let mut schemas = self.schemas.write().unwrap();
schemas.insert(name.into(), schema)
}
}

impl CatalogProvider for MemoryCatalogProvider {
fn as_any(&self) -> &dyn Any {
self
}

fn schema_names(&self) -> Vec<String> {
let schemas = self.schemas.read().unwrap();
schemas.keys().cloned().collect()
}

fn schema(&self, name: &str) -> Option<Arc<dyn SchemaProvider>> {
let schemas = self.schemas.read().unwrap();
schemas.get(name).cloned()
}
}
145 changes: 145 additions & 0 deletions rust/datafusion/src/catalog/mod.rs
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,145 @@
// Licensed to the Apache Software Foundation (ASF) under one
// or more contributor license agreements. See the NOTICE file
// distributed with this work for additional information
// regarding copyright ownership. The ASF licenses this file
// to you under the Apache License, Version 2.0 (the
// "License"); you may not use this file except in compliance
// with the License. You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing,
// software distributed under the License is distributed on an
// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
// KIND, either express or implied. See the License for the
// specific language governing permissions and limitations
// under the License.

//! This module contains interfaces and default implementations
//! of table namespacing concepts, including catalogs and schemas.

pub mod catalog;
pub mod schema;

use crate::error::DataFusionError;
use std::convert::TryFrom;

/// Represents a resolved path to a table of the form "catalog.schema.table"
#[derive(Clone, Copy)]
pub struct ResolvedTableReference<'a> {
/// The catalog (aka database) containing the table
pub catalog: &'a str,
/// The schema containing the table
pub schema: &'a str,
/// The table name
pub table: &'a str,
}

/// Represents a path to a table that may require further resolution
#[derive(Clone, Copy)]
pub enum TableReference<'a> {
/// An unqualified table reference, e.g. "table"
Bare {
/// The table name
table: &'a str,
},
/// A partially resolved table reference, e.g. "schema.table"
Partial {
/// The schema containing the table
schema: &'a str,
/// The table name
table: &'a str,
},
/// A fully resolved table reference, e.g. "catalog.schema.table"
Full {
/// The catalog (aka database) containing the table
catalog: &'a str,
/// The schema containing the table
schema: &'a str,
/// The table name
table: &'a str,
},
}

impl<'a> TableReference<'a> {
/// Retrieve the actual table name, regardless of qualification
pub fn table(&self) -> &str {
match self {
Self::Full { table, .. }
| Self::Partial { table, .. }
| Self::Bare { table } => table,
}
}

/// Given a default catalog and schema, ensure this table reference is fully resolved
pub fn resolve(
self,
default_catalog: &'a str,
default_schema: &'a str,
) -> ResolvedTableReference<'a> {
match self {
Self::Full {
catalog,
schema,
table,
} => ResolvedTableReference {
catalog,
schema,
table,
},
Self::Partial { schema, table } => ResolvedTableReference {
catalog: default_catalog,
schema,
table,
},
Self::Bare { table } => ResolvedTableReference {
catalog: default_catalog,
schema: default_schema,
table,
},
}
}
}

impl<'a> From<&'a str> for TableReference<'a> {
fn from(s: &'a str) -> Self {
Self::Bare { table: s }
}
}

impl<'a> From<ResolvedTableReference<'a>> for TableReference<'a> {
fn from(resolved: ResolvedTableReference<'a>) -> Self {
Self::Full {
catalog: resolved.catalog,
schema: resolved.schema,
table: resolved.table,
}
}
}

impl<'a> TryFrom<&'a sqlparser::ast::ObjectName> for TableReference<'a> {
type Error = DataFusionError;

fn try_from(value: &'a sqlparser::ast::ObjectName) -> Result<Self, Self::Error> {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

let idents = &value.0;

match idents.len() {
1 => Ok(Self::Bare {
table: &idents[0].value,
}),
2 => Ok(Self::Partial {
schema: &idents[0].value,
table: &idents[1].value,
}),
3 => Ok(Self::Full {
catalog: &idents[0].value,
schema: &idents[1].value,
table: &idents[2].value,
}),
_ => Err(DataFusionError::Plan(format!(
"invalid table reference: {}",
value
))),
}
}
}
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions rust/benchmarks/src/bin/tpch.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -157,9 +157,9 @@ async fn benchmark(opt: BenchmarkOpt) -> Result<Vec<arrow::record_batch::RecordB
table,
start.elapsed().as_millis()
);
ctx.register_table(table, Arc::new(memtable));
ctx.register_table(*table, Arc::new(memtable))?;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change to make register_table fallible is a breaking change, but a very reasonable one I think.

} else {
ctx.register_table(table, table_provider);
ctx.register_table(*table, table_provider)?;
}
}

Expand DownExpand Up@@ -1105,7 +1105,7 @@ fn get_table(
table: &str,
table_format: &str,
max_concurrency: usize,
) -> Result<Arc<dyn TableProvider + Send + Sync>> {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW I was confused about this change initially until I saw that you added Send + Sync to the TableProvider trait itself. I think that is a good change (so we don't have to remember to add Send + Sync everywhere)

) -> Result<Arc<dyn TableProvider>> {
match table_format {
// dbgen creates .tbl ('|' delimited) files without header
"tbl" => {
Expand DownExpand Up@@ -1614,7 +1614,7 @@ mod tests {

let provider = MemTable::try_new(Arc::new(schema), vec![vec![batch]])?;

ctx.register_table(table, Arc::new(provider));
ctx.register_table(table, Arc::new(provider))?;
}

let plan = create_logical_plan(&mut ctx, n)?;
Expand Down
2 changes: 1 addition & 1 deletion rust/datafusion/benches/aggregate_query_sql.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -150,7 +150,7 @@ fn create_context(

// declare a table in memory. In spark API, this corresponds to createDataFrame(...).
let provider = MemTable::try_new(schema, partitions)?;
ctx.register_table("t", Arc::new(provider));
ctx.register_table("t", Arc::new(provider))?;

Ok(Arc::new(Mutex::new(ctx)))
}
Expand Down
2 changes: 1 addition & 1 deletion rust/datafusion/benches/filter_query_sql.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -62,7 +62,7 @@ fn create_context(array_len: usize, batch_size: usize) -> Result<ExecutionContex

// declare a table in memory. In spark API, this corresponds to createDataFrame(...).
let provider = MemTable::try_new(schema, vec![batches])?;
ctx.register_table("t", Arc::new(provider));
ctx.register_table("t", Arc::new(provider))?;

Ok(ctx)
}
Expand Down
2 changes: 1 addition & 1 deletion rust/datafusion/benches/math_query_sql.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -72,7 +72,7 @@ fn create_context(

// declare a table in memory. In spark API, this corresponds to createDataFrame(...).
let provider = MemTable::try_new(schema, vec![batches])?;
ctx.register_table("t", Arc::new(provider));
ctx.register_table("t", Arc::new(provider))?;

Ok(Arc::new(Mutex::new(ctx)))
}
Expand Down
3 changes: 2 additions & 1 deletion rust/datafusion/benches/sort_limit_query_sql.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -81,7 +81,8 @@ fn create_context() -> Arc<Mutex<ExecutionContext>> {
// create local execution context
let mut ctx = ExecutionContext::new();
ctx.state.lock().unwrap().config.concurrency = 1;
ctx.register_table("aggregate_test_100", Arc::new(mem_table));
ctx.register_table("aggregate_test_100", Arc::new(mem_table))
.unwrap();
ctx_holder.lock().unwrap().push(Arc::new(Mutex::new(ctx)))
});

Expand Down
2 changes: 1 addition & 1 deletion rust/datafusion/examples/dataframe_in_memory.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -49,7 +49,7 @@ async fn main() -> Result<()> {

// declare a table in memory. In spark API, this corresponds to createDataFrame(...).
let provider = MemTable::try_new(schema, vec![vec![batch]])?;
ctx.register_table("t", Arc::new(provider));
ctx.register_table("t", Arc::new(provider))?;
let df = ctx.table("t")?;

// construct an expression corresponding to "SELECT a, b FROM t WHERE b = 10" in SQL
Expand Down
2 changes: 1 addition & 1 deletion rust/datafusion/examples/simple_udaf.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -48,7 +48,7 @@ fn create_context() -> Result<ExecutionContext> {

// declare a table in memory. In spark API, this corresponds to createDataFrame(...).
let provider = MemTable::try_new(schema, vec![vec![batch1], vec![batch2]])?;
ctx.register_table("t", Arc::new(provider));
ctx.register_table("t", Arc::new(provider))?;
Ok(ctx)
}

Expand Down
2 changes: 1 addition & 1 deletion rust/datafusion/examples/simple_udf.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -50,7 +50,7 @@ fn create_context() -> Result<ExecutionContext> {

// declare a table in memory. In spark API, this corresponds to createDataFrame(...).
let provider = MemTable::try_new(schema, vec![vec![batch]])?;
ctx.register_table("t", Arc::new(provider));
ctx.register_table("t", Arc::new(provider))?;
Ok(ctx)
}

Expand Down
78 changes: 78 additions & 0 deletions rust/datafusion/src/catalog/catalog.rs
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,78 @@
// Licensed to the Apache Software Foundation (ASF) under one
// or more contributor license agreements. See the NOTICE file
// distributed with this work for additional information
// regarding copyright ownership. The ASF licenses this file
// to you under the Apache License, Version 2.0 (the
// "License"); you may not use this file except in compliance
// with the License. You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing,
// software distributed under the License is distributed on an
// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
// KIND, either express or implied. See the License for the
// specific language governing permissions and limitations
// under the License.

//! Describes the interface and built-in implementations of catalogs,

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

//! representing collections of named schemas.

use crate::catalog::schema::SchemaProvider;
use std::any::Any;
use std::collections::HashMap;
use std::sync::{Arc, RwLock};

/// Represents a catalog, comprising a number of named schemas.
pub trait CatalogProvider: Sync + Send {
/// Returns the catalog provider as [`Any`](std::any::Any)
/// so that it can be downcast to a specific implementation.
fn as_any(&self) -> &dyn Any;

/// Retrieves the list of available schema names in this catalog.
fn schema_names(&self) -> Vec<String>;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about returning something more like Vec<&str> to prevent requiring a copy?

Ideally it would be nice if we could do something like

fn schema_names(&self) -> impl Iterator<Item=&str>

As all uses of the results here will need to iterate over the names I suspect

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I iniitally tried to implement these returning &[&str] but with the threading requirements I struggled to get anything working that way. I think this would require a larger refactoring to enable, but I'm not 100% sure on that.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vec<&str> might be possible


/// Retrieves a specific schema from the catalog by name, provided it exists.
fn schema(&self, name: &str) -> Option<Arc<dyn SchemaProvider>>;
}

/// Simple in-memory implementation of a catalog.
pub struct MemoryCatalogProvider {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In some other PR perhaps we can put the concrete implementations into their own modules. I don't think this one is big enough to warrant that yet, however; I just wanted to point it out

schemas: RwLock<HashMap<String, Arc<dyn SchemaProvider>>>,
}

impl MemoryCatalogProvider {
/// Instantiates a new MemoryCatalogProvider with an empty collection of schemas.
pub fn new() -> Self {
Self {
schemas: RwLock::new(HashMap::new()),
}
}

/// Adds a new schema to this catalog.
/// If a schema of the same name existed before, it is replaced in the catalog and returned.
pub fn register_schema(
&self,
name: impl Into<String>,
schema: Arc<dyn SchemaProvider>,
) -> Option<Arc<dyn SchemaProvider>> {
let mut schemas = self.schemas.write().unwrap();
schemas.insert(name.into(), schema)
}
}

impl CatalogProvider for MemoryCatalogProvider {
fn as_any(&self) -> &dyn Any {
self
}

fn schema_names(&self) -> Vec<String> {
let schemas = self.schemas.read().unwrap();
schemas.keys().cloned().collect()
}

fn schema(&self, name: &str) -> Option<Arc<dyn SchemaProvider>> {
let schemas = self.schemas.read().unwrap();
schemas.get(name).cloned()
}
}
145 changes: 145 additions & 0 deletions rust/datafusion/src/catalog/mod.rs
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,145 @@
// Licensed to the Apache Software Foundation (ASF) under one
// or more contributor license agreements. See the NOTICE file
// distributed with this work for additional information
// regarding copyright ownership. The ASF licenses this file
// to you under the Apache License, Version 2.0 (the
// "License"); you may not use this file except in compliance
// with the License. You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing,
// software distributed under the License is distributed on an
// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
// KIND, either express or implied. See the License for the
// specific language governing permissions and limitations
// under the License.

//! This module contains interfaces and default implementations
//! of table namespacing concepts, including catalogs and schemas.

pub mod catalog;
pub mod schema;

use crate::error::DataFusionError;
use std::convert::TryFrom;

/// Represents a resolved path to a table of the form "catalog.schema.table"
#[derive(Clone, Copy)]
pub struct ResolvedTableReference<'a> {
/// The catalog (aka database) containing the table
pub catalog: &'a str,
/// The schema containing the table
pub schema: &'a str,
/// The table name
pub table: &'a str,
}

/// Represents a path to a table that may require further resolution
#[derive(Clone, Copy)]
pub enum TableReference<'a> {
/// An unqualified table reference, e.g. "table"
Bare {
/// The table name
table: &'a str,
},
/// A partially resolved table reference, e.g. "schema.table"
Partial {
/// The schema containing the table
schema: &'a str,
/// The table name
table: &'a str,
},
/// A fully resolved table reference, e.g. "catalog.schema.table"
Full {
/// The catalog (aka database) containing the table
catalog: &'a str,
/// The schema containing the table
schema: &'a str,
/// The table name
table: &'a str,
},
}

impl<'a> TableReference<'a> {
/// Retrieve the actual table name, regardless of qualification
pub fn table(&self) -> &str {
match self {
Self::Full { table, .. }
| Self::Partial { table, .. }
| Self::Bare { table } => table,
}
}

/// Given a default catalog and schema, ensure this table reference is fully resolved
pub fn resolve(
self,
default_catalog: &'a str,
default_schema: &'a str,
) -> ResolvedTableReference<'a> {
match self {
Self::Full {
catalog,
schema,
table,
} => ResolvedTableReference {
catalog,
schema,
table,
},
Self::Partial { schema, table } => ResolvedTableReference {
catalog: default_catalog,
schema,
table,
},
Self::Bare { table } => ResolvedTableReference {
catalog: default_catalog,
schema: default_schema,
table,
},
}
}
}

impl<'a> From<&'a str> for TableReference<'a> {
fn from(s: &'a str) -> Self {
Self::Bare { table: s }
}
}

impl<'a> From<ResolvedTableReference<'a>> for TableReference<'a> {
fn from(resolved: ResolvedTableReference<'a>) -> Self {
Self::Full {
catalog: resolved.catalog,
schema: resolved.schema,
table: resolved.table,
}
}
}

impl<'a> TryFrom<&'a sqlparser::ast::ObjectName> for TableReference<'a> {
type Error = DataFusionError;

fn try_from(value: &'a sqlparser::ast::ObjectName) -> Result<Self, Self::Error> {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

let idents = &value.0;

match idents.len() {
1 => Ok(Self::Bare {
table: &idents[0].value,
}),
2 => Ok(Self::Partial {
schema: &idents[0].value,
table: &idents[1].value,
}),
3 => Ok(Self::Full {
catalog: &idents[0].value,
schema: &idents[1].value,
table: &idents[2].value,
}),
_ => Err(DataFusionError::Plan(format!(
"invalid table reference: {}",
value
))),
}
}
}
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions rust/benchmarks/src/bin/tpch.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -157,9 +157,9 @@ async fn benchmark(opt: BenchmarkOpt) -> Result<Vec<arrow::record_batch::RecordB
table,
start.elapsed().as_millis()
);
ctx.register_table(table, Arc::new(memtable));
ctx.register_table(*table, Arc::new(memtable))?;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change to make register_table fallible is a breaking change, but a very reasonable one I think.

} else {
ctx.register_table(table, table_provider);
ctx.register_table(*table, table_provider)?;
}
}

Expand DownExpand Up@@ -1105,7 +1105,7 @@ fn get_table(
table: &str,
table_format: &str,
max_concurrency: usize,
) -> Result<Arc<dyn TableProvider + Send + Sync>> {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW I was confused about this change initially until I saw that you added Send + Sync to the TableProvider trait itself. I think that is a good change (so we don't have to remember to add Send + Sync everywhere)

) -> Result<Arc<dyn TableProvider>> {
match table_format {
// dbgen creates .tbl ('|' delimited) files without header
"tbl" => {
Expand DownExpand Up@@ -1614,7 +1614,7 @@ mod tests {

let provider = MemTable::try_new(Arc::new(schema), vec![vec![batch]])?;

ctx.register_table(table, Arc::new(provider));
ctx.register_table(table, Arc::new(provider))?;
}

let plan = create_logical_plan(&mut ctx, n)?;
Expand Down
2 changes: 1 addition & 1 deletion rust/datafusion/benches/aggregate_query_sql.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -150,7 +150,7 @@ fn create_context(

// declare a table in memory. In spark API, this corresponds to createDataFrame(...).
let provider = MemTable::try_new(schema, partitions)?;
ctx.register_table("t", Arc::new(provider));
ctx.register_table("t", Arc::new(provider))?;

Ok(Arc::new(Mutex::new(ctx)))
}
Expand Down
2 changes: 1 addition & 1 deletion rust/datafusion/benches/filter_query_sql.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -62,7 +62,7 @@ fn create_context(array_len: usize, batch_size: usize) -> Result<ExecutionContex

// declare a table in memory. In spark API, this corresponds to createDataFrame(...).
let provider = MemTable::try_new(schema, vec![batches])?;
ctx.register_table("t", Arc::new(provider));
ctx.register_table("t", Arc::new(provider))?;

Ok(ctx)
}
Expand Down
2 changes: 1 addition & 1 deletion rust/datafusion/benches/math_query_sql.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -72,7 +72,7 @@ fn create_context(

// declare a table in memory. In spark API, this corresponds to createDataFrame(...).
let provider = MemTable::try_new(schema, vec![batches])?;
ctx.register_table("t", Arc::new(provider));
ctx.register_table("t", Arc::new(provider))?;

Ok(Arc::new(Mutex::new(ctx)))
}
Expand Down
3 changes: 2 additions & 1 deletion rust/datafusion/benches/sort_limit_query_sql.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -81,7 +81,8 @@ fn create_context() -> Arc<Mutex<ExecutionContext>> {
// create local execution context
let mut ctx = ExecutionContext::new();
ctx.state.lock().unwrap().config.concurrency = 1;
ctx.register_table("aggregate_test_100", Arc::new(mem_table));
ctx.register_table("aggregate_test_100", Arc::new(mem_table))
.unwrap();
ctx_holder.lock().unwrap().push(Arc::new(Mutex::new(ctx)))
});

Expand Down
2 changes: 1 addition & 1 deletion rust/datafusion/examples/dataframe_in_memory.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -49,7 +49,7 @@ async fn main() -> Result<()> {

// declare a table in memory. In spark API, this corresponds to createDataFrame(...).
let provider = MemTable::try_new(schema, vec![vec![batch]])?;
ctx.register_table("t", Arc::new(provider));
ctx.register_table("t", Arc::new(provider))?;
let df = ctx.table("t")?;

// construct an expression corresponding to "SELECT a, b FROM t WHERE b = 10" in SQL
Expand Down
2 changes: 1 addition & 1 deletion rust/datafusion/examples/simple_udaf.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -48,7 +48,7 @@ fn create_context() -> Result<ExecutionContext> {

// declare a table in memory. In spark API, this corresponds to createDataFrame(...).
let provider = MemTable::try_new(schema, vec![vec![batch1], vec![batch2]])?;
ctx.register_table("t", Arc::new(provider));
ctx.register_table("t", Arc::new(provider))?;
Ok(ctx)
}

Expand Down
2 changes: 1 addition & 1 deletion rust/datafusion/examples/simple_udf.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -50,7 +50,7 @@ fn create_context() -> Result<ExecutionContext> {

// declare a table in memory. In spark API, this corresponds to createDataFrame(...).
let provider = MemTable::try_new(schema, vec![vec![batch]])?;
ctx.register_table("t", Arc::new(provider));
ctx.register_table("t", Arc::new(provider))?;
Ok(ctx)
}

Expand Down
78 changes: 78 additions & 0 deletions rust/datafusion/src/catalog/catalog.rs
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,78 @@
// Licensed to the Apache Software Foundation (ASF) under one
// or more contributor license agreements. See the NOTICE file
// distributed with this work for additional information
// regarding copyright ownership. The ASF licenses this file
// to you under the Apache License, Version 2.0 (the
// "License"); you may not use this file except in compliance
// with the License. You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing,
// software distributed under the License is distributed on an
// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
// KIND, either express or implied. See the License for the
// specific language governing permissions and limitations
// under the License.

//! Describes the interface and built-in implementations of catalogs,

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

//! representing collections of named schemas.

use crate::catalog::schema::SchemaProvider;
use std::any::Any;
use std::collections::HashMap;
use std::sync::{Arc, RwLock};

/// Represents a catalog, comprising a number of named schemas.
pub trait CatalogProvider: Sync + Send {
/// Returns the catalog provider as [`Any`](std::any::Any)
/// so that it can be downcast to a specific implementation.
fn as_any(&self) -> &dyn Any;

/// Retrieves the list of available schema names in this catalog.
fn schema_names(&self) -> Vec<String>;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about returning something more like Vec<&str> to prevent requiring a copy?

Ideally it would be nice if we could do something like

fn schema_names(&self) -> impl Iterator<Item=&str>

As all uses of the results here will need to iterate over the names I suspect

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I iniitally tried to implement these returning &[&str] but with the threading requirements I struggled to get anything working that way. I think this would require a larger refactoring to enable, but I'm not 100% sure on that.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vec<&str> might be possible


/// Retrieves a specific schema from the catalog by name, provided it exists.
fn schema(&self, name: &str) -> Option<Arc<dyn SchemaProvider>>;
}

/// Simple in-memory implementation of a catalog.
pub struct MemoryCatalogProvider {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In some other PR perhaps we can put the concrete implementations into their own modules. I don't think this one is big enough to warrant that yet, however; I just wanted to point it out

schemas: RwLock<HashMap<String, Arc<dyn SchemaProvider>>>,
}

impl MemoryCatalogProvider {
/// Instantiates a new MemoryCatalogProvider with an empty collection of schemas.
pub fn new() -> Self {
Self {
schemas: RwLock::new(HashMap::new()),
}
}

/// Adds a new schema to this catalog.
/// If a schema of the same name existed before, it is replaced in the catalog and returned.
pub fn register_schema(
&self,
name: impl Into<String>,
schema: Arc<dyn SchemaProvider>,
) -> Option<Arc<dyn SchemaProvider>> {
let mut schemas = self.schemas.write().unwrap();
schemas.insert(name.into(), schema)
}
}

impl CatalogProvider for MemoryCatalogProvider {
fn as_any(&self) -> &dyn Any {
self
}

fn schema_names(&self) -> Vec<String> {
let schemas = self.schemas.read().unwrap();
schemas.keys().cloned().collect()
}

fn schema(&self, name: &str) -> Option<Arc<dyn SchemaProvider>> {
let schemas = self.schemas.read().unwrap();
schemas.get(name).cloned()
}
}
145 changes: 145 additions & 0 deletions rust/datafusion/src/catalog/mod.rs
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,145 @@
// Licensed to the Apache Software Foundation (ASF) under one
// or more contributor license agreements. See the NOTICE file
// distributed with this work for additional information
// regarding copyright ownership. The ASF licenses this file
// to you under the Apache License, Version 2.0 (the
// "License"); you may not use this file except in compliance
// with the License. You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing,
// software distributed under the License is distributed on an
// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
// KIND, either express or implied. See the License for the
// specific language governing permissions and limitations
// under the License.

//! This module contains interfaces and default implementations
//! of table namespacing concepts, including catalogs and schemas.

pub mod catalog;
pub mod schema;

use crate::error::DataFusionError;
use std::convert::TryFrom;

/// Represents a resolved path to a table of the form "catalog.schema.table"
#[derive(Clone, Copy)]
pub struct ResolvedTableReference<'a> {
/// The catalog (aka database) containing the table
pub catalog: &'a str,
/// The schema containing the table
pub schema: &'a str,
/// The table name
pub table: &'a str,
}

/// Represents a path to a table that may require further resolution
#[derive(Clone, Copy)]
pub enum TableReference<'a> {
/// An unqualified table reference, e.g. "table"
Bare {
/// The table name
table: &'a str,
},
/// A partially resolved table reference, e.g. "schema.table"
Partial {
/// The schema containing the table
schema: &'a str,
/// The table name
table: &'a str,
},
/// A fully resolved table reference, e.g. "catalog.schema.table"
Full {
/// The catalog (aka database) containing the table
catalog: &'a str,
/// The schema containing the table
schema: &'a str,
/// The table name
table: &'a str,
},
}

impl<'a> TableReference<'a> {
/// Retrieve the actual table name, regardless of qualification
pub fn table(&self) -> &str {
match self {
Self::Full { table, .. }
| Self::Partial { table, .. }
| Self::Bare { table } => table,
}
}

/// Given a default catalog and schema, ensure this table reference is fully resolved
pub fn resolve(
self,
default_catalog: &'a str,
default_schema: &'a str,
) -> ResolvedTableReference<'a> {
match self {
Self::Full {
catalog,
schema,
table,
} => ResolvedTableReference {
catalog,
schema,
table,
},
Self::Partial { schema, table } => ResolvedTableReference {
catalog: default_catalog,
schema,
table,
},
Self::Bare { table } => ResolvedTableReference {
catalog: default_catalog,
schema: default_schema,
table,
},
}
}
}

impl<'a> From<&'a str> for TableReference<'a> {
fn from(s: &'a str) -> Self {
Self::Bare { table: s }
}
}

impl<'a> From<ResolvedTableReference<'a>> for TableReference<'a> {
fn from(resolved: ResolvedTableReference<'a>) -> Self {
Self::Full {
catalog: resolved.catalog,
schema: resolved.schema,
table: resolved.table,
}
}
}

impl<'a> TryFrom<&'a sqlparser::ast::ObjectName> for TableReference<'a> {
type Error = DataFusionError;

fn try_from(value: &'a sqlparser::ast::ObjectName) -> Result<Self, Self::Error> {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

let idents = &value.0;

match idents.len() {
1 => Ok(Self::Bare {
table: &idents[0].value,
}),
2 => Ok(Self::Partial {
schema: &idents[0].value,
table: &idents[1].value,
}),
3 => Ok(Self::Full {
catalog: &idents[0].value,
schema: &idents[1].value,
table: &idents[2].value,
}),
_ => Err(DataFusionError::Plan(format!(
"invalid table reference: {}",
value
))),
}
}
}
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions rust/benchmarks/src/bin/tpch.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -157,9 +157,9 @@ async fn benchmark(opt: BenchmarkOpt) -> Result<Vec<arrow::record_batch::RecordB
table,
start.elapsed().as_millis()
);
ctx.register_table(table, Arc::new(memtable));
ctx.register_table(*table, Arc::new(memtable))?;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change to make register_table fallible is a breaking change, but a very reasonable one I think.

} else {
ctx.register_table(table, table_provider);
ctx.register_table(*table, table_provider)?;
}
}

Expand DownExpand Up@@ -1105,7 +1105,7 @@ fn get_table(
table: &str,
table_format: &str,
max_concurrency: usize,
) -> Result<Arc<dyn TableProvider + Send + Sync>> {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW I was confused about this change initially until I saw that you added Send + Sync to the TableProvider trait itself. I think that is a good change (so we don't have to remember to add Send + Sync everywhere)

) -> Result<Arc<dyn TableProvider>> {
match table_format {
// dbgen creates .tbl ('|' delimited) files without header
"tbl" => {
Expand DownExpand Up@@ -1614,7 +1614,7 @@ mod tests {

let provider = MemTable::try_new(Arc::new(schema), vec![vec![batch]])?;

ctx.register_table(table, Arc::new(provider));
ctx.register_table(table, Arc::new(provider))?;
}

let plan = create_logical_plan(&mut ctx, n)?;
Expand Down
2 changes: 1 addition & 1 deletion rust/datafusion/benches/aggregate_query_sql.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -150,7 +150,7 @@ fn create_context(

// declare a table in memory. In spark API, this corresponds to createDataFrame(...).
let provider = MemTable::try_new(schema, partitions)?;
ctx.register_table("t", Arc::new(provider));
ctx.register_table("t", Arc::new(provider))?;

Ok(Arc::new(Mutex::new(ctx)))
}
Expand Down
2 changes: 1 addition & 1 deletion rust/datafusion/benches/filter_query_sql.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -62,7 +62,7 @@ fn create_context(array_len: usize, batch_size: usize) -> Result<ExecutionContex

// declare a table in memory. In spark API, this corresponds to createDataFrame(...).
let provider = MemTable::try_new(schema, vec![batches])?;
ctx.register_table("t", Arc::new(provider));
ctx.register_table("t", Arc::new(provider))?;

Ok(ctx)
}
Expand Down
2 changes: 1 addition & 1 deletion rust/datafusion/benches/math_query_sql.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -72,7 +72,7 @@ fn create_context(

// declare a table in memory. In spark API, this corresponds to createDataFrame(...).
let provider = MemTable::try_new(schema, vec![batches])?;
ctx.register_table("t", Arc::new(provider));
ctx.register_table("t", Arc::new(provider))?;

Ok(Arc::new(Mutex::new(ctx)))
}
Expand Down
3 changes: 2 additions & 1 deletion rust/datafusion/benches/sort_limit_query_sql.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -81,7 +81,8 @@ fn create_context() -> Arc<Mutex<ExecutionContext>> {
// create local execution context
let mut ctx = ExecutionContext::new();
ctx.state.lock().unwrap().config.concurrency = 1;
ctx.register_table("aggregate_test_100", Arc::new(mem_table));
ctx.register_table("aggregate_test_100", Arc::new(mem_table))
.unwrap();
ctx_holder.lock().unwrap().push(Arc::new(Mutex::new(ctx)))
});

Expand Down
2 changes: 1 addition & 1 deletion rust/datafusion/examples/dataframe_in_memory.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -49,7 +49,7 @@ async fn main() -> Result<()> {

// declare a table in memory. In spark API, this corresponds to createDataFrame(...).
let provider = MemTable::try_new(schema, vec![vec![batch]])?;
ctx.register_table("t", Arc::new(provider));
ctx.register_table("t", Arc::new(provider))?;
let df = ctx.table("t")?;

// construct an expression corresponding to "SELECT a, b FROM t WHERE b = 10" in SQL
Expand Down
2 changes: 1 addition & 1 deletion rust/datafusion/examples/simple_udaf.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -48,7 +48,7 @@ fn create_context() -> Result<ExecutionContext> {

// declare a table in memory. In spark API, this corresponds to createDataFrame(...).
let provider = MemTable::try_new(schema, vec![vec![batch1], vec![batch2]])?;
ctx.register_table("t", Arc::new(provider));
ctx.register_table("t", Arc::new(provider))?;
Ok(ctx)
}

Expand Down
2 changes: 1 addition & 1 deletion rust/datafusion/examples/simple_udf.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -50,7 +50,7 @@ fn create_context() -> Result<ExecutionContext> {

// declare a table in memory. In spark API, this corresponds to createDataFrame(...).
let provider = MemTable::try_new(schema, vec![vec![batch]])?;
ctx.register_table("t", Arc::new(provider));
ctx.register_table("t", Arc::new(provider))?;
Ok(ctx)
}

Expand Down
78 changes: 78 additions & 0 deletions rust/datafusion/src/catalog/catalog.rs
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,78 @@
// Licensed to the Apache Software Foundation (ASF) under one
// or more contributor license agreements. See the NOTICE file
// distributed with this work for additional information
// regarding copyright ownership. The ASF licenses this file
// to you under the Apache License, Version 2.0 (the
// "License"); you may not use this file except in compliance
// with the License. You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing,
// software distributed under the License is distributed on an
// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
// KIND, either express or implied. See the License for the
// specific language governing permissions and limitations
// under the License.

//! Describes the interface and built-in implementations of catalogs,

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

//! representing collections of named schemas.

use crate::catalog::schema::SchemaProvider;
use std::any::Any;
use std::collections::HashMap;
use std::sync::{Arc, RwLock};

/// Represents a catalog, comprising a number of named schemas.
pub trait CatalogProvider: Sync + Send {
/// Returns the catalog provider as [`Any`](std::any::Any)
/// so that it can be downcast to a specific implementation.
fn as_any(&self) -> &dyn Any;

/// Retrieves the list of available schema names in this catalog.
fn schema_names(&self) -> Vec<String>;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about returning something more like Vec<&str> to prevent requiring a copy?

Ideally it would be nice if we could do something like

fn schema_names(&self) -> impl Iterator<Item=&str>

As all uses of the results here will need to iterate over the names I suspect

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I iniitally tried to implement these returning &[&str] but with the threading requirements I struggled to get anything working that way. I think this would require a larger refactoring to enable, but I'm not 100% sure on that.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vec<&str> might be possible


/// Retrieves a specific schema from the catalog by name, provided it exists.
fn schema(&self, name: &str) -> Option<Arc<dyn SchemaProvider>>;
}

/// Simple in-memory implementation of a catalog.
pub struct MemoryCatalogProvider {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In some other PR perhaps we can put the concrete implementations into their own modules. I don't think this one is big enough to warrant that yet, however; I just wanted to point it out

schemas: RwLock<HashMap<String, Arc<dyn SchemaProvider>>>,
}

impl MemoryCatalogProvider {
/// Instantiates a new MemoryCatalogProvider with an empty collection of schemas.
pub fn new() -> Self {
Self {
schemas: RwLock::new(HashMap::new()),
}
}

/// Adds a new schema to this catalog.
/// If a schema of the same name existed before, it is replaced in the catalog and returned.
pub fn register_schema(
&self,
name: impl Into<String>,
schema: Arc<dyn SchemaProvider>,
) -> Option<Arc<dyn SchemaProvider>> {
let mut schemas = self.schemas.write().unwrap();
schemas.insert(name.into(), schema)
}
}

impl CatalogProvider for MemoryCatalogProvider {
fn as_any(&self) -> &dyn Any {
self
}

fn schema_names(&self) -> Vec<String> {
let schemas = self.schemas.read().unwrap();
schemas.keys().cloned().collect()
}

fn schema(&self, name: &str) -> Option<Arc<dyn SchemaProvider>> {
let schemas = self.schemas.read().unwrap();
schemas.get(name).cloned()
}
}
145 changes: 145 additions & 0 deletions rust/datafusion/src/catalog/mod.rs
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,145 @@
// Licensed to the Apache Software Foundation (ASF) under one
// or more contributor license agreements. See the NOTICE file
// distributed with this work for additional information
// regarding copyright ownership. The ASF licenses this file
// to you under the Apache License, Version 2.0 (the
// "License"); you may not use this file except in compliance
// with the License. You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing,
// software distributed under the License is distributed on an
// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
// KIND, either express or implied. See the License for the
// specific language governing permissions and limitations
// under the License.

//! This module contains interfaces and default implementations
//! of table namespacing concepts, including catalogs and schemas.

pub mod catalog;
pub mod schema;

use crate::error::DataFusionError;
use std::convert::TryFrom;

/// Represents a resolved path to a table of the form "catalog.schema.table"
#[derive(Clone, Copy)]
pub struct ResolvedTableReference<'a> {
/// The catalog (aka database) containing the table
pub catalog: &'a str,
/// The schema containing the table
pub schema: &'a str,
/// The table name
pub table: &'a str,
}

/// Represents a path to a table that may require further resolution
#[derive(Clone, Copy)]
pub enum TableReference<'a> {
/// An unqualified table reference, e.g. "table"
Bare {
/// The table name
table: &'a str,
},
/// A partially resolved table reference, e.g. "schema.table"
Partial {
/// The schema containing the table
schema: &'a str,
/// The table name
table: &'a str,
},
/// A fully resolved table reference, e.g. "catalog.schema.table"
Full {
/// The catalog (aka database) containing the table
catalog: &'a str,
/// The schema containing the table
schema: &'a str,
/// The table name
table: &'a str,
},
}

impl<'a> TableReference<'a> {
/// Retrieve the actual table name, regardless of qualification
pub fn table(&self) -> &str {
match self {
Self::Full { table, .. }
| Self::Partial { table, .. }
| Self::Bare { table } => table,
}
}

/// Given a default catalog and schema, ensure this table reference is fully resolved
pub fn resolve(
self,
default_catalog: &'a str,
default_schema: &'a str,
) -> ResolvedTableReference<'a> {
match self {
Self::Full {
catalog,
schema,
table,
} => ResolvedTableReference {
catalog,
schema,
table,
},
Self::Partial { schema, table } => ResolvedTableReference {
catalog: default_catalog,
schema,
table,
},
Self::Bare { table } => ResolvedTableReference {
catalog: default_catalog,
schema: default_schema,
table,
},
}
}
}

impl<'a> From<&'a str> for TableReference<'a> {
fn from(s: &'a str) -> Self {
Self::Bare { table: s }
}
}

impl<'a> From<ResolvedTableReference<'a>> for TableReference<'a> {
fn from(resolved: ResolvedTableReference<'a>) -> Self {
Self::Full {
catalog: resolved.catalog,
schema: resolved.schema,
table: resolved.table,
}
}
}

impl<'a> TryFrom<&'a sqlparser::ast::ObjectName> for TableReference<'a> {
type Error = DataFusionError;

fn try_from(value: &'a sqlparser::ast::ObjectName) -> Result<Self, Self::Error> {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

let idents = &value.0;

match idents.len() {
1 => Ok(Self::Bare {
table: &idents[0].value,
}),
2 => Ok(Self::Partial {
schema: &idents[0].value,
table: &idents[1].value,
}),
3 => Ok(Self::Full {
catalog: &idents[0].value,
schema: &idents[1].value,
table: &idents[2].value,
}),
_ => Err(DataFusionError::Plan(format!(
"invalid table reference: {}",
value
))),
}
}
}
Loading