ARROW-12034: [Developer Tools] Formalize Minor PRs by emkornfield · Pull Request #9763 · apache/arrow

emkornfield · 2021-03-21T17:33:49Z

No description provided.

github-actions · 2021-03-21T17:34:10Z

Thanks for opening a pull request!

Could you open an issue for this pull request on JIRA?
https://issues.apache.org/jira/browse/ARROW

Then could you also rename pull request title in the following format?

ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}

See also:

emkornfield · 2021-03-21T17:35:22Z

Is there a good way to test this, especially the GHA part?

github-actions · 2021-03-21T17:35:25Z

https://issues.apache.org/jira/browse/ARROW-12034

kou · 2021-03-21T20:58:28Z

The PR title check job is ran on the master branch.

You can test this change by the following:

Push the change to https://github.com/emkornfield/arrow/tree/master (not apache/arrow)
Create a test PR on https://github.com/emkornfield/arrow (not apache/arrow)

e.g.: kou#10 is a test PR that was used to test my change.

emkornfield · 2021-03-28T17:49:33Z

Thanks @kou, finally had a time to test this out. It seems to work. One question is if I should add a GHA that provides positive confirmation that the "MINOR:" title is correct.

kou · 2021-03-28T21:38:25Z

I don't think that we need it but it may be able to implement by the following:

diff --git a/.github/workflows/dev_pr/link.js b/.github/workflows/dev_pr/link.js
index 550a9cd39..c27b5f8f1 100644
--- a/.github/workflows/dev_pr/link.js+++ b/.github/workflows/dev_pr/link.js@@ -19,6 +19,9 @@ function detectJIRAID(title) {
if (!title) {
return null;
}
+ if (title.startsWith("MINOR: ") {+ return "MINOR";+ }
const matched = /^(WIP:?\s*)?((ARROW|PARQUET)-\d+)/.exec(title);
if (!matched) {
return null;
@@ -47,15 +50,20 @@ async function haveComment(github, context, pullRequestNumber, body) {
}
async function commentJIRAURL(github, context, pullRequestNumber, jiraID) {
- const jiraURL = `https://issues.apache.org/jira/browse/${jiraID}`;- if (await haveComment(github, context, pullRequestNumber, jiraURL)) {+ let body;+ if (jiraID === "MINOR") {+ body = 'This is a minor PR.';+ } else {+ body = `https://issues.apache.org/jira/browse/${jiraID}`;+ }+ if (await haveComment(github, context, pullRequestNumber, body)) {
return;
}
await github.issues.createComment({
owner: context.repo.owner,
repo: context.repo.repo,
issue_number: pullRequestNumber,
- body: jiraURL+ body: body
});
}

emkornfield · 2021-03-29T03:06:13Z

@kou I tend to agree it might not be need, just might need some getting used of no GHA if MINOR is specified. If people complain, I'll try adding the proposed diff as a follow-up.

fix indentation

alamb

The basic idea looks good to me. Thank you @emkornfield

I do not know how to test the automation / scripts other than "in production" but that might be ok for this kind of PR

emkornfield · 2021-03-30T16:15:50Z

I do not know how to test the automation / scripts other than "in production" but that might be ok for this kind of PR

@kou gave the pointer of testing on my fork above, which I did.

wesm · 2021-03-30T20:40:18Z

+1 from me on the content

emkornfield · 2021-03-31T04:59:06Z

I'll wait until at least Friday and then merge unless anyone objects.

kou

+1

emkornfield · 2021-03-21T17:33:49Z

No description provided.

github-actions · 2021-03-21T17:34:10Z

Thanks for opening a pull request!

Could you open an issue for this pull request on JIRA?
https://issues.apache.org/jira/browse/ARROW

Then could you also rename pull request title in the following format?

ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}

See also:

emkornfield · 2021-03-21T17:35:22Z

Is there a good way to test this, especially the GHA part?

github-actions · 2021-03-21T17:35:25Z

https://issues.apache.org/jira/browse/ARROW-12034

kou · 2021-03-21T20:58:28Z

The PR title check job is ran on the master branch.

You can test this change by the following:

Push the change to https://github.com/emkornfield/arrow/tree/master (not apache/arrow)
Create a test PR on https://github.com/emkornfield/arrow (not apache/arrow)

e.g.: kou#10 is a test PR that was used to test my change.

emkornfield · 2021-03-28T17:49:33Z

Thanks @kou, finally had a time to test this out. It seems to work. One question is if I should add a GHA that provides positive confirmation that the "MINOR:" title is correct.

kou · 2021-03-28T21:38:25Z

I don't think that we need it but it may be able to implement by the following:

diff --git a/.github/workflows/dev_pr/link.js b/.github/workflows/dev_pr/link.js
index 550a9cd39..c27b5f8f1 100644
--- a/.github/workflows/dev_pr/link.js+++ b/.github/workflows/dev_pr/link.js@@ -19,6 +19,9 @@ function detectJIRAID(title) {
if (!title) {
return null;
}
+ if (title.startsWith("MINOR: ") {+ return "MINOR";+ }
const matched = /^(WIP:?\s*)?((ARROW|PARQUET)-\d+)/.exec(title);
if (!matched) {
return null;
@@ -47,15 +50,20 @@ async function haveComment(github, context, pullRequestNumber, body) {
}
async function commentJIRAURL(github, context, pullRequestNumber, jiraID) {
- const jiraURL = `https://issues.apache.org/jira/browse/${jiraID}`;- if (await haveComment(github, context, pullRequestNumber, jiraURL)) {+ let body;+ if (jiraID === "MINOR") {+ body = 'This is a minor PR.';+ } else {+ body = `https://issues.apache.org/jira/browse/${jiraID}`;+ }+ if (await haveComment(github, context, pullRequestNumber, body)) {
return;
}
await github.issues.createComment({
owner: context.repo.owner,
repo: context.repo.repo,
issue_number: pullRequestNumber,
- body: jiraURL+ body: body
});
}

emkornfield · 2021-03-29T03:06:13Z

@kou I tend to agree it might not be need, just might need some getting used of no GHA if MINOR is specified. If people complain, I'll try adding the proposed diff as a follow-up.

fix indentation

alamb

The basic idea looks good to me. Thank you @emkornfield

I do not know how to test the automation / scripts other than "in production" but that might be ok for this kind of PR

emkornfield · 2021-03-30T16:15:50Z

I do not know how to test the automation / scripts other than "in production" but that might be ok for this kind of PR

@kou gave the pointer of testing on my fork above, which I did.

wesm · 2021-03-30T20:40:18Z

+1 from me on the content

emkornfield · 2021-03-31T04:59:06Z

I'll wait until at least Friday and then merge unless anyone objects.

kou

+1

emkornfield · 2021-03-21T17:33:49Z

No description provided.

github-actions · 2021-03-21T17:34:10Z

Thanks for opening a pull request!

Could you open an issue for this pull request on JIRA?
https://issues.apache.org/jira/browse/ARROW

Then could you also rename pull request title in the following format?

ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}

See also:

emkornfield · 2021-03-21T17:35:22Z

Is there a good way to test this, especially the GHA part?

github-actions · 2021-03-21T17:35:25Z

https://issues.apache.org/jira/browse/ARROW-12034

kou · 2021-03-21T20:58:28Z

The PR title check job is ran on the master branch.

You can test this change by the following:

Push the change to https://github.com/emkornfield/arrow/tree/master (not apache/arrow)
Create a test PR on https://github.com/emkornfield/arrow (not apache/arrow)

e.g.: kou#10 is a test PR that was used to test my change.

emkornfield · 2021-03-28T17:49:33Z

Thanks @kou, finally had a time to test this out. It seems to work. One question is if I should add a GHA that provides positive confirmation that the "MINOR:" title is correct.

kou · 2021-03-28T21:38:25Z

I don't think that we need it but it may be able to implement by the following:

diff --git a/.github/workflows/dev_pr/link.js b/.github/workflows/dev_pr/link.js
index 550a9cd39..c27b5f8f1 100644
--- a/.github/workflows/dev_pr/link.js+++ b/.github/workflows/dev_pr/link.js@@ -19,6 +19,9 @@ function detectJIRAID(title) {
if (!title) {
return null;
}
+ if (title.startsWith("MINOR: ") {+ return "MINOR";+ }
const matched = /^(WIP:?\s*)?((ARROW|PARQUET)-\d+)/.exec(title);
if (!matched) {
return null;
@@ -47,15 +50,20 @@ async function haveComment(github, context, pullRequestNumber, body) {
}
async function commentJIRAURL(github, context, pullRequestNumber, jiraID) {
- const jiraURL = `https://issues.apache.org/jira/browse/${jiraID}`;- if (await haveComment(github, context, pullRequestNumber, jiraURL)) {+ let body;+ if (jiraID === "MINOR") {+ body = 'This is a minor PR.';+ } else {+ body = `https://issues.apache.org/jira/browse/${jiraID}`;+ }+ if (await haveComment(github, context, pullRequestNumber, body)) {
return;
}
await github.issues.createComment({
owner: context.repo.owner,
repo: context.repo.repo,
issue_number: pullRequestNumber,
- body: jiraURL+ body: body
});
}

emkornfield · 2021-03-29T03:06:13Z

@kou I tend to agree it might not be need, just might need some getting used of no GHA if MINOR is specified. If people complain, I'll try adding the proposed diff as a follow-up.

fix indentation

alamb

The basic idea looks good to me. Thank you @emkornfield

I do not know how to test the automation / scripts other than "in production" but that might be ok for this kind of PR

emkornfield · 2021-03-30T16:15:50Z

I do not know how to test the automation / scripts other than "in production" but that might be ok for this kind of PR

@kou gave the pointer of testing on my fork above, which I did.

wesm · 2021-03-30T20:40:18Z

+1 from me on the content

emkornfield · 2021-03-31T04:59:06Z

I'll wait until at least Friday and then merge unless anyone objects.

kou

+1

emkornfield · 2021-03-21T17:33:49Z

No description provided.

github-actions · 2021-03-21T17:34:10Z

Thanks for opening a pull request!

Could you open an issue for this pull request on JIRA?
https://issues.apache.org/jira/browse/ARROW

Then could you also rename pull request title in the following format?

ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}

See also:

emkornfield · 2021-03-21T17:35:22Z

Is there a good way to test this, especially the GHA part?

github-actions · 2021-03-21T17:35:25Z

https://issues.apache.org/jira/browse/ARROW-12034

kou · 2021-03-21T20:58:28Z

The PR title check job is ran on the master branch.

You can test this change by the following:

Push the change to https://github.com/emkornfield/arrow/tree/master (not apache/arrow)
Create a test PR on https://github.com/emkornfield/arrow (not apache/arrow)

e.g.: kou#10 is a test PR that was used to test my change.

emkornfield · 2021-03-28T17:49:33Z

Thanks @kou, finally had a time to test this out. It seems to work. One question is if I should add a GHA that provides positive confirmation that the "MINOR:" title is correct.

kou · 2021-03-28T21:38:25Z

I don't think that we need it but it may be able to implement by the following:

diff --git a/.github/workflows/dev_pr/link.js b/.github/workflows/dev_pr/link.js
index 550a9cd39..c27b5f8f1 100644
--- a/.github/workflows/dev_pr/link.js+++ b/.github/workflows/dev_pr/link.js@@ -19,6 +19,9 @@ function detectJIRAID(title) {
if (!title) {
return null;
}
+ if (title.startsWith("MINOR: ") {+ return "MINOR";+ }
const matched = /^(WIP:?\s*)?((ARROW|PARQUET)-\d+)/.exec(title);
if (!matched) {
return null;
@@ -47,15 +50,20 @@ async function haveComment(github, context, pullRequestNumber, body) {
}
async function commentJIRAURL(github, context, pullRequestNumber, jiraID) {
- const jiraURL = `https://issues.apache.org/jira/browse/${jiraID}`;- if (await haveComment(github, context, pullRequestNumber, jiraURL)) {+ let body;+ if (jiraID === "MINOR") {+ body = 'This is a minor PR.';+ } else {+ body = `https://issues.apache.org/jira/browse/${jiraID}`;+ }+ if (await haveComment(github, context, pullRequestNumber, body)) {
return;
}
await github.issues.createComment({
owner: context.repo.owner,
repo: context.repo.repo,
issue_number: pullRequestNumber,
- body: jiraURL+ body: body
});
}

emkornfield · 2021-03-29T03:06:13Z

@kou I tend to agree it might not be need, just might need some getting used of no GHA if MINOR is specified. If people complain, I'll try adding the proposed diff as a follow-up.

fix indentation

alamb

The basic idea looks good to me. Thank you @emkornfield

I do not know how to test the automation / scripts other than "in production" but that might be ok for this kind of PR

emkornfield · 2021-03-30T16:15:50Z

I do not know how to test the automation / scripts other than "in production" but that might be ok for this kind of PR

@kou gave the pointer of testing on my fork above, which I did.

wesm · 2021-03-30T20:40:18Z

+1 from me on the content

emkornfield · 2021-03-31T04:59:06Z

I'll wait until at least Friday and then merge unless anyone objects.

kou

+1

emkornfield · 2021-03-21T17:33:49Z

No description provided.

github-actions · 2021-03-21T17:34:10Z

Thanks for opening a pull request!

Could you open an issue for this pull request on JIRA?
https://issues.apache.org/jira/browse/ARROW

Then could you also rename pull request title in the following format?

ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}

See also:

emkornfield · 2021-03-21T17:35:22Z

Is there a good way to test this, especially the GHA part?

github-actions · 2021-03-21T17:35:25Z

https://issues.apache.org/jira/browse/ARROW-12034

kou · 2021-03-21T20:58:28Z

The PR title check job is ran on the master branch.

You can test this change by the following:

Push the change to https://github.com/emkornfield/arrow/tree/master (not apache/arrow)
Create a test PR on https://github.com/emkornfield/arrow (not apache/arrow)

e.g.: kou#10 is a test PR that was used to test my change.

emkornfield · 2021-03-28T17:49:33Z

Thanks @kou, finally had a time to test this out. It seems to work. One question is if I should add a GHA that provides positive confirmation that the "MINOR:" title is correct.

kou · 2021-03-28T21:38:25Z

I don't think that we need it but it may be able to implement by the following:

diff --git a/.github/workflows/dev_pr/link.js b/.github/workflows/dev_pr/link.js
index 550a9cd39..c27b5f8f1 100644
--- a/.github/workflows/dev_pr/link.js+++ b/.github/workflows/dev_pr/link.js@@ -19,6 +19,9 @@ function detectJIRAID(title) {
if (!title) {
return null;
}
+ if (title.startsWith("MINOR: ") {+ return "MINOR";+ }
const matched = /^(WIP:?\s*)?((ARROW|PARQUET)-\d+)/.exec(title);
if (!matched) {
return null;
@@ -47,15 +50,20 @@ async function haveComment(github, context, pullRequestNumber, body) {
}
async function commentJIRAURL(github, context, pullRequestNumber, jiraID) {
- const jiraURL = `https://issues.apache.org/jira/browse/${jiraID}`;- if (await haveComment(github, context, pullRequestNumber, jiraURL)) {+ let body;+ if (jiraID === "MINOR") {+ body = 'This is a minor PR.';+ } else {+ body = `https://issues.apache.org/jira/browse/${jiraID}`;+ }+ if (await haveComment(github, context, pullRequestNumber, body)) {
return;
}
await github.issues.createComment({
owner: context.repo.owner,
repo: context.repo.repo,
issue_number: pullRequestNumber,
- body: jiraURL+ body: body
});
}

emkornfield · 2021-03-29T03:06:13Z

@kou I tend to agree it might not be need, just might need some getting used of no GHA if MINOR is specified. If people complain, I'll try adding the proposed diff as a follow-up.

fix indentation

alamb

The basic idea looks good to me. Thank you @emkornfield

I do not know how to test the automation / scripts other than "in production" but that might be ok for this kind of PR

emkornfield · 2021-03-30T16:15:50Z

I do not know how to test the automation / scripts other than "in production" but that might be ok for this kind of PR

@kou gave the pointer of testing on my fork above, which I did.

wesm · 2021-03-30T20:40:18Z

+1 from me on the content

emkornfield · 2021-03-31T04:59:06Z

I'll wait until at least Friday and then merge unless anyone objects.

kou

+1

emkornfield · 2021-03-21T17:33:49Z

No description provided.

github-actions · 2021-03-21T17:34:10Z

Thanks for opening a pull request!

Could you open an issue for this pull request on JIRA?
https://issues.apache.org/jira/browse/ARROW

Then could you also rename pull request title in the following format?

ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}

See also:

emkornfield · 2021-03-21T17:35:22Z

Is there a good way to test this, especially the GHA part?

github-actions · 2021-03-21T17:35:25Z

https://issues.apache.org/jira/browse/ARROW-12034

kou · 2021-03-21T20:58:28Z

The PR title check job is ran on the master branch.

You can test this change by the following:

Push the change to https://github.com/emkornfield/arrow/tree/master (not apache/arrow)
Create a test PR on https://github.com/emkornfield/arrow (not apache/arrow)

e.g.: kou#10 is a test PR that was used to test my change.

emkornfield · 2021-03-28T17:49:33Z

Thanks @kou, finally had a time to test this out. It seems to work. One question is if I should add a GHA that provides positive confirmation that the "MINOR:" title is correct.

kou · 2021-03-28T21:38:25Z

I don't think that we need it but it may be able to implement by the following:

diff --git a/.github/workflows/dev_pr/link.js b/.github/workflows/dev_pr/link.js
index 550a9cd39..c27b5f8f1 100644
--- a/.github/workflows/dev_pr/link.js+++ b/.github/workflows/dev_pr/link.js@@ -19,6 +19,9 @@ function detectJIRAID(title) {
if (!title) {
return null;
}
+ if (title.startsWith("MINOR: ") {+ return "MINOR";+ }
const matched = /^(WIP:?\s*)?((ARROW|PARQUET)-\d+)/.exec(title);
if (!matched) {
return null;
@@ -47,15 +50,20 @@ async function haveComment(github, context, pullRequestNumber, body) {
}
async function commentJIRAURL(github, context, pullRequestNumber, jiraID) {
- const jiraURL = `https://issues.apache.org/jira/browse/${jiraID}`;- if (await haveComment(github, context, pullRequestNumber, jiraURL)) {+ let body;+ if (jiraID === "MINOR") {+ body = 'This is a minor PR.';+ } else {+ body = `https://issues.apache.org/jira/browse/${jiraID}`;+ }+ if (await haveComment(github, context, pullRequestNumber, body)) {
return;
}
await github.issues.createComment({
owner: context.repo.owner,
repo: context.repo.repo,
issue_number: pullRequestNumber,
- body: jiraURL+ body: body
});
}

emkornfield · 2021-03-29T03:06:13Z

@kou I tend to agree it might not be need, just might need some getting used of no GHA if MINOR is specified. If people complain, I'll try adding the proposed diff as a follow-up.

fix indentation

alamb

The basic idea looks good to me. Thank you @emkornfield

I do not know how to test the automation / scripts other than "in production" but that might be ok for this kind of PR

emkornfield · 2021-03-30T16:15:50Z

I do not know how to test the automation / scripts other than "in production" but that might be ok for this kind of PR

@kou gave the pointer of testing on my fork above, which I did.

wesm · 2021-03-30T20:40:18Z

+1 from me on the content

emkornfield · 2021-03-31T04:59:06Z

I'll wait until at least Friday and then merge unless anyone objects.

kou

+1

emkornfield · 2021-03-21T17:33:49Z

No description provided.

github-actions · 2021-03-21T17:34:10Z

Thanks for opening a pull request!

Could you open an issue for this pull request on JIRA?
https://issues.apache.org/jira/browse/ARROW

Then could you also rename pull request title in the following format?

ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}

See also:

emkornfield · 2021-03-21T17:35:22Z

Is there a good way to test this, especially the GHA part?

github-actions · 2021-03-21T17:35:25Z

https://issues.apache.org/jira/browse/ARROW-12034

kou · 2021-03-21T20:58:28Z

The PR title check job is ran on the master branch.

You can test this change by the following:

Push the change to https://github.com/emkornfield/arrow/tree/master (not apache/arrow)
Create a test PR on https://github.com/emkornfield/arrow (not apache/arrow)

e.g.: kou#10 is a test PR that was used to test my change.

emkornfield · 2021-03-28T17:49:33Z

Thanks @kou, finally had a time to test this out. It seems to work. One question is if I should add a GHA that provides positive confirmation that the "MINOR:" title is correct.

kou · 2021-03-28T21:38:25Z

I don't think that we need it but it may be able to implement by the following:

diff --git a/.github/workflows/dev_pr/link.js b/.github/workflows/dev_pr/link.js
index 550a9cd39..c27b5f8f1 100644
--- a/.github/workflows/dev_pr/link.js+++ b/.github/workflows/dev_pr/link.js@@ -19,6 +19,9 @@ function detectJIRAID(title) {
if (!title) {
return null;
}
+ if (title.startsWith("MINOR: ") {+ return "MINOR";+ }
const matched = /^(WIP:?\s*)?((ARROW|PARQUET)-\d+)/.exec(title);
if (!matched) {
return null;
@@ -47,15 +50,20 @@ async function haveComment(github, context, pullRequestNumber, body) {
}
async function commentJIRAURL(github, context, pullRequestNumber, jiraID) {
- const jiraURL = `https://issues.apache.org/jira/browse/${jiraID}`;- if (await haveComment(github, context, pullRequestNumber, jiraURL)) {+ let body;+ if (jiraID === "MINOR") {+ body = 'This is a minor PR.';+ } else {+ body = `https://issues.apache.org/jira/browse/${jiraID}`;+ }+ if (await haveComment(github, context, pullRequestNumber, body)) {
return;
}
await github.issues.createComment({
owner: context.repo.owner,
repo: context.repo.repo,
issue_number: pullRequestNumber,
- body: jiraURL+ body: body
});
}

emkornfield · 2021-03-29T03:06:13Z

@kou I tend to agree it might not be need, just might need some getting used of no GHA if MINOR is specified. If people complain, I'll try adding the proposed diff as a follow-up.

fix indentation

alamb

The basic idea looks good to me. Thank you @emkornfield

I do not know how to test the automation / scripts other than "in production" but that might be ok for this kind of PR

emkornfield · 2021-03-30T16:15:50Z

I do not know how to test the automation / scripts other than "in production" but that might be ok for this kind of PR

@kou gave the pointer of testing on my fork above, which I did.

wesm · 2021-03-30T20:40:18Z

+1 from me on the content

emkornfield · 2021-03-31T04:59:06Z

I'll wait until at least Friday and then merge unless anyone objects.

kou

+1

emkornfield · 2021-03-21T17:33:49Z

No description provided.

github-actions · 2021-03-21T17:34:10Z

Thanks for opening a pull request!

Could you open an issue for this pull request on JIRA?
https://issues.apache.org/jira/browse/ARROW

Then could you also rename pull request title in the following format?

ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}

See also:

emkornfield · 2021-03-21T17:35:22Z

Is there a good way to test this, especially the GHA part?

github-actions · 2021-03-21T17:35:25Z

https://issues.apache.org/jira/browse/ARROW-12034

kou · 2021-03-21T20:58:28Z

The PR title check job is ran on the master branch.

You can test this change by the following:

Push the change to https://github.com/emkornfield/arrow/tree/master (not apache/arrow)
Create a test PR on https://github.com/emkornfield/arrow (not apache/arrow)

e.g.: kou#10 is a test PR that was used to test my change.

emkornfield · 2021-03-28T17:49:33Z

Thanks @kou, finally had a time to test this out. It seems to work. One question is if I should add a GHA that provides positive confirmation that the "MINOR:" title is correct.

kou · 2021-03-28T21:38:25Z

I don't think that we need it but it may be able to implement by the following:

diff --git a/.github/workflows/dev_pr/link.js b/.github/workflows/dev_pr/link.js
index 550a9cd39..c27b5f8f1 100644
--- a/.github/workflows/dev_pr/link.js+++ b/.github/workflows/dev_pr/link.js@@ -19,6 +19,9 @@ function detectJIRAID(title) {
if (!title) {
return null;
}
+ if (title.startsWith("MINOR: ") {+ return "MINOR";+ }
const matched = /^(WIP:?\s*)?((ARROW|PARQUET)-\d+)/.exec(title);
if (!matched) {
return null;
@@ -47,15 +50,20 @@ async function haveComment(github, context, pullRequestNumber, body) {
}
async function commentJIRAURL(github, context, pullRequestNumber, jiraID) {
- const jiraURL = `https://issues.apache.org/jira/browse/${jiraID}`;- if (await haveComment(github, context, pullRequestNumber, jiraURL)) {+ let body;+ if (jiraID === "MINOR") {+ body = 'This is a minor PR.';+ } else {+ body = `https://issues.apache.org/jira/browse/${jiraID}`;+ }+ if (await haveComment(github, context, pullRequestNumber, body)) {
return;
}
await github.issues.createComment({
owner: context.repo.owner,
repo: context.repo.repo,
issue_number: pullRequestNumber,
- body: jiraURL+ body: body
});
}

emkornfield · 2021-03-29T03:06:13Z

@kou I tend to agree it might not be need, just might need some getting used of no GHA if MINOR is specified. If people complain, I'll try adding the proposed diff as a follow-up.

fix indentation

alamb

The basic idea looks good to me. Thank you @emkornfield

I do not know how to test the automation / scripts other than "in production" but that might be ok for this kind of PR

emkornfield · 2021-03-30T16:15:50Z

I do not know how to test the automation / scripts other than "in production" but that might be ok for this kind of PR

@kou gave the pointer of testing on my fork above, which I did.

wesm · 2021-03-30T20:40:18Z

+1 from me on the content

emkornfield · 2021-03-31T04:59:06Z

I'll wait until at least Friday and then merge unless anyone objects.

kou

+1

emkornfield changed the title ~~[Developer Tools] Formalize Minor PRs~~ARROW-12034: [Developer Tools] Formalize Minor PRsMar 21, 2021

emkornfield added 2 commits March 28, 2021 10:41

ARROW-12034: [Developer Tools] Formalize Minor PRs
3b328b1

fix more typos
28dca1b

emkornfield force-pushed the trivial_prs branch from 354b522 to 28dca1bCompare March 28, 2021 17:48

Update merge_arrow_pr.py
fe595e3
fix indentation

alamb approved these changes Mar 30, 2021
View reviewed changes

kou approved these changes Mar 31, 2021
View reviewed changes

emkornfield closed this in 5cabd31Apr 4, 2021

emkornfield deleted the trivial_prs branch April 7, 2021 15:38

asfimport mentioned this pull request Apr 4, 2021
[Docs] Formalize Minor PRs #27863
Closed

emkornfield changed the title ~~[Developer Tools] Formalize Minor PRs~~ARROW-12034: [Developer Tools] Formalize Minor PRsMar 21, 2021

emkornfield added 2 commits March 28, 2021 10:41

ARROW-12034: [Developer Tools] Formalize Minor PRs
3b328b1

fix more typos
28dca1b

emkornfield force-pushed the trivial_prs branch from 354b522 to 28dca1bCompare March 28, 2021 17:48

Update merge_arrow_pr.py
fe595e3
fix indentation

alamb approved these changes Mar 30, 2021
View reviewed changes

kou approved these changes Mar 31, 2021
View reviewed changes

emkornfield closed this in 5cabd31Apr 4, 2021

emkornfield deleted the trivial_prs branch April 7, 2021 15:38

asfimport mentioned this pull request Apr 4, 2021
[Docs] Formalize Minor PRs #27863
Closed

emkornfield changed the title ~~[Developer Tools] Formalize Minor PRs~~ARROW-12034: [Developer Tools] Formalize Minor PRsMar 21, 2021

emkornfield added 2 commits March 28, 2021 10:41

ARROW-12034: [Developer Tools] Formalize Minor PRs
3b328b1

fix more typos
28dca1b

emkornfield force-pushed the trivial_prs branch from 354b522 to 28dca1bCompare March 28, 2021 17:48

Update merge_arrow_pr.py
fe595e3
fix indentation

alamb approved these changes Mar 30, 2021
View reviewed changes

kou approved these changes Mar 31, 2021
View reviewed changes

emkornfield closed this in 5cabd31Apr 4, 2021

emkornfield deleted the trivial_prs branch April 7, 2021 15:38

asfimport mentioned this pull request Apr 4, 2021
[Docs] Formalize Minor PRs #27863
Closed

emkornfield changed the title ~~[Developer Tools] Formalize Minor PRs~~ARROW-12034: [Developer Tools] Formalize Minor PRsMar 21, 2021

emkornfield added 2 commits March 28, 2021 10:41

ARROW-12034: [Developer Tools] Formalize Minor PRs
3b328b1

fix more typos
28dca1b

emkornfield force-pushed the trivial_prs branch from 354b522 to 28dca1bCompare March 28, 2021 17:48

Update merge_arrow_pr.py
fe595e3
fix indentation

alamb approved these changes Mar 30, 2021
View reviewed changes

kou approved these changes Mar 31, 2021
View reviewed changes

emkornfield closed this in 5cabd31Apr 4, 2021

emkornfield deleted the trivial_prs branch April 7, 2021 15:38

asfimport mentioned this pull request Apr 4, 2021
[Docs] Formalize Minor PRs #27863
Closed

emkornfield changed the title ~~[Developer Tools] Formalize Minor PRs~~ARROW-12034: [Developer Tools] Formalize Minor PRsMar 21, 2021

emkornfield added 2 commits March 28, 2021 10:41

ARROW-12034: [Developer Tools] Formalize Minor PRs
3b328b1

fix more typos
28dca1b

emkornfield force-pushed the trivial_prs branch from 354b522 to 28dca1bCompare March 28, 2021 17:48

Update merge_arrow_pr.py
fe595e3
fix indentation

alamb approved these changes Mar 30, 2021
View reviewed changes

kou approved these changes Mar 31, 2021
View reviewed changes

emkornfield closed this in 5cabd31Apr 4, 2021

emkornfield deleted the trivial_prs branch April 7, 2021 15:38

asfimport mentioned this pull request Apr 4, 2021
[Docs] Formalize Minor PRs #27863
Closed

emkornfield changed the title ~~[Developer Tools] Formalize Minor PRs~~ARROW-12034: [Developer Tools] Formalize Minor PRsMar 21, 2021

emkornfield added 2 commits March 28, 2021 10:41

ARROW-12034: [Developer Tools] Formalize Minor PRs
3b328b1

fix more typos
28dca1b

emkornfield force-pushed the trivial_prs branch from 354b522 to 28dca1bCompare March 28, 2021 17:48

Update merge_arrow_pr.py
fe595e3
fix indentation

alamb approved these changes Mar 30, 2021
View reviewed changes

kou approved these changes Mar 31, 2021
View reviewed changes

emkornfield closed this in 5cabd31Apr 4, 2021

emkornfield deleted the trivial_prs branch April 7, 2021 15:38

asfimport mentioned this pull request Apr 4, 2021
[Docs] Formalize Minor PRs #27863
Closed

emkornfield changed the title ~~[Developer Tools] Formalize Minor PRs~~ARROW-12034: [Developer Tools] Formalize Minor PRsMar 21, 2021

emkornfield added 2 commits March 28, 2021 10:41

ARROW-12034: [Developer Tools] Formalize Minor PRs
3b328b1

fix more typos
28dca1b

emkornfield force-pushed the trivial_prs branch from 354b522 to 28dca1bCompare March 28, 2021 17:48

Update merge_arrow_pr.py
fe595e3
fix indentation

alamb approved these changes Mar 30, 2021
View reviewed changes

kou approved these changes Mar 31, 2021
View reviewed changes

emkornfield closed this in 5cabd31Apr 4, 2021

emkornfield deleted the trivial_prs branch April 7, 2021 15:38

asfimport mentioned this pull request Apr 4, 2021
[Docs] Formalize Minor PRs #27863
Closed

emkornfield changed the title ~~[Developer Tools] Formalize Minor PRs~~ARROW-12034: [Developer Tools] Formalize Minor PRsMar 21, 2021

emkornfield added 2 commits March 28, 2021 10:41

ARROW-12034: [Developer Tools] Formalize Minor PRs
3b328b1

fix more typos
28dca1b

emkornfield force-pushed the trivial_prs branch from 354b522 to 28dca1bCompare March 28, 2021 17:48

Update merge_arrow_pr.py
fe595e3
fix indentation

alamb approved these changes Mar 30, 2021
View reviewed changes

kou approved these changes Mar 31, 2021
View reviewed changes

emkornfield closed this in 5cabd31Apr 4, 2021

emkornfield deleted the trivial_prs branch April 7, 2021 15:38

asfimport mentioned this pull request Apr 4, 2021
[Docs] Formalize Minor PRs #27863
Closed

Uh oh!

Conversation

emkornfield commented Mar 21, 2021

Uh oh!

github-actionsBot commented Mar 21, 2021

Uh oh!

emkornfield commented Mar 21, 2021

Uh oh!

github-actionsBot commented Mar 21, 2021

Uh oh!

kou commented Mar 21, 2021

Uh oh!

emkornfield commented Mar 28, 2021

Uh oh!

kou commented Mar 28, 2021

Uh oh!

emkornfield commented Mar 29, 2021

Uh oh!

alamb left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

emkornfield commented Mar 30, 2021

Uh oh!

wesm commented Mar 30, 2021

Uh oh!

emkornfield commented Mar 31, 2021

Uh oh!

kou left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

emkornfield commented Mar 21, 2021

Uh oh!

github-actionsBot commented Mar 21, 2021

Uh oh!

emkornfield commented Mar 21, 2021

Uh oh!

github-actionsBot commented Mar 21, 2021

Uh oh!

kou commented Mar 21, 2021

Uh oh!

emkornfield commented Mar 28, 2021

Uh oh!

kou commented Mar 28, 2021

Uh oh!

emkornfield commented Mar 29, 2021

Uh oh!

alamb left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

emkornfield commented Mar 30, 2021

Uh oh!

wesm commented Mar 30, 2021

Uh oh!

emkornfield commented Mar 31, 2021

Uh oh!

kou left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

alamb left a comment •
edited
Loading

alamb left a comment •
edited
Loading

alamb left a comment •
edited
Loading