Uh oh!
There was an error while loading. Please reload this page.
ARROW-11259: [Python][Dataset] Allow creating nested field ref - #9799
ARROW-11259: [Python][Dataset] Allow creating nested field ref#9799pitrou wants to merge 1 commit into
Conversation
We can't yet filter on a nested field ref, so this merely adds syntactical support.
bkietz
left a comment
There was a problem hiding this comment.
This patch seems well put together of itself, but does it add value to support construction of nested field references if we can't filter on them yet? It seems first we should refactor the parts of scan which depend on non nested field refs (ScanOptions::MaterializedFields, SetProjection) before exposing anything in python
pitrou
commented
Mar 24, 2021
Probably not, but it also should be relatively orthogonal to future refactors? |
jorisvandenbossche
commented
Mar 25, 2021
We do plan to support nested field references in filters? If so I am fine with already merging this, but no strong opinion. |
pitrou
commented
Jun 23, 2021
Should I close this PR? @bkietz |
jorisvandenbossche
commented
Nov 10, 2021
Now there is actual support for nested field refs (#11466), this PR can be revived? |
pitrou
commented
Dec 13, 2021
@jorisvandenbossche Do you want to take it up? |
jorisvandenbossche
commented
Dec 14, 2021
Yes, will do |
This PR tries to redo the work from #9799. It will unblock: - https://issues.apache.org/jira/browse/ARROW-13798 - https://issues.apache.org/jira/browse/ARROW-14596 cc @jorisvandenbossche@pitrouCloses#12863 from AlenkaF/ARROW-11259 Lead-authored-by: Alenka Frim <frim.alenka@gmail.com> Co-authored-by: Antoine Pitrou <antoine@python.org> Signed-off-by: Antoine Pitrou <antoine@python.org>
We can't yet filter on a nested field ref, so this merely adds syntactical support.