Skip to content

ARROW-11336: [C++][Doc] Improve Developing on Windows docs - #9855

Closed
ianmcook wants to merge 11 commits into
apache:masterfrom
ianmcook:ARROW-11336
Closed

ARROW-11336: [C++][Doc] Improve Developing on Windows docs#9855
ianmcook wants to merge 11 commits into
apache:masterfrom
ianmcook:ARROW-11336

Conversation

@ianmcook

@ianmcookianmcook commented Mar 30, 2021•
edited
Loading

Copy link
Copy Markdown
Member
  • Improves the Developing on Windows docs
    • Adds instructions for Visual Studio 2019 users
    • Documents how to use vcpkg to install Arrow dependencies on Windows
    • Improves some ambiguous instructions and fixes minor errors
  • Adds more mentions of vcpkg to the Building Arrow C++ docs
  • Describes how to open the Visual Studio IDE with a conda environment activated (ARROW-11192)

@github-actions

github-actionsBot commented Mar 31, 2021

Copy link
Copy Markdown

https://issues.apache.org/jira/browse/ARROW-11336

@ianmcookianmcook changed the title ARROW-11336: [C++][Doc] Improve Developing on Windows docs [WIP]ARROW-11336: [C++][Doc] Improve Developing on Windows docsMar 31, 2021
@ianmcook
ianmcook marked this pull request as ready for review March 31, 2021 15:59
@ianmcook

ianmcook commented Mar 31, 2021

Copy link
Copy Markdown
MemberAuthor

@bkietz please review

jorisvandenbossche
jorisvandenbossche reviewed Apr 1, 2021
View reviewed changes

@jorisvandenbosschejorisvandenbossche left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't use windows, so can't comment on the content ;) But was just reading through (looks good!), and have one small sphinx suggestion

Comment threaddocs/source/developers/cpp/windows.rst Outdated
pitrou
pitrou reviewed Apr 1, 2021
View reviewed changes

@pitroupitrou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good generally, two small comments.

Comment threaddocs/source/developers/cpp/windows.rst Outdated
Comment threaddocs/source/developers/cpp/windows.rst Outdated
bkietz
bkietz requested changes Apr 6, 2021
View reviewed changes

@bkietzbkietz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comments, otherwise this looks good

Comment threaddocs/source/developers/cpp/windows.rst Outdated
Comment threaddocs/source/developers/cpp/windows.rst Outdated
Comment threaddocs/source/developers/cpp/windows.rst Outdated
@ianmcook
ianmcook requested a review from bkietzApril 7, 2021 19:54
@bkietzbkietz closed this in c736034Apr 8, 2021
@asfimportasfimport mentioned this pull request Apr 8, 2021
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jorisvandenbosschejorisvandenbosschejorisvandenbossche left review comments
@pitroupitroupitrou left review comments
@bkietzbkietzbkietz approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ianmcook@jorisvandenbossche@bkietz@pitrou