ARROW-12165: [Rust] inline append functions of builders#9860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ritchie46 wants to merge 1 commit into from
Closed

ARROW-12165: [Rust] inline append functions of builders #9860

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 30 additions & 0 deletions rust/arrow/src/array/builder.rs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -433,20 +433,23 @@ impl BooleanBuilder {
}

/// Appends a value of type `T` into the builder
#[inline]
pub fn append_value(&mut self, v: bool) -> Result<()> {
self.bitmap_builder.append(true);
self.values_builder.append(v);
Ok(())
}

/// Appends a null slot into the builder
#[inline]
pub fn append_null(&mut self) -> Result<()> {
self.bitmap_builder.append(false);
self.values_builder.advance(1);
Ok(())
}

/// Appends an `Option<T>` into the builder
#[inline]
pub fn append_option(&mut self, v: Option<bool>) -> Result<()> {
match v {
None => self.append_null()?,
Expand All@@ -456,13 +459,15 @@ impl BooleanBuilder {
}

/// Appends a slice of type `T` into the builder
#[inline]
pub fn append_slice(&mut self, v: &[bool]) -> Result<()> {
self.bitmap_builder.append_n(v.len(), true);
self.values_builder.append_slice(v);
Ok(())
}

/// Appends values from a slice of type `T` and a validity boolean slice
#[inline]
pub fn append_values(&mut self, values: &[bool], is_valid: &[bool]) -> Result<()> {
if values.len() != is_valid.len() {
return Err(ArrowError::InvalidArgumentError(
Expand DownExpand Up@@ -578,6 +583,7 @@ impl<T: ArrowPrimitiveType> PrimitiveBuilder<T> {
}

/// Appends a value of type `T` into the builder
#[inline]
pub fn append_value(&mut self, v: T::Native) -> Result<()> {
if let Some(b) = self.bitmap_builder.as_mut() {
b.append(true);
Expand All@@ -587,6 +593,7 @@ impl<T: ArrowPrimitiveType> PrimitiveBuilder<T> {
}

/// Appends a null slot into the builder
#[inline]
pub fn append_null(&mut self) -> Result<()> {
self.materialize_bitmap_builder();
self.bitmap_builder.as_mut().unwrap().append(false);
Expand All@@ -595,6 +602,7 @@ impl<T: ArrowPrimitiveType> PrimitiveBuilder<T> {
}

/// Appends an `Option<T>` into the builder
#[inline]
pub fn append_option(&mut self, v: Option<T::Native>) -> Result<()> {
match v {
None => self.append_null()?,
Expand All@@ -604,6 +612,7 @@ impl<T: ArrowPrimitiveType> PrimitiveBuilder<T> {
}

/// Appends a slice of type `T` into the builder
#[inline]
pub fn append_slice(&mut self, v: &[T::Native]) -> Result<()> {
if let Some(b) = self.bitmap_builder.as_mut() {
b.append_n(v.len(), true);
Expand All@@ -613,6 +622,7 @@ impl<T: ArrowPrimitiveType> PrimitiveBuilder<T> {
}

/// Appends values from a slice of type `T` and a validity boolean slice
#[inline]
pub fn append_values(
&mut self,
values: &[T::Native],
Expand DownExpand Up@@ -766,6 +776,7 @@ where
}

/// Finish the current variable-length list array slot
#[inline]
pub fn append(&mut self, is_valid: bool) -> Result<()> {
self.offsets_builder
.append(OffsetSize::from_usize(self.values_builder.len()).unwrap());
Expand DownExpand Up@@ -897,6 +908,7 @@ where
}

/// Finish the current variable-length list array slot
#[inline]
pub fn append(&mut self, is_valid: bool) -> Result<()> {
self.bitmap_builder.append(is_valid);
self.len += 1;
Expand DownExpand Up@@ -1115,6 +1127,7 @@ impl<OffsetSize: BinaryOffsetSizeTrait> GenericBinaryBuilder<OffsetSize> {
///
/// Note, when appending individual byte values you must call `append` to delimit each
/// distinct list value.
#[inline]
pub fn append_byte(&mut self, value: u8) -> Result<()> {
self.builder.values().append_value(value)?;
Ok(())
Expand All@@ -1124,18 +1137,21 @@ impl<OffsetSize: BinaryOffsetSizeTrait> GenericBinaryBuilder<OffsetSize> {
///
/// Automatically calls the `append` method to delimit the slice appended in as a
/// distinct array element.
#[inline]
pub fn append_value(&mut self, value: impl AsRef<[u8]>) -> Result<()> {
self.builder.values().append_slice(value.as_ref())?;
self.builder.append(true)?;
Ok(())
}

/// Finish the current variable-length list array slot.
#[inline]
pub fn append(&mut self, is_valid: bool) -> Result<()> {
self.builder.append(is_valid)
}

/// Append a null value to the array.
#[inline]
pub fn append_null(&mut self) -> Result<()> {
self.append(false)
}
Expand DownExpand Up@@ -1170,6 +1186,7 @@ impl<OffsetSize: StringOffsetSizeTrait> GenericStringBuilder<OffsetSize> {
///
/// Automatically calls the `append` method to delimit the string appended in as a
/// distinct array element.
#[inline]
pub fn append_value(&mut self, value: impl AsRef<str>) -> Result<()> {
self.builder
.values()
Expand All@@ -1179,11 +1196,13 @@ impl<OffsetSize: StringOffsetSizeTrait> GenericStringBuilder<OffsetSize> {
}

/// Finish the current variable-length list array slot.
#[inline]
pub fn append(&mut self, is_valid: bool) -> Result<()> {
self.builder.append(is_valid)
}

/// Append a null value to the array.
#[inline]
pub fn append_null(&mut self) -> Result<()> {
self.append(false)
}
Expand All@@ -1208,6 +1227,7 @@ impl FixedSizeBinaryBuilder {
///
/// Automatically calls the `append` method to delimit the slice appended in as a
/// distinct array element.
#[inline]
pub fn append_value(&mut self, value: impl AsRef<[u8]>) -> Result<()> {
if self.builder.value_length() != value.as_ref().len() as i32 {
return Err(ArrowError::InvalidArgumentError(
Expand All@@ -1219,6 +1239,7 @@ impl FixedSizeBinaryBuilder {
}

/// Append a null value to the array.
#[inline]
pub fn append_null(&mut self) -> Result<()> {
let length: usize = self.builder.value_length() as usize;
self.builder.values().append_slice(&vec![0u8; length][..])?;
Expand DownExpand Up@@ -1248,6 +1269,7 @@ impl DecimalBuilder {
///
/// Automatically calls the `append` method to delimit the slice appended in as a
/// distinct array element.
#[inline]
pub fn append_value(&mut self, value: i128) -> Result<()> {
let value_as_bytes = Self::from_i128_to_fixed_size_bytes(
value,
Expand DownExpand Up@@ -1276,6 +1298,7 @@ impl DecimalBuilder {
}

/// Append a null value to the array.
#[inline]
pub fn append_null(&mut self) -> Result<()> {
let length: usize = self.builder.value_length() as usize;
self.builder.values().append_slice(&vec![0u8; length][..])?;
Expand DownExpand Up@@ -1465,13 +1488,15 @@ impl StructBuilder {

/// Appends an element (either null or non-null) to the struct. The actual elements
/// should be appended for each child sub-array in a consistent way.
#[inline]
pub fn append(&mut self, is_valid: bool) -> Result<()> {
self.bitmap_builder.append(is_valid);
self.len += 1;
Ok(())
}

/// Appends a null element to the struct.
#[inline]
pub fn append_null(&mut self) -> Result<()> {
self.append(false)
}
Expand DownExpand Up@@ -1649,6 +1674,7 @@ impl UnionBuilder {
}

/// Appends a null to this builder.
#[inline]
pub fn append_null(&mut self) -> Result<()> {
if self.bitmap_builder.is_none() {
let mut builder = BooleanBufferBuilder::new(self.len + 1);
Expand All@@ -1675,6 +1701,7 @@ impl UnionBuilder {
}

/// Appends a value to this builder.
#[inline]
pub fn append<T: ArrowPrimitiveType>(
&mut self,
type_name: &str,
Expand DownExpand Up@@ -1844,6 +1871,7 @@ where
/// Append a primitive value to the array. Return an existing index
/// if already present in the values array or a new index if the
/// value is appended to the values array.
#[inline]
pub fn append(&mut self, value: V::Native) -> Result<K::Native> {
if let Some(&key) = self.map.get(value.to_byte_slice()) {
// Append existing value.
Expand All@@ -1860,6 +1888,7 @@ where
}
}

#[inline]
pub fn append_null(&mut self) -> Result<()> {
self.keys_builder.append_null()
}
Expand DownExpand Up@@ -2047,6 +2076,7 @@ where
}
}

#[inline]
pub fn append_null(&mut self) -> Result<()> {
self.keys_builder.append_null()
}
Expand Down
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
ARROW-12165: [Rust] inline append functions of builders#9860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

ritchie46
wants to merge
1
commit into

from

 Closed


ARROW-12165: [Rust] inline append functions of builders
#9860
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


30 changes: 30 additions & 0 deletions
rust/arrow/src/array/builder.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -433,20 +433,23 @@ impl BooleanBuilder {
 }

 /// Appends a value of type `T` into the builder
 #[inline]
 pub fn append_value(&mut self, v: bool) -> Result<()> {
 self.bitmap_builder.append(true);
 self.values_builder.append(v);
 Ok(())
 }

 /// Appends a null slot into the builder
 #[inline]
 pub fn append_null(&mut self) -> Result<()> {
 self.bitmap_builder.append(false);
 self.values_builder.advance(1);
 Ok(())
 }

 /// Appends an `Option<T>` into the builder
 #[inline]
 pub fn append_option(&mut self, v: Option<bool>) -> Result<()> {
 match v {
 None => self.append_null()?,
Expand All@@ -456,13 +459,15 @@ impl BooleanBuilder {
 }

 /// Appends a slice of type `T` into the builder
 #[inline]
 pub fn append_slice(&mut self, v: &[bool]) -> Result<()> {
 self.bitmap_builder.append_n(v.len(), true);
 self.values_builder.append_slice(v);
 Ok(())
 }

 /// Appends values from a slice of type `T` and a validity boolean slice
 #[inline]
 pub fn append_values(&mut self, values: &[bool], is_valid: &[bool]) -> Result<()> {
 if values.len() != is_valid.len() {
 return Err(ArrowError::InvalidArgumentError(
Expand DownExpand Up@@ -578,6 +583,7 @@ impl<T: ArrowPrimitiveType> PrimitiveBuilder<T> {
 }

 /// Appends a value of type `T` into the builder
 #[inline]
 pub fn append_value(&mut self, v: T::Native) -> Result<()> {
 if let Some(b) = self.bitmap_builder.as_mut() {
 b.append(true);
Expand All@@ -587,6 +593,7 @@ impl<T: ArrowPrimitiveType> PrimitiveBuilder<T> {
 }

 /// Appends a null slot into the builder
 #[inline]
 pub fn append_null(&mut self) -> Result<()> {
 self.materialize_bitmap_builder();
 self.bitmap_builder.as_mut().unwrap().append(false);
Expand All@@ -595,6 +602,7 @@ impl<T: ArrowPrimitiveType> PrimitiveBuilder<T> {
 }

 /// Appends an `Option<T>` into the builder
 #[inline]
 pub fn append_option(&mut self, v: Option<T::Native>) -> Result<()> {
 match v {
 None => self.append_null()?,
Expand All@@ -604,6 +612,7 @@ impl<T: ArrowPrimitiveType> PrimitiveBuilder<T> {
 }

 /// Appends a slice of type `T` into the builder
 #[inline]
 pub fn append_slice(&mut self, v: &[T::Native]) -> Result<()> {
 if let Some(b) = self.bitmap_builder.as_mut() {
 b.append_n(v.len(), true);
Expand All@@ -613,6 +622,7 @@ impl<T: ArrowPrimitiveType> PrimitiveBuilder<T> {
 }

 /// Appends values from a slice of type `T` and a validity boolean slice
 #[inline]
 pub fn append_values(
 &mut self,
 values: &[T::Native],
Expand DownExpand Up@@ -766,6 +776,7 @@ where
 }

 /// Finish the current variable-length list array slot
 #[inline]
 pub fn append(&mut self, is_valid: bool) -> Result<()> {
 self.offsets_builder
 .append(OffsetSize::from_usize(self.values_builder.len()).unwrap());
Expand DownExpand Up@@ -897,6 +908,7 @@ where
 }

 /// Finish the current variable-length list array slot
 #[inline]
 pub fn append(&mut self, is_valid: bool) -> Result<()> {
 self.bitmap_builder.append(is_valid);
 self.len += 1;
Expand DownExpand Up@@ -1115,6 +1127,7 @@ impl<OffsetSize: BinaryOffsetSizeTrait> GenericBinaryBuilder<OffsetSize> {
 ///
 /// Note, when appending individual byte values you must call `append` to delimit each
 /// distinct list value.
 #[inline]
 pub fn append_byte(&mut self, value: u8) -> Result<()> {
 self.builder.values().append_value(value)?;
 Ok(())
Expand All@@ -1124,18 +1137,21 @@ impl<OffsetSize: BinaryOffsetSizeTrait> GenericBinaryBuilder<OffsetSize> {
 ///
 /// Automatically calls the `append` method to delimit the slice appended in as a
 /// distinct array element.
 #[inline]
 pub fn append_value(&mut self, value: impl AsRef<[u8]>) -> Result<()> {
 self.builder.values().append_slice(value.as_ref())?;
 self.builder.append(true)?;
 Ok(())
 }

 /// Finish the current variable-length list array slot.
 #[inline]
 pub fn append(&mut self, is_valid: bool) -> Result<()> {
 self.builder.append(is_valid)
 }

 /// Append a null value to the array.
 #[inline]
 pub fn append_null(&mut self) -> Result<()> {
 self.append(false)
 }
Expand DownExpand Up@@ -1170,6 +1186,7 @@ impl<OffsetSize: StringOffsetSizeTrait> GenericStringBuilder<OffsetSize> {
 ///
 /// Automatically calls the `append` method to delimit the string appended in as a
 /// distinct array element.
 #[inline]
 pub fn append_value(&mut self, value: impl AsRef<str>) -> Result<()> {
 self.builder
 .values()
Expand All@@ -1179,11 +1196,13 @@ impl<OffsetSize: StringOffsetSizeTrait> GenericStringBuilder<OffsetSize> {
 }

 /// Finish the current variable-length list array slot.
 #[inline]
 pub fn append(&mut self, is_valid: bool) -> Result<()> {
 self.builder.append(is_valid)
 }

 /// Append a null value to the array.
 #[inline]
 pub fn append_null(&mut self) -> Result<()> {
 self.append(false)
 }
Expand All@@ -1208,6 +1227,7 @@ impl FixedSizeBinaryBuilder {
 ///
 /// Automatically calls the `append` method to delimit the slice appended in as a
 /// distinct array element.
 #[inline]
 pub fn append_value(&mut self, value: impl AsRef<[u8]>) -> Result<()> {
 if self.builder.value_length() != value.as_ref().len() as i32 {
 return Err(ArrowError::InvalidArgumentError(
Expand All@@ -1219,6 +1239,7 @@ impl FixedSizeBinaryBuilder {
 }

 /// Append a null value to the array.
 #[inline]
 pub fn append_null(&mut self) -> Result<()> {
 let length: usize = self.builder.value_length() as usize;
 self.builder.values().append_slice(&vec![0u8; length][..])?;
Expand DownExpand Up@@ -1248,6 +1269,7 @@ impl DecimalBuilder {
 ///
 /// Automatically calls the `append` method to delimit the slice appended in as a
 /// distinct array element.
 #[inline]
 pub fn append_value(&mut self, value: i128) -> Result<()> {
 let value_as_bytes = Self::from_i128_to_fixed_size_bytes(
 value,
Expand DownExpand Up@@ -1276,6 +1298,7 @@ impl DecimalBuilder {
 }

 /// Append a null value to the array.
 #[inline]
 pub fn append_null(&mut self) -> Result<()> {
 let length: usize = self.builder.value_length() as usize;
 self.builder.values().append_slice(&vec![0u8; length][..])?;
Expand DownExpand Up@@ -1465,13 +1488,15 @@ impl StructBuilder {

 /// Appends an element (either null or non-null) to the struct. The actual elements
 /// should be appended for each child sub-array in a consistent way.
 #[inline]
 pub fn append(&mut self, is_valid: bool) -> Result<()> {
 self.bitmap_builder.append(is_valid);
 self.len += 1;
 Ok(())
 }

 /// Appends a null element to the struct.
 #[inline]
 pub fn append_null(&mut self) -> Result<()> {
 self.append(false)
 }
Expand DownExpand Up@@ -1649,6 +1674,7 @@ impl UnionBuilder {
 }

 /// Appends a null to this builder.
 #[inline]
 pub fn append_null(&mut self) -> Result<()> {
 if self.bitmap_builder.is_none() {
 let mut builder = BooleanBufferBuilder::new(self.len + 1);
Expand All@@ -1675,6 +1701,7 @@ impl UnionBuilder {
 }

 /// Appends a value to this builder.
 #[inline]
 pub fn append<T: ArrowPrimitiveType>(
 &mut self,
 type_name: &str,
Expand DownExpand Up@@ -1844,6 +1871,7 @@ where
 /// Append a primitive value to the array. Return an existing index
 /// if already present in the values array or a new index if the
 /// value is appended to the values array.
 #[inline]
 pub fn append(&mut self, value: V::Native) -> Result<K::Native> {
 if let Some(&key) = self.map.get(value.to_byte_slice()) {
 // Append existing value.
Expand All@@ -1860,6 +1888,7 @@ where
 }
 }

 #[inline]
 pub fn append_null(&mut self) -> Result<()> {
 self.keys_builder.append_null()
 }
Expand DownExpand Up@@ -2047,6 +2076,7 @@ where
 }
 }

 #[inline]
 pub fn append_null(&mut self) -> Result<()> {
 self.keys_builder.append_null()
 }
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
ARROW-12165: [Rust] inline append functions of builders#9860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

ritchie46
wants to merge
1
commit into

from

 Closed


ARROW-12165: [Rust] inline append functions of builders
#9860
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


30 changes: 30 additions & 0 deletions
rust/arrow/src/array/builder.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -433,20 +433,23 @@ impl BooleanBuilder {
 }

 /// Appends a value of type `T` into the builder
 #[inline]
 pub fn append_value(&mut self, v: bool) -> Result<()> {
 self.bitmap_builder.append(true);
 self.values_builder.append(v);
 Ok(())
 }

 /// Appends a null slot into the builder
 #[inline]
 pub fn append_null(&mut self) -> Result<()> {
 self.bitmap_builder.append(false);
 self.values_builder.advance(1);
 Ok(())
 }

 /// Appends an `Option<T>` into the builder
 #[inline]
 pub fn append_option(&mut self, v: Option<bool>) -> Result<()> {
 match v {
 None => self.append_null()?,
Expand All@@ -456,13 +459,15 @@ impl BooleanBuilder {
 }

 /// Appends a slice of type `T` into the builder
 #[inline]
 pub fn append_slice(&mut self, v: &[bool]) -> Result<()> {
 self.bitmap_builder.append_n(v.len(), true);
 self.values_builder.append_slice(v);
 Ok(())
 }

 /// Appends values from a slice of type `T` and a validity boolean slice
 #[inline]
 pub fn append_values(&mut self, values: &[bool], is_valid: &[bool]) -> Result<()> {
 if values.len() != is_valid.len() {
 return Err(ArrowError::InvalidArgumentError(
Expand DownExpand Up@@ -578,6 +583,7 @@ impl<T: ArrowPrimitiveType> PrimitiveBuilder<T> {
 }

 /// Appends a value of type `T` into the builder
 #[inline]
 pub fn append_value(&mut self, v: T::Native) -> Result<()> {
 if let Some(b) = self.bitmap_builder.as_mut() {
 b.append(true);
Expand All@@ -587,6 +593,7 @@ impl<T: ArrowPrimitiveType> PrimitiveBuilder<T> {
 }

 /// Appends a null slot into the builder
 #[inline]
 pub fn append_null(&mut self) -> Result<()> {
 self.materialize_bitmap_builder();
 self.bitmap_builder.as_mut().unwrap().append(false);
Expand All@@ -595,6 +602,7 @@ impl<T: ArrowPrimitiveType> PrimitiveBuilder<T> {
 }

 /// Appends an `Option<T>` into the builder
 #[inline]
 pub fn append_option(&mut self, v: Option<T::Native>) -> Result<()> {
 match v {
 None => self.append_null()?,
Expand All@@ -604,6 +612,7 @@ impl<T: ArrowPrimitiveType> PrimitiveBuilder<T> {
 }

 /// Appends a slice of type `T` into the builder
 #[inline]
 pub fn append_slice(&mut self, v: &[T::Native]) -> Result<()> {
 if let Some(b) = self.bitmap_builder.as_mut() {
 b.append_n(v.len(), true);
Expand All@@ -613,6 +622,7 @@ impl<T: ArrowPrimitiveType> PrimitiveBuilder<T> {
 }

 /// Appends values from a slice of type `T` and a validity boolean slice
 #[inline]
 pub fn append_values(
 &mut self,
 values: &[T::Native],
Expand DownExpand Up@@ -766,6 +776,7 @@ where
 }

 /// Finish the current variable-length list array slot
 #[inline]
 pub fn append(&mut self, is_valid: bool) -> Result<()> {
 self.offsets_builder
 .append(OffsetSize::from_usize(self.values_builder.len()).unwrap());
Expand DownExpand Up@@ -897,6 +908,7 @@ where
 }

 /// Finish the current variable-length list array slot
 #[inline]
 pub fn append(&mut self, is_valid: bool) -> Result<()> {
 self.bitmap_builder.append(is_valid);
 self.len += 1;
Expand DownExpand Up@@ -1115,6 +1127,7 @@ impl<OffsetSize: BinaryOffsetSizeTrait> GenericBinaryBuilder<OffsetSize> {
 ///
 /// Note, when appending individual byte values you must call `append` to delimit each
 /// distinct list value.
 #[inline]
 pub fn append_byte(&mut self, value: u8) -> Result<()> {
 self.builder.values().append_value(value)?;
 Ok(())
Expand All@@ -1124,18 +1137,21 @@ impl<OffsetSize: BinaryOffsetSizeTrait> GenericBinaryBuilder<OffsetSize> {
 ///
 /// Automatically calls the `append` method to delimit the slice appended in as a
 /// distinct array element.
 #[inline]
 pub fn append_value(&mut self, value: impl AsRef<[u8]>) -> Result<()> {
 self.builder.values().append_slice(value.as_ref())?;
 self.builder.append(true)?;
 Ok(())
 }

 /// Finish the current variable-length list array slot.
 #[inline]
 pub fn append(&mut self, is_valid: bool) -> Result<()> {
 self.builder.append(is_valid)
 }

 /// Append a null value to the array.
 #[inline]
 pub fn append_null(&mut self) -> Result<()> {
 self.append(false)
 }
Expand DownExpand Up@@ -1170,6 +1186,7 @@ impl<OffsetSize: StringOffsetSizeTrait> GenericStringBuilder<OffsetSize> {
 ///
 /// Automatically calls the `append` method to delimit the string appended in as a
 /// distinct array element.
 #[inline]
 pub fn append_value(&mut self, value: impl AsRef<str>) -> Result<()> {
 self.builder
 .values()
Expand All@@ -1179,11 +1196,13 @@ impl<OffsetSize: StringOffsetSizeTrait> GenericStringBuilder<OffsetSize> {
 }

 /// Finish the current variable-length list array slot.
 #[inline]
 pub fn append(&mut self, is_valid: bool) -> Result<()> {
 self.builder.append(is_valid)
 }

 /// Append a null value to the array.
 #[inline]
 pub fn append_null(&mut self) -> Result<()> {
 self.append(false)
 }
Expand All@@ -1208,6 +1227,7 @@ impl FixedSizeBinaryBuilder {
 ///
 /// Automatically calls the `append` method to delimit the slice appended in as a
 /// distinct array element.
 #[inline]
 pub fn append_value(&mut self, value: impl AsRef<[u8]>) -> Result<()> {
 if self.builder.value_length() != value.as_ref().len() as i32 {
 return Err(ArrowError::InvalidArgumentError(
Expand All@@ -1219,6 +1239,7 @@ impl FixedSizeBinaryBuilder {
 }

 /// Append a null value to the array.
 #[inline]
 pub fn append_null(&mut self) -> Result<()> {
 let length: usize = self.builder.value_length() as usize;
 self.builder.values().append_slice(&vec![0u8; length][..])?;
Expand DownExpand Up@@ -1248,6 +1269,7 @@ impl DecimalBuilder {
 ///
 /// Automatically calls the `append` method to delimit the slice appended in as a
 /// distinct array element.
 #[inline]
 pub fn append_value(&mut self, value: i128) -> Result<()> {
 let value_as_bytes = Self::from_i128_to_fixed_size_bytes(
 value,
Expand DownExpand Up@@ -1276,6 +1298,7 @@ impl DecimalBuilder {
 }

 /// Append a null value to the array.
 #[inline]
 pub fn append_null(&mut self) -> Result<()> {
 let length: usize = self.builder.value_length() as usize;
 self.builder.values().append_slice(&vec![0u8; length][..])?;
Expand DownExpand Up@@ -1465,13 +1488,15 @@ impl StructBuilder {

 /// Appends an element (either null or non-null) to the struct. The actual elements
 /// should be appended for each child sub-array in a consistent way.
 #[inline]
 pub fn append(&mut self, is_valid: bool) -> Result<()> {
 self.bitmap_builder.append(is_valid);
 self.len += 1;
 Ok(())
 }

 /// Appends a null element to the struct.
 #[inline]
 pub fn append_null(&mut self) -> Result<()> {
 self.append(false)
 }
Expand DownExpand Up@@ -1649,6 +1674,7 @@ impl UnionBuilder {
 }

 /// Appends a null to this builder.
 #[inline]
 pub fn append_null(&mut self) -> Result<()> {
 if self.bitmap_builder.is_none() {
 let mut builder = BooleanBufferBuilder::new(self.len + 1);
Expand All@@ -1675,6 +1701,7 @@ impl UnionBuilder {
 }

 /// Appends a value to this builder.
 #[inline]
 pub fn append<T: ArrowPrimitiveType>(
 &mut self,
 type_name: &str,
Expand DownExpand Up@@ -1844,6 +1871,7 @@ where
 /// Append a primitive value to the array. Return an existing index
 /// if already present in the values array or a new index if the
 /// value is appended to the values array.
 #[inline]
 pub fn append(&mut self, value: V::Native) -> Result<K::Native> {
 if let Some(&key) = self.map.get(value.to_byte_slice()) {
 // Append existing value.
Expand All@@ -1860,6 +1888,7 @@ where
 }
 }

 #[inline]
 pub fn append_null(&mut self) -> Result<()> {
 self.keys_builder.append_null()
 }
Expand DownExpand Up@@ -2047,6 +2076,7 @@ where
 }
 }

 #[inline]
 pub fn append_null(&mut self) -> Result<()> {
 self.keys_builder.append_null()
 }
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
ARROW-12165: [Rust] inline append functions of builders#9860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

ritchie46
wants to merge
1
commit into

from

 Closed


ARROW-12165: [Rust] inline append functions of builders
#9860
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


30 changes: 30 additions & 0 deletions
rust/arrow/src/array/builder.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -433,20 +433,23 @@ impl BooleanBuilder {
 }

 /// Appends a value of type `T` into the builder
 #[inline]
 pub fn append_value(&mut self, v: bool) -> Result<()> {
 self.bitmap_builder.append(true);
 self.values_builder.append(v);
 Ok(())
 }

 /// Appends a null slot into the builder
 #[inline]
 pub fn append_null(&mut self) -> Result<()> {
 self.bitmap_builder.append(false);
 self.values_builder.advance(1);
 Ok(())
 }

 /// Appends an `Option<T>` into the builder
 #[inline]
 pub fn append_option(&mut self, v: Option<bool>) -> Result<()> {
 match v {
 None => self.append_null()?,
Expand All@@ -456,13 +459,15 @@ impl BooleanBuilder {
 }

 /// Appends a slice of type `T` into the builder
 #[inline]
 pub fn append_slice(&mut self, v: &[bool]) -> Result<()> {
 self.bitmap_builder.append_n(v.len(), true);
 self.values_builder.append_slice(v);
 Ok(())
 }

 /// Appends values from a slice of type `T` and a validity boolean slice
 #[inline]
 pub fn append_values(&mut self, values: &[bool], is_valid: &[bool]) -> Result<()> {
 if values.len() != is_valid.len() {
 return Err(ArrowError::InvalidArgumentError(
Expand DownExpand Up@@ -578,6 +583,7 @@ impl<T: ArrowPrimitiveType> PrimitiveBuilder<T> {
 }

 /// Appends a value of type `T` into the builder
 #[inline]
 pub fn append_value(&mut self, v: T::Native) -> Result<()> {
 if let Some(b) = self.bitmap_builder.as_mut() {
 b.append(true);
Expand All@@ -587,6 +593,7 @@ impl<T: ArrowPrimitiveType> PrimitiveBuilder<T> {
 }

 /// Appends a null slot into the builder
 #[inline]
 pub fn append_null(&mut self) -> Result<()> {
 self.materialize_bitmap_builder();
 self.bitmap_builder.as_mut().unwrap().append(false);
Expand All@@ -595,6 +602,7 @@ impl<T: ArrowPrimitiveType> PrimitiveBuilder<T> {
 }

 /// Appends an `Option<T>` into the builder
 #[inline]
 pub fn append_option(&mut self, v: Option<T::Native>) -> Result<()> {
 match v {
 None => self.append_null()?,
Expand All@@ -604,6 +612,7 @@ impl<T: ArrowPrimitiveType> PrimitiveBuilder<T> {
 }

 /// Appends a slice of type `T` into the builder
 #[inline]
 pub fn append_slice(&mut self, v: &[T::Native]) -> Result<()> {
 if let Some(b) = self.bitmap_builder.as_mut() {
 b.append_n(v.len(), true);
Expand All@@ -613,6 +622,7 @@ impl<T: ArrowPrimitiveType> PrimitiveBuilder<T> {
 }

 /// Appends values from a slice of type `T` and a validity boolean slice
 #[inline]
 pub fn append_values(
 &mut self,
 values: &[T::Native],
Expand DownExpand Up@@ -766,6 +776,7 @@ where
 }

 /// Finish the current variable-length list array slot
 #[inline]
 pub fn append(&mut self, is_valid: bool) -> Result<()> {
 self.offsets_builder
 .append(OffsetSize::from_usize(self.values_builder.len()).unwrap());
Expand DownExpand Up@@ -897,6 +908,7 @@ where
 }

 /// Finish the current variable-length list array slot
 #[inline]
 pub fn append(&mut self, is_valid: bool) -> Result<()> {
 self.bitmap_builder.append(is_valid);
 self.len += 1;
Expand DownExpand Up@@ -1115,6 +1127,7 @@ impl<OffsetSize: BinaryOffsetSizeTrait> GenericBinaryBuilder<OffsetSize> {
 ///
 /// Note, when appending individual byte values you must call `append` to delimit each
 /// distinct list value.
 #[inline]
 pub fn append_byte(&mut self, value: u8) -> Result<()> {
 self.builder.values().append_value(value)?;
 Ok(())
Expand All@@ -1124,18 +1137,21 @@ impl<OffsetSize: BinaryOffsetSizeTrait> GenericBinaryBuilder<OffsetSize> {
 ///
 /// Automatically calls the `append` method to delimit the slice appended in as a
 /// distinct array element.
 #[inline]
 pub fn append_value(&mut self, value: impl AsRef<[u8]>) -> Result<()> {
 self.builder.values().append_slice(value.as_ref())?;
 self.builder.append(true)?;
 Ok(())
 }

 /// Finish the current variable-length list array slot.
 #[inline]
 pub fn append(&mut self, is_valid: bool) -> Result<()> {
 self.builder.append(is_valid)
 }

 /// Append a null value to the array.
 #[inline]
 pub fn append_null(&mut self) -> Result<()> {
 self.append(false)
 }
Expand DownExpand Up@@ -1170,6 +1186,7 @@ impl<OffsetSize: StringOffsetSizeTrait> GenericStringBuilder<OffsetSize> {
 ///
 /// Automatically calls the `append` method to delimit the string appended in as a
 /// distinct array element.
 #[inline]
 pub fn append_value(&mut self, value: impl AsRef<str>) -> Result<()> {
 self.builder
 .values()
Expand All@@ -1179,11 +1196,13 @@ impl<OffsetSize: StringOffsetSizeTrait> GenericStringBuilder<OffsetSize> {
 }

 /// Finish the current variable-length list array slot.
 #[inline]
 pub fn append(&mut self, is_valid: bool) -> Result<()> {
 self.builder.append(is_valid)
 }

 /// Append a null value to the array.
 #[inline]
 pub fn append_null(&mut self) -> Result<()> {
 self.append(false)
 }
Expand All@@ -1208,6 +1227,7 @@ impl FixedSizeBinaryBuilder {
 ///
 /// Automatically calls the `append` method to delimit the slice appended in as a
 /// distinct array element.
 #[inline]
 pub fn append_value(&mut self, value: impl AsRef<[u8]>) -> Result<()> {
 if self.builder.value_length() != value.as_ref().len() as i32 {
 return Err(ArrowError::InvalidArgumentError(
Expand All@@ -1219,6 +1239,7 @@ impl FixedSizeBinaryBuilder {
 }

 /// Append a null value to the array.
 #[inline]
 pub fn append_null(&mut self) -> Result<()> {
 let length: usize = self.builder.value_length() as usize;
 self.builder.values().append_slice(&vec![0u8; length][..])?;
Expand DownExpand Up@@ -1248,6 +1269,7 @@ impl DecimalBuilder {
 ///
 /// Automatically calls the `append` method to delimit the slice appended in as a
 /// distinct array element.
 #[inline]
 pub fn append_value(&mut self, value: i128) -> Result<()> {
 let value_as_bytes = Self::from_i128_to_fixed_size_bytes(
 value,
Expand DownExpand Up@@ -1276,6 +1298,7 @@ impl DecimalBuilder {
 }

 /// Append a null value to the array.
 #[inline]
 pub fn append_null(&mut self) -> Result<()> {
 let length: usize = self.builder.value_length() as usize;
 self.builder.values().append_slice(&vec![0u8; length][..])?;
Expand DownExpand Up@@ -1465,13 +1488,15 @@ impl StructBuilder {

 /// Appends an element (either null or non-null) to the struct. The actual elements
 /// should be appended for each child sub-array in a consistent way.
 #[inline]
 pub fn append(&mut self, is_valid: bool) -> Result<()> {
 self.bitmap_builder.append(is_valid);
 self.len += 1;
 Ok(())
 }

 /// Appends a null element to the struct.
 #[inline]
 pub fn append_null(&mut self) -> Result<()> {
 self.append(false)
 }
Expand DownExpand Up@@ -1649,6 +1674,7 @@ impl UnionBuilder {
 }

 /// Appends a null to this builder.
 #[inline]
 pub fn append_null(&mut self) -> Result<()> {
 if self.bitmap_builder.is_none() {
 let mut builder = BooleanBufferBuilder::new(self.len + 1);
Expand All@@ -1675,6 +1701,7 @@ impl UnionBuilder {
 }

 /// Appends a value to this builder.
 #[inline]
 pub fn append<T: ArrowPrimitiveType>(
 &mut self,
 type_name: &str,
Expand DownExpand Up@@ -1844,6 +1871,7 @@ where
 /// Append a primitive value to the array. Return an existing index
 /// if already present in the values array or a new index if the
 /// value is appended to the values array.
 #[inline]
 pub fn append(&mut self, value: V::Native) -> Result<K::Native> {
 if let Some(&key) = self.map.get(value.to_byte_slice()) {
 // Append existing value.
Expand All@@ -1860,6 +1888,7 @@ where
 }
 }

 #[inline]
 pub fn append_null(&mut self) -> Result<()> {
 self.keys_builder.append_null()
 }
Expand DownExpand Up@@ -2047,6 +2076,7 @@ where
 }
 }

 #[inline]
 pub fn append_null(&mut self) -> Result<()> {
 self.keys_builder.append_null()
 }
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
ARROW-12165: [Rust] inline append functions of builders#9860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

ritchie46
wants to merge
1
commit into

from

 Closed


ARROW-12165: [Rust] inline append functions of builders
#9860
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


30 changes: 30 additions & 0 deletions
rust/arrow/src/array/builder.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -433,20 +433,23 @@ impl BooleanBuilder {
 }

 /// Appends a value of type `T` into the builder
 #[inline]
 pub fn append_value(&mut self, v: bool) -> Result<()> {
 self.bitmap_builder.append(true);
 self.values_builder.append(v);
 Ok(())
 }

 /// Appends a null slot into the builder
 #[inline]
 pub fn append_null(&mut self) -> Result<()> {
 self.bitmap_builder.append(false);
 self.values_builder.advance(1);
 Ok(())
 }

 /// Appends an `Option<T>` into the builder
 #[inline]
 pub fn append_option(&mut self, v: Option<bool>) -> Result<()> {
 match v {
 None => self.append_null()?,
Expand All@@ -456,13 +459,15 @@ impl BooleanBuilder {
 }

 /// Appends a slice of type `T` into the builder
 #[inline]
 pub fn append_slice(&mut self, v: &[bool]) -> Result<()> {
 self.bitmap_builder.append_n(v.len(), true);
 self.values_builder.append_slice(v);
 Ok(())
 }

 /// Appends values from a slice of type `T` and a validity boolean slice
 #[inline]
 pub fn append_values(&mut self, values: &[bool], is_valid: &[bool]) -> Result<()> {
 if values.len() != is_valid.len() {
 return Err(ArrowError::InvalidArgumentError(
Expand DownExpand Up@@ -578,6 +583,7 @@ impl<T: ArrowPrimitiveType> PrimitiveBuilder<T> {
 }

 /// Appends a value of type `T` into the builder
 #[inline]
 pub fn append_value(&mut self, v: T::Native) -> Result<()> {
 if let Some(b) = self.bitmap_builder.as_mut() {
 b.append(true);
Expand All@@ -587,6 +593,7 @@ impl<T: ArrowPrimitiveType> PrimitiveBuilder<T> {
 }

 /// Appends a null slot into the builder
 #[inline]
 pub fn append_null(&mut self) -> Result<()> {
 self.materialize_bitmap_builder();
 self.bitmap_builder.as_mut().unwrap().append(false);
Expand All@@ -595,6 +602,7 @@ impl<T: ArrowPrimitiveType> PrimitiveBuilder<T> {
 }

 /// Appends an `Option<T>` into the builder
 #[inline]
 pub fn append_option(&mut self, v: Option<T::Native>) -> Result<()> {
 match v {
 None => self.append_null()?,
Expand All@@ -604,6 +612,7 @@ impl<T: ArrowPrimitiveType> PrimitiveBuilder<T> {
 }

 /// Appends a slice of type `T` into the builder
 #[inline]
 pub fn append_slice(&mut self, v: &[T::Native]) -> Result<()> {
 if let Some(b) = self.bitmap_builder.as_mut() {
 b.append_n(v.len(), true);
Expand All@@ -613,6 +622,7 @@ impl<T: ArrowPrimitiveType> PrimitiveBuilder<T> {
 }

 /// Appends values from a slice of type `T` and a validity boolean slice
 #[inline]
 pub fn append_values(
 &mut self,
 values: &[T::Native],
Expand DownExpand Up@@ -766,6 +776,7 @@ where
 }

 /// Finish the current variable-length list array slot
 #[inline]
 pub fn append(&mut self, is_valid: bool) -> Result<()> {
 self.offsets_builder
 .append(OffsetSize::from_usize(self.values_builder.len()).unwrap());
Expand DownExpand Up@@ -897,6 +908,7 @@ where
 }

 /// Finish the current variable-length list array slot
 #[inline]
 pub fn append(&mut self, is_valid: bool) -> Result<()> {
 self.bitmap_builder.append(is_valid);
 self.len += 1;
Expand DownExpand Up@@ -1115,6 +1127,7 @@ impl<OffsetSize: BinaryOffsetSizeTrait> GenericBinaryBuilder<OffsetSize> {
 ///
 /// Note, when appending individual byte values you must call `append` to delimit each
 /// distinct list value.
 #[inline]
 pub fn append_byte(&mut self, value: u8) -> Result<()> {
 self.builder.values().append_value(value)?;
 Ok(())
Expand All@@ -1124,18 +1137,21 @@ impl<OffsetSize: BinaryOffsetSizeTrait> GenericBinaryBuilder<OffsetSize> {
 ///
 /// Automatically calls the `append` method to delimit the slice appended in as a
 /// distinct array element.
 #[inline]
 pub fn append_value(&mut self, value: impl AsRef<[u8]>) -> Result<()> {
 self.builder.values().append_slice(value.as_ref())?;
 self.builder.append(true)?;
 Ok(())
 }

 /// Finish the current variable-length list array slot.
 #[inline]
 pub fn append(&mut self, is_valid: bool) -> Result<()> {
 self.builder.append(is_valid)
 }

 /// Append a null value to the array.
 #[inline]
 pub fn append_null(&mut self) -> Result<()> {
 self.append(false)
 }
Expand DownExpand Up@@ -1170,6 +1186,7 @@ impl<OffsetSize: StringOffsetSizeTrait> GenericStringBuilder<OffsetSize> {
 ///
 /// Automatically calls the `append` method to delimit the string appended in as a
 /// distinct array element.
 #[inline]
 pub fn append_value(&mut self, value: impl AsRef<str>) -> Result<()> {
 self.builder
 .values()
Expand All@@ -1179,11 +1196,13 @@ impl<OffsetSize: StringOffsetSizeTrait> GenericStringBuilder<OffsetSize> {
 }

 /// Finish the current variable-length list array slot.
 #[inline]
 pub fn append(&mut self, is_valid: bool) -> Result<()> {
 self.builder.append(is_valid)
 }

 /// Append a null value to the array.
 #[inline]
 pub fn append_null(&mut self) -> Result<()> {
 self.append(false)
 }
Expand All@@ -1208,6 +1227,7 @@ impl FixedSizeBinaryBuilder {
 ///
 /// Automatically calls the `append` method to delimit the slice appended in as a
 /// distinct array element.
 #[inline]
 pub fn append_value(&mut self, value: impl AsRef<[u8]>) -> Result<()> {
 if self.builder.value_length() != value.as_ref().len() as i32 {
 return Err(ArrowError::InvalidArgumentError(
Expand All@@ -1219,6 +1239,7 @@ impl FixedSizeBinaryBuilder {
 }

 /// Append a null value to the array.
 #[inline]
 pub fn append_null(&mut self) -> Result<()> {
 let length: usize = self.builder.value_length() as usize;
 self.builder.values().append_slice(&vec![0u8; length][..])?;
Expand DownExpand Up@@ -1248,6 +1269,7 @@ impl DecimalBuilder {
 ///
 /// Automatically calls the `append` method to delimit the slice appended in as a
 /// distinct array element.
 #[inline]
 pub fn append_value(&mut self, value: i128) -> Result<()> {
 let value_as_bytes = Self::from_i128_to_fixed_size_bytes(
 value,
Expand DownExpand Up@@ -1276,6 +1298,7 @@ impl DecimalBuilder {
 }

 /// Append a null value to the array.
 #[inline]
 pub fn append_null(&mut self) -> Result<()> {
 let length: usize = self.builder.value_length() as usize;
 self.builder.values().append_slice(&vec![0u8; length][..])?;
Expand DownExpand Up@@ -1465,13 +1488,15 @@ impl StructBuilder {

 /// Appends an element (either null or non-null) to the struct. The actual elements
 /// should be appended for each child sub-array in a consistent way.
 #[inline]
 pub fn append(&mut self, is_valid: bool) -> Result<()> {
 self.bitmap_builder.append(is_valid);
 self.len += 1;
 Ok(())
 }

 /// Appends a null element to the struct.
 #[inline]
 pub fn append_null(&mut self) -> Result<()> {
 self.append(false)
 }
Expand DownExpand Up@@ -1649,6 +1674,7 @@ impl UnionBuilder {
 }

 /// Appends a null to this builder.
 #[inline]
 pub fn append_null(&mut self) -> Result<()> {
 if self.bitmap_builder.is_none() {
 let mut builder = BooleanBufferBuilder::new(self.len + 1);
Expand All@@ -1675,6 +1701,7 @@ impl UnionBuilder {
 }

 /// Appends a value to this builder.
 #[inline]
 pub fn append<T: ArrowPrimitiveType>(
 &mut self,
 type_name: &str,
Expand DownExpand Up@@ -1844,6 +1871,7 @@ where
 /// Append a primitive value to the array. Return an existing index
 /// if already present in the values array or a new index if the
 /// value is appended to the values array.
 #[inline]
 pub fn append(&mut self, value: V::Native) -> Result<K::Native> {
 if let Some(&key) = self.map.get(value.to_byte_slice()) {
 // Append existing value.
Expand All@@ -1860,6 +1888,7 @@ where
 }
 }

 #[inline]
 pub fn append_null(&mut self) -> Result<()> {
 self.keys_builder.append_null()
 }
Expand DownExpand Up@@ -2047,6 +2076,7 @@ where
 }
 }

 #[inline]
 pub fn append_null(&mut self) -> Result<()> {
 self.keys_builder.append_null()
 }
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
ARROW-12165: [Rust] inline append functions of builders#9860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

ritchie46
wants to merge
1
commit into

from

 Closed


ARROW-12165: [Rust] inline append functions of builders
#9860
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


30 changes: 30 additions & 0 deletions
rust/arrow/src/array/builder.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -433,20 +433,23 @@ impl BooleanBuilder {
 }

 /// Appends a value of type `T` into the builder
 #[inline]
 pub fn append_value(&mut self, v: bool) -> Result<()> {
 self.bitmap_builder.append(true);
 self.values_builder.append(v);
 Ok(())
 }

 /// Appends a null slot into the builder
 #[inline]
 pub fn append_null(&mut self) -> Result<()> {
 self.bitmap_builder.append(false);
 self.values_builder.advance(1);
 Ok(())
 }

 /// Appends an `Option<T>` into the builder
 #[inline]
 pub fn append_option(&mut self, v: Option<bool>) -> Result<()> {
 match v {
 None => self.append_null()?,
Expand All@@ -456,13 +459,15 @@ impl BooleanBuilder {
 }

 /// Appends a slice of type `T` into the builder
 #[inline]
 pub fn append_slice(&mut self, v: &[bool]) -> Result<()> {
 self.bitmap_builder.append_n(v.len(), true);
 self.values_builder.append_slice(v);
 Ok(())
 }

 /// Appends values from a slice of type `T` and a validity boolean slice
 #[inline]
 pub fn append_values(&mut self, values: &[bool], is_valid: &[bool]) -> Result<()> {
 if values.len() != is_valid.len() {
 return Err(ArrowError::InvalidArgumentError(
Expand DownExpand Up@@ -578,6 +583,7 @@ impl<T: ArrowPrimitiveType> PrimitiveBuilder<T> {
 }

 /// Appends a value of type `T` into the builder
 #[inline]
 pub fn append_value(&mut self, v: T::Native) -> Result<()> {
 if let Some(b) = self.bitmap_builder.as_mut() {
 b.append(true);
Expand All@@ -587,6 +593,7 @@ impl<T: ArrowPrimitiveType> PrimitiveBuilder<T> {
 }

 /// Appends a null slot into the builder
 #[inline]
 pub fn append_null(&mut self) -> Result<()> {
 self.materialize_bitmap_builder();
 self.bitmap_builder.as_mut().unwrap().append(false);
Expand All@@ -595,6 +602,7 @@ impl<T: ArrowPrimitiveType> PrimitiveBuilder<T> {
 }

 /// Appends an `Option<T>` into the builder
 #[inline]
 pub fn append_option(&mut self, v: Option<T::Native>) -> Result<()> {
 match v {
 None => self.append_null()?,
Expand All@@ -604,6 +612,7 @@ impl<T: ArrowPrimitiveType> PrimitiveBuilder<T> {
 }

 /// Appends a slice of type `T` into the builder
 #[inline]
 pub fn append_slice(&mut self, v: &[T::Native]) -> Result<()> {
 if let Some(b) = self.bitmap_builder.as_mut() {
 b.append_n(v.len(), true);
Expand All@@ -613,6 +622,7 @@ impl<T: ArrowPrimitiveType> PrimitiveBuilder<T> {
 }

 /// Appends values from a slice of type `T` and a validity boolean slice
 #[inline]
 pub fn append_values(
 &mut self,
 values: &[T::Native],
Expand DownExpand Up@@ -766,6 +776,7 @@ where
 }

 /// Finish the current variable-length list array slot
 #[inline]
 pub fn append(&mut self, is_valid: bool) -> Result<()> {
 self.offsets_builder
 .append(OffsetSize::from_usize(self.values_builder.len()).unwrap());
Expand DownExpand Up@@ -897,6 +908,7 @@ where
 }

 /// Finish the current variable-length list array slot
 #[inline]
 pub fn append(&mut self, is_valid: bool) -> Result<()> {
 self.bitmap_builder.append(is_valid);
 self.len += 1;
Expand DownExpand Up@@ -1115,6 +1127,7 @@ impl<OffsetSize: BinaryOffsetSizeTrait> GenericBinaryBuilder<OffsetSize> {
 ///
 /// Note, when appending individual byte values you must call `append` to delimit each
 /// distinct list value.
 #[inline]
 pub fn append_byte(&mut self, value: u8) -> Result<()> {
 self.builder.values().append_value(value)?;
 Ok(())
Expand All@@ -1124,18 +1137,21 @@ impl<OffsetSize: BinaryOffsetSizeTrait> GenericBinaryBuilder<OffsetSize> {
 ///
 /// Automatically calls the `append` method to delimit the slice appended in as a
 /// distinct array element.
 #[inline]
 pub fn append_value(&mut self, value: impl AsRef<[u8]>) -> Result<()> {
 self.builder.values().append_slice(value.as_ref())?;
 self.builder.append(true)?;
 Ok(())
 }

 /// Finish the current variable-length list array slot.
 #[inline]
 pub fn append(&mut self, is_valid: bool) -> Result<()> {
 self.builder.append(is_valid)
 }

 /// Append a null value to the array.
 #[inline]
 pub fn append_null(&mut self) -> Result<()> {
 self.append(false)
 }
Expand DownExpand Up@@ -1170,6 +1186,7 @@ impl<OffsetSize: StringOffsetSizeTrait> GenericStringBuilder<OffsetSize> {
 ///
 /// Automatically calls the `append` method to delimit the string appended in as a
 /// distinct array element.
 #[inline]
 pub fn append_value(&mut self, value: impl AsRef<str>) -> Result<()> {
 self.builder
 .values()
Expand All@@ -1179,11 +1196,13 @@ impl<OffsetSize: StringOffsetSizeTrait> GenericStringBuilder<OffsetSize> {
 }

 /// Finish the current variable-length list array slot.
 #[inline]
 pub fn append(&mut self, is_valid: bool) -> Result<()> {
 self.builder.append(is_valid)
 }

 /// Append a null value to the array.
 #[inline]
 pub fn append_null(&mut self) -> Result<()> {
 self.append(false)
 }
Expand All@@ -1208,6 +1227,7 @@ impl FixedSizeBinaryBuilder {
 ///
 /// Automatically calls the `append` method to delimit the slice appended in as a
 /// distinct array element.
 #[inline]
 pub fn append_value(&mut self, value: impl AsRef<[u8]>) -> Result<()> {
 if self.builder.value_length() != value.as_ref().len() as i32 {
 return Err(ArrowError::InvalidArgumentError(
Expand All@@ -1219,6 +1239,7 @@ impl FixedSizeBinaryBuilder {
 }

 /// Append a null value to the array.
 #[inline]
 pub fn append_null(&mut self) -> Result<()> {
 let length: usize = self.builder.value_length() as usize;
 self.builder.values().append_slice(&vec![0u8; length][..])?;
Expand DownExpand Up@@ -1248,6 +1269,7 @@ impl DecimalBuilder {
 ///
 /// Automatically calls the `append` method to delimit the slice appended in as a
 /// distinct array element.
 #[inline]
 pub fn append_value(&mut self, value: i128) -> Result<()> {
 let value_as_bytes = Self::from_i128_to_fixed_size_bytes(
 value,
Expand DownExpand Up@@ -1276,6 +1298,7 @@ impl DecimalBuilder {
 }

 /// Append a null value to the array.
 #[inline]
 pub fn append_null(&mut self) -> Result<()> {
 let length: usize = self.builder.value_length() as usize;
 self.builder.values().append_slice(&vec![0u8; length][..])?;
Expand DownExpand Up@@ -1465,13 +1488,15 @@ impl StructBuilder {

 /// Appends an element (either null or non-null) to the struct. The actual elements
 /// should be appended for each child sub-array in a consistent way.
 #[inline]
 pub fn append(&mut self, is_valid: bool) -> Result<()> {
 self.bitmap_builder.append(is_valid);
 self.len += 1;
 Ok(())
 }

 /// Appends a null element to the struct.
 #[inline]
 pub fn append_null(&mut self) -> Result<()> {
 self.append(false)
 }
Expand DownExpand Up@@ -1649,6 +1674,7 @@ impl UnionBuilder {
 }

 /// Appends a null to this builder.
 #[inline]
 pub fn append_null(&mut self) -> Result<()> {
 if self.bitmap_builder.is_none() {
 let mut builder = BooleanBufferBuilder::new(self.len + 1);
Expand All@@ -1675,6 +1701,7 @@ impl UnionBuilder {
 }

 /// Appends a value to this builder.
 #[inline]
 pub fn append<T: ArrowPrimitiveType>(
 &mut self,
 type_name: &str,
Expand DownExpand Up@@ -1844,6 +1871,7 @@ where
 /// Append a primitive value to the array. Return an existing index
 /// if already present in the values array or a new index if the
 /// value is appended to the values array.
 #[inline]
 pub fn append(&mut self, value: V::Native) -> Result<K::Native> {
 if let Some(&key) = self.map.get(value.to_byte_slice()) {
 // Append existing value.
Expand All@@ -1860,6 +1888,7 @@ where
 }
 }

 #[inline]
 pub fn append_null(&mut self) -> Result<()> {
 self.keys_builder.append_null()
 }
Expand DownExpand Up@@ -2047,6 +2076,7 @@ where
 }
 }

 #[inline]
 pub fn append_null(&mut self) -> Result<()> {
 self.keys_builder.append_null()
 }
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
ARROW-12165: [Rust] inline append functions of builders#9860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

ritchie46
wants to merge
1
commit into

from

 Closed


ARROW-12165: [Rust] inline append functions of builders
#9860
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


30 changes: 30 additions & 0 deletions
rust/arrow/src/array/builder.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -433,20 +433,23 @@ impl BooleanBuilder {
 }

 /// Appends a value of type `T` into the builder
 #[inline]
 pub fn append_value(&mut self, v: bool) -> Result<()> {
 self.bitmap_builder.append(true);
 self.values_builder.append(v);
 Ok(())
 }

 /// Appends a null slot into the builder
 #[inline]
 pub fn append_null(&mut self) -> Result<()> {
 self.bitmap_builder.append(false);
 self.values_builder.advance(1);
 Ok(())
 }

 /// Appends an `Option<T>` into the builder
 #[inline]
 pub fn append_option(&mut self, v: Option<bool>) -> Result<()> {
 match v {
 None => self.append_null()?,
Expand All@@ -456,13 +459,15 @@ impl BooleanBuilder {
 }

 /// Appends a slice of type `T` into the builder
 #[inline]
 pub fn append_slice(&mut self, v: &[bool]) -> Result<()> {
 self.bitmap_builder.append_n(v.len(), true);
 self.values_builder.append_slice(v);
 Ok(())
 }

 /// Appends values from a slice of type `T` and a validity boolean slice
 #[inline]
 pub fn append_values(&mut self, values: &[bool], is_valid: &[bool]) -> Result<()> {
 if values.len() != is_valid.len() {
 return Err(ArrowError::InvalidArgumentError(
Expand DownExpand Up@@ -578,6 +583,7 @@ impl<T: ArrowPrimitiveType> PrimitiveBuilder<T> {
 }

 /// Appends a value of type `T` into the builder
 #[inline]
 pub fn append_value(&mut self, v: T::Native) -> Result<()> {
 if let Some(b) = self.bitmap_builder.as_mut() {
 b.append(true);
Expand All@@ -587,6 +593,7 @@ impl<T: ArrowPrimitiveType> PrimitiveBuilder<T> {
 }

 /// Appends a null slot into the builder
 #[inline]
 pub fn append_null(&mut self) -> Result<()> {
 self.materialize_bitmap_builder();
 self.bitmap_builder.as_mut().unwrap().append(false);
Expand All@@ -595,6 +602,7 @@ impl<T: ArrowPrimitiveType> PrimitiveBuilder<T> {
 }

 /// Appends an `Option<T>` into the builder
 #[inline]
 pub fn append_option(&mut self, v: Option<T::Native>) -> Result<()> {
 match v {
 None => self.append_null()?,
Expand All@@ -604,6 +612,7 @@ impl<T: ArrowPrimitiveType> PrimitiveBuilder<T> {
 }

 /// Appends a slice of type `T` into the builder
 #[inline]
 pub fn append_slice(&mut self, v: &[T::Native]) -> Result<()> {
 if let Some(b) = self.bitmap_builder.as_mut() {
 b.append_n(v.len(), true);
Expand All@@ -613,6 +622,7 @@ impl<T: ArrowPrimitiveType> PrimitiveBuilder<T> {
 }

 /// Appends values from a slice of type `T` and a validity boolean slice
 #[inline]
 pub fn append_values(
 &mut self,
 values: &[T::Native],
Expand DownExpand Up@@ -766,6 +776,7 @@ where
 }

 /// Finish the current variable-length list array slot
 #[inline]
 pub fn append(&mut self, is_valid: bool) -> Result<()> {
 self.offsets_builder
 .append(OffsetSize::from_usize(self.values_builder.len()).unwrap());
Expand DownExpand Up@@ -897,6 +908,7 @@ where
 }

 /// Finish the current variable-length list array slot
 #[inline]
 pub fn append(&mut self, is_valid: bool) -> Result<()> {
 self.bitmap_builder.append(is_valid);
 self.len += 1;
Expand DownExpand Up@@ -1115,6 +1127,7 @@ impl<OffsetSize: BinaryOffsetSizeTrait> GenericBinaryBuilder<OffsetSize> {
 ///
 /// Note, when appending individual byte values you must call `append` to delimit each
 /// distinct list value.
 #[inline]
 pub fn append_byte(&mut self, value: u8) -> Result<()> {
 self.builder.values().append_value(value)?;
 Ok(())
Expand All@@ -1124,18 +1137,21 @@ impl<OffsetSize: BinaryOffsetSizeTrait> GenericBinaryBuilder<OffsetSize> {
 ///
 /// Automatically calls the `append` method to delimit the slice appended in as a
 /// distinct array element.
 #[inline]
 pub fn append_value(&mut self, value: impl AsRef<[u8]>) -> Result<()> {
 self.builder.values().append_slice(value.as_ref())?;
 self.builder.append(true)?;
 Ok(())
 }

 /// Finish the current variable-length list array slot.
 #[inline]
 pub fn append(&mut self, is_valid: bool) -> Result<()> {
 self.builder.append(is_valid)
 }

 /// Append a null value to the array.
 #[inline]
 pub fn append_null(&mut self) -> Result<()> {
 self.append(false)
 }
Expand DownExpand Up@@ -1170,6 +1186,7 @@ impl<OffsetSize: StringOffsetSizeTrait> GenericStringBuilder<OffsetSize> {
 ///
 /// Automatically calls the `append` method to delimit the string appended in as a
 /// distinct array element.
 #[inline]
 pub fn append_value(&mut self, value: impl AsRef<str>) -> Result<()> {
 self.builder
 .values()
Expand All@@ -1179,11 +1196,13 @@ impl<OffsetSize: StringOffsetSizeTrait> GenericStringBuilder<OffsetSize> {
 }

 /// Finish the current variable-length list array slot.
 #[inline]
 pub fn append(&mut self, is_valid: bool) -> Result<()> {
 self.builder.append(is_valid)
 }

 /// Append a null value to the array.
 #[inline]
 pub fn append_null(&mut self) -> Result<()> {
 self.append(false)
 }
Expand All@@ -1208,6 +1227,7 @@ impl FixedSizeBinaryBuilder {
 ///
 /// Automatically calls the `append` method to delimit the slice appended in as a
 /// distinct array element.
 #[inline]
 pub fn append_value(&mut self, value: impl AsRef<[u8]>) -> Result<()> {
 if self.builder.value_length() != value.as_ref().len() as i32 {
 return Err(ArrowError::InvalidArgumentError(
Expand All@@ -1219,6 +1239,7 @@ impl FixedSizeBinaryBuilder {
 }

 /// Append a null value to the array.
 #[inline]
 pub fn append_null(&mut self) -> Result<()> {
 let length: usize = self.builder.value_length() as usize;
 self.builder.values().append_slice(&vec![0u8; length][..])?;
Expand DownExpand Up@@ -1248,6 +1269,7 @@ impl DecimalBuilder {
 ///
 /// Automatically calls the `append` method to delimit the slice appended in as a
 /// distinct array element.
 #[inline]
 pub fn append_value(&mut self, value: i128) -> Result<()> {
 let value_as_bytes = Self::from_i128_to_fixed_size_bytes(
 value,
Expand DownExpand Up@@ -1276,6 +1298,7 @@ impl DecimalBuilder {
 }

 /// Append a null value to the array.
 #[inline]
 pub fn append_null(&mut self) -> Result<()> {
 let length: usize = self.builder.value_length() as usize;
 self.builder.values().append_slice(&vec![0u8; length][..])?;
Expand DownExpand Up@@ -1465,13 +1488,15 @@ impl StructBuilder {

 /// Appends an element (either null or non-null) to the struct. The actual elements
 /// should be appended for each child sub-array in a consistent way.
 #[inline]
 pub fn append(&mut self, is_valid: bool) -> Result<()> {
 self.bitmap_builder.append(is_valid);
 self.len += 1;
 Ok(())
 }

 /// Appends a null element to the struct.
 #[inline]
 pub fn append_null(&mut self) -> Result<()> {
 self.append(false)
 }
Expand DownExpand Up@@ -1649,6 +1674,7 @@ impl UnionBuilder {
 }

 /// Appends a null to this builder.
 #[inline]
 pub fn append_null(&mut self) -> Result<()> {
 if self.bitmap_builder.is_none() {
 let mut builder = BooleanBufferBuilder::new(self.len + 1);
Expand All@@ -1675,6 +1701,7 @@ impl UnionBuilder {
 }

 /// Appends a value to this builder.
 #[inline]
 pub fn append<T: ArrowPrimitiveType>(
 &mut self,
 type_name: &str,
Expand DownExpand Up@@ -1844,6 +1871,7 @@ where
 /// Append a primitive value to the array. Return an existing index
 /// if already present in the values array or a new index if the
 /// value is appended to the values array.
 #[inline]
 pub fn append(&mut self, value: V::Native) -> Result<K::Native> {
 if let Some(&key) = self.map.get(value.to_byte_slice()) {
 // Append existing value.
Expand All@@ -1860,6 +1888,7 @@ where
 }
 }

 #[inline]
 pub fn append_null(&mut self) -> Result<()> {
 self.keys_builder.append_null()
 }
Expand DownExpand Up@@ -2047,6 +2076,7 @@ where
 }
 }

 #[inline]
 pub fn append_null(&mut self) -> Result<()> {
 self.keys_builder.append_null()
 }
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
ARROW-12165: [Rust] inline append functions of builders#9860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

ritchie46
wants to merge
1
commit into

from

 Closed


ARROW-12165: [Rust] inline append functions of builders
#9860
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


30 changes: 30 additions & 0 deletions
rust/arrow/src/array/builder.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -433,20 +433,23 @@ impl BooleanBuilder {
 }

 /// Appends a value of type `T` into the builder
 #[inline]
 pub fn append_value(&mut self, v: bool) -> Result<()> {
 self.bitmap_builder.append(true);
 self.values_builder.append(v);
 Ok(())
 }

 /// Appends a null slot into the builder
 #[inline]
 pub fn append_null(&mut self) -> Result<()> {
 self.bitmap_builder.append(false);
 self.values_builder.advance(1);
 Ok(())
 }

 /// Appends an `Option<T>` into the builder
 #[inline]
 pub fn append_option(&mut self, v: Option<bool>) -> Result<()> {
 match v {
 None => self.append_null()?,
Expand All@@ -456,13 +459,15 @@ impl BooleanBuilder {
 }

 /// Appends a slice of type `T` into the builder
 #[inline]
 pub fn append_slice(&mut self, v: &[bool]) -> Result<()> {
 self.bitmap_builder.append_n(v.len(), true);
 self.values_builder.append_slice(v);
 Ok(())
 }

 /// Appends values from a slice of type `T` and a validity boolean slice
 #[inline]
 pub fn append_values(&mut self, values: &[bool], is_valid: &[bool]) -> Result<()> {
 if values.len() != is_valid.len() {
 return Err(ArrowError::InvalidArgumentError(
Expand DownExpand Up@@ -578,6 +583,7 @@ impl<T: ArrowPrimitiveType> PrimitiveBuilder<T> {
 }

 /// Appends a value of type `T` into the builder
 #[inline]
 pub fn append_value(&mut self, v: T::Native) -> Result<()> {
 if let Some(b) = self.bitmap_builder.as_mut() {
 b.append(true);
Expand All@@ -587,6 +593,7 @@ impl<T: ArrowPrimitiveType> PrimitiveBuilder<T> {
 }

 /// Appends a null slot into the builder
 #[inline]
 pub fn append_null(&mut self) -> Result<()> {
 self.materialize_bitmap_builder();
 self.bitmap_builder.as_mut().unwrap().append(false);
Expand All@@ -595,6 +602,7 @@ impl<T: ArrowPrimitiveType> PrimitiveBuilder<T> {
 }

 /// Appends an `Option<T>` into the builder
 #[inline]
 pub fn append_option(&mut self, v: Option<T::Native>) -> Result<()> {
 match v {
 None => self.append_null()?,
Expand All@@ -604,6 +612,7 @@ impl<T: ArrowPrimitiveType> PrimitiveBuilder<T> {
 }

 /// Appends a slice of type `T` into the builder
 #[inline]
 pub fn append_slice(&mut self, v: &[T::Native]) -> Result<()> {
 if let Some(b) = self.bitmap_builder.as_mut() {
 b.append_n(v.len(), true);
Expand All@@ -613,6 +622,7 @@ impl<T: ArrowPrimitiveType> PrimitiveBuilder<T> {
 }

 /// Appends values from a slice of type `T` and a validity boolean slice
 #[inline]
 pub fn append_values(
 &mut self,
 values: &[T::Native],
Expand DownExpand Up@@ -766,6 +776,7 @@ where
 }

 /// Finish the current variable-length list array slot
 #[inline]
 pub fn append(&mut self, is_valid: bool) -> Result<()> {
 self.offsets_builder
 .append(OffsetSize::from_usize(self.values_builder.len()).unwrap());
Expand DownExpand Up@@ -897,6 +908,7 @@ where
 }

 /// Finish the current variable-length list array slot
 #[inline]
 pub fn append(&mut self, is_valid: bool) -> Result<()> {
 self.bitmap_builder.append(is_valid);
 self.len += 1;
Expand DownExpand Up@@ -1115,6 +1127,7 @@ impl<OffsetSize: BinaryOffsetSizeTrait> GenericBinaryBuilder<OffsetSize> {
 ///
 /// Note, when appending individual byte values you must call `append` to delimit each
 /// distinct list value.
 #[inline]
 pub fn append_byte(&mut self, value: u8) -> Result<()> {
 self.builder.values().append_value(value)?;
 Ok(())
Expand All@@ -1124,18 +1137,21 @@ impl<OffsetSize: BinaryOffsetSizeTrait> GenericBinaryBuilder<OffsetSize> {
 ///
 /// Automatically calls the `append` method to delimit the slice appended in as a
 /// distinct array element.
 #[inline]
 pub fn append_value(&mut self, value: impl AsRef<[u8]>) -> Result<()> {
 self.builder.values().append_slice(value.as_ref())?;
 self.builder.append(true)?;
 Ok(())
 }

 /// Finish the current variable-length list array slot.
 #[inline]
 pub fn append(&mut self, is_valid: bool) -> Result<()> {
 self.builder.append(is_valid)
 }

 /// Append a null value to the array.
 #[inline]
 pub fn append_null(&mut self) -> Result<()> {
 self.append(false)
 }
Expand DownExpand Up@@ -1170,6 +1186,7 @@ impl<OffsetSize: StringOffsetSizeTrait> GenericStringBuilder<OffsetSize> {
 ///
 /// Automatically calls the `append` method to delimit the string appended in as a
 /// distinct array element.
 #[inline]
 pub fn append_value(&mut self, value: impl AsRef<str>) -> Result<()> {
 self.builder
 .values()
Expand All@@ -1179,11 +1196,13 @@ impl<OffsetSize: StringOffsetSizeTrait> GenericStringBuilder<OffsetSize> {
 }

 /// Finish the current variable-length list array slot.
 #[inline]
 pub fn append(&mut self, is_valid: bool) -> Result<()> {
 self.builder.append(is_valid)
 }

 /// Append a null value to the array.
 #[inline]
 pub fn append_null(&mut self) -> Result<()> {
 self.append(false)
 }
Expand All@@ -1208,6 +1227,7 @@ impl FixedSizeBinaryBuilder {
 ///
 /// Automatically calls the `append` method to delimit the slice appended in as a
 /// distinct array element.
 #[inline]
 pub fn append_value(&mut self, value: impl AsRef<[u8]>) -> Result<()> {
 if self.builder.value_length() != value.as_ref().len() as i32 {
 return Err(ArrowError::InvalidArgumentError(
Expand All@@ -1219,6 +1239,7 @@ impl FixedSizeBinaryBuilder {
 }

 /// Append a null value to the array.
 #[inline]
 pub fn append_null(&mut self) -> Result<()> {
 let length: usize = self.builder.value_length() as usize;
 self.builder.values().append_slice(&vec![0u8; length][..])?;
Expand DownExpand Up@@ -1248,6 +1269,7 @@ impl DecimalBuilder {
 ///
 /// Automatically calls the `append` method to delimit the slice appended in as a
 /// distinct array element.
 #[inline]
 pub fn append_value(&mut self, value: i128) -> Result<()> {
 let value_as_bytes = Self::from_i128_to_fixed_size_bytes(
 value,
Expand DownExpand Up@@ -1276,6 +1298,7 @@ impl DecimalBuilder {
 }

 /// Append a null value to the array.
 #[inline]
 pub fn append_null(&mut self) -> Result<()> {
 let length: usize = self.builder.value_length() as usize;
 self.builder.values().append_slice(&vec![0u8; length][..])?;
Expand DownExpand Up@@ -1465,13 +1488,15 @@ impl StructBuilder {

 /// Appends an element (either null or non-null) to the struct. The actual elements
 /// should be appended for each child sub-array in a consistent way.
 #[inline]
 pub fn append(&mut self, is_valid: bool) -> Result<()> {
 self.bitmap_builder.append(is_valid);
 self.len += 1;
 Ok(())
 }

 /// Appends a null element to the struct.
 #[inline]
 pub fn append_null(&mut self) -> Result<()> {
 self.append(false)
 }
Expand DownExpand Up@@ -1649,6 +1674,7 @@ impl UnionBuilder {
 }

 /// Appends a null to this builder.
 #[inline]
 pub fn append_null(&mut self) -> Result<()> {
 if self.bitmap_builder.is_none() {
 let mut builder = BooleanBufferBuilder::new(self.len + 1);
Expand All@@ -1675,6 +1701,7 @@ impl UnionBuilder {
 }

 /// Appends a value to this builder.
 #[inline]
 pub fn append<T: ArrowPrimitiveType>(
 &mut self,
 type_name: &str,
Expand DownExpand Up@@ -1844,6 +1871,7 @@ where
 /// Append a primitive value to the array. Return an existing index
 /// if already present in the values array or a new index if the
 /// value is appended to the values array.
 #[inline]
 pub fn append(&mut self, value: V::Native) -> Result<K::Native> {
 if let Some(&key) = self.map.get(value.to_byte_slice()) {
 // Append existing value.
Expand All@@ -1860,6 +1888,7 @@ where
 }
 }

 #[inline]
 pub fn append_null(&mut self) -> Result<()> {
 self.keys_builder.append_null()
 }
Expand DownExpand Up@@ -2047,6 +2076,7 @@ where
 }
 }

 #[inline]
 pub fn append_null(&mut self) -> Result<()> {
 self.keys_builder.append_null()
 }
Expand Down