Uh oh!
There was an error while loading. Please reload this page.
ARROW-12204: [Rust][CI] Reduce size of Rust build artifacts in integration test - #9889
Closed
alamb wants to merge 3 commits into
Closed
ARROW-12204: [Rust][CI] Reduce size of Rust build artifacts in integration test#9889alamb wants to merge 3 commits into
alamb wants to merge 3 commits into
Conversation
alamb
commented
Apr 5, 2021
ContributorAuthor
There was a problem hiding this comment.
Doing a full rust build as part of the integration test appears to be unecessary
ContributorAuthor
There was a problem hiding this comment.
this is here to force the rust + integration tests to run
pitrou
commented
Apr 5, 2021
Member
By the way, you can run integration tests locally using |
pitrou
commented
Apr 5, 2021
Member
Se here for installing Archery. |
alambforce-pushed
the
alamb/reduce_integration_size
branch
from
April 5, 2021 12:40
40e45b1 to
6317315Comparealamb
marked this pull request as ready for review
April 5, 2021 12:40
jorgecarleitao
approved these changes
Apr 6, 2021
jorgecarleitao
left a comment
Member
There was a problem hiding this comment.
LGTM. Thanks a lot, @alamb ! Left a minor comment.
| strategy: | ||
| matrix: | ||
| arch: [amd64] | ||
| rust: [nightly-2020-11-24] |
There was a problem hiding this comment.
Should we change this to stable(or have both), since this is the target version?
ContributorAuthor
There was a problem hiding this comment.
yes, that is a good idea. I will make the change
alamb added a commit
that referenced
this pull request
Apr 7, 2021
…tests # Rationale 1. As @jorgecarleitao noted on #9889 (comment), we should be running the check if arrow compiles with stable rust as that is what we target for the arrow crate 2. I noticed that there were several redundant (and inconsistent) settings of `RUSTFLAGS` 3. The titles of many of the tests are confusing (to me) as they have a lot of detailed architecture / rust version information before the description of what they are testing  # Changes 1. Use rust stable for the check that ensures the crate builds without default features 2. Remove redundant `RUSTFLAGS` 3. Change titles of the jobs to consistently start with a description of what they do # Note This could be three individual PRs, but I wanted to avoid the overhead of three separate JIRA tickets and juggling several concurrent potentially conflicting PRs. I will break it into three individual ones however if reviewers want. Closes#9904 from alamb/alamb/cleanup_rust_ci Authored-by: Andrew Lamb <andrew@nerdnetworks.org> Signed-off-by: Andrew Lamb <andrew@nerdnetworks.org>
alamb added a commit
to apache/arrow-rs
that referenced
this pull request
Apr 20, 2021
…tests # Rationale 1. As @jorgecarleitao noted on apache/arrow#9889 (comment), we should be running the check if arrow compiles with stable rust as that is what we target for the arrow crate 2. I noticed that there were several redundant (and inconsistent) settings of `RUSTFLAGS` 3. The titles of many of the tests are confusing (to me) as they have a lot of detailed architecture / rust version information before the description of what they are testing  # Changes 1. Use rust stable for the check that ensures the crate builds without default features 2. Remove redundant `RUSTFLAGS` 3. Change titles of the jobs to consistently start with a description of what they do # Note This could be three individual PRs, but I wanted to avoid the overhead of three separate JIRA tickets and juggling several concurrent potentially conflicting PRs. I will break it into three individual ones however if reviewers want. Closes#9904 from alamb/alamb/cleanup_rust_ci Authored-by: Andrew Lamb <andrew@nerdnetworks.org> Signed-off-by: Andrew Lamb <andrew@nerdnetworks.org>
This was referenced Apr 6, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
The integration test has a fixed size builder docker image and has builds from several Arrow implementations.
The Rust build artifacts (compiled binaries) in the integration tests still consume ~ 1GB of space even after #9879 (see @pitrou 's comment on #9884 (comment)).
Changes
arrow-integration-testingcrate (which has the binaries needed for integration testing) rather than all of themcargo checkto ensure we can build arrow without default features to a github action and out of the integration testThis should both speed up the rust build as part of integration testing as well as reduce the amount of disk space required in the builder (both peak and after the rust build).
Results
According to this log after this PR's changes, the rust artifacts are much smaller.
Note we could still save space by removing the rust toolchain and
.cargofiles but I think that can be an optimization for another time: