Uh oh!
There was an error while loading. Please reload this page.
Avro-2785: Update specs on how unions encoded - #847
Conversation
Uh oh!
There was an error while loading. Please reload this page.
anhldbk
commented
May 3, 2020
@Fokko What should I do? I agree with Roger's comment |
Fokko
commented
May 3, 2020
I can't merge the PR, there is a merge conflict in |
anhldbk
commented
May 3, 2020
@Fokko PTAL :) |
Fokko
commented
May 3, 2020
@anhldbk I see a lot of unrelated changes in |
anhldbk
commented
May 4, 2020
@Fokko I've got troubles with my Python formatter. Gonna resolve it and tell you later |
anhldbk
commented
May 4, 2020
@Fokko actualluy my latest commit fixed the λ git diff AVRO-2785 upstream/master -- lang/py/avro/io.py
diff --git a/lang/py/avro/io.py b/lang/py/avro/io.py
index e165db3a..b910ba56 100644
--- a/lang/py/avro/io.py
+++ b/lang/py/avro/io.py
@@ -846,7 +846,7 @@ class DatumReader(object):
def read_union(self, writers_schema, readers_schema, decoder):
"""- A union is encoded by first writing an int value indicating+ A union is encoded by first writing a long value indicating the zero-based position within the union of the schema of its value. The value is then encoded per the indicated schema within the union."""
@@ -1096,7 +1096,7 @@ class DatumWriter(object):
def write_union(self, writers_schema, datum, encoder):
"""- A union is encoded by first writing an int value indicating+ A union is encoded by first writing a long value indicating the zero-based position within the union of the schema of its value. The value is then encoded per the indicated schema within the union.""" |
kojiromike
commented
May 5, 2020
Looks good to me. Thanks for contributing! |
Fokko
commented
May 9, 2020
Thanks @anhldbk |
* AVRO-2785: Updated specs about how Unions are encoded * AVRO-2785: Updated related docs for Perl & Python * AVRO-2785: add side notes for enum_encoding Thank you @kojiromike * AVRO-2785: add side notes for union_encoding Thank you @kojiromike * AVRO-2785: update side notes for union_encoding * AVRO-2785: remove invalid side note on enum_encoding
My PR addresses the following issue Avro-2785