Uh oh!
There was an error while loading. Please reload this page.
[BEAM-8740] Remove unused dependency from Spark runner - #10564
Conversation
iemejia
commented
Jan 13, 2020
Run Spark ValidatesRunner |
iemejia
commented
Jan 13, 2020
Run Spark StructuredStreaming ValidatesRunner |
| ValidatesRunner.class, | ||
| UsesStatefulParDo.class, | ||
| UsesTimersInParDo.class, | ||
| UsesTestStream.class, |
There was a problem hiding this comment.
I had to add this one because it was not correctly categorized and VR were breaking
There was a problem hiding this comment.
It seems is reported here
https://issues.apache.org/jira/browse/BEAM-9083
There was a problem hiding this comment.
Shouldn't the VR tests exclude UsesTestStreamWithOutputTimestamp?
There was a problem hiding this comment.
That's the line exactly below that one. Notice that Spark runner does not implement TestStream so we probably need to make the test belong to both categories.
There was a problem hiding this comment.
Mind to maybe lgtm / merge this one @lukecwik. Seems most VR are broken because of it.
There was a problem hiding this comment.
I see, I was under the impression that we would place things in the most appropriate category but now thinking about it makes sense to place it in this category as well.
R: @aromanenko-dev